#412 Change Keyboard Shortcuts (with GUI)

[Anonymous]

I searched in multiple places (included this feature request area) for a way to change keyboard shortcuts.

I know in the old version of Rosegarden, you could quickly and easily change a huge variety of keyboard shortcuts.
And I loved how your could filter keyboard shortcuts, by searching for their names.

But the new version of Rosegarden does not seem to have ANY menu for changing keyboard shortcuts.

Therefore, my primary feature request is a simple way to change the keyboard shortcuts in Rosegarden.

My secondary feature request, is to re-implement the ability to filter shortcuts by name, that tool was great!

[Yves Guillemot]

Not sure I understand what the problem is.

There are a few shortcuts manually set in the code (eg. MIDIInstrumentParameterPanel.cpp). I will try to replace these with entries in the rc files.

Please, avoid if possible.
Translating a string coming from a .cpp file is easy because the file name give the context of the string.
Translating a string coming from a .rc file is a pain for the translator because, in the linguist tool, all these strings are seen coming from an unique huge QObject file. As a result, the context of a string is very difficult to find and the translation is not easy.

[Philip Leishman]

I just want to define the shortcuts in the rc files. Since the Qt translations for shortcuts are used there should be fewer strings to translate from the rc files.
If a shortcut is defined in the code and not in the rc files it will not appear in the shortcut editor !

[Philip Leishman]

I have moved some shortcuts to the rc files in the latest commit. The only one I can't see how to do is the "Shift+P" in MIDIInstrumentParameterPanel. This is a shortcut for a QCheckBox - no way to do that in the rc files !!

[Ted Felix]

Merged latest as [0a6402]. Please test latest git.

[Philip Leishman]

I removed all shortcuts from the tooltips in the rc files and append them (correctly translated) to the tooltip automatically.
See latest merge request.

[Philip Leishman]

Also improved the duration toolbar

[Ted Felix]

Merged latest as [2cb046]. Please test latest git.

[Philip Leishman]

OK. I broke the undo/redo tooltips with my last change :(
Actually undo/redo seems like a special case here. The shortcut editors show undo/redo for each window but really there is only one undo and one redo action !
I think I need some special case code in the shortcut editor.
Hmmm....

[Ted Felix]

I broke the undo/redo tooltips with my last change :(

I thought they were working fine for me. Guess I wasn't paying attention.

I think I need some special case code in the shortcut editor.

The "Nothing to Undo" does look odd. Can we change the name in the .rc file to "Undo" and then set the "Nothing to Undo" initially in the code? That seems like the logical thing to do.

[Philip Leishman]

Create a segment - undo says "undo create segment" - correct.
Now open the segment in the notation editor - in the notation editor undo says "Nothing to undo" !

I think I must write some special case code for undo and redo so it just appears once in the shortcut editor.

[Philip Leishman]

I pushed a new version. Some special code for undo/redo !
Seems to work OK now.
Please test latest version. Thanks
See merge request.

[Ted Felix]

Working great for me. Pushed along with some minor cleanup as [26a977]. Please test latest git.

[Philip Leishman]

I have updated the translation scripts. Shortcuts are no longer included in the translation files.
See merge request.

[Ted Felix]

Pushed as [89588b]. I tweaked the wording on the generated comment for tooltips. Make sure I didn't say anything misleading.