#1787 Import Banks from Device no longer sets device name

[musewhirl]

I don't know when this changed, but I recall that when importing banks from a device file, the device name was read from the file and used as the default in the MIDI playback subwindow of the Manage MIDI Devices.

Steps to reproduce:

1. Start rosegarden
2. Select Studio/Manage MIDI Devices
3. Click New in the MIDI playback subwindow
4. An entry called New Device appears (as originally)
5. Click Banks button
6. Select File/Import and select one from RG's library which is easily distinguishable from any existing devices in the window
7. The New Device default remains the same
8. Gunzip the selected rgd file and confirm that its <device> tag has a name attribute</device>

The name attribute is what I think used to appear on importing the banks, but I don't have old enough RG versions to be certain. The user can still edit it to be whatever they want after that though. So, a regression issue appears to exist, unless this is the currently desired behavior.

[Philip Leishman]

I cannot reproduce this.
I used the first file (AccessVirus.rgd)
On import with "Overwrtie Banks" I get a device called "Virus".
If I choose "Merge Banks" I get a device called "New Device/Virus"
I tried a few other files - they all seemed to work.
Can you give a concrete example of a file that fails ?

[musewhirl]

Before posting, I tested with two random rgd files, which I obviously can't remember now. This time around, I picked Yamaha-DX7.rgd and that still matched the steps to reproduce. However, being suspicious, I looked more closely at the intervening popup dialog, which I have never actually changed in the past i.e. I've always just hit the OK button, because that always worked for me. I also always note Overwrite, and that was right there in the Bank import behavior sub-window. Admittedly, I've never even looked at the Options sub-window on the left, yet the and now noticed it had "Import device name" unchecked. I've never touched that in any version of RG.

So, I checked the box, and now the device name behaved the way it should i.e. what was New Device became Yamaha DX7, just the way I remembered from the past. I then checked the Rosegarden.conf file, searching for banks, and saw the following:

importbanksoverwrite=true
importbanksrename=true

A backup Rosegarden.conf file just prior to my change above had:

importbanksoverwrite=true
importbanksrename=false

I also checked a new instance of RG and its default appears to be importbanksrename=true.

Yet, I clearly remember it working in my case. I checked my backups and tracked the change to between: 20251103 and 20251117. The corresponding build zips are:

u-lman-rosegarden-47b408557dfe3abff9d49453a8dae9c3edd5cb26 dated 20251101

Using this build, importbanksrename=true remained that way...the only changes to Rosegarden.conf were for the recent files list. Then for the following build from master three days later:

rosegarden-git-10f12fc70be91d234e78c7ef153b8d7f2b9f5911 dated 20251104

Although the build itself is also dated 20251104 (same day), the Rosegarden.conf file was later changed on 20251116 with these differences:

lv2-b=true | lv2-b=false
Lv2Environment=true | Lv2Environment=false
importbanksrename=true | importbanksrename=false
sendControlChangesWhenLooping=true | sendControlChangesWhenLooping=false
sendProgramChangesWhenLooping=true | sendProgramChangesWhenLooping=false

I distinctly remember opening the Rosegarden/Preferences/General/Behavior tab to uncheck "Drag with dynamic modifiers". In addition, since I was there, and not using LV2, I think I decided to also uncheck both LV2 Plugin Support and Setup LV2 Environment. But I did not change importbanksrename. I am also not sure what the last two are referring to? Are those something I would have changed under some other preference name or scenario?

Besides, the importbanksrename=true isn't even on that tab. I guess one could argue that I changed it at some other time, but presumably that would have had to have been via the Banks GUI, and as mentioned above, I didn't even know that checkbox existed.

I tried to recreate the scenario which might have changed the setting using a new RG instance albeit not using the old master versions mentioned above. In order of first making sure that the banks information was set to true, and then unchecking the LV2 and dynamic modifiers. I noticed a few items:

• A new instance of RG has very few preferences in the Rosegarden.conf file, in particular, the word banks does not even appear in the file. I assume that is normal? i.e. the user will not know the defaults until some other event?
• As for that, when I imported an rgd file using the GUI defaults, then the two banks entries did appear in Rosegarden.conf along with others

To simulate my issue, I then unchecked the LV2 and dynamic modifiers preferences mentioned above, got more new entries in Rosegarden.conf, and rechecked, and importbanksrename was still true i.e. I still don't know how it was set to false...unless there was some coding error on master at that time, which has long since been fixed. The only thing I've not tried is rebuilding the second RG version above and seeing if it had a problem...even if it did, then it would appear to have been fixed now, unless I experience this again.

Unless you know of some other circumstance which would cause the flag to change, we could just leave this bug open for a while, and I'll double check nothing else I do changes the value. Or you could close it and if it does occur, the circumstance may be more obvious

[Philip Leishman]

As far as I can see the default for renaming the device has always been true.
The importbanksrename item in the conf file only gets written if the device editor is used to import banks.
As far as I can see the only way to set "Import device name" to false is to uncheck the check box.
Maybe not worth checking on this much more. I recommend closing this bug.

[musewhirl]

I agree. I can't find a way to reproduce it. I even tested what would happen if a device name happened to be an empty string in the rgd file. In that case, you only get a device not found...no side effects.

I checked backups from 2018 forward, and all have the checkbox as true. So, after seven years it suddenly becomes false in November 2025. Beats me. Besides, it's harmless anyway, so feel free to close and I'll only mention it if the value changes again.