#1784 All Undo disappears after "Merge MusicXML File(s)

[musewhirl]

Implementing Undo for this operation could prove tricky, but without it perhaps the user should be warned that there is no undo after using it.

Probably doesn't matter what needs to be undone, but just in case:

Steps to reproduce:

1. Open a session with a number of MIDI tracks
2. Delete some MIDI tracks (CTRL-D)
3. Use CTRL-Z to undo them
4. Now delete them again
5. Select File/Merge/Merge MusicXML File(s) to bring in multiple MIDI tracks from an XML file
6. Use CTRL-Z and nothing happens
7. As far as I can tell, you can't get back the deleted tracks

I believe all previous changes are forgotten.

[Philip Leishman]

Yes - on merge all command history is cleared.
Strangely enough there is a lot of undo/redo logic in MergeFileCommand so undo should work.
Maybe the clearing of the history is "accidental" ?
Anyone know ?

[Philip Leishman]

It seems this is also true for merge of midi and RG2 files.
I made a straightforward change to respect the clearHistory flag and everything seems to work OK.
See codeberg merge request.

[Ted Felix]

Philip's fix merged as [3e9794]. Please test latest git.