#1723 Transport window does not update on tempo/time signature changes

[Ted Felix]

The time on the transport window does not update if tempo or time signature changes are made prior to the playback position pointer. Procedure:

• Launch rg.
• Move the playback pointer to bar 8.
• Confirm the transport window time reads 00:00:14.0000
• Perform a tempo change to 100 BPM at bar 1.
  • Composition > Add Tempo Change
  • New Tempo: 100
  • Replace the last tempo change.
• Confirm the transport window time reads 00:00:16.8000
• Switch the transport window to bar mode using the small "pause" button in the upper left.
• Confirm the transport window reads "8:1 0".
• Add a time signature change.
  • Composition > Open Tempo and Time Signature Editor
  • Press G to add a time signature.
  • Set the time signature to 3/4.
• Confirm the transport window reads "10:2 0"

I attempted to fix this by forcing a refresh after every command. See the
commented out code in RosegardenMainWindow::slotCommandExecuted(). This
unfortunately broke notation and matrix editor note previews.

This issue was originally pointed out in bug [#1721].

[Philip Leishman]

I am not sure I understand the problem.
I can reproduce the steps above but --- what is wrong ?

[Ted Felix]

You might be working with a slightly older version from git. I fixed this in [4c4d9d] but then reverted it in [563583]. If you are between those points it will work (but matrix and notation note previews will be broken). Make sure you are working with the latest from git and you should see that the transport window time does not change when it should.

[Philip Leishman]

OK - now I see it

[Philip Leishman]

I have tried fixing this using the CompositionObserver.
Seems to work. Hopefully without side effects
See merge request.

[Ted Felix]

Pushed fix as [66401b]. Please test latest git.