#1051 RG stops JACK transport from playing, at end of composition

[Chris Cannam]

Start Rosegarden, and another JACK transport client such as Ardour. Ensure they are both synced to JACK.

Press Play (or record) from the "other" application. RG's transport will start rolling, as it should. But when the end of RG's composition is reached, it will stop the transport -- even though the other application may be still playing (and, worse, recording).

If you didn't actually press Play in Rosegarden, then Rosegarden should never stop the transport on your behalf, unless you actually pressed Stop.

(reported by Mike Taht, who lost a recording session)

[D. Michael McIntyre]

• Description has changed:

Diff:

--- old
+++ new
@@ -1,4 +1,3 @@
-
 Start Rosegarden, and another JACK transport client such as Ardour.  Ensure they are both synced to JACK.

 Press Play (or record) from the "other" application.  RG's transport will start rolling, as it should.  But when the end of RG's composition is reached, it will stop the transport -- even though the other application may be still playing (and, worse, recording).

• milestone: --> One Of These Days

[Philip Leishman]

I have made a change to try and avoid jack transport stop if we just run into the end of the composition. I don't know the sound code very well but the change is fairly trivial.
Note - this has relevance for bug [#1605] too.
See merge request.

[Ted Felix]

The fix prevents rg from sending out a JACK transport stop when the end of composition is reached. Sounds like it should be OK. Wish we still had the original reporter to test this. When I merge this in, I'll ping the user list to see if anyone actually uses JACK transport.

https://sourceforge.net/p/rosegarden/git/merge-requests/37/

[Ted Felix]

Pushed as [4654a1]. Please test latest git.

[Ted Felix]

@lman: There were conflicts when I merged this. You probably want to delete your local and remote branches. Otherwise git might get confused if you try to use them again:

git branch -D bug-1051-jack-transport
git push origin --delete bug-1051-jack-transport