Menu
▾
▴
[Rhq-commits] [rhq-project.org rhq] [5035] RHQ-2394: Adding, updating tests
|
From: <js...@rh...> - 2009-08-30 14:01:38
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><style type="text/css"><!-- #msg DL { border : 1px #006 solid; background-color : #369; padding : 6px; color : #fff; } #msg DT { float : left; width : 6em; font-weight : bold; } #msg DL, #msg DT, #msg UL, #msg LI { font-family : arial,helvetica,sans-serif; font-size : 10pt; } h3 { font-family : arial,helvetica,sans-serif; font-size : 10pt; font-weight : bold; } #msg PRE { overflow : auto; white-space : normal; background-color : #ffc; border : 1px #fc0 solid; padding : 6px; } #msg UL, PRE, .diff { overflow : auto; } #patch h4 { font-family : arial,helvetica,sans-serif; font-size : 10pt; } #patch h4 { padding: 8px; background : #369; color : #fff; margin : 0; } #patch .propset h4, #patch .binary h4 {margin: 0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {background:#eeeeee;padding: 0 0 10px 0;} #patch .propset .diff, #patch .binary .diff {padding: 10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch .add {background:#ddffdd;} #patch .rem {background:#ffdddd;} #patch .lines, .info {color:#888888;background:#ffffff;} .diff { width : 100%; } #msg DL { border : 1px #006 solid; background-color : #369; padding : 6px; color : #fff; } #msg DT { float : left; width : 6em; font-weight : bold; } #msg DL, #msg DT, #msg UL, #msg LI { font-family : arial,helvetica,sans-serif; font-size : 10pt; } h3 { font-family : arial,helvetica,sans-serif; font-size : 10pt; font-weight : bold; } #msg PRE { overflow : auto; white-space : normal; background-color : #ffc; border : 1px #fc0 solid; padding : 6px; } #msg UL, PRE, .diff { overflow : auto; } #patch h4 { font-family : arial,helvetica,sans-serif; font-size : 10pt; } #patch h4 { padding: 8px; background : #369; color : #fff; margin : 0; } #patch .propset h4, #patch .binary h4 {margin: 0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {background:#eeeeee;padding: 0 0 10px 0;} #patch .propset .diff, #patch .binary .diff {padding: 10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch .add {background:#ddffdd;} #patch .rem {background:#ffdddd;} #patch .lines, .info {color:#888888;background:#ffffff;} .diff { width : 100%; } --></style> <title>[rhq-project.org rhq] [5035] RHQ-2394: Adding, updating tests</title> </head> <body> <div id="msg"> <dl> <dt>Revision</dt> <dd>5035</dd> <dt>Author</dt> <dd>jsanda</dd> <dt>Date</dt> <dd>2009-08-30 09:01:23 -0500 (Sun, 30 Aug 2009)</dd> </dl> <h3>Log Message</h3> <pre>RHQ-2394: Adding, updating tests</pre> <h3>Modified Paths</h3> <ul> <li><a href="#rhqtrunkmodulescoredomainsrctestjavaorgrhqcoredomainconfigurationPropertyMapTestjava">rhq/trunk/modules/core/domain/src/test/java/org/rhq/core/domain/configuration/PropertyMapTest.java</a></li> </ul> </div> <div id="patch"> <h3>Diff</h3> <a id="rhqtrunkmodulescoredomainsrctestjavaorgrhqcoredomainconfigurationPropertyMapTestjava"></a> <div class="modfile"><h4>Modified: rhq/trunk/modules/core/domain/src/test/java/org/rhq/core/domain/configuration/PropertyMapTest.java (5034 => 5035)</h4> <pre class="diff"> <span class="info">--- rhq/trunk/modules/core/domain/src/test/java/org/rhq/core/domain/configuration/PropertyMapTest.java 2009-08-30 14:01:15 UTC (rev 5034) +++ rhq/trunk/modules/core/domain/src/test/java/org/rhq/core/domain/configuration/PropertyMapTest.java 2009-08-30 14:01:23 UTC (rev 5035) </span><span class="lines">@@ -67,9 +67,29 @@ </span><span class="cx"> assertEquals(copy.getMap().size(), original.getMap().size(), "Failed to copy simple property contained in original property map"); </span><span class="rem">- assertNotSame(copy.getMap().get(0), original.getMap().get(0), "Properties in the map should be copied by value as opposed to just copying the references"); </span><span class="add">+ assertNotSame( + copy.getMap().get(simpleProperty.getName()), + original.getMap().get(simpleProperty.getName()), + "Properties in the map should be copied by value as opposed to just copying the references" + ); </span><span class="cx"> } </span><span class="add">+ @Test + public void deepCopyShouldSetParentOfCopiedProperty() { + PropertyMap original = createPropertyMap(); + + PropertySimple simpleProperty = new PropertySimple("simpleProperty", "Simple Property"); + original.put(simpleProperty); + + PropertyMap copy = original.deepCopy(); + + assertSame( + copy.get(simpleProperty.getName()).getParentMap(), + copy, + "The parentMap property of copied properties should be set to the new PropertyMap" + ); + } + </span><span class="cx"> private PropertyMap createPropertyMap() { PropertyMap map = new PropertyMap("mapProperty"); map.setId(1); </span> </pre> </div> </div> </body> </html> |