rails-devel — List for discussion of Rails development

Re: [Rails-devel] [Rails-users] Release Rails 1.7.2 available

[Stefan F. <ste...@we...>]

Volker: Thanks for reporting those issues. Comments see below. Stefan

On 04/05/2012 11:09 AM, vol...@ar... wrote:
> Hi Stefan.
> the download of the new release worked for me without problems.
>
> 2 issues of minor level.
> 1. when leaving the configuration window, the message say please use save or save as... Button. There is no save-Button. see Screenshot.

The save or save as buttons are part of the Config-Window, not the 
dialogue displayed. The save button is not displayed yet as you cannot 
save to a predefined profile directly, so it is not active at that 
moment. This dialogue was a quick fix to a complain that it is not clear
what happens after closing the ConfigWindow. So expect to a better 
behavior sometime in the future.

> 2. 18EU, selecting a minor company for Bid, decline the bid. the next player gets only a tiny button without the text "select no bid", see screenshot and save-file.

Yes that is the third type of a pass action ("DeclineToBid"), which had 
no icon/icon text defined by Frederick, as this text is specific to the 
18EU startround. Fixed in Rails1.7.x branch (but not merged into master 
yet). Workaround is to click on the tiny button (with no text).

>
> greetings Volker
>

Re: [Rails-devel] Version 1.7.0 has stopped working

[Mike B. <com...@ip...>]

Hi Stefan:

1.7.2 has fixed the loading problem for me as well, it was probably the same
problem.

I'll now try to recreate the UI problems and if I can will start a new
thread with a saved game, but hopefully they have also been fixed! If they
have, I will reply to that effect on this thread.

Mike Bourke
Campaign Mastery http://www.campaignmastery.com
Co-author, Assassin's Amulet http://www.legaciescampaignsetting.com



-----Original Message-----
From: Stefan Frey [mailto:ste...@we...] 
Sent: Thursday, 5 April 2012 3:01 AM
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Version 1.7.0 has stopped working

Mike:
thanks for the 18Kaas save file.

Please try the new release 1.7.2. which fixes a similar behavior 
experienced by Phil Davies using 1.7.1 on a Windows system.

Hope that helps.

Stefan



On 04/04/2012 06:53 AM, Mike Bourke wrote:
> Sorry, cannot provide the game files because the game never gets as far
> as generating them. As I said, in trying to fix the problem I deleted
> **everything** that was in the game directories and replaced them with
> fresh copies from the zipped distribution file.
>
> The batch file runs, and reaches the point where I would expect to see
> the window open where you can specify player names, load past games, etc
> but all that happens is that the batch file window closes.
>
> It doesn't appear to be a java problem or an installation problem
> because 1.6.3 still works. The log file that I included (also attached
> to this message) is the only information that I could find produced by
> the attempt to start the game.
>
> Equally obviously, I cannot forward any game files relating to the 1.7.0
> problems because they have also been wiped out during the attempted
> reinstall. Once I get 1.7.0 working again, I'll be happy to create game
> saves for you showing the User Interface problems.
>
> But I am attaching the 18Kaas game file you requested (1.6.3), saved
> immediately prior to the final "done" of the game - you can step back to
> any point you desire to test changes.
>
> I think I have finally sorted out the subscription issues at least
> enough that I should get your messages and be able to reply to the
> thread properly from this point on. Unfortunately, I haven't been able
> to find a "reply to" function to connect this reply with the thread
> started on the subject.
>
> Mike Bourke
>
> Campaign Mastery http://www.campaignmastery.com
> <http://www.campaignmastery.com/>
>
> Co-author, /Assassin's Amulet /http://www.legaciescampaignsetting.com
> <http://www.legaciescampaignsetting.com/>
>
>
>
>
>
> ---
> avast! Antivirus: Outbound message clean.
> Virus Database (VPS): 120403-0, 03/04/2012
> Tested on: 4/04/2012 2:53:15 PM
> avast! - copyright (c) 1988-2012 AVAST Software.
> http://www.avast.com
>
>
>
>
>
>
>
>
----------------------------------------------------------------------------
--
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel


----------------------------------------------------------------------------
--
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel



---
avast! Antivirus: Outbound message clean.
Virus Database (VPS): 120404-0, 04/04/2012
Tested on: 5/04/2012 7:25:13 PM
avast! - copyright (c) 1988-2012 AVAST Software.
http://www.avast.com

Re: [Rails-devel] [Rails-users] Release Rails 1.7.2 available

[Mike B. <com...@ip...>]

Download worked fine. I note that the home page
http://rails.sourceforge.net/ has not been updated since the release of
1.7.0, however.

Mike Bourke
Campaign Mastery http://www.campaignmastery.com
Co-author, Assassin's Amulet http://www.legaciescampaignsetting.com


-----Original Message-----
From: vol...@ar... [mailto:vol...@ar...] 
Sent: Thursday, 5 April 2012 7:10 PM
To: rai...@li...
Subject: [Rails-devel] [Rails-users] Release Rails 1.7.2 available

Hi Stefan.
the download of the new release worked for me without problems.

2 issues of minor level.
1. when leaving the configuration window, the message say please use save or
save as... Button. There is no save-Button. see Screenshot.
2. 18EU, selecting a minor company for Bid, decline the bid. the next player
gets only a tiny button without the text "select no bid", see screenshot and
save-file.

greetings Volker


----- Original Nachricht ----
> Phil:
> Seems to be an ongoing issue.
> 
> Out of 10 tries I only get 1 complete listing of the complete folder and
> all files in 1.7.2.
> Once I was even able to set the properties on the files.
> The weird experience was that from the other 9 failed tries the results 
> were often different (sometimes the folder was not existent, sometimes 
> empty, sometimes it showed the readme ...)
> 
> Sourceforge recently changed it filepaths (see 
>
http://sourceforge.net/apps/wordpress/sourceforge/2012/03/09/file-release-sy
> stem-permissions-updates/), 
> but for the first upload I used the same URI as for the 1.7.1 release 
> one day before.
> 
> I deleted the complete folder and uploaded everything again (using the 
> new upload URIs), but no success.
> 
> If nothing changes until start of US business day, I will file a ticket.
> 
> Stefan
> 


-- 
Volker Schnell
email: vol...@ar...
homepage: home.arcor.de\volker_schnell



---
avast! Antivirus: Outbound message clean.
Virus Database (VPS): 120404-0, 04/04/2012
Tested on: 5/04/2012 7:19:53 PM
avast! - copyright (c) 1988-2012 AVAST Software.
http://www.avast.com

Re: [Rails-devel] [Rails-users] Release Rails 1.7.2 available

[Stefan F. <ste...@we...>]

Phil:
Seems to be an ongoing issue.

Out of 10 tries I only get 1 complete listing of the complete folder and
all files in 1.7.2.
Once I was even able to set the properties on the files.
The weird experience was that from the other 9 failed tries the results 
were often different (sometimes the folder was not existent, sometimes 
empty, sometimes it showed the readme ...)

Sourceforge recently changed it filepaths (see 
http://sourceforge.net/apps/wordpress/sourceforge/2012/03/09/file-release-system-permissions-updates/), 
but for the first upload I used the same URI as for the 1.7.1 release 
one day before.

I deleted the complete folder and uploaded everything again (using the 
new upload URIs), but no success.

If nothing changes until start of US business day, I will file a ticket.

Stefan


On 04/05/2012 07:52 AM, Phil Davies wrote:
> I think there is something wonky with the hosting for the 1.7.2 files, I
> can only see the 1.7.1 download:
>
> Inline images 1
>
> On 4 April 2012 17:58, Stefan Frey <ste...@we...
> <mailto:ste...@we...>> wrote:
>
>     A new maintenance release for Rails 1.x series
>
>     Downloads are available at http://rails.sourceforge.net/ or by the
>     direct link http://sourceforge.net/projects/rails/files/Rails/1.7.2/
>
>     Remark: Unfortunately sourceforge is slow today, so please be patient
>     until the new release is available.
>
>     This (quick) release fixes a critical error that could prevent Rails to
>     start after changing the configuration settings
>     on Windows systems.
>
>     Contributors: Erik Vos, Stefan Frey
>
>     Bugs reported by John David Galt, Phil Davies
>
>     Bugs fixed:
>     - Fixed error in creation of new profiles on Windows OS systems
>     - Made configuration system more robust against corrupted/misconfigured
>     profiles
>     - Fixed missing options after "Destinations reached" dialogue without
>     any selection
>
>     ------------------------------------------------------------------------------
>     Better than sec? Nothing is better than sec when it comes to
>     monitoring Big Data applications. Try Boundary one-second
>     resolution app monitoring today. Free.
>     http://p.sf.net/sfu/Boundary-dev2dev
>     _______________________________________________
>     Rails-users mailing list
>     Rai...@li...
>     <mailto:Rai...@li...>
>     https://lists.sourceforge.net/lists/listinfo/rails-users
>
>

Re: [Rails-devel] Version 1.7.0 has stopped working

[Stefan F. <ste...@we...>]

Mike:
thanks for the 18Kaas save file.

Please try the new release 1.7.2. which fixes a similar behavior 
experienced by Phil Davies using 1.7.1 on a Windows system.

Hope that helps.

Stefan



On 04/04/2012 06:53 AM, Mike Bourke wrote:
> Sorry, cannot provide the game files because the game never gets as far
> as generating them. As I said, in trying to fix the problem I deleted
> **everything** that was in the game directories and replaced them with
> fresh copies from the zipped distribution file.
>
> The batch file runs, and reaches the point where I would expect to see
> the window open where you can specify player names, load past games, etc
> but all that happens is that the batch file window closes.
>
> It doesn’t appear to be a java problem or an installation problem
> because 1.6.3 still works. The log file that I included (also attached
> to this message) is the only information that I could find produced by
> the attempt to start the game.
>
> Equally obviously, I cannot forward any game files relating to the 1.7.0
> problems because they have also been wiped out during the attempted
> reinstall. Once I get 1.7.0 working again, I’ll be happy to create game
> saves for you showing the User Interface problems.
>
> But I am attaching the 18Kaas game file you requested (1.6.3), saved
> immediately prior to the final “done” of the game – you can step back to
> any point you desire to test changes.
>
> I think I have finally sorted out the subscription issues at least
> enough that I should get your messages and be able to reply to the
> thread properly from this point on. Unfortunately, I haven’t been able
> to find a “reply to” function to connect this reply with the thread
> started on the subject.
>
> Mike Bourke
>
> Campaign Mastery http://www.campaignmastery.com
> <http://www.campaignmastery.com/>
>
> Co-author, /Assassin’s Amulet /http://www.legaciescampaignsetting.com
> <http://www.legaciescampaignsetting.com/>
>
>
>
>
>
> ---
> avast! Antivirus: Outbound message clean.
> Virus Database (VPS): 120403-0, 03/04/2012
> Tested on: 4/04/2012 2:53:15 PM
> avast! - copyright (c) 1988-2012 AVAST Software.
> http://www.avast.com
>
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bug: 1856, 1.7.0

[Erik V. <eri...@xs...>]

Bug found and fixed.  

After a non-modal dialog action that is not followed by any action to be
sent to the game engine, a null action must be processed in the UI to ensure
that the current window gets properly updated.  That was not provided for in
this case.

Erik.

> -----Original Message-----
> From: John David Galt [mailto:jd...@di...]
> Sent: Monday, April 02, 2012 6:59 AM
> To: rai...@li...
> Subject: [Rails-devel] Bug: 1856, 1.7.0
> 
> At the point of this save file, I used the menu item "Special ->
Destinations
> Reached" to check whether I had recorded the companies that have
> destinated.
> 
> As soon as I did so, the "Done" button became grayed out.
> 
> In order to continue the game after that, I had to undo, then redo the
"Set
> Revenue" step.

Re: [Rails-devel] Version 1.7.0 has stopped working

[Stefan F. <ste...@we...>]

Mike:
could you please send me game files for both occasions:

A) Where Rails 1.7.0 behaves badly and closes all windows.
B) Where revenue calculation for diesels and other trains is skewed.

In a recent post to the list I already listed a few UI bugs in 1.7.0 
which are most-likely side-effects from Frederick's new code, I quote 
those below.

 >
 > * The viewport of the map previously changed actively to show more of
 > the network of the active company when the active company changes.
 > This behavior seems to be deactivated now.
 >
 > * After activating the option to display the best route outside the
 > revenue step does not work (anymore).
 >
 > * Network Info only displays shows dialog for the best route, but does
 > not display best routes on the map.

Thanks a lot for your help.

Stefan

PS: Test games are (usually) version-independent. There are many test 
cases still used ranging back into 1.3 versions.


On 04/03/2012 01:51 PM, Mike Bourke wrote:
> Hi folks,
>
> It seems I have run into a spot of trouble: Rails 1.7.0 has stopped
> working. The game will partially start and then all windows will close.
> The closest thing I can identify to a crash report is the attached log
> file, but I don’t know how much help it will be. Rails 1.6.3 still
> loads. Before it stopped working the game had frozen and I was forced to
> crash the program. This is a recurring issue in endgame situations but
> especially bad in the Canadian game. I suspect this may have corrupted a
> key file but I have tried overwriting everything using the original zip
> archive without success.
>
> I can also report a couple of bugs in the general interface of 1.7.0
> that I did not see noted in the support requests: Once diesels arrive,
> games will only show the route followed by the diesel, any lesser train
> is ignored in terms of display. At the same time, the value of the
> contribution made by the lesser train is shown as 0, but the total
> earned is greater than the amount shown for the diesel alone by what
> appears to be the correct amount. This bug had manifested in several
> different games that I had played (I was working my way through them all
> systematically), starting with 1830.
>
> Stefan, for some reason I did not get your reply to my previous error report
>
> http://sourceforge.net/mailarchive/forum.php?thread_name=000001cd0e60%24a6a45810%24f3ed0830%24%40xs4all.nl&forum_name=rails-devel
> <http://sourceforge.net/mailarchive/forum.php?thread_name=000001cd0e60%24a6a45810%24f3ed0830%24%40xs4all.nl&forum_name=rails-devel>
>
> so I’m afraid I can’t send you the finished game, but I’d be happy to
> play out another one to generate a test case for you. Until I can get
> 1.7.0 up and running, though, this would have to be a 1.6.3 game.
>
> Mike Bourke
>
> Campaign Mastery http://www.campaignmastery.com
> <http://www.campaignmastery.com/>
>
> Co-author, /Assassin’s Amulet /http://www.legaciescampaignsetting.com
> <http://www.legaciescampaignsetting.com/>
>
>
>
>
>
> ---
> avast! Antivirus: Outbound message clean.
> Virus Database (VPS): 120403-0, 03/04/2012
> Tested on: 3/04/2012 9:51:17 PM
> avast! - copyright (c) 1988-2012 AVAST Software.
> http://www.avast.com
>
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] [Rails-users] Release Rails 1.7.1 available

[Stefan F. <ste...@we...>]

Phil:
no that is not the intended behavior ;-)
If I follow your steps on my system everything works correct.
In 1.7.1 it even updates the SetupWindow automatically to select the new 
profile.

However my 18xx.log shows an error because (due to an automatic check 
that the active profile is loaded gets executed before the storage), but 
this should not impact the Rails behavior.

Could you please send me your 18xx.log (still located inside the working 
directory).

Stefan

On 04/03/2012 12:42 PM, Phil Davies wrote:
> Stefan,
>
> I'm still getting strange behaviour with the configuration options on
> windows.
>
> Start Rails
> Click Configuration
> Alter the settings I want
> Click Save As
> Type in 'PhilDefault'
> Click OK
> This drops me back to the configuration window where seemingly nothing
> has changed, I'd kind of expect it to send me back to the 'start game'
> window
> Close the configuration window
> My 'PhilDefault' configuration option doesn't appear in the list of
> configurations.  Even restarting rails doesn't make them show up.
>
> Am I doing something weird?
>
>
> On 3 April 2012 11:26, Stefan Frey <ste...@we...
> <mailto:ste...@we...>> wrote:
>
>     A new maintenance release for Rails 1.x series
>
>     Downloads are available at http://rails.sourceforge.net/ or by the
>     direct link http://sourceforge.net/projects/rails/files/Rails/1.7.1/
>
>     This release fixes several recent bugs.
>
>     Contributors: Erik Vos, Martin Brumm, Stefan Frey
>
>     Bugs reported by John David Galt, Volker Schnell, Mike Bourke, Arne
>     Östlund, Jerry Anderson
>     (I hope I forgot to list no one).
>
>     A few minor improvements to the rails setup:
>     - An (initial) configuration profile for face-to-face/hotseat play is
>     added ("hotseat"): Activates autosave and changes filename pattern
>     suggested for save.
>     - Windows settings (including docking settings if activated) and
>     autosave backup are stored in the centralized rails configuraton folder.
>     Thus from this release on those settings should survive upgrades to new
>     releases.
>
>     List of bugs fixed:
>
>     - Typo in manifest that caused image errors in some background maps
>     - 18EU: Not possible to lay home token for companies started outside of
>     current network.
>     - 1856, 18EU, 1830 Coalfield and others: Fixed wrong calculation for
>     routes for Goderich tile, red off-board run-through (-939)
>     - 18Kaas: Enables unlimited D-trains option
>     - 1835: Fixed wrong total player worth calculation
>     - 1835: Fixed wrong revenue calculation with respect to Elsas/Alsace
>     outside of green phase
>
>     ------------------------------------------------------------------------------
>     Better than sec? Nothing is better than sec when it comes to
>     monitoring Big Data applications. Try Boundary one-second
>     resolution app monitoring today. Free.
>     http://p.sf.net/sfu/Boundary-dev2dev
>     _______________________________________________
>     Rails-users mailing list
>     Rai...@li...
>     <mailto:Rai...@li...>
>     https://lists.sourceforge.net/lists/listinfo/rails-users
>
>
>
>
> ------------------------------------------------------------------------------
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] [Rails-users] Release Rails 1.7.1 available

[Phil D. <de...@gm...>]

Stefan,

I'm still getting strange behaviour with the configuration options on
windows.

Start Rails
Click Configuration
Alter the settings I want
Click Save As
Type in 'PhilDefault'
Click OK
This drops me back to the configuration window where seemingly nothing has
changed, I'd kind of expect it to send me back to the 'start game' window
Close the configuration window
My 'PhilDefault' configuration option doesn't appear in the list of
configurations.  Even restarting rails doesn't make them show up.

Am I doing something weird?


On 3 April 2012 11:26, Stefan Frey <ste...@we...> wrote:

> A new maintenance release for Rails 1.x series
>
> Downloads are available at http://rails.sourceforge.net/ or by the
> direct link http://sourceforge.net/projects/rails/files/Rails/1.7.1/
>
> This release fixes several recent bugs.
>
> Contributors: Erik Vos, Martin Brumm, Stefan Frey
>
> Bugs reported by John David Galt, Volker Schnell, Mike Bourke, Arne
> Östlund, Jerry Anderson
> (I hope I forgot to list no one).
>
> A few minor improvements to the rails setup:
> - An (initial) configuration profile for face-to-face/hotseat play is
> added ("hotseat"): Activates autosave and changes filename pattern
> suggested for save.
> - Windows settings (including docking settings if activated) and
> autosave backup are stored in the centralized rails configuraton folder.
> Thus from this release on those settings should survive upgrades to new
> releases.
>
> List of bugs fixed:
>
> - Typo in manifest that caused image errors in some background maps
> - 18EU: Not possible to lay home token for companies started outside of
> current network.
> - 1856, 18EU, 1830 Coalfield and others: Fixed wrong calculation for
> routes for Goderich tile, red off-board run-through (-939)
> - 18Kaas: Enables unlimited D-trains option
> - 1835: Fixed wrong total player worth calculation
> - 1835: Fixed wrong revenue calculation with respect to Elsas/Alsace
> outside of green phase
>
>
> ------------------------------------------------------------------------------
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
> _______________________________________________
> Rails-users mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-users
>

Re: [Rails-devel] Bug: 1835, 1.7.0

[Erik V. <eri...@xs...>]

Stefan,

Perhaps a neat 1.x-style solution would be to create (perhaps two separate)
inner State subclasses to maintain the MapHex tile and token states.
This would be similar to what I'm working on for the player order (but it
only partly works yet).

Whether or not this will really materialize before Rails 2.0 becomes master
remains to be seen.

Erik. 

> -----Original Message-----
> From: Stefan Frey [mailto:ste...@we...]
> Sent: Monday, April 02, 2012 9:31 AM
> To: rai...@li...
> Subject: Re: [Rails-devel] Bug: 1835, 1.7.0
> 
> Erik:
> those kind of problems were the motivation for starting coding on
Rails2.0.
> Actually HexMap is the one the classes that I am currently refactoring to
add
> those new elements I have created for this reason.
> But it is one of the harder cases.
> 
> So at this point you have to consider if you really want to fix that
inside the
> Rails1.x branch or you want jump ship and get involved in
> Rails2.0 at some point in time.
> 
> Stefan
> 
> 
> On 04/01/2012 11:46 PM, Erik Vos wrote:
> > It should be possible to reconstruct earlier stages by repeated undoing.
> > That works to some extent here, but it also reveals another bug: the
> > PR tokens do not disappear when PR formation is undone, and the minor
> > tokens do not return.
> > I'm pretty sure that this is due to the need for an explicit update()
> > in
> > HexMap.layBaseToken() (line ; that must have the consequence that
> > update() is not called on an undo.
> > If I then save the game and reload it, the PR tokens are gone and the
> > minor tokens reappear, which more or less proves the above analysis.
> >
> >> From that earlier saved file I can indeed confirm the reported bug.
> >> On
> > first sight, I cannot find a clear reason why this is so, but my guess
> > is that it's another missing update().
> >
> > I'll look for an easy fix, but I'm actually afraid that it's a real
> > design flaw.
> > All this could even mean that having HexMap extend ModelObject was a
> > bad idea (although it seems to work for tile lays).
> > Anyhow,  I'll reconsider the whole subject of Observing token lays.
> >
> > Erik
> >
> >> -----Original Message-----
> >> From: Dr. Martin Brumm [mailto:dr....@t-...]
> >> Sent: Sunday, April 01, 2012 9:03 PM
> >> To: 'Development list for Rails: an 18xx game'
> >> Cc: jd...@di...
> >> Subject: Re: [Rails-devel] Bug: 1835, 1.7.0
> >>
> >> Hi John,
> >> On loading the save file everything is ok.
> >>
> >> Please send an earlier save file if possible.
> >>
> >> Regards,
> >> Martin
> >>
> >> -----Ursprüngliche Nachricht-----
> >> Von: John David Galt [mailto:jd...@di...]
> >> Gesendet: Sonntag, 1. April 2012 20:29
> >> An: rai...@li...
> >> Betreff: [Rails-devel] Bug: 1835, 1.7.0
> >>
> >> In the operating round just finished, PR formed and all its privates
> >> and
> > minors
> >> merged.  However, the M5 head in Berlin has not gone away as it should.
> >>
> >>
> >>
> >>
> > ----------------------------------------------------------------------
> > ------
> > --
> >> This SF email is sponsosred by:
> >> Try Windows Azure free for 90 days Click Here
> >> http://p.sf.net/sfu/sfd2d- msazure
> >> _______________________________________________
> >> Rails-devel mailing list
> >> Rai...@li...
> >> https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> >
> >
> > ----------------------------------------------------------------------
> > --------
> > This SF email is sponsosred by:
> > Try Windows Azure free for 90 days Click Here
> > http://p.sf.net/sfu/sfd2d-msazure
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> 
>
----------------------------------------------------------------------------
--
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-
> msazure _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bug: 1835, 1.7.0

[Erik V. <eri...@xs...>]

> So I will provide a StaticModifier similar to the one used for Birmingham
in
> 1851 (or was it 18TN - cannot remember now)?

It was 1851 indeed.  

Erik

Re: [Rails-devel] Worth-Calculation for 1835

[Phil D. <de...@gm...>]

I would always personally favour stating net worth as 'what if the
game ended right now' but I appreciate this is a highly subjective
area

On 2 April 2012 08:28, Stefan Frey <ste...@we...> wrote:
> Last time this discussion came up I wrote down an algorithm that tried
> to tackle that issue on a general level. However it did not attract much
> love at that time.
> So I will wait for better suggestions, but I am still reluctant to
> implement that on a case-by-case basis.
> Stefan
>
> On 04/02/2012 03:02 AM, Chris Shaffer wrote:
>> This is a more global discussion than just 1835.  The question is
>> whether to show net worth for a presumed "reasonable expectation of what
>> will happen and when the game will end" or to show the net worth "if the
>> game ended right now."  Any game with disappearing privates that have
>> value during existence will be affected, but other scenarios are also
>> affected.
>>
>> I recommend if you decide to display the former, you give players an
>> option to also calculate and view the figures for the latter.
>>
>> --
>> Chris
>>
>> Please consider the environment before printing this e-mail.
>>
>>
>> On Sun, Apr 1, 2012 at 11:36 AM, John David Galt
>> <jd...@di... <mailto:jd...@di...>>
>> wrote:
>>
>>     On 2012-04-01 04:59, Erik Vos wrote:
>>      >> I found an issue about the worth-calcualtion in Rails for the
>>      >> 1835-Variant.
>>      >> Maybe the Pru shares counts double.
>>
>>      > Thanks for catching this bug, and for pointing me in exactly the
>>     right
>>      > direction for a solution.
>>      >
>>      > The PR is unique in that the market price corresponds to *two*
>>     (5%) share
>>      > units. This fact was overlooked in the worth calculation.
>>      > I have pushed a fix to the master branch.
>>
>>     I have another small issue with the net worth calculation for 1835:
>>     LD is
>>     shown at face value, even though it will quickly disappear for nothing.
>>     (This makes that player appear to have a large negative income in
>>     the round
>>     when SX floats.)  I recommend counting it as zero.  Likewise the B&O
>>     private
>>     and those like it in other games.
>>
>>     ------------------------------------------------------------------------------
>>     This SF email is sponsosred by:
>>     Try Windows Azure free for 90 days Click Here
>>     http://p.sf.net/sfu/sfd2d-msazure
>>     _______________________________________________
>>     Rails-devel mailing list
>>     Rai...@li...
>>     <mailto:Rai...@li...>
>>     https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> This SF email is sponsosred by:
>> Try Windows Azure free for 90 days Click Here
>> http://p.sf.net/sfu/sfd2d-msazure
>>
>>
>>
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] 1880 Opening Bids Error

[<Dr....@t-...>]

Hi Tom, 

	i'll gonna look into that this evening. 

Thanks for reporting! 

	Regards, 

	Martin  

	Von: "Tom McCorry" <tom...@gm...> 

	An: "'Development list for Rails: an 18xx game'"
<rai...@li...> 

	Betreff: [Rails-devel] 1880 Opening Bids Error 

	Datum: Mon, 02 Apr 2012 04:31:19 +0200 

	A few errors noted in 1880 Rails Alpha 5: 

	1)      Until a person makes an initial bid, the up/down arrows next
to the bid window do not work. Once a bid has been made in that round,
the buttons work normally. The problem occurs again when the next item
goes up for auction. 

	2)      See attached game file. Bidding for P4 is occurring. The
first person passes, the next person bids $75, the next bids $80, and
fourth passes. The software goes back to Player 1 who passed rather
than Player 2. 

	Tom McCorry

Re: [Rails-devel] Bug: 1835, 1.7.0

[Stefan F. <ste...@we...>]

Erik:
those kind of problems were the motivation for starting coding on 
Rails2.0. Actually HexMap is the one the classes that I am currently 
refactoring to add those new elements I have created for this reason.
But it is one of the harder cases.

So at this point you have to consider if you really want to fix that 
inside the Rails1.x branch or you want jump ship and get involved in 
Rails2.0 at some point in time.

Stefan


On 04/01/2012 11:46 PM, Erik Vos wrote:
> It should be possible to reconstruct earlier stages by repeated undoing.
> That works to some extent here, but it also reveals another bug: the PR
> tokens do not disappear when PR formation is undone, and the minor tokens do
> not return.
> I'm pretty sure that this is due to the need for an explicit update() in
> HexMap.layBaseToken() (line ; that must have the consequence that update()
> is not called on an undo.
> If I then save the game and reload it, the PR tokens are gone and the minor
> tokens reappear, which more or less proves the above analysis.
>
>> From that earlier saved file I can indeed confirm the reported bug.  On
> first sight, I cannot find a clear reason why this is so, but my guess is
> that it's another missing update().
>
> I'll look for an easy fix, but I'm actually afraid that it's a real design
> flaw.
> All this could even mean that having HexMap extend ModelObject was a bad
> idea (although it seems to work for tile lays).
> Anyhow,  I'll reconsider the whole subject of Observing token lays.
>
> Erik
>
>> -----Original Message-----
>> From: Dr. Martin Brumm [mailto:dr....@t-...]
>> Sent: Sunday, April 01, 2012 9:03 PM
>> To: 'Development list for Rails: an 18xx game'
>> Cc: jd...@di...
>> Subject: Re: [Rails-devel] Bug: 1835, 1.7.0
>>
>> Hi John,
>> On loading the save file everything is ok.
>>
>> Please send an earlier save file if possible.
>>
>> Regards,
>> Martin
>>
>> -----Ursprüngliche Nachricht-----
>> Von: John David Galt [mailto:jd...@di...]
>> Gesendet: Sonntag, 1. April 2012 20:29
>> An: rai...@li...
>> Betreff: [Rails-devel] Bug: 1835, 1.7.0
>>
>> In the operating round just finished, PR formed and all its privates and
> minors
>> merged.  However, the M5 head in Berlin has not gone away as it should.
>>
>>
>>
>>
> ----------------------------------------------------------------------------
> --
>> This SF email is sponsosred by:
>> Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-
>> msazure _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Worth-Calculation for 1835

[Stefan F. <ste...@we...>]

Last time this discussion came up I wrote down an algorithm that tried
to tackle that issue on a general level. However it did not attract much 
love at that time.
So I will wait for better suggestions, but I am still reluctant to 
implement that on a case-by-case basis.
Stefan

On 04/02/2012 03:02 AM, Chris Shaffer wrote:
> This is a more global discussion than just 1835.  The question is
> whether to show net worth for a presumed "reasonable expectation of what
> will happen and when the game will end" or to show the net worth "if the
> game ended right now."  Any game with disappearing privates that have
> value during existence will be affected, but other scenarios are also
> affected.
>
> I recommend if you decide to display the former, you give players an
> option to also calculate and view the figures for the latter.
>
> --
> Chris
>
> Please consider the environment before printing this e-mail.
>
>
> On Sun, Apr 1, 2012 at 11:36 AM, John David Galt
> <jd...@di... <mailto:jd...@di...>>
> wrote:
>
>     On 2012-04-01 04:59, Erik Vos wrote:
>      >> I found an issue about the worth-calcualtion in Rails for the
>      >> 1835-Variant.
>      >> Maybe the Pru shares counts double.
>
>      > Thanks for catching this bug, and for pointing me in exactly the
>     right
>      > direction for a solution.
>      >
>      > The PR is unique in that the market price corresponds to *two*
>     (5%) share
>      > units. This fact was overlooked in the worth calculation.
>      > I have pushed a fix to the master branch.
>
>     I have another small issue with the net worth calculation for 1835:
>     LD is
>     shown at face value, even though it will quickly disappear for nothing.
>     (This makes that player appear to have a large negative income in
>     the round
>     when SX floats.)  I recommend counting it as zero.  Likewise the B&O
>     private
>     and those like it in other games.
>
>     ------------------------------------------------------------------------------
>     This SF email is sponsosred by:
>     Try Windows Azure free for 90 days Click Here
>     http://p.sf.net/sfu/sfd2d-msazure
>     _______________________________________________
>     Rails-devel mailing list
>     Rai...@li...
>     <mailto:Rai...@li...>
>     https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bug: 1835, 1.7.0

[Stefan F. <ste...@we...>]

John David:
this error is confirmed:
The value for Alsace is zero for the non-valid periods.

I was tempted to make off-board hexes blocked for zero value, however
there is no reason why not a designer choose to add an off-board area
with a zero value but still being a valid destination.

So I will provide a StaticModifier similar to the one used for 
Birmingham in 1851 (or was it 18TN - cannot remember now)?

Stefan


On 04/01/2012 11:59 PM, John David Galt wrote:
> On 2012-04-01 12:02, Dr. Martin Brumm wrote:
>> Hi John,
>> On loading the save file everything is ok.
>
> That's true for me also.  Probably Erik is right, it just needs to do a refresh.
>
> Later in the same game, I run into this: the route calculator allows a run into
> the Alsace-Lorraine for zero (which is against the rules).
>
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

[Rails-devel] Bug: 1856, 1.7.0

[John D. G. <jd...@di...>]

At the point of this save file, I used the menu item "Special -> Destinations
Reached" to check whether I had recorded the companies that have destinated.

As soon as I did so, the "Done" button became grayed out.

In order to continue the game after that, I had to undo, then redo the "Set
Revenue" step.

Re: [Rails-devel] Worth-Calculation for 1835

[Chris S. <chr...@gm...>]

This is a more global discussion than just 1835.  The question is whether
to show net worth for a presumed "reasonable expectation of what will
happen and when the game will end" or to show the net worth "if the game
ended right now."  Any game with disappearing privates that have value
during existence will be affected, but other scenarios are also affected.

I recommend if you decide to display the former, you give players an option
to also calculate and view the figures for the latter.

--
Chris

Please consider the environment before printing this e-mail.


On Sun, Apr 1, 2012 at 11:36 AM, John David Galt <
jd...@di...> wrote:

> On 2012-04-01 04:59, Erik Vos wrote:
> >> I found an issue about the worth-calcualtion in Rails for the
> >> 1835-Variant.
> >> Maybe the Pru shares counts double.
>
> > Thanks for catching this bug, and for pointing me in exactly the right
> > direction for a solution.
> >
> > The PR is unique in that the market price corresponds to *two* (5%) share
> > units. This fact was overlooked in the worth calculation.
> > I have pushed a fix to the master branch.
>
> I have another small issue with the net worth calculation for 1835: LD is
> shown at face value, even though it will quickly disappear for nothing.
> (This makes that player appear to have a large negative income in the round
> when SX floats.)  I recommend counting it as zero.  Likewise the B&O
> private
> and those like it in other games.
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Bug: 1835, 1.7.0

[John D. G. <jd...@di...>]

On 2012-04-01 12:02, Dr. Martin Brumm wrote:
> Hi John,
> On loading the save file everything is ok.

That's true for me also.  Probably Erik is right, it just needs to do a refresh.

Later in the same game, I run into this: the route calculator allows a run into
the Alsace-Lorraine for zero (which is against the rules).

Re: [Rails-devel] Bug: 1835, 1.7.0

[Erik V. <eri...@xs...>]

It should be possible to reconstruct earlier stages by repeated undoing.
That works to some extent here, but it also reveals another bug: the PR
tokens do not disappear when PR formation is undone, and the minor tokens do
not return.
I'm pretty sure that this is due to the need for an explicit update() in
HexMap.layBaseToken() (line ; that must have the consequence that update()
is not called on an undo.
If I then save the game and reload it, the PR tokens are gone and the minor
tokens reappear, which more or less proves the above analysis.

>From that earlier saved file I can indeed confirm the reported bug.  On
first sight, I cannot find a clear reason why this is so, but my guess is
that it's another missing update().

I'll look for an easy fix, but I'm actually afraid that it's a real design
flaw.
All this could even mean that having HexMap extend ModelObject was a bad
idea (although it seems to work for tile lays). 
Anyhow,  I'll reconsider the whole subject of Observing token lays.

Erik

> -----Original Message-----
> From: Dr. Martin Brumm [mailto:dr....@t-...]
> Sent: Sunday, April 01, 2012 9:03 PM
> To: 'Development list for Rails: an 18xx game'
> Cc: jd...@di...
> Subject: Re: [Rails-devel] Bug: 1835, 1.7.0
> 
> Hi John,
> On loading the save file everything is ok.
> 
> Please send an earlier save file if possible.
> 
> Regards,
> Martin
> 
> -----Ursprüngliche Nachricht-----
> Von: John David Galt [mailto:jd...@di...]
> Gesendet: Sonntag, 1. April 2012 20:29
> An: rai...@li...
> Betreff: [Rails-devel] Bug: 1835, 1.7.0
> 
> In the operating round just finished, PR formed and all its privates and
minors
> merged.  However, the M5 head in Berlin has not gone away as it should.
> 
> 
> 
>
----------------------------------------------------------------------------
--
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-
> msazure _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bug: 1835, 1.7.0

[Dr. M. B. <dr....@t-...>]

Hi John,
On loading the save file everything is ok.

Please send an earlier save file if possible.

Regards,
Martin

-----Ursprüngliche Nachricht-----
Von: John David Galt [mailto:jd...@di...] 
Gesendet: Sonntag, 1. April 2012 20:29
An: rai...@li...
Betreff: [Rails-devel] Bug: 1835, 1.7.0

In the operating round just finished, PR formed and all its privates and
minors merged.  However, the M5 head in Berlin has not gone away as it
should.

Re: [Rails-devel] Worth-Calculation for 1835

[John D. G. <jd...@di...>]

On 2012-04-01 04:59, Erik Vos wrote:
>> I found an issue about the worth-calcualtion in Rails for the
>> 1835-Variant.
>> Maybe the Pru shares counts double.

> Thanks for catching this bug, and for pointing me in exactly the right
> direction for a solution.
> 
> The PR is unique in that the market price corresponds to *two* (5%) share
> units. This fact was overlooked in the worth calculation.
> I have pushed a fix to the master branch.

I have another small issue with the net worth calculation for 1835: LD is
shown at face value, even though it will quickly disappear for nothing.
(This makes that player appear to have a large negative income in the round
when SX floats.)  I recommend counting it as zero.  Likewise the B&O private
and those like it in other games.

[Rails-devel] Bug: 1835, 1.7.0

[John D. G. <jd...@di...>]

In the operating round just finished, PR formed and all its privates and
minors merged.  However, the M5 head in Berlin has not gone away as it should.

Re: [Rails-devel] Worth-Calculation for 1835

[Stefan F. <ste...@we...>]

Erik:
thanks. I have picked this and all other fixes from you into Rails1.7.x 
and updated the reports of those 1835 test cases that were effected, so 
that all test cases are successful again.
Will do the release for 1.7.1 later today.
Stefan


On 04/01/2012 01:59 PM, Erik Vos wrote:
>> I found an issue about the worth-calcualtion in Rails for the
> 1835-Variant.
>> Maybe the Pru shares counts double.
>
> Thanks for catching this bug, and for pointing me in exactly the right
> direction for a solution.
>
> The PR is unique in that the market price corresponds to *two* (5%) share
> units. This fact was overlooked in the worth calculation.
> I have pushed a fix to the master branch.
>
> Erik.
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Worth-Calculation for 1835

[Erik V. <eri...@xs...>]

> I found an issue about the worth-calcualtion in Rails for the
1835-Variant.
> Maybe the Pru shares counts double.

Thanks for catching this bug, and for pointing me in exactly the right
direction for a solution.

The PR is unique in that the market price corresponds to *two* (5%) share
units. This fact was overlooked in the worth calculation.
I have pushed a fix to the master branch.

Erik.