rails-devel — List for discussion of Rails development

Re: [Rails-devel] Fwd: Bug in 1830 Coalfields

[Stefan F. <ste...@we...>]

Arne:
thanks for catching this bug.

Actually that was an easy one to identify as this bug has been fixed (at 
least once) before but returned into the code again.

This is the Goderich (-939) tile missing the station tag in Tiles.xml.
The last commit to this Tiles.xml by Erik reverted the correct defintion 
again. I could have fixed this manually now, but as I know that Erik has 
an (semi-automated) creation process of Tiles.xml I would prefer him to 
look what had this bug return again.

Stefan


On 03/24/2012 12:55 PM, Arne Östlund wrote:
> 1830 Coalfield with the run through through Chicago and Gulf does not
> count right. I think Rails counts them as $0 for revenue. In the example
> file attached B&O runs for $730. But with a manual count B&O can gain
> $820 running through both Gulf and Chicago, The route shown ought to be
> $790 not $730. I.e. The Gulf is not counted by Rails. The same is true
> for Chicago.
>
> Regards,
> Arne Östlund
>
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Fwd: [18xx] 1880 rules question - starting location BCR stock token

[<Dr....@t-...>]

Thanks, 

	i'll adjust the code in the next days. 

	Kind regards, 

	Martin  

	Von: Chris Shaffer <chr...@gm...> 

	An: Rails Development List <rai...@li...> 

	Betreff: [Rails-devel] Fwd: [18xx] 1880 rules question - starting
location BCR stock token 

	Datum: Fri, 23 Mar 2012 17:05:03 +0100 

	    FYI

-- Chris Shaffer Please consider the environment before printing this
email.  
Begin forwarded message:

  From: Lonny <Lo...@ka... [1]>
Date: March 23, 2012 8:29:44 AM PDT
To: 18...@ya... [2]
Subject: Re: [18xx] 1880 rules question - starting location BCR stock
token
Reply-To: 18...@ya... [3]

   2012/3/23 Chris Shaffer <chr...@gm... [4]>

 The rules say:

 The owner of P6 receives the 20% Director's Certificate of the BCR.
The
  starting price of the company is automatically set at 100.

 In which of the four 100 price locations is the BCR token placed? If
it is
 variable, who makes the decision?

It is variable.
The owner of P6 who is director of the BCR makes this decision.

Lonny Orgler

 --
 Chris

 Please consider the environment before printing this e-mail.

 [Non-text portions of this message have been removed]

------------------------------------

This is a message from the 18xx mailing list.Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/18xx/ [5]

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/18xx/join [6]
    (Yahoo! ID required)

<*> To change settings via email:
    18x...@ya... [7] 
    18x...@ya... [8]

<*> To unsubscribe from this group, send an email to:
    18x...@ya... [9]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/ [10]

Links:
------
[1] mailto:Lo...@ka...
[2] mailto:18...@ya...
[3] mailto:18...@ya...
[4] mailto:chr...@gm...
[5] http://groups.yahoo.com/group/18xx/
[6] http://groups.yahoo.com/group/18xx/join
[7] mailto:18x...@ya...
[8] mailto:18x...@ya...
[9] mailto:18x...@ya...
[10] http://docs.yahoo.com/info/terms/

[Rails-devel] Fwd: [18xx] 1880 rules question - starting location BCR stock token

[Chris S. <chr...@gm...>]

FYI

--
Chris Shaffer

Please consider the environment before printing this email.

Begin forwarded message:

> From: Lonny <Lo...@ka...>
> Date: March 23, 2012 8:29:44 AM PDT
> To: 18...@ya...
> Subject: Re: [18xx] 1880 rules question - starting location BCR stock token
> Reply-To: 18...@ya...
> 
> 2012/3/23 Chris Shaffer <chr...@gm...>
>> 
>> 
>> 
>> The rules say:
>> 
>> The owner of P6 receives the 20% Director's Certificate of the BCR. The
>>> starting price of the company is automatically set at 100.
>> 
>> In which of the four 100 price locations is the BCR token placed? If it is
>> variable, who makes the decision?
> 
> It is variable.
> The owner of P6 who is director of the BCR makes this decision.
> 
> Lonny Orgler
> 
> 
>> 
>> --
>> Chris
>> 
>> Please consider the environment before printing this e-mail.
>> 
>> [Non-text portions of this message have been removed]
>> 
>> 
> 
> 
> ------------------------------------
> 
> This is a message from the 18xx mailing list.Yahoo! Groups Links
> 
> <*> To visit your group on the web, go to:
>    http://groups.yahoo.com/group/18xx/
> 
> <*> Your email settings:
>    Individual Email | Traditional
> 
> <*> To change settings online go to:
>    http://groups.yahoo.com/group/18xx/join
>    (Yahoo! ID required)
> 
> <*> To change settings via email:
>    18x...@ya... 
>    18x...@ya...
> 
> <*> To unsubscribe from this group, send an email to:
>    18x...@ya...
> 
> <*> Your use of Yahoo! Groups is subject to:
>    http://docs.yahoo.com/info/terms/
> 

Re: [Rails-devel] BugFix Release for Rails 1880 Alpha5 available

[Chris S. <chr...@gm...>]

1. I asked the rules question on the 18xx mailing list.

2. Shouldn't the system enforce the rules?  As I understand it, it would be
illegal for a player to choose an AB or a CD building right.

--
Chris

Please consider the environment before printing this e-mail.


On Fri, Mar 23, 2012 at 12:14 AM, Dr....@t-... <
Dr....@t-...> wrote:

> Hi Tom,
>
>
>
>  1) I have found no clue in the rules that the player is allowed to choose
> the position. Can you point me in that direction where to find that
> specific rule ? The window is a auxilliary construct to be able to have a
> jump in point for the following selection.
>
> 2) The player may choose to select any BuildingRights (even those that
> make absolutely no sense). But Rails is not programmed to do a decision for
> the player :).
>
> 3) Known Problem, Workaround is to save and reload the game. Erik was
> investigating on how to handle it. Internally the players are reordered the
> display is wrong.
>
>
>
> Regards,
>
> Martin
>
>
>
> *Von:* "Tom McCorry" <tom...@gm...>
>
> *An:* <Dr....@t-...>, "'Development list for Rails: an
> 18xx game'" <rai...@li...>
>
> *Betreff:* RE: [Rails-devel] BugFix Release for Rails 1880 Alpha5
> available
>
> *Datum:* Fri, 23 Mar 2012 02:02:14 +0100
>
>
>
>
>
> Errors noted in Alpha5 Auction:
>
>
>
> 1)      After buying BCR a window pops up for opening price with only
> $100 selected. The window that should pop up is which position within the
> 100 group the BCR will start.
>
> 2)      The BCR Building permits list all available permits. Since it is
> known it is a 20% share at this point, only the ABC and BCD build shares
> should be listed.
>
> 3)      Players are not reordered properly after the auction (least money
> to most money).
>
>
>
>
>
> Tom McCorry
>
>
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] BugFix Release for Rails 1880 Alpha5 available

[<Dr....@t-...>]

Hi Tom, 

	 1) I have found no clue in the rules that the player is allowed to
choose the position. Can you point me in that direction where to find
that specific rule ? The window is a auxilliary construct to be able
to have a jump in point for the following selection. 

	2) The player may choose to select any BuildingRights (even those
that make absolutely no sense). But Rails is not programmed to do a
decision for the player :). 

	3) Known Problem, Workaround is to save and reload the game. Erik was
investigating on how to handle it. Internally the players are
reordered the display is wrong. 

	Regards, 

	Martin  

	Von: "Tom McCorry" <tom...@gm...> 

	An: <Dr....@t-...>, "'Development list for Rails: an
18xx game'" <rai...@li...> 

	Betreff: RE: [Rails-devel] BugFix Release for Rails 1880  Alpha5
available 

	Datum: Fri, 23 Mar 2012 02:02:14 +0100 

	Errors noted in Alpha5 Auction: 

	1)      After buying BCR a window pops up for opening price with only
$100 selected. The window that should pop up is which position within
the 100 group the BCR will start. 

	2)      The BCR Building permits list all available permits. Since it
is known it is a 20% share at this point, only the ABC and BCD build
shares should be listed. 

	3)      Players are not reordered properly after the auction (least
money to most money). 

	Tom McCorry

Re: [Rails-devel] BugFix Release for Rails 1880 Alpha5 available

[Tom M. <tom...@gm...>]

Errors noted in Alpha5 Auction:

 

1)      After buying BCR a window pops up for opening price with only $100 selected. The window that should pop up is which position within the 100 group the BCR will start.

2)      The BCR Building permits list all available permits. Since it is known it is a 20% share at this point, only the ABC and BCD build shares should be listed.

3)      Players are not reordered properly after the auction (least money to most money).

 

 

Tom McCorry

[Rails-devel] BugFix Release for Rails 1880 Alpha5 available

[<Dr....@t-...>]

Hello, 

	please find enclosed the link to the bugfix Release for the 1880
Version of Rails. 

	http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha5.zip 

	The previous version did not restore certain properties of the major
companies, leading to the issues:  

 	*That no Major Company besides the BCR would have been able to build
after reloading a save file.
 	*That more than 4 Major Companies could be started with a par price
of 100.

	This might break saved games, so i advise anyone to install it in
paralell and replay the game manually to the last action before first
buy in the first StockRound (Startround was fine). 

	Kind Regards, 

	Martin

[Rails-devel] remote git branch for 1880 created

[Stefan F. <ste...@we...>]

Martin:
after some off-list discussion Brett, Erik and myself came to the 
conclusion that we suggest the following for the 1880 development to 
keep everything on sourceforge and to optimize the workflow for everyone 
involved.

There is a new branch derived from the current master called 
"specific_1880". That branch could be used to keep your current 
development in synch with all other developers.

As before if you intend you get your changes merged to master please 
submit a patch to the mailing list to collect feedback.

In addition I would volunteer to create and upload alpha versions to the 
sourceforge webpage from the specific_1880 branch, however without any 
manual testing of that package, so that I can rely on the automated 
ant-process for that. However if you prefer keeping the dropbox solution 
I am happy with that too.

In my view that is essentially the workflow that we can offer everyone 
who is interested to get another 18xx running on Rails.

Stefan

Re: [Rails-devel] Fix for MapHex Display Problem

[Erik V. <eri...@xs...>]

 
	We should however somewhere most prominent put at least that Assumption (Preprinted Tiles have negative IDs, tiles can have an ID and a picture ID differing) as a Design 	Guideline either on the Wiki or in a Readme for Developers/Implementers.

It's rather a requirement than an assumption.  

	Theres a number of not so trivial points in the code that costs a lot of time for someone to understand :)

Yes, the learning curve is steep.  I'm not sure we are already at a point where we can codify the whole global design; it's still somewhat volatile, and in particular Stefan is working on it. 
But surely there are many aspects that can and should be described.
 
	Action-Handling through different Classes...
	movestack() (wth is that :)) I think it has to do something with the possibility to undo and redo moves :)

Exactly: it's the undo stack.

	differentiation between game engine and UI
 
	Thats some points of my head which cost me a lot of time and frustration.

	While i find the design from my limited point of experience flexible its not easy to understand :)

I should remark that you have taken a path that I would not recommend to anyone: to implement a complex game like 1880 with almost no prior experience with Rails.
For myself, I take a gradual path: increasing complexity in small steps, adding some new features with every new game that I start working on.  If I would have thought of doing 1880, I would first have looked for some simpler game from the OO stable.  Given all that, I must say that you have made tremendous progress, a lot more than I had expected.

Erik
 

Re: [Rails-devel] Fix for MapHex Display Problem

[<Dr....@t-...>]

Hi Erik, 

	i agree with you. 

	We should however somewhere most prominent put at least that
Assumption (Preprinted Tiles have negative IDs, tiles can have an ID
and a picture ID differing) as a Design Guideline either on the Wiki
or in a Readme for Developers/Implementers. 

	Theres a number of not so trivial points in the code that costs a lot
of time for someone to understand :) 

	Action-Handling through different Classes... 

	movestack() (wth is that :)) I think it has to do something with the
possibility to undo and redo moves :) 

	differentiation between game engine and UI 

	Thats some points of my head which cost me a lot of time and
frustration. 

	While i find the design from my limited point of experience flexible
its not easy to understand :) 

	Regards 

	Martin  

	Von: "Erik Vos" <eri...@xs...> 

	An: "'Dr. Martin Brumm'" <dr....@t-...>, "'Rails
Development'" <rai...@li...> 

	Betreff: RE: Fix for MapHex Display Problem 

	Datum: Mon, 19 Mar 2012 11:15:38 +0100 

	Ah, I had overlooked that use case. Thanks for spotting that! 

	My construct was intended to allow different pictures to be defined
per hex (in addition to per tile), but of course this only applies to
preprinted tiles. 

	Indeed these should always have a negative number.  Different
pictures for layable tiles cannot be defined per hex, so the detour
via MapHex is not needed at all. 

	For clarity, I would prefer to use the tileID sign, rather than the
pictureId sign to make his distinction (which I did in my first
commit). But I later realised that we should then make
tile.getPictureId() return the tileID if no picture is defined, and
that change could have more impact, so I have reverted that idea my
second commit. I’m now back on exactly your code (but with some
added comments).  I may come back to this aspect later on.  

	Erik. 

	From: Dr. Martin Brumm [mailto:dr....@t-...] 
Sent: Sunday, March 18, 2012 4:29 PM
To: 'Erik Vos'; 'Rails Development'
Subject: AW: Fix for MapHex Display Problem   

	Hi Erik, 

	the bug emerged as you placed any tile on a preprinted Hex with a
negative ID. (So in principle any native preprinted Tile). 

	In that case the Select Mechanismn for upgrading a tile printed the
right tiles for upgrade (id and everything) on the left selection
panel but showed the hex.graphic of the preprinted MapHex. 

	You couldn’t see anything besides the original MapHex gaphic on the
Map nor on the Selectionpanel on the left side. 

	I tested it with 1830 and 1880 from the current master repository. 

	My Fix assumes that all preprinted tiles have negative ID and all
upgrade Tiles have an ID >0. 

	So far that assumption is true as far as I could see. 

	Regards, 

	Martin 

	Von: Erik Vos [mailto:eri...@xs...] [1] 
Gesendet: Sonntag, 18. März 2012 16:23
An: Dr....@t-... [2]; 'Rails Development'
Betreff: RE: Fix for MapHex Display Problem   

	Martin, 

	What exactly was the problem that you encountered?  Do you have a
saved file that shows it? 

	Your change isn’t incorrect, but IMO it should be superfluous, as
hex.getPictureID() should already handle all valid cases (although in
a different way).  

	If you really saw a problem, there must be another underlying bug. 

	I’m assuming that the tile/pic configurations are correct (all
preprinted ones negative, all laid ones positive).  This may need
further checking, though. 

	Erik. 

	From: Dr....@t-... [3]
[mailto:Dr....@t-...] [4] 
Sent: Sunday, March 18, 2012 10:05 AM
To: Rails Development; Erik Vos
Subject: Fix for MapHex Display Problem   

	Hi, 

	please find enclosed the patch for the small problem created with the
introduction of tilebased pictureIDs. 

	Autor: Martin Brumm <Dr....@t-... [5]>  2012-03-18
10:01:39
Eintragender: Martin Brumm <Dr....@t-... [6]> 
2012-03-18 10:01:39
Eltern: a384f297999ccc2de0d66a1c9d836b37d6e45dd8 (Fixed the startprice
but didnt remove the pop up for IG/BCR)
Zweig: master
Folgt auf: v1.5.0
Vorgänger von: 

    Fixed new pictureID Display. Tiles with a positive Picture ID have
    preference over hex.PictureIDs.

---------------------- rails/ui/swing/hexmap/GUITile.java
----------------------
index f7162f9..5ccf092 100644
@@ -53,7 +53,12 @@ public class GUITile {
         this.hex = (MapHex)guiHex.getModel();
         TileManager tileManager =
guiHex.getHexMap().orUIManager.getTileManager();
         tile = tileManager.getTile(tileId);
-        picId = hex.getPictureId();
+        
+        if (tile.getPictureId() >0 ) { 
+            picId= tile.getPictureId();
+        } else {        
+                picId = hex.getPictureId();
+        }

         if (hex.getTileOrientation() == TileOrientation.EW) {
             baseRotation = 0.5 * DEG60;

Links:
------
[1] mailto:[mailto:eri...@xs...]
[2] mailto:Dr....@t-...
[3] mailto:Dr....@t-...
[4] mailto:[mailto:Dr....@t-...]
[5] mailto:Dr....@t-...
[6] mailto:Dr....@t-...

Re: [Rails-devel] Fix for MapHex Display Problem

[Erik V. <eri...@xs...>]

Ah, I had overlooked that use case. Thanks for spotting that!

 

My construct was intended to allow different pictures to be defined per hex (in addition to per tile), but of course this only applies to preprinted tiles.

Indeed these should always have a negative number.  Different pictures for layable tiles cannot be defined per hex, so the detour via MapHex is not needed at all.

 

For clarity, I would prefer to use the tileID sign, rather than the pictureId sign to make his distinction (which I did in my first commit). But I later realised that we should then make tile.getPictureId() return the tileID if no picture is defined, and that change could have more impact, so I have reverted that idea my second commit. I’m now back on exactly your code (but with some added comments).  I may come back to this aspect later on. 

 

Erik.

 

 

From: Dr. Martin Brumm [mailto:dr....@t-...] 
Sent: Sunday, March 18, 2012 4:29 PM
To: 'Erik Vos'; 'Rails Development'
Subject: AW: Fix for MapHex Display Problem

 

Hi Erik,

 

the bug emerged as you placed any tile on a preprinted Hex with a negative ID. (So in principle any native preprinted Tile).

 

In that case the Select Mechanismn for upgrading a tile printed the right tiles for upgrade (id and everything) on the left selection panel but showed the hex.graphic of the preprinted MapHex.

 

You couldn’t see anything besides the original MapHex gaphic on the Map nor on the Selectionpanel on the left side.

 

I tested it with 1830 and 1880 from the current master repository.

 

My Fix assumes that all preprinted tiles have negative ID and all upgrade Tiles have an ID >0.

So far that assumption is true as far as I could see.

 

Regards,

Martin

 

Von: Erik Vos [mailto:eri...@xs...] 
Gesendet: Sonntag, 18. März 2012 16:23
An: Dr....@t-...; 'Rails Development'
Betreff: RE: Fix for MapHex Display Problem

 

Martin,

 

What exactly was the problem that you encountered?  Do you have a saved file that shows it?

 

Your change isn’t incorrect, but IMO it should be superfluous, as hex.getPictureID() should already handle all valid cases (although in a different way). 

If you really saw a problem, there must be another underlying bug.

 

I’m assuming that the tile/pic configurations are correct (all preprinted ones negative, all laid ones positive).  This may need further checking, though.

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Sunday, March 18, 2012 10:05 AM
To: Rails Development; Erik Vos
Subject: Fix for MapHex Display Problem

 

Hi,

 

please find enclosed the patch for the small problem created with the introduction of tilebased pictureIDs.

 

Autor: Martin Brumm <Dr....@t-...>  2012-03-18 10:01:39
Eintragender: Martin Brumm <Dr....@t-...>  2012-03-18 10:01:39
Eltern: a384f297999ccc2de0d66a1c9d836b37d6e45dd8 (Fixed the startprice but didnt remove the pop up for IG/BCR)
Zweig: master
Folgt auf: v1.5.0
Vorgänger von: 

    Fixed new pictureID Display. Tiles with a positive Picture ID have
    preference over hex.PictureIDs.

---------------------- rails/ui/swing/hexmap/GUITile.java ----------------------
index f7162f9..5ccf092 100644
@@ -53,7 +53,12 @@ public class GUITile {
         this.hex = (MapHex)guiHex.getModel();
         TileManager tileManager = guiHex.getHexMap().orUIManager.getTileManager();
         tile = tileManager.getTile(tileId);
-        picId = hex.getPictureId();
+        
+        if (tile.getPictureId() >0 ) { 
+            picId= tile.getPictureId();
+        } else {        
+                picId = hex.getPictureId();
+        }
 
         if (hex.getTileOrientation() == TileOrientation.EW) {
             baseRotation = 0.5 * DEG60;

Re: [Rails-devel] Fix for MapHex Display Problem

[Dr. M. B. <dr....@t-...>]

Hi Erik,

 

the bug emerged as you placed any tile on a preprinted Hex with a negative ID. (So in principle any native preprinted Tile).

 

In that case the Select Mechanismn for upgrading a tile printed the right tiles for upgrade (id and everything) on the left selection panel but showed the hex.graphic of the preprinted MapHex.

 

You couldn’t see anything besides the original MapHex gaphic on the Map nor on the Selectionpanel on the left side.

 

I tested it with 1830 and 1880 from the current master repository.

 

My Fix assumes that all preprinted tiles have negative ID and all upgrade Tiles have an ID >0.

So far that assumption is true as far as I could see.

 

Regards,

Martin

 

Von: Erik Vos [mailto:eri...@xs...] 
Gesendet: Sonntag, 18. März 2012 16:23
An: Dr....@t-...; 'Rails Development'
Betreff: RE: Fix for MapHex Display Problem

 

Martin,

 

What exactly was the problem that you encountered?  Do you have a saved file that shows it?

 

Your change isn’t incorrect, but IMO it should be superfluous, as hex.getPictureID() should already handle all valid cases (although in a different way). 

If you really saw a problem, there must be another underlying bug.

 

I’m assuming that the tile/pic configurations are correct (all preprinted ones negative, all laid ones positive).  This may need further checking, though.

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Sunday, March 18, 2012 10:05 AM
To: Rails Development; Erik Vos
Subject: Fix for MapHex Display Problem

 

Hi,

 

please find enclosed the patch for the small problem created with the introduction of tilebased pictureIDs.

 

Autor: Martin Brumm <Dr....@t-...>  2012-03-18 10:01:39
Eintragender: Martin Brumm <Dr....@t-...>  2012-03-18 10:01:39
Eltern: a384f297999ccc2de0d66a1c9d836b37d6e45dd8 (Fixed the startprice but didnt remove the pop up for IG/BCR)
Zweig: master
Folgt auf: v1.5.0
Vorgänger von: 

    Fixed new pictureID Display. Tiles with a positive Picture ID have
    preference over hex.PictureIDs.

---------------------- rails/ui/swing/hexmap/GUITile.java ----------------------
index f7162f9..5ccf092 100644
@@ -53,7 +53,12 @@ public class GUITile {
         this.hex = (MapHex)guiHex.getModel();
         TileManager tileManager = guiHex.getHexMap().orUIManager.getTileManager();
         tile = tileManager.getTile(tileId);
-        picId = hex.getPictureId();
+        
+        if (tile.getPictureId() >0 ) { 
+            picId= tile.getPictureId();
+        } else {        
+                picId = hex.getPictureId();
+        }
 
         if (hex.getTileOrientation() == TileOrientation.EW) {
             baseRotation = 0.5 * DEG60;

Re: [Rails-devel] Rails 1.7-0-1880 alpha3 avail

[Erik V. <eri...@xs...>]

Pushed to master.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Saturday, March 17, 2012 11:05 PM
To: Rails Development
Subject: [Rails-devel] Rails 1.7-0-1880 alpha3 avail

 

Hi,

 

i have fixed the reported bugs by Phil Davies in the following alpha-Release.

 

Please find the fixes enclosed in this mail. 

 

The package can be found for testing at :

 

http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha3.zip

 

Kind Regards,

Martin

 

Autor: Martin Brumm <Dr....@t-...>  2012-03-17 22:35:04
Eintragender: Martin Brumm <Dr....@t-...>  2012-03-17 22:35:04
Eltern: 457a77d344caf6f33031547de95fcb9992db758f (Fixed Spelling of Vladivostok in OffBoardRevenue_1880)
Zweig: master
Folgt auf: v1.5.0

    Fixed the startprice but didnt remove the pop up for IG/BCR
    Fixed the bid problem reported by Phil Davies
    
    The StartPrice Problematic with a fixed price but needed BuildingRight
    will need some more thinking. I am currently using the NeedSharePrice
    Status to trigger the Setting of Prices and BuildingRights... Maybe i
    have to add another StatusFlag :(

---------------- rails/game/specific/_1880/StartRound_1880.java ----------------
index d906796..9c2ecde 100644
@@ -240,8 +240,25 @@ public class StartRound_1880 extends StartRound {
                 Bank.format(bidAmount),
                 item.getName(),
                 Bank.format(player.getCash()) ));
+        if ((item.getBidders() >0) && (numPasses.intValue()== getNumberOfPlayers()-1)) {
+            // All but the highest bidder have passed.
+            int price = item.getBid();
+
+            log.debug("Highest bidder is "
+                      + item.getBidder().getName());
+            if (item.needsPriceSetting() != null) {
+                item.setStatus(StartItem.NEEDS_SHARE_PRICE);
+            } else {
+                assignItem(item.getBidder(), item, price, 0);
+            }
+            auctionItemState.set(null);
+            numPasses.set(0);
+           setNextStartingPlayer();
+           return true;
+        } else {
          setNextBiddingPlayer(item);
          return true;
+        }
 
     }
 
@@ -294,17 +311,15 @@ public class StartRound_1880 extends StartRound {
                     assignItem((Player)startingPlayer.get(),
                             auctionItem, 0, 0);
                     setNextStartingPlayer();
-                    // startPacket.getFirstItem().getName());
                     return true;
                 }
             } else {
                 numPasses.set(0);
-                //gameManager.nextRound(this);
                 finishRound();
 
             }
         }
-       // if ((numPasses.intValue() >= auctionItem.getBidders() - 1) && 
+
         if ((auctionItem.getBidders() >0) && (numPasses.intValue()== getNumberOfPlayers()-1)) {
             // All but the highest bidder have passed.
             int price = auctionItem.getBid();

--------- rails/ui/swing/gamespecific/_1880/StartRoundWindow_1880.java ---------
index dc264d2..7683295 100644
@@ -77,22 +77,22 @@ public class StartRoundWindow_1880 extends StartRoundWindow {
 
            // Get a sorted prices List
            // TODO: should be included in BuyStartItem
-           List<StockSpaceI> startSpaces = stockMarket.getStartSpaces();
-           Map<Integer, StockSpaceI> spacePerPrice =
-                   new HashMap<Integer, StockSpaceI>();
-           startPrices = new int[startSpaces.size()];
-           String[] options = new String[startSpaces.size()];
-           for (int i = 0; i < startSpaces.size(); i++) {
-               if (((StockMarket_1880) stockMarket).getParSlot(startSpaces.get(i).getPrice())) { //Make sure we got a Parslot left over
-               startPrices[i] = startSpaces.get(i).getPrice();
-               spacePerPrice.put(startPrices[i], startSpaces.get(i));
-               }
-           }
-           Arrays.sort(startPrices);
-           for (int i = 0; i < startSpaces.size(); i++) {
-               options[i] = Bank.format(spacePerPrice.get(startPrices[i]).getPrice());
-           }
-
+//           List<StockSpaceI> startSpaces = stockMarket.getStartSpaces();
+//           Map<Integer, StockSpaceI> spacePerPrice =
+//                   new HashMap<Integer, StockSpaceI>();
+//           startPrices = new int[startSpaces.size()];
+           String[] options = {""};
+//           for (int i = 0; i < startSpaces.size(); i++) {
+//               if (((StockMarket_1880) stockMarket).getParSlot(startSpaces.get(i).getPrice())) { //Make sure we got a Parslot left over
+//               startPrices[i] = startSpaces.get(i).getPrice();
+//               spacePerPrice.put(startPrices[i], startSpaces.get(i));
+//               }
+//           }
+//           Arrays.sort(startPrices);
+//           for (int i = 0; i < startSpaces.size(); i++) {
+//               options[i] = Bank.format(spacePerPrice.get(startPrices[i]).getPrice());
+//           }
+           options[0] = "100";
            RadioButtonDialog dialog = new RadioButtonDialog(
                    COMPANY_START_PRICE_DIALOG,
                    this,
@@ -102,7 +102,7 @@ public class StartRoundWindow_1880 extends StartRoundWindow {
                                    activeItem.getPlayerName(),
                                    compName),
                            options,
-                           -1);
+                           0);
            setCurrentDialog (dialog, activeItem);
            }
        return true;
@@ -143,7 +143,7 @@ public class StartRoundWindow_1880 extends StartRoundWindow {
 
           int index = dialog.getSelectedOption();
           if (index >= 0) {
-              int price = startPrices[index];
+              int price = 100;
               action.setAssociatedSharePrice(price);
               ((StockMarket_1880) stockMarket).setParSlot(price);
               
Autor: Martin Brumm <Dr....@t-...>  2012-03-17 21:46:15
Eintragender: Martin Brumm <Dr....@t-...>  2012-03-17 21:46:15
Eltern: c04dd80f6970197d123f1493f4f3c0d5f602d560 (Added missing check for running company to 1880 public company modifier)
Kind:  a384f297999ccc2de0d66a1c9d836b37d6e45dd8 (Fixed the startprice but didnt remove the pop up for IG/BCR)
Zweig: master
Folgt auf: v1.5.0
Vorgänger von: 

    Fixed Spelling of Vladivostok in OffBoardRevenue_1880

--------- rails/game/specific/_1880/OffBoardRevenueModifier_1880.java ---------
index 7580a5c..d8cbf97 100644
@@ -29,7 +29,7 @@ public class OffBoardRevenueModifier_1880 implements RevenueStaticModifier {
         // 1. get the two off-board type stations (Russia and Wladiwostok) 
         Set<NetworkVertex> offBoard = new HashSet<NetworkVertex>();
         for (NetworkVertex vertex:revenueAdapter.getVertices()) { // We just need the two offboard Cities
-            if (vertex.isStation() && ((vertex.getStation().getName().equals("Russia") ||(vertex.getStation().getName().equals("Wladiwostok"))))) {
+            if (vertex.isStation() && ((vertex.getStation().getName().equals("Russia") ||(vertex.getStation().getName().equals("Vladivostok"))))) {
                 offBoard.add(vertex);
             }
         }

Re: [Rails-devel] Fix for MapHex Display Problem

[Erik V. <eri...@xs...>]

Martin,

 

What exactly was the problem that you encountered?  Do you have a saved file that shows it?

 

Your change isn’t incorrect, but IMO it should be superfluous, as hex.getPictureID() should already handle all valid cases (although in a different way). 

If you really saw a problem, there must be another underlying bug.

 

I’m assuming that the tile/pic configurations are correct (all preprinted ones negative, all laid ones positive).  This may need further checking, though.

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Sunday, March 18, 2012 10:05 AM
To: Rails Development; Erik Vos
Subject: Fix for MapHex Display Problem

 

Hi,

 

please find enclosed the patch for the small problem created with the introduction of tilebased pictureIDs.

 

Autor: Martin Brumm <Dr....@t-...>  2012-03-18 10:01:39
Eintragender: Martin Brumm <Dr....@t-...>  2012-03-18 10:01:39
Eltern: a384f297999ccc2de0d66a1c9d836b37d6e45dd8 (Fixed the startprice but didnt remove the pop up for IG/BCR)
Zweig: master
Folgt auf: v1.5.0
Vorgänger von: 

    Fixed new pictureID Display. Tiles with a positive Picture ID have
    preference over hex.PictureIDs.

---------------------- rails/ui/swing/hexmap/GUITile.java ----------------------
index f7162f9..5ccf092 100644
@@ -53,7 +53,12 @@ public class GUITile {
         this.hex = (MapHex)guiHex.getModel();
         TileManager tileManager = guiHex.getHexMap().orUIManager.getTileManager();
         tile = tileManager.getTile(tileId);
-        picId = hex.getPictureId();
+        
+        if (tile.getPictureId() >0 ) { 
+            picId= tile.getPictureId();
+        } else {        
+                picId = hex.getPictureId();
+        }
 
         if (hex.getTileOrientation() == TileOrientation.EW) {
             baseRotation = 0.5 * DEG60;

[Rails-devel] Fix for MapHex Display Problem

[<Dr....@t-...>]

Hi, 

	please find enclosed the patch for the small problem created with the
introduction of tilebased pictureIDs. 

	Autor: Martin Brumm <Dr....@t-...>  2012-03-18
10:01:39
Eintragender: Martin Brumm <Dr....@t-...>  2012-03-18
10:01:39
Eltern: a384f297999ccc2de0d66a1c9d836b37d6e45dd8 (Fixed the startprice
but didnt remove the pop up for IG/BCR)
Zweig: master
Folgt auf: v1.5.0
Vorgänger von: 

    Fixed new pictureID Display. Tiles with a positive Picture ID have
    preference over hex.PictureIDs.

---------------------- rails/ui/swing/hexmap/GUITile.java
----------------------
index f7162f9..5ccf092 100644
@@ -53,7 +53,12 @@ public class GUITile {
         this.hex = (MapHex)guiHex.getModel();
         TileManager tileManager =
guiHex.getHexMap().orUIManager.getTileManager();
         tile = tileManager.getTile(tileId);
-        picId = hex.getPictureId();
+        
+        if (tile.getPictureId() >0 ) { 
+            picId= tile.getPictureId();
+        } else {        
+                picId = hex.getPictureId();
+        }

         if (hex.getTileOrientation() == TileOrientation.EW) {
             baseRotation = 0.5 * DEG60;

[Rails-devel] Interesting side effects?

[<Dr....@t-...>]

Hi Stefan et al. 

	I have noticed an effect i currently cant really explain. 

	If  i use the package i created last night everything is fine. But
any  other game out of the master repository(even the remote one
without m  latest patch) or the branches (with the latest patch) the
tile laying  step does present the right number and name of tiles but
no pictures ? 

 Can you confirm this locally? 

	Regards, 

	Martin

Re: [Rails-devel] rails-Version with 1880 alpha3 available

[Stefan F. <ste...@we...>]

Martin:
has my changes fixed your issues with 1880 revenue calculation?
And could you please provide an example for an 1880 test game to allow 
for easier testing in the future?
Thanks,
Stefan


On 03/17/2012 10:50 PM, Dr....@t-... wrote:
> Hi Phil,
>
> your bugs have ben solved the bidding bug fully. The price setting
> intermediate as i will probably have to rewrite the entire handling code
> there.
>
> http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha3.zip
>
> Regards,
>
> Martin
>
> *Von:* Phil Davies <de...@gm...>
>
> *An:* "Dr....@t-..." <Dr....@t-...>,
> "Development list for Rails: an 18xx game"
> <rai...@li...>
>
> *Betreff:* Re: [Rails-devel] rails-Version with 1880 alpha2 available
>
> *Datum:* Wed, 14 Mar 2012 15:01:54 +0100
>
> Also, you get prompted for a start price for the BCR. Should it not get
> automatically set to 100?
>
> On 14 March 2012 13:40, Phil Davies <de...@gm...
> <mailto:de...@gm...>> wrote:
>
>     Martin,
>     I think there is an error with the startround, see attached save.
>     Bid on the IG with Chris, then pass with Chris2. Expected behaviour
>     is that Chris gets the IG for $160 and then Phil2 is offered the bid
>     on the RC. What actually happens is a short OR runs!
>     Phil
>
>     On 13 March 2012 20:41, Dr....@t-...
>     <mailto:Dr....@t-...> <Dr....@t-...
>     <mailto:Dr....@t-...>> wrote:
>
>         Hi,
>
>         you can find an updated version at :
>
>         http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha2.zip
>
>         Fixes: Internal Maphandling/Hexes back to use of rails generic.
>
>         : Various Map mistakes reported by Tom Mccorry.
>
>         This version is still not fully functional in regard to the
>         private company handling mechanismn.
>
>         Further Feedback very much appreciated.
>
>         Please send bug reports regarding this version either to me or
>         if you are on the rai...@li...
>         <mailto:rai...@li...> list there.
>
>         Kind regards,
>
>         Martin
>
>         ------------------------------------------------------------------------------
>         Keep Your Developer Skills Current with LearnDevNow!
>         The most comprehensive online learning library for Microsoft
>         developers
>         is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5,
>         CSS3, MVC3,
>         Metro Style Apps, more. Free future releases when you subscribe now!
>         http://p.sf.net/sfu/learndevnow-d2d
>         _______________________________________________
>         Rails-devel mailing list
>         Rai...@li...
>         <mailto:Rai...@li...>
>         https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

[Rails-devel] rails-Version with 1880 alpha3 available

[<Dr....@t-...>]

Hi Phil, 

	your bugs have ben solved the bidding bug fully. The price setting
intermediate as i will probably have to rewrite the entire handling
code there. 

	http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha3.zip 

	Regards, 

	Martin 

	Von: Phil Davies <de...@gm...> 

	An: "Dr....@t-..." <Dr....@t-...>, 
"Development list for Rails: an 18xx game"
<rai...@li...> 

	Betreff: Re: [Rails-devel] rails-Version with 1880 alpha2 available 

	Datum: Wed, 14 Mar 2012 15:01:54 +0100 

	   Also, you get prompted for a start price for the BCR.  Should it
not get automatically set to 100?

 On 14 March 2012 13:40, Phil Davies <de...@gm... [1]> wrote:
 Martin, I think there is an error with the startround, see attached
save. Bid on the IG with Chris, then pass with Chris2.  Expected
behaviour is that Chris gets the IG for $160 and then Phil2 is offered
the bid on the RC.  What actually happens is a short OR runs! Phil

   On 13 March 2012 20:41, Dr....@t-... [2]
<Dr....@t-... [3]> wrote:      

	Hi, 

	you can find an updated version at : 

	http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha2.zip [4] 

	Fixes: Internal Maphandling/Hexes back to use of rails generic. 

	          : Various Map mistakes reported by Tom Mccorry. 

	This version is still not fully functional in regard to the private
company handling mechanismn. 

	Further Feedback very much appreciated. 

	Please send bug reports regarding this version either to me or if you
are on the rai...@li... [5] list there.  

	Kind regards, 

	Martin 

	     
------------------------------------------------------------------------------
 Keep Your Developer Skills Current with LearnDevNow!
 The most comprehensive online learning library for Microsoft
developers
 is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3,
MVC3,
 Metro Style Apps, more. Free future releases when you subscribe now!
 http://p.sf.net/sfu/learndevnow-d2d [6]
_______________________________________________
 Rails-devel mailing list
 Rai...@li... [7]
 https://lists.sourceforge.net/lists/listinfo/rails-devel [8]

Links:
------
[1] mailto:de...@gm...
[2] mailto:Dr....@t-...
[3] mailto:Dr....@t-...
[4] http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha2.zip
[5] mailto:rai...@li...
[6] http://p.sf.net/sfu/learndevnow-d2d
[7] mailto:Rai...@li...
[8] https://lists.sourceforge.net/lists/listinfo/rails-devel

[Rails-devel] Commit rights for Martin?

[Stefan F. <ste...@we...>]

Brett, Erik and Martin:
as for my last suggestion there was no feedback so far, I will repeat my 
suggestion to give Martin rights to the repo/website:

For documentation and other reasons I would strongly prefer to have all 
testing and developing for 1880 on-site.

So I suggest to give Martin the rights to commit to the git-repo and/or 
upload to sourceforge.

On the other hand I ask Martin to keep bug-fix discussion for 1880 on 
the list, as others might have to fix/refactor 1880 in the future and it 
is good to keep that available in the archives.

I hope my proposals will find your agreement, but I am open for others.

Stefan

Re: [Rails-devel] 1880 "almost" playable for review and testing- Bughunting now possible would be the better state :)

[Stefan F. <ste...@we...>]

Martin:
you have implemented the static modifier inside the PubliCompany_1880 
class. By this each instance/object gets registered with the revenue 
manager and each of them gets called every time revenue is calculated.
So you have to check inside your implementation if the running company 
is equal to the company implementing, so check if 
(revenueManager.getCompany() != this) first.

I have added that already, as it is easier then you again submitting a 
patch.

And I took the liberty to rename all OffBoardModifier (1880, 1851, 18EU) 
to include the game name as each is specific for each game.

Stefan


On 03/13/2012 04:09 PM, Dr....@t-... wrote:
> HI Stefan & Erik,
>
> understood, but the mechanismn is not working as intended right now.
>
> Somewhere theres a hardcoded point that an offhex city is always a City
> and cant be scored as a town. At least if i use Eriks example the code
> doesnt treat the town as a town.
>
> Btw Stefan any clue why the revenuemodifier backfires the way it does in
> 1880 ?
>
> It generates not 1 but 21 trains (one for each public Company) to be
> calculated per private company and not one :) And of course calculates
> the routes for those 21 trains.
>
> Regards,
> Martin
>
> *Von:* Stefan Frey <ste...@we...>
> *An:* rai...@li...
> *Betreff:* Re: [Rails-devel] 1880 "almost" playable for review and
> testing- Bughunting now possible would be the better state :)
> *Datum:* Tue, 13 Mar 2012 15:47:18 +0100
>
> Martin & Erik:
> I support Erik's suggestion below. Erik and I introduced generic
> attributes exactly for that reason.
> Stefan
>
>  >
>  > 1. You have split the tile type OFF_MAP_AREA into separate OFF_MAP_CITY
>  > and OFF_MAP_TOWN types.
>  >
>  > I understand why you are doing that (the blue “off-map harbours” score
>  > as towns), but I don’t think this rather special 1880 feature warrants
>  > the addition of a new generic type.
>  >
>  > There should be a much easier way to accomplish what you want: in
>  > Map.xml, replace
>  >
>  >
> <Hexname="Q13"tile="-9021"orientation="4"value="20,30,40,50"city="Haikou"/>
>  >
>  > by
>  >
>  >
> <Hexname="Q13"tile="-9021"orientation="4"value="20,30,40,50"score="town"city="Haikou"/>
>  >
>  > and similar for hex N16.
>  >
>  > I’m saying “there /should/ be” because this way to configure scoring is
>  > as yet hardly tested. This is the right time to do so…
>  >
>  > BTW I suppose in NetworkVertex line 251 you have
>  >
>  > *if*((station.getType().equals(Station./OFF_MAP_CITY/)) ||
>  > (station.getType().equals(Station./OFF_MAP_CITY/))) {
>  >
>  > … I suppose one of these OFF_MAP_CITY’s is a typo for OFF_MAP_TOWN. But
>  > if you follow my suggestion, this change isn’t necessary at all.
>  >
>  > 2. For your new blue preprinted harbour tiles, you define a new tile
>  > colour name /Tile.BLUE_COLOUR_NAME/.
>  >
>  > I don’t think that there is any need to define such a new name. This
>  > and the other “colour names” in this class have only superficial
>  > relation with the actual tile colours – their function is to define the
>  > tile type with respect to upgradeability and related characteristics.
>  > Here, I used the word “colour” for lack of a better name – the word
>  > “type” would much better describe the purpose of this item, but “type”
>  > is already heavily overused. Perhaps I should have used “level”.
>  >
>  > In this context, your off-map harbour hexes behave exactly like all
>  > other off-map hexes (except for scoring, see above). So, strange as it
>  > may seem, the “colour” of your new tiles 9021 and 9031 can best be
>  > described as “red”.
>  >
>  > (In hindsight, “offmap” would perhaps have been a better choice for the
>  > “colour” name of all off-map tiles than “red”).
>  >
>  > I’ll come back to your questions separately, if time permits.
>  >
>  >
>  > Erik.
>  >
>  > *From:*Dr....@t-... [mailto:Dr....@t-...]
>  > *Sent:* Friday, March 09, 2012 8:27 AM
>  > *To:* Rails Development
>  > *Subject:* [Rails-devel] 1880 "almost" playable for review and testing-
>  > Bughunting now possible would be the better state :)
>  >
>  > Hi Stefan, Erik, Frederick, Brent, et al.
>  >
>  > please check the code enclosed. I hope its complete and can be added to
>  > the latest master.
>  >
>  > If not my git setup is definetely FUBARed.
>  >
>  > commit c3bf5cd3efef8640b149d9f89744a6415864a1d3
>  > Author: Martin Brumm <Dr....@t-... <javascript:void(0)>
>  > <Dr....@t-... <javascript:void(0)>>> 2012-03-08 22:33:22
>  > Committer: Martin Brumm <Dr....@t-... <javascript:void(0)>
>  > <Dr....@t-... <javascript:void(0)>>> 2012-03-08 22:33:22
>  > Parent: 3f95ed86c7a463c64341871e73028af7edd88911 (added the 1880
>  > specific ShareSellingRound to the configuration.)
>  > Branches: master
>  >
>  > Implementing a SpecialBuyRight for a Number of Trains, not yet finished
>  > need to find the trigger and a valid way to proceed for the following
>  > mechanismn:
>  >
>  > If a train has been bought and we have a phase change the second train
>  > might be acquired once by the owner of the private Rocket of China
>  > (2+2,3,3+3,4 are possible trains/phases) So we need to ask the player if
>  > he wants to exercise that special buy action... Afterwards if he does
>  > the paper is closed. Different approaches not yet successfull.
>  >
>  > Second special power, after the last train of 2+2 or 3 or 3+3
>  > provenience the owner of the P0 might once declare his company closed
>  > and gets 40, 70 or 100 Yuan respectivly, private company is then closed.
>  > Note that money goes to the player not any company.
>  >
>  > Otherwise most things should be in and working now.
>  >
>  > So we need here a big check from Erik, Stefan, Brent and Frederick if
>  > everything is ok :)
>  >
>  > And let the testing start... (i am damn sure something will go wrong :))
>  >
>  > Regards,
>  > Martin
>  >
>  > Does anybody know a command to extract the commit history and put it in
>  > one file without the code ? :)
>  >
>  > Known Bugs:
>  >
>  > StatusWindow isnt reflecting Player Order Correctly after Startround has
>  > ended: Workaround: Save and reload Game
>  >
>  > Revenue Calculation for Minors is whacky... Havent figured out yet where
>  > the huge amount of trains is coming from :)
>  >
>  > Advice needed on implementing the specialpowers of the privates, sofar
>  > my tries have been unsuccessfull and thus deleted from the code.
>  >
>  > And as usual please point out or refactor the code if needed by your
>  > experience.
>  >
>  > Probably some others testing needs now to commence :)
>  >
>  >
>  >
>  >
> ------------------------------------------------------------------------------
>  > Virtualization& Cloud Management Using Capacity Planning
>  > Cloud computing makes use of virtualization - but cloud computing
>  > also focuses on allowing computing to be delivered as a service.
>  > http://www.accelacomm.com/jaw/sfnl/114/51521223/
> <?ctl=dereferer&to=aHR0cDovL3d3dy5hY2NlbGFjb21tLmNvbS9qYXcvc2ZubC8xMTQvNTE1MjEyMjMv>
>  >
>  >
>  >
>  > _______________________________________________
>  > Rails-devel mailing list
>  > Rai...@li... <javascript:void(0)>
>  > https://lists.sourceforge.net/lists/listinfo/rails-devel
> <?ctl=dereferer&to=aHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vcmFpbHMtZGV2ZWw%3D>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> <?ctl=dereferer&to=aHR0cDovL3Auc2YubmV0L3NmdS9sZWFybmRldm5vdy1kMmQ%3D>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li... <javascript:void(0)>
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> <?ctl=dereferer&to=aHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vcmFpbHMtZGV2ZWw%3D>
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] rails-Version with 1880 alpha2 available

[Phil D. <de...@gm...>]

Also, you get prompted for a start price for the BCR.  Should it not get
automatically set to 100?

On 14 March 2012 13:40, Phil Davies <de...@gm...> wrote:

> Martin,
>
> I think there is an error with the startround, see attached save.
>
> Bid on the IG with Chris, then pass with Chris2.  Expected behaviour is
> that Chris gets the IG for $160 and then Phil2 is offered the bid on the
> RC.  What actually happens is a short OR runs!
>
> Phil
>
> On 13 March 2012 20:41, Dr....@t-... <
> Dr....@t-...> wrote:
>
>> Hi,
>>
>>
>>
>> you can find an updated version at :
>>
>>
>>
>> http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha2.zip
>>
>>
>>
>> Fixes: Internal Maphandling/Hexes back to use of rails generic.
>>
>>           : Various Map mistakes reported by Tom Mccorry.
>>
>>
>>
>> This version is still not fully functional in regard to the private
>> company handling mechanismn.
>>
>>
>>
>> Further Feedback very much appreciated.
>>
>>
>>
>> Please send bug reports regarding this version either to me or if you are
>> on the rai...@li... list there.
>>
>>
>>
>> Kind regards,
>>
>> Martin
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Keep Your Developer Skills Current with LearnDevNow!
>> The most comprehensive online learning library for Microsoft developers
>> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
>> Metro Style Apps, more. Free future releases when you subscribe now!
>> http://p.sf.net/sfu/learndevnow-d2d
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>>
>

Re: [Rails-devel] Patch against previous 1880 patch

[Erik V. <eri...@xs...>]

	I may also have screwed up on the ‘pic’ attribute: it should be in TileSet.xml, not in Map.xml – but in TileSet.xml it would affect all -902/-903 tiles.
	In Map.xml it doesn’t work (yet), so the 1880 harbours will still show up red.

	I don’t see a simple solution right now, even though it would be highly desirable if there were one. 
	I’ll sleep a good night over how we can get this right, but we may have to revert to your initial approach.  

After all, it wasn't that difficult. 'pic' is now allowed in Map.xml, and used in 1880.
I have also cleaned up its (ineffective) usage in 1830/Map.xml, where TileSet.xml already had it.

It turned out that Martin's new 1880-specific classes had not been included in my previous commit.  That has been fixed now as well.

Erik.

Re: [Rails-devel] Patch against previous 1880 patch

[Erik V. <eri...@xs...>]

Martin,

 

Thanks for sorting it out, you are absolutely right.

 

I may also have screwed up on the ‘pic’ attribute: it should be in TileSet.xml, not in Map.xml – but in TileSet.xml it would affect all -902/-903 tiles.

In Map.xml it doesn’t work (yet), so the 1800 harbours will still show up red.

 

I don’t see a simple solution right now, even though it would be highly desirable if there were one. 

I’ll sleep a good night over how we can get this right, but we may have to revert to your initial approach.  

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Tuesday, March 13, 2012 8:37 PM
To: Rails Development; Erik Vos; Stefan Frey
Subject: Patch against previous 1880 patch

 

 

Hi Stefan, Erik et al.

 

i fixed the Map, Tiles etc. for 1880.

 

Erik: the actual definition has to be: <Access type="town" score="minor"/>.

 

Kind Regards,

Martin

 

[Rails-devel] rails-Version with 1880 alpha2 available

[<Dr....@t-...>]

Hi, 

	you can find an updated version at : 

	http://dl.dropbox.com/u/29072620/rails-1.7.0-1880-alpha2.zip 

	Fixes: Internal Maphandling/Hexes back to use of rails generic. 

	          : Various Map mistakes reported by Tom Mccorry. 

	This version is still not fully functional in regard to the private
company handling mechanismn. 

	Further Feedback very much appreciated. 

	Please send bug reports regarding this version either to me or if you
are on the rai...@li... list there.  

	Kind regards, 

	Martin

Re: [Rails-devel] 1880 "almost" playable for review and testing- Bughunting now possible would be the better state :)

[Tom M. <tom...@gm...>]

On further review Hex M8 is technically not an "off-board" location but conceptually it could be.




--------------------------------------------
Tom McCorry

Sent from my iPad

On Mar 13, 2012, at 15:19, "Dr. Martin Brumm" <dr....@t-...> wrote:

> Hi Tom,
>  
>  
> Which OffboardMapHex should be considered as a Town in 18AL ?
>  
> Kind Regards,
> Martin
>  
> Von: Tom McCorry [mailto:tom...@gm...] 
> Gesendet: Dienstag, 13. März 2012 19:52
> An: Dr....@t-...; Development list for Rails: an 18xx game
> Cc: Development list for Rails: an 18xx game
> Betreff: Re: [Rails-devel] 1880 "almost" playable for review and testing- Bughunting now possible would be the better state :)
>  
> This is actually a 'bug' beyond 1880 since the off-board towns that also exist in 18AL are not treated properly by the route calculator.
> 
>  
> --------------------------------------------
> Tom McCorry
>  
> Sent from my iPad
> 
> On Mar 13, 2012, at 11:09, "Dr....@t-..." <Dr....@t-...> wrote:
> 
> HI Stefan & Erik,
>  
> understood, but the mechanismn is not working as intended right now.
>  
> Somewhere theres a hardcoded point that an offhex city is always a City and cant be scored as a town. At least if i use Eriks example the code doesnt treat the town as a town.
>  
>  
> Btw Stefan any clue why the revenuemodifier backfires the way it does in 1880 ?
>  
> It generates not 1 but 21  trains (one for each public Company) to be calculated per private company and not one :) And of course calculates the routes for those 21 trains.
>  
> Regards,
> Martin
>  
>  
>  
> Von: Stefan Frey <ste...@we...>
> An: rai...@li...
> Betreff: Re: [Rails-devel] 1880 "almost" playable for review and testing- Bughunting now possible would be the better state :)
> Datum: Tue, 13 Mar 2012 15:47:18 +0100
> 
> Martin & Erik:
> I support Erik's suggestion below. Erik and I introduced generic 
> attributes exactly for that reason.
> Stefan
> 
> >
> > 1. You have split the tile type OFF_MAP_AREA into separate OFF_MAP_CITY
> > and OFF_MAP_TOWN types.
> >
> > I understand why you are doing that (the blue “off-map harbours” score
> > as towns), but I don’t think this rather special 1880 feature warrants
> > the addition of a new generic type.
> >
> > There should be a much easier way to accomplish what you want: in
> > Map.xml, replace
> >
> > <Hexname="Q13"tile="-9021"orientation="4"value="20,30,40,50"city="Haikou"/>
> >
> > by
> >
> > <Hexname="Q13"tile="-9021"orientation="4"value="20,30,40,50"score="town"city="Haikou"/>
> >
> > and similar for hex N16.
> >
> > I’m saying “there /should/ be” because this way to configure scoring is
> > as yet hardly tested. This is the right time to do so…
> >
> > BTW I suppose in NetworkVertex line 251 you have
> >
> > *if*((station.getType().equals(Station./OFF_MAP_CITY/)) ||
> > (station.getType().equals(Station./OFF_MAP_CITY/))) {
> >
> > … I suppose one of these OFF_MAP_CITY’s is a typo for OFF_MAP_TOWN. But
> > if you follow my suggestion, this change isn’t necessary at all.
> >
> > 2. For your new blue preprinted harbour tiles, you define a new tile
> > colour name /Tile.BLUE_COLOUR_NAME/.
> >
> > I don’t think that there is any need to define such a new name. This
> > and the other “colour names” in this class have only superficial
> > relation with the actual tile colours – their function is to define the
> > tile type with respect to upgradeability and related characteristics.
> > Here, I used the word “colour” for lack of a better name – the word
> > “type” would much better describe the purpose of this item, but “type”
> > is already heavily overused. Perhaps I should have used “level”.
> >
> > In this context, your off-map harbour hexes behave exactly like all
> > other off-map hexes (except for scoring, see above). So, strange as it
> > may seem, the “colour” of your new tiles 9021 and 9031 can best be
> > described as “red”.
> >
> > (In hindsight, “offmap” would perhaps have been a better choice for the
> > “colour” name of all off-map tiles than “red”).
> >
> > I’ll come back to your questions separately, if time permits.
> >
> >
> > Erik.
> >
> > *From:*Dr....@t-... [mailto:Dr....@t-...]
> > *Sent:* Friday, March 09, 2012 8:27 AM
> > *To:* Rails Development
> > *Subject:* [Rails-devel] 1880 "almost" playable for review and testing-
> > Bughunting now possible would be the better state :)
> >
> > Hi Stefan, Erik, Frederick, Brent, et al.
> >
> > please check the code enclosed. I hope its complete and can be added to
> > the latest master.
> >
> > If not my git setup is definetely FUBARed.
> >
> > commit c3bf5cd3efef8640b149d9f89744a6415864a1d3
> > Author: Martin Brumm <Dr....@t-...
> > <Dr....@t-...>> 2012-03-08 22:33:22
> > Committer: Martin Brumm <Dr....@t-...
> > <Dr....@t-...>> 2012-03-08 22:33:22
> > Parent: 3f95ed86c7a463c64341871e73028af7edd88911 (added the 1880
> > specific ShareSellingRound to the configuration.)
> > Branches: master
> >
> > Implementing a SpecialBuyRight for a Number of Trains, not yet finished
> > need to find the trigger and a valid way to proceed for the following
> > mechanismn:
> >
> > If a train has been bought and we have a phase change the second train
> > might be acquired once by the owner of the private Rocket of China
> > (2+2,3,3+3,4 are possible trains/phases) So we need to ask the player if
> > he wants to exercise that special buy action... Afterwards if he does
> > the paper is closed. Different approaches not yet successfull.
> >
> > Second special power, after the last train of 2+2 or 3 or 3+3
> > provenience the owner of the P0 might once declare his company closed
> > and gets 40, 70 or 100 Yuan respectivly, private company is then closed.
> > Note that money goes to the player not any company.
> >
> > Otherwise most things should be in and working now.
> >
> > So we need here a big check from Erik, Stefan, Brent and Frederick if
> > everything is ok :)
> >
> > And let the testing start... (i am damn sure something will go wrong :))
> >
> > Regards,
> > Martin
> >
> > Does anybody know a command to extract the commit history and put it in
> > one file without the code ? :)
> >
> > Known Bugs:
> >
> > StatusWindow isnt reflecting Player Order Correctly after Startround has
> > ended: Workaround: Save and reload Game
> >
> > Revenue Calculation for Minors is whacky... Havent figured out yet where
> > the huge amount of trains is coming from :)
> >
> > Advice needed on implementing the specialpowers of the privates, sofar
> > my tries have been unsuccessfull and thus deleted from the code.
> >
> > And as usual please point out or refactor the code if needed by your
> > experience.
> >
> > Probably some others testing needs now to commence :)
> >
> >
> >
> > ------------------------------------------------------------------------------
> > Virtualization& Cloud Management Using Capacity Planning
> > Cloud computing makes use of virtualization - but cloud computing
> > also focuses on allowing computing to be delivered as a service.
> > http://www.accelacomm.com/jaw/sfnl/114/51521223/
> >
> >
> >
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> 
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>  
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel