rails-devel — List for discussion of Rails development

[Rails-devel] Bug, 1.7.12, 1835

[John D. G. <jd...@di...>]

At the point of this save file, "By" is trying to lay its second tile,
a city at hex N12.  When I click on the hex, only tile 6 appears at the
left as a tile available for building, and it is grayed out as having
run out.  However, "Info" shows that there are still some of tiles 5 and
57 available, and I want to lay a #57 but it is not being allowed.

[Rails-devel] Rails 2.0 status

[Stefan F. <ste...@we...>]

Hi all,
due to private reasons I was not able to join the discussion for the 
last few weeks.
Unfortunately this delays the publication of Rails 2.0 alpha until 
February earliest.
I might be able to make publish a Rails 1.7.x release if bug fixes from 
Erik (or others) are pushed.
A happy new year to all Rails devs and users!
Stefan

Re: [Rails-devel] Current dev mode: Git push to which branches?

[Stefan F. <ste...@we...>]

Hi Frederick,
if I remember correctly you had right to push to the repo:
The preferred branch is 1.7.x, you can or cannot push it to master, as I 
merge/pick fixes as soon as a new release of 1.x is done.
Stefan

On 12/18/2012 07:30 AM, Frederick Weld wrote:
> Hi,
> I have come across some minor issues with two background svgs that I
> have fixed. Whereto should I push these changes apart from master?
> (1.7.x? or something else?)
> Regards,
> Frederick
> PS: In case you wonder, I'm not able to reengage into coding for the
> time being.
>
>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Current dev mode: Git push to which branches?

[brett l. <bre...@gm...>]

Typically for new developers, we accept patches. With us using git,
pull requests are also now a viable option.

---Brett.


On Tue, Dec 18, 2012 at 1:30 AM, Frederick Weld
<fre...@go...> wrote:
> Hi,
>
> I have come across some minor issues with two background svgs that I have
> fixed. Whereto should I push these changes apart from master? (1.7.x? or
> something else?)
>
> Regards,
> Frederick
>
> PS: In case you wonder, I'm not able to reengage into coding for the time
> being.
>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] Current dev mode: Git push to which branches?

[Frederick W. <fre...@go...>]

Hi,

I have come across some minor issues with two background svgs that I have
fixed. Whereto should I push these changes apart from master? (1.7.x? or
something else?)

Regards,
Frederick

PS: In case you wonder, I'm not able to reengage into coding for the time
being.

Re: [Rails-devel] 1835 bug Exchange presedencie

[Erik V. <eri...@xs...>]

Apologies that this bug report has been left unresponded for so long. 
I agree that a choice should be given. It's on my to-do list.
Erik.

> -----Original Message-----
> From: Schnell, Volker [mailto:vol...@ar...]
> Sent: Thursday, November 08, 2012 8:51 PM
> To: rai...@li...
> Subject: [Rails-devel] 1835 bug Exchange presedencie
> 
> Hi,
> our actual game show up some rails-Bugs.
> 
> player Volker has 40% MS (Director-share and a 20% Share), Player Sven has
> alse 40% MS (1 20% and 2 10%).
> Player Sven buys another MS and is now MS-Director. The Director-Paper has
> to be exchanged.
> Rails changes the 20% MS into 2 10% MS,
> 
> Rule 3.3.8  Beim Direktorwechsel übergibt der alte Direktor seine
Direktor-
> Aktie unmittelbar an den neuen Direktor und erhält dafür gleichviele
> prozentuale Anteile dieser Gesellschaft zurück. Die Stückelung wählt der
alte
> Direktor. (i.e. 20% vs 20% or 2 10% vs 20%).
> (At the exchange of the Director the old Director give his director-Share
> immediately to the new director and receive the equal procentual Shares of
> this Company. The  denomination chooses the old director.
> 
> Rails has to offer an option, which denomination-Exchange the old Director
> wants (in case of the usibility it is also possible to ask the current
player).
> The options are:
> 1 20% <-> 1 20% MS
> 1 20% <-> 2 10% MS
> see attached file. the second option was not possible.
> 
> --
> Volker Schnell
> email: vol...@ar...
> homepage: home.arcor.de\volker_schnell

Re: [Rails-devel] Bug report, Rails 1.7.10, 18EU

[Erik V. <eri...@xs...>]

Indeed, and I think I have found the cause.  I'll fix it once I'm set up to
use the new repository.

> -----Original Message-----
> From: John David Galt [mailto:jd...@di...]
> Sent: Sunday, December 09, 2012 11:49 PM
> To: Development list for Rails: an 18xx game
> Subject: [Rails-devel] Bug report, Rails 1.7.10, 18EU
> 
> When a major company floats as the result of a merger during the Final
> Exchange Round, its last 5 shares are supposed to be automatically sold
into
> the Bank Pool immediately, as though it had been started in Phase 5 (rules
> section 4.2.2, first bullet point, second sentence).  This does not
happen.

[Rails-devel] Bug report, Rails 1.7.10, 18EU

[John D. G. <jd...@di...>]

When a major company floats as the result of a merger during the Final
Exchange Round, its last 5 shares are supposed to be automatically sold
into the Bank Pool immediately, as though it had been started in Phase 5
(rules section 4.2.2, first bullet point, second sentence).  This does not
happen.

[Rails-devel] Fwd: SourceForge Repo Clone Complete

[brett l. <bre...@gm...>]

Sourceforge is migrating to a new software platform. This means that
our git URL has changed.

Old repository url: git://rails.git.sourceforge.net/gitroot/rails/rails

New repository url: ssh://USE...@gi.../p/rails/code

Please update your repository checkouts accordingly.

---Brett.

Re: [Rails-devel] (no subject)

[brett l. <bre...@gm...>]

Please do not click on this link. It's spam and possibly malware.

This user has been removed from the mailing list.

---Brett.


---Brett.


On Sat, Nov 10, 2012 at 11:41 AM, kos petoussis <kos...@gm...> wrote:

>   http://gazzinfo.com/wp-content/themes/twentyten/ugoogle.html
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] (no subject)

[kos p. <kos...@gm...>]

  http://gazzinfo.com/wp-content/themes/twentyten/ugoogle.html

Re: [Rails-devel] 1835 bug Exchange presedencie

[Mike B. <com...@ip...>]

I would agree with the statement that it is a reasonable default assumption
- but the point of the original message seems to be that this is not the way
Rails is actually processing the changeover.

Mike Bourke
Campaign Mastery http://www.campaignmastery.com
Co-author, Assassin's Amulet http://www.legaciescampaignsetting.com

Re: [Rails-devel] 1835 bug Exchange presedencie

[John D. G. <jd...@di...>]

On 2012-11-08 11:50, Schnell, Volker wrote:
> player Volker has 40% MS (Director-share and a 20% Share), Player Sven has alse 40% MS (1 20% and 2 10%).
> Player Sven buys another MS and is now MS-Director. The Director-Paper has to be exchanged.
> Rails changes the 20% MS into 2 10% MS,

The rule you've quoted sounds like it agrees with the 2nd edition English rules,
which say that the outgoing Director decides how the 20% he receives is made up
(if there is a choice among the certificates in the new Director's hand and the
bank pool).

Since the new director, Sven, has both a 20% and two 10% certificates, the
program ought to be asking the outgoing director (Volker) which he would rather
receive in exchange for the director's certificate.  Still, it's reasonable for
the program to assume that Volker will always choose Sven's 20% certificate.

[Rails-devel] 1835 bug Exchange presedencie

[Schnell, V. <vol...@ar...>]

Hi,
our actual game show up some rails-Bugs.

player Volker has 40% MS (Director-share and a 20% Share), Player Sven 
has alse 40% MS (1 20% and 2 10%).
Player Sven buys another MS and is now MS-Director. The Director-Paper 
has to be exchanged.
Rails changes the 20% MS into 2 10% MS,

Rule 3.3.8  Beim Direktorwechsel übergibt der alte Direktor seine 
Direktor-Aktie unmittelbar an den neuen Direktor und erhält dafür 
gleichviele prozentuale Anteile dieser Gesellschaft zurück. Die 
Stückelung wählt der alte Direktor. (i.e. 20% vs 20% or 2 10% vs 20%).
(At the exchange of the Director the old Director give his 
director-Share immediately to the new director and receive the equal 
procentual Shares of this Company. The  denomination chooses the old 
director.

Rails has to offer an option, which denomination-Exchange the old 
Director wants (in case of the usibility it is also possible to ask the 
current player).
The options are:
1 20% <-> 1 20% MS
1 20% <-> 2 10% MS
see attached file. the second option was not possible.

-- 
Volker Schnell
email: vol...@ar...
homepage: home.arcor.de\volker_schnell

Re: [Rails-devel] D&H-bug in 1830?

[John D. G. <jd...@di...>]

Are-Harald Brenne wrote:
>> Seems like it's possible to lay a token at the D&H-hex using the D&H teleport >> ability while that hex still has no tracks on it.

On 2012-11-01 07:51, Erik Vos wrote:
> I have always thought that this was a feature, but after rereading the original rules I must admit that only token laying is mentioned as being optional, which possibly implies that tile laying is mandatory.
> 
> The absence of track itself does not seem to be the problem; laying teleport tokens without any track being present is not unheard of. One example in 1856 is the W&S teleport on Kitchener.  But in this specific case you may be right.
> 
> Other opinions?

I agree that the absence of track does not prevent a token from being laid.
Indeed, in most games, when a company with no preprinted track in its hone hex
takes its first operating turn, its token always goes down first (either at the
beginning of that operating turn or earlier, upon floating), thus allowing the
company to lay the home tile on the rationale that it is extending track from
that existing station.

(Similarly, I would rule in all games that if a teleport token is placed in an
empty hex, that company can lay a tile in that hex on a later turn without any
need to use a teleport power when doing so.)

But to answer the specific question at hand, I'd have to look at details of
how the teleport power is spelt out in the rules.  Like you, I read Avalon
Hill's 1830 rules as not saying whether the tile lay is optional or not, but
from that I draw the conclusion that it is.  So I would leave Rails as it is.

Re: [Rails-devel] D&H-bug in 1830?

[Erik V. <eri...@xs...>]

I have always thought that this was a feature, but after rereading the
original rules I must admit that only token laying is mentioned as being
optional, which possibly implies that tile laying is mandatory.

 

The absence of track itself does not seem to be the problem; laying teleport
tokens without any track being present is not unheard of. One example in
1856 is the W&S teleport on Kitchener.  But in this specific case you may be
right.

 

Other opinions?

 

Erik.

 

From: Are-Harald Brenne [mailto:are...@gm...] 
Sent: Thursday, November 01, 2012 2:45 PM
To: rai...@li...
Subject: [Rails-devel] D&H-bug in 1830?

 

Seems like it's possible to lay a token at the D&H-hex using the D&H
teleport ability while that hex still has no tracks on it.

 

That's a bug, right?

Much appreciated software you make guys!

 

Cheers,

Are-Harald Brenne

[Rails-devel] D&H-bug in 1830?

[Are-Harald B. <are...@gm...>]

Seems like it's possible to lay a token at the D&H-hex using the D&H
teleport ability while that hex still has no tracks on it.

That's a bug, right?

Much appreciated software you make guys!

Cheers,
Are-Harald Brenne

[Rails-devel] Bug: 18Kaas B tiles

[Juho S. <js...@ik...>]

The 18Kaas rules say:

> 1. The home token for the B&O is the new "B+" tile in green and brown (the 1830 ‘B’ tile cannot be used).
> 4. Use all trains, tiles (inclusive the 3 special "B+" und "U" tiles) and all money ($12.000) from your 1830 game.

The way I'd interpret these rules is: By rule 1, the B+ tile can only
be used for the B&O home hex, not the B&M one. By rule 4, the B tiles
should still be available for use for the B&M hex.

Currently that's not the case. Instead the B+ tile is usable for both
the B&O and B&M home hexes, and the B tiles are completely missing
from the tile manifest. My guess is that the "the 1830 B tile cannot
be used" bit got misinterpreted as "cannot be used in the game" rather
than "cannot be used in the B&O hex".

-- 
Juho Snellman

[Rails-devel] Variants and GameOptions (was: 1835 Schlesien)

[Stefan F. <ste...@we...>]

I am currently refactoring GameOptions for Rails2.0.

I thought about the issue raised in the discussion for 1835 Schlesien 
and I like the Chris proposal.

So in addition to a GameOption tags there will be a GameVariant tag.
GameVariants define a set of GameOptions.

** An example of the GameVariant tag:

<Variant name="Schlesien">
	<Option name="StartRound" value="Clemens" suggest="yes"/>
	<Option name="LDIncome" value="30M"/>
</Variant>

This would give the user the checkbox to activate the Schlesien variant 
and would do the following:

A) A GameOption "Schlesien" to true, that can be used itself as a value 
in a IfOption tag.

B) In the option display to the user the options are preset according to 
the variant. If suggest is not set, the option is grayed out.
If suggest is set to yes, the user can deviate, however there will be a 
visual indication that the option is preset by the variant.

** Further refinements:

* If variants are mutually exclusive they can be defined with a group 
attribute.

<Variant name="Schlesien" group="map">
<Variant name="Hessian" group="map">

In this case the variants with the same group name will be selected from 
a dropdown list.

* If several variants can be chosen simultaneously and they set the same 
GameOption the variant which does not have suggest takes precedence. If 
neither has suggest, the first in ordering will take precendence, but a 
warning will be issued.


Further comments or ideas on that?

Stefan


On 08/31/2012 05:22 PM, Chris Shaffer wrote:
> In the case where a variant is a selection of options, wouldn't it be
> good to have flexibility?  For example, if variant A modifies the start
> packet, map, and tiles, while variant B modifies map, tiles, and adds a
> private company, it could be presented as:
>
> Option modify start packet A
> Option modify map A
> Option modify map B
> Option modify tiles A
> Option modify tiles B
> Option add private company B
> Variant A (same as checking all A above)
> Variant B (same as checking all B above)
>
> So on game start, a player could mix and match from the two variants, or
> they could select Variant A which would be the same as checking the
> three A boxes above.
>
> --
> Chris
>
> Please consider the environment before printing this e-mail.
>
>
> On Fri, Aug 31, 2012 at 3:15 AM, Erik Vos <eri...@xs...
> <mailto:eri...@xs...>> wrote:
>
>      >> However, it seems to me that a "variant" such as Clemens which
>     changes
>      >> only the start packet should not be listed as a variant but
>     merely an
>     option in
>      >> the Options tab -- so that it can be played with another variant.
>     Similarly for
>      >> other small changes.
>      >
>      > Agreed, in principle, but here we again run into the problems of
>     compatibility
>      > testing and the introduction of new source of bugs as a consequence.
>
>     And backwards compatibility, mostly for existing test cases.
>
>     My summary: a game option relates to a variant as a (medical) symptom
>     relates to a syndrome.
>     A game option covers a single aspect, a variant covers multiple aspects.
>
>     My latest proposal is:
>
>     1. Create the new InitialRoundType option as described before.  It only
>     covers the start packet distribution method (not the start packet
>     itself;
>     that is variant stuff).
>     The initial values will cover the methods already implemented: Standard,
>     Snake and Clemens.
>
>     2. Schlesien will become a new variant.
>     Do we agree that we can forget the original Coalfields variant,
>     which does
>     not change train and tile quantities, but is otherwise identical?
>
>     3. For backwards compatibility reasons, the Snake and Clemens _variants_
>     will be kept temporarily (to be dropped in Rails 2.0).
>     Saved file conversion will be built in: both versions can be loaded, but
>     only the new file version will be saved.
>
>     4. A new configuration flag (XML tag or attribute) will allow to
>     ignore the
>     InitialRoundType setting.
>     Future new variants may encompass new start packet distribution methods.
>     Case by case we will have to consider if such methods are generic
>     enough to
>     become another InitialRoundType value. If not, this flag must be set
>     with
>     the new variant.
>
>     Erik.
>
>
>
>
>     ------------------------------------------------------------------------------
>     Live Security Virtual Conference
>     Exclusive live event will cover all the ways today's security and
>     threat landscape has changed and how IT managers can respond.
>     Discussions
>     will include endpoint security, mobile security and the latest in
>     malware
>     threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>     _______________________________________________
>     Rails-devel mailing list
>     Rai...@li...
>     <mailto:Rai...@li...>
>     https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] Test cases for 1835 (was next 1835 bug)

[Stefan F. <ste...@we...>]

Erik,
you were right. It does not happen in master as there is the fix missing 
that a free tile lay is not allowed if the potential costs are not 
covered by the companies treasury (this is only in Rails 1.7.x).

It would require adding a Skip action to the test cases.

Details for 1835_PR_3rdTrain see below.

Stefan

1835_PR_3rdTrain:
Both the save file and the report file do not differ.

Reload is not possible as there is a skip action missing at the time 
that OBB offers an extra tile lay.

Start of Operating Round 5.2

...

BY (Alice) operates.
BY lays tile #214 at hex J6/SE for 50M
BY earns 330M
BY pays out full dividend of 330M
...

Sequence of Actions:

Action 216 Alice: LayTile tile=214 hex=J6 orientation=5 tokens=null
Action 217 Alice: Skip
Action 218 Alice: SetDividend: BY, settable, previous=240M, new=330M, 
allowed=PAYOUT,WITHHOLD, chosen=PAYOUT
Action 219 Alice: Done

The skip here is required to skip the token step.

However after laying Tile 214 on hex J6, BY should still be offered the 
extra (and free) tile lay on M17 due to the OBB private, but that does 
not happen as BY has only 20 remaining (and a tile lay on M17 
potentially costs 50).

This requires an additional skip which is missing in the game file.


On 10/17/2012 05:02 PM, Erik Vos wrote:
> Sending this failed the first time, this is a retry.
>
>> -----Original Message-----
>> From: Erik Vos [mailto:eri...@xs...]
>> Sent: Wednesday, October 17, 2012 2:47 PM
>> To: 'Development list for Rails: an 18xx game'
>> Subject: RE: [Rails-devel] next 1835 bug
>>
>> Stefan,
>>
>>> There are two test for 1835 which fail for several releases already,
>>> so I usually ignore them, but maybe you have some time to check them.
>>> (Just run the test cases it will show which one are problematic).
>>
>> I see no test case failures for 1835.
>> Could it be that fixes to .rails files exist in master that have escaped
> your
>> attention?
>>
>> Erik.
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_sfd2d_oct
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] next 1835 bug

[Erik V. <eri...@xs...>]

Sending this failed the first time, this is a retry.

> -----Original Message-----
> From: Erik Vos [mailto:eri...@xs...]
> Sent: Wednesday, October 17, 2012 2:47 PM
> To: 'Development list for Rails: an 18xx game'
> Subject: RE: [Rails-devel] next 1835 bug
> 
> Stefan,
> 
> > There are two test for 1835 which fail for several releases already,
> > so I usually ignore them, but maybe you have some time to check them.
> > (Just run the test cases it will show which one are problematic).
> 
> I see no test case failures for 1835.
> Could it be that fixes to .rails files exist in master that have escaped
your
> attention?
> 
> Erik.

Re: [Rails-devel] next 1835 bug

[Stefan F. <ste...@we...>]

Erik:
I have not realized that there was a fix until now.
Just released with 1.7.12.

I have added the case as a test game under test/bugs.
There are two test for 1835 which fail for several releases already, so 
I usually ignore them, but maybe you have some time to check them.
(Just run the test cases it will show which one are problematic).
If not, I will remove them, already done that under Rails2.0.

Stefan


On 10/12/2012 11:03 PM, Erik Vos wrote:
> Ah OK, the M1 can have had no revenue because it had no train, otherwise it
> could not have bought that 5-train.
> So I'm saved by the minor train limit being 1 in that phase.  Anyway, it
> works.
>
> I have pushed the fixes mentioned to master.
>
> Erik.
>
>> -----Original Message-----
>> From: Schnell, Volker [mailto:vol...@ar...]
>> Sent: Friday, October 12, 2012 10:41 PM
>> To: rai...@li...
>> Subject: Re: [Rails-devel] next 1835 bug
>>
>> hi Eric,
>> it is correct, the pru operates and also runs the 5 train. the owner of
> the M1
>> receives no dividend greetings volker
>>
>> Am 12.10.2012 22:19, schrieb Erik Vos:
>>> A check was missing on that: M1 bought a 5-train and was still
>>> considered being operational.
>>> I have added a check after resuming an OR after a PR formation round
>>> triggered by buying a train: if the operating company has closed in
>>> the meantime (as is the case here), the turn will be finished.
>>>
>>> It now runs well, but I was surprised to see that now the PR gets a
>>> turn. I doubt if that is correct.
>>> AFAIK, the PR cannot operate if any minor has both operated and merged
>>> in that same OR. Or am I wrong here?
>>> I vaguely remember a discussion about this issue long ago, but I'm not
>>> sure what  the outcome was.
>>>
>>> I also fixed a harmless error in the definition of tile -114
> (Braunschweig):
>>> an extra redundant null track, which I have removed.
>>> Nothing pushed yet.
>>>
>>> Erik.
>>>
>>>> -----Original Message-----
>>>> From: Erik Vos [mailto:eri...@xs...]
>>>> Sent: Friday, October 12, 2012 12:13 AM
>>>> To: vol...@ar...; 'Development list for Rails: an 18xx game'
>>>> Subject: Re: [Rails-devel] next 1835 bug
>>>>
>>>> There is an uncatched exception on the console:
>>>> Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
>>>> 	at
>>>> rails.game.OperatingRound.setBuyableTrains(OperatingRound.java:3056)
>>>> 	at
>>>> rails.game.OperatingRound.setPossibleActions(OperatingRound.java:392)
>>>> 	...
>>>> The cause probably is, that the operating company that bought the
>>>> train no longer exists whilst wrapping up its OR turn. I presume this
>>>> bug has crept
>>> in
>>>> by some change.
>>>> I'll try to sort it out tomorrow.
>>>>
>>>> Erik
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Schnell, Volker [mailto:vol...@ar...]
>>>>> Sent: Thursday, October 11, 2012 7:56 PM
>>>>> To: rai...@li...
>>>>> Subject: [Rails-devel] next 1835 bug
>>>>>
>>>>> Hello,
>>>>>
>>>>> our game have some strange options.
>>>>> the pre Pru M1 buy the first 5-Train. Then the merger takes place
>>>>> und
>>>> rails
>>>>> stopped.
>>>>> "done" is an option, but nothing happens. see attached file The
>>>>> Prussian
>>>> can
>>>>> operate normal incl. the 5-Train. The owner of the M1 receive no
>>> revenue.
>>>>> greetings
>>>>>
>>>>> Volker
>>>>>
>>>>> --
>>>>> Volker Schnell
>>>>> email: vol...@ar...
>>>>> homepage: home.arcor.de\volker_schnell
>>>>
>>>>
>>>>
>>> ----------------------------------------------------------------------
>>> ------
>>> --
>>>> Don't let slow site performance ruin your business. Deploy New Relic
>>>> APM Deploy New Relic app performance management and know exactly
>> what
>>>> is happening inside your Ruby, Python, PHP, Java, and .NET app Try
>>>> New Relic at no cost today and get our sweet Data Nerd shirt too!
>>>> http://p.sf.net/sfu/newrelic-dev2dev
>>>> _______________________________________________
>>>> Rails-devel mailing list
>>>> Rai...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>
>>> ----------------------------------------------------------------------
>>> -------- Don't let slow site performance ruin your business. Deploy
>>> New Relic APM Deploy New Relic app performance management and know
>>> exactly what is happening inside your Ruby, Python, PHP, Java, and
>>> .NET app Try New Relic at no cost today and get our sweet Data Nerd
>>> shirt too!
>>> http://p.sf.net/sfu/newrelic-dev2dev
>>> _______________________________________________
>>> Rails-devel mailing list
>>> Rai...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>> --
>> Volker Schnell
>> email: vol...@ar...
>> homepage: home.arcor.de\volker_schnell
>>
>>
>>
> ----------------------------------------------------------------------------
> --
>> Don't let slow site performance ruin your business. Deploy New Relic APM
>> Deploy New Relic app performance management and know exactly
>> what is happening inside your Ruby, Python, PHP, Java, and .NET app
>> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
>> http://p.sf.net/sfu/newrelic-dev2dev
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] Release Rails 1.7.12 available

[Stefan F. <ste...@we...>]

A new maintenance release for the Rails 1.x series.

Downloads are available at http://rails.sourceforge.net/ or by the
direct link http://sourceforge.net/projects/rails/files/Rails/1.7.12/

This release fixes a single bug.

Contributors: Erik Vos

Bug reported by Volker Schnell

1835: after resuming an OR after a PR formation round, a check was 
missing if the (minor) operating company still exists.
Fix: finish the turn if the operating company is closed at that point.

Re: [Rails-devel] next 1835 bug

[Erik V. <eri...@xs...>]

Ah OK, the M1 can have had no revenue because it had no train, otherwise it
could not have bought that 5-train.
So I'm saved by the minor train limit being 1 in that phase.  Anyway, it
works.

I have pushed the fixes mentioned to master.

Erik.

> -----Original Message-----
> From: Schnell, Volker [mailto:vol...@ar...]
> Sent: Friday, October 12, 2012 10:41 PM
> To: rai...@li...
> Subject: Re: [Rails-devel] next 1835 bug
> 
> hi Eric,
> it is correct, the pru operates and also runs the 5 train. the owner of
the M1
> receives no dividend greetings volker
> 
> Am 12.10.2012 22:19, schrieb Erik Vos:
> > A check was missing on that: M1 bought a 5-train and was still
> > considered being operational.
> > I have added a check after resuming an OR after a PR formation round
> > triggered by buying a train: if the operating company has closed in
> > the meantime (as is the case here), the turn will be finished.
> >
> > It now runs well, but I was surprised to see that now the PR gets a
> > turn. I doubt if that is correct.
> > AFAIK, the PR cannot operate if any minor has both operated and merged
> > in that same OR. Or am I wrong here?
> > I vaguely remember a discussion about this issue long ago, but I'm not
> > sure what  the outcome was.
> >
> > I also fixed a harmless error in the definition of tile -114
(Braunschweig):
> > an extra redundant null track, which I have removed.
> > Nothing pushed yet.
> >
> > Erik.
> >
> >> -----Original Message-----
> >> From: Erik Vos [mailto:eri...@xs...]
> >> Sent: Friday, October 12, 2012 12:13 AM
> >> To: vol...@ar...; 'Development list for Rails: an 18xx game'
> >> Subject: Re: [Rails-devel] next 1835 bug
> >>
> >> There is an uncatched exception on the console:
> >> Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
> >> 	at
> >> rails.game.OperatingRound.setBuyableTrains(OperatingRound.java:3056)
> >> 	at
> >> rails.game.OperatingRound.setPossibleActions(OperatingRound.java:392)
> >> 	...
> >> The cause probably is, that the operating company that bought the
> >> train no longer exists whilst wrapping up its OR turn. I presume this
> >> bug has crept
> > in
> >> by some change.
> >> I'll try to sort it out tomorrow.
> >>
> >> Erik
> >>
> >>
> >>> -----Original Message-----
> >>> From: Schnell, Volker [mailto:vol...@ar...]
> >>> Sent: Thursday, October 11, 2012 7:56 PM
> >>> To: rai...@li...
> >>> Subject: [Rails-devel] next 1835 bug
> >>>
> >>> Hello,
> >>>
> >>> our game have some strange options.
> >>> the pre Pru M1 buy the first 5-Train. Then the merger takes place
> >>> und
> >> rails
> >>> stopped.
> >>> "done" is an option, but nothing happens. see attached file The
> >>> Prussian
> >> can
> >>> operate normal incl. the 5-Train. The owner of the M1 receive no
> > revenue.
> >>> greetings
> >>>
> >>> Volker
> >>>
> >>> --
> >>> Volker Schnell
> >>> email: vol...@ar...
> >>> homepage: home.arcor.de\volker_schnell
> >>
> >>
> >>
> > ----------------------------------------------------------------------
> > ------
> > --
> >> Don't let slow site performance ruin your business. Deploy New Relic
> >> APM Deploy New Relic app performance management and know exactly
> what
> >> is happening inside your Ruby, Python, PHP, Java, and .NET app Try
> >> New Relic at no cost today and get our sweet Data Nerd shirt too!
> >> http://p.sf.net/sfu/newrelic-dev2dev
> >> _______________________________________________
> >> Rails-devel mailing list
> >> Rai...@li...
> >> https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> > ----------------------------------------------------------------------
> > -------- Don't let slow site performance ruin your business. Deploy
> > New Relic APM Deploy New Relic app performance management and know
> > exactly what is happening inside your Ruby, Python, PHP, Java, and
> > .NET app Try New Relic at no cost today and get our sweet Data Nerd
> > shirt too!
> > http://p.sf.net/sfu/newrelic-dev2dev
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> --
> Volker Schnell
> email: vol...@ar...
> homepage: home.arcor.de\volker_schnell
> 
> 
>
----------------------------------------------------------------------------
--
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] next 1835 bug

[Schnell, V. <vol...@ar...>]

hi Eric,
it is correct, the pru operates and also runs the 5 train. the owner of 
the M1 receives no dividend
greetings
volker

Am 12.10.2012 22:19, schrieb Erik Vos:
> A check was missing on that: M1 bought a 5-train and was still considered
> being operational.
> I have added a check after resuming an OR after a PR formation round
> triggered by buying a train: if the operating company has closed in the
> meantime (as is the case here), the turn will be finished.
>
> It now runs well, but I was surprised to see that now the PR gets a turn. I
> doubt if that is correct.
> AFAIK, the PR cannot operate if any minor has both operated and merged in
> that same OR. Or am I wrong here?
> I vaguely remember a discussion about this issue long ago, but I'm not sure
> what  the outcome was.
>
> I also fixed a harmless error in the definition of tile -114 (Braunschweig):
> an extra redundant null track, which I have removed.
> Nothing pushed yet.
>
> Erik.
>
>> -----Original Message-----
>> From: Erik Vos [mailto:eri...@xs...]
>> Sent: Friday, October 12, 2012 12:13 AM
>> To: vol...@ar...; 'Development list for Rails: an 18xx game'
>> Subject: Re: [Rails-devel] next 1835 bug
>>
>> There is an uncatched exception on the console:
>> Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
>> 	at
>> rails.game.OperatingRound.setBuyableTrains(OperatingRound.java:3056)
>> 	at
>> rails.game.OperatingRound.setPossibleActions(OperatingRound.java:392)
>> 	...
>> The cause probably is, that the operating company that bought the train no
>> longer exists whilst wrapping up its OR turn. I presume this bug has crept
> in
>> by some change.
>> I'll try to sort it out tomorrow.
>>
>> Erik
>>
>>
>>> -----Original Message-----
>>> From: Schnell, Volker [mailto:vol...@ar...]
>>> Sent: Thursday, October 11, 2012 7:56 PM
>>> To: rai...@li...
>>> Subject: [Rails-devel] next 1835 bug
>>>
>>> Hello,
>>>
>>> our game have some strange options.
>>> the pre Pru M1 buy the first 5-Train. Then the merger takes place und
>> rails
>>> stopped.
>>> "done" is an option, but nothing happens. see attached file The
>>> Prussian
>> can
>>> operate normal incl. the 5-Train. The owner of the M1 receive no
> revenue.
>>> greetings
>>>
>>> Volker
>>>
>>> --
>>> Volker Schnell
>>> email: vol...@ar...
>>> homepage: home.arcor.de\volker_schnell
>>
>>
>>
> ----------------------------------------------------------------------------
> --
>> Don't let slow site performance ruin your business. Deploy New Relic APM
>> Deploy New Relic app performance management and know exactly what is
>> happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic
>> at no cost today and get our sweet Data Nerd shirt too!
>> http://p.sf.net/sfu/newrelic-dev2dev
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

-- 
Volker Schnell
email: vol...@ar...
homepage: home.arcor.de\volker_schnell