rails-devel — List for discussion of Rails development

Re: [Rails-devel] 1835

[James R. <rom...@gm...>]

Are you requesting that less information be visible?  I'd vote against
that.  Why make me go scurrying to unbox my game to remind myself how many
T5's there are lower down in the deck?


On Fri, Mar 5, 2010 at 10:27 AM, Chris Shaffer <chr...@gm...>wrote:

> Maybe we could have the current and on-deck trains displayed, as they are
> on many newer game boards where you can see currently available + top of
> stack of bigger trains?  That way, the display would never be more than two
> trains, no matter how many types exist in the game.
>
> --
> Chris
>
> Please consider the environment before printing this e-mail.
>
>
>
> On Fri, Mar 5, 2010 at 6:42 AM, Phil Davies <de...@gm...> wrote:
>
>> I appreciate I might be a minority in this but I quite like having the
>> single string of train prices, it's a nice 'at a glance' view of
>> upcoming costs without having to dive into the info menu.
>>
>> I imagine games with very long train schedules might look pretty
>> horrible with this though...
>>
>> Phil
>>
>> On 4 March 2010 22:23, Erik Vos <eri...@xs...> wrote:
>> > I have fixed the double price to be paid for 1835 Prussian shares.
>> > This is the first case where the share price is not tied to the smallest
>> > share unit (5%), so I had to introduce a new parameter for the number of
>> > (smallest) shares units where the share price is valid for.
>> >
>> > I have also extended the Train info to specify price and quantity. The
>> long
>> > train price string in the GameStatus window has been removed.
>> >
>> > Erik.
>> >
>> >
>> >
>> ------------------------------------------------------------------------------
>> > Download Intel&#174; Parallel Studio Eval
>> > Try the new software tools for yourself. Speed compiling, find bugs
>> > proactively, and fine-tune applications for parallel performance.
>> > See why Intel Parallel Studio got high marks during beta.
>> > http://p.sf.net/sfu/intel-sw-dev
>> > _______________________________________________
>> > Rails-devel mailing list
>> > Rai...@li...
>> > https://lists.sourceforge.net/lists/listinfo/rails-devel
>> >
>>
>>
>> ------------------------------------------------------------------------------
>> Download Intel&#174; Parallel Studio Eval
>> Try the new software tools for yourself. Speed compiling, find bugs
>> proactively, and fine-tune applications for parallel performance.
>> See why Intel Parallel Studio got high marks during beta.
>> http://p.sf.net/sfu/intel-sw-dev
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>
>
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] 1835

[Chris S. <chr...@gm...>]

Maybe we could have the current and on-deck trains displayed, as they are on
many newer game boards where you can see currently available + top of stack
of bigger trains?  That way, the display would never be more than two
trains, no matter how many types exist in the game.

--
Chris

Please consider the environment before printing this e-mail.


On Fri, Mar 5, 2010 at 6:42 AM, Phil Davies <de...@gm...> wrote:

> I appreciate I might be a minority in this but I quite like having the
> single string of train prices, it's a nice 'at a glance' view of
> upcoming costs without having to dive into the info menu.
>
> I imagine games with very long train schedules might look pretty
> horrible with this though...
>
> Phil
>
> On 4 March 2010 22:23, Erik Vos <eri...@xs...> wrote:
> > I have fixed the double price to be paid for 1835 Prussian shares.
> > This is the first case where the share price is not tied to the smallest
> > share unit (5%), so I had to introduce a new parameter for the number of
> > (smallest) shares units where the share price is valid for.
> >
> > I have also extended the Train info to specify price and quantity. The
> long
> > train price string in the GameStatus window has been removed.
> >
> > Erik.
> >
> >
> >
> ------------------------------------------------------------------------------
> > Download Intel&#174; Parallel Studio Eval
> > Try the new software tools for yourself. Speed compiling, find bugs
> > proactively, and fine-tune applications for parallel performance.
> > See why Intel Parallel Studio got high marks during beta.
> > http://p.sf.net/sfu/intel-sw-dev
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
>
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] 1835

[Phil D. <de...@gm...>]

I appreciate I might be a minority in this but I quite like having the
single string of train prices, it's a nice 'at a glance' view of
upcoming costs without having to dive into the info menu.

I imagine games with very long train schedules might look pretty
horrible with this though...

Phil

On 4 March 2010 22:23, Erik Vos <eri...@xs...> wrote:
> I have fixed the double price to be paid for 1835 Prussian shares.
> This is the first case where the share price is not tied to the smallest
> share unit (5%), so I had to introduce a new parameter for the number of
> (smallest) shares units where the share price is valid for.
>
> I have also extended the Train info to specify price and quantity. The long
> train price string in the GameStatus window has been removed.
>
> Erik.
>
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] Director Change

[Stefan F. <ste...@we...>]

As reported in bug #2962977 by Chris Fawcett the director change algorithm in 
Rails can select the wrong player. 

It occurs if there are several potential candidates for new directorship, then 
Rails select the first in playing order after the old director - regardless 
of the number of the shares they are holding. 

The bug is fixed in CVS. A backport to Rails 1.1.3 is available on request by 
e-mail.

Stefan Frey

[Rails-devel] 1835

[Erik V. <eri...@xs...>]

I have fixed the double price to be paid for 1835 Prussian shares.
This is the first case where the share price is not tied to the smallest
share unit (5%), so I had to introduce a new parameter for the number of
(smallest) shares units where the share price is valid for.

I have also extended the Train info to specify price and quantity. The long
train price string in the GameStatus window has been removed.

Erik.

Re: [Rails-devel] Info

[Erik V. <eri...@xs...>]

OK, I have applied and committed this patch. Thanks!
Erik. 

-----Original Message-----
From: Phil Davies [mailto:de...@gm...] 
Sent: Tuesday 02 March 2010 15:51
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Info

Hows this, dropped to toMenu back to one line (and updated ORUIManager
which was using the getInfo not the toMenu to populate the special
menu, leading it to still use the longer description)

Altered the LocalisedText to place closing the private as a
consequence and added a second entry to handle the 'any' discount over
a specific discount (there is probably a neater way to do that :p)

It occurred to me looking at this that putting the privates income on
the info menu would be a good idea, but I'll do that separately.

Phil


On 28 February 2010 23:35, Erik Vos <eri...@xs...> wrote:
> Where does the toMenu() get called?
>
> [EV] When building an entry for the 'Special' menu. See StatusWindow line
> 400.
> This should be a localized text, but in many cases it isn't yet.
>
> Erik.
>
>
>
----------------------------------------------------------------------------
--
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Info

[Phil D. <de...@gm...>]

Hows this, dropped to toMenu back to one line (and updated ORUIManager
which was using the getInfo not the toMenu to populate the special
menu, leading it to still use the longer description)

Altered the LocalisedText to place closing the private as a
consequence and added a second entry to handle the 'any' discount over
a specific discount (there is probably a neater way to do that :p)

It occurred to me looking at this that putting the privates income on
the info menu would be a good idea, but I'll do that separately.

Phil


On 28 February 2010 23:35, Erik Vos <eri...@xs...> wrote:
> Where does the toMenu() get called?
>
> [EV] When building an entry for the 'Special' menu. See StatusWindow line
> 400.
> This should be a localized text, but in many cases it isn't yet.
>
> Erik.
>
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] 1835 Prussian formation

[Erik V. <eri...@xs...>]

Right! The special property text is now added at the end of all other info.
Erik.

-----Original Message-----
From: Phil Davies [mailto:de...@gm...] 
Sent: Monday 01 March 2010 16:48
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] 1835 Prussian formation

Yeah, PrivateCompany.java, line 47

Special properties get configured before other aspects of the company,
leading to the infoText getting populated, then overwritten on line 50



On 1 March 2010 10:56, Phil Davies <de...@gm...> wrote:
> Not sure whether this is related but it seems likely, the special
> properties of private companies no longer show up on the info menu of
> the map window...
>
> Phil
>
> On 28 February 2010 21:49, Erik Vos <eri...@xs...> wrote:
>> I have committed a bunch of changes related to the Prussian formation in
>> 1835.
>> This has affected a large number of files, but most changes are name
changes
>> directly or indirectly caused by the need to move the SpecialProperties
>> possession attribute one level up: from PrivateCompany to Company. So
Public
>> Companies now also can have special properties.
>>
>> Long ago I had defined the exchange of the "black" privates and minors
for a
>> Prussian as special properties, reusing the M&H/NYC swap special
property. I
>> still couldn't think of a better way to specify this (in particular,
whether
>> a 5% or 10% share will be obtained), so I had to add special properties
to
>> minors, which are public companies.
>>
>> I have tested most of the existing special properties of other games, and
>> these still work, so I suppose the damage can't be great. Should any
>> glitches arise nevertheless, I will no doubt soon here about it.
>>
>> Erik.
>>
>>
>>
>>
>>
----------------------------------------------------------------------------
--
>> Download Intel&#174; Parallel Studio Eval
>> Try the new software tools for yourself. Speed compiling, find bugs
>> proactively, and fine-tune applications for parallel performance.
>> See why Intel Parallel Studio got high marks during beta.
>> http://p.sf.net/sfu/intel-sw-dev
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>

----------------------------------------------------------------------------
--
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] 1835 Prussian formation

[Phil D. <de...@gm...>]

Yeah, PrivateCompany.java, line 47

Special properties get configured before other aspects of the company,
leading to the infoText getting populated, then overwritten on line 50



On 1 March 2010 10:56, Phil Davies <de...@gm...> wrote:
> Not sure whether this is related but it seems likely, the special
> properties of private companies no longer show up on the info menu of
> the map window...
>
> Phil
>
> On 28 February 2010 21:49, Erik Vos <eri...@xs...> wrote:
>> I have committed a bunch of changes related to the Prussian formation in
>> 1835.
>> This has affected a large number of files, but most changes are name changes
>> directly or indirectly caused by the need to move the SpecialProperties
>> possession attribute one level up: from PrivateCompany to Company. So Public
>> Companies now also can have special properties.
>>
>> Long ago I had defined the exchange of the "black" privates and minors for a
>> Prussian as special properties, reusing the M&H/NYC swap special property. I
>> still couldn't think of a better way to specify this (in particular, whether
>> a 5% or 10% share will be obtained), so I had to add special properties to
>> minors, which are public companies.
>>
>> I have tested most of the existing special properties of other games, and
>> these still work, so I suppose the damage can't be great. Should any
>> glitches arise nevertheless, I will no doubt soon here about it.
>>
>> Erik.
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Download Intel&#174; Parallel Studio Eval
>> Try the new software tools for yourself. Speed compiling, find bugs
>> proactively, and fine-tune applications for parallel performance.
>> See why Intel Parallel Studio got high marks during beta.
>> http://p.sf.net/sfu/intel-sw-dev
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>

Re: [Rails-devel] 1835 Prussian formation

[Phil D. <de...@gm...>]

Not sure whether this is related but it seems likely, the special
properties of private companies no longer show up on the info menu of
the map window...

Phil

On 28 February 2010 21:49, Erik Vos <eri...@xs...> wrote:
> I have committed a bunch of changes related to the Prussian formation in
> 1835.
> This has affected a large number of files, but most changes are name changes
> directly or indirectly caused by the need to move the SpecialProperties
> possession attribute one level up: from PrivateCompany to Company. So Public
> Companies now also can have special properties.
>
> Long ago I had defined the exchange of the "black" privates and minors for a
> Prussian as special properties, reusing the M&H/NYC swap special property. I
> still couldn't think of a better way to specify this (in particular, whether
> a 5% or 10% share will be obtained), so I had to add special properties to
> minors, which are public companies.
>
> I have tested most of the existing special properties of other games, and
> these still work, so I suppose the damage can't be great. Should any
> glitches arise nevertheless, I will no doubt soon here about it.
>
> Erik.
>
>
>
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Info

[Erik V. <eri...@xs...>]

Where does the toMenu() get called? 

[EV] When building an entry for the 'Special' menu. See StatusWindow line
400. 
This should be a localized text, but in many cases it isn't yet.

Erik.

Re: [Rails-devel] Info

[Phil D. <de...@gm...>]

On 23 February 2010 20:23, Erik Vos <eri...@xs...> wrote:
> Gave this one a shot, in several cases I found the local getInfo() was
> just pointing straight at the toMenu() method so I've done the same
> here.  I also extended the description to include the value for the
> routes on the named trains and the full name for the destinations.
>
> [EV] Equalizing toMenu() and getInfo() can be an easy shortcut, and it
> reduces the number of LocalizedText entries (which is a Good Thing). But it
> does not work if the info gets long (3 lines in this case). And to make it
> worse, this special property now shows up *twice* in the Special menu for
> the company owning M&C (not sure why).
> In any case, toMenu() should produce a sensible and not overly long
> one-liner.

Where does the toMenu() get called? the info menu is a menu in and of
itself, so I wsn't entirely sure on the difference.  I'll certainly
clear that back to one line and in this case produce different
versions for the train naming I think.

> One thing that might be an issue is the text for SpecialTrainBuy which
> states 'Close {private} to purchase...' This would be incorrect if
> there is an 18XX game out there that had train discounts that didn't
> close the private.  I am unaware whether or not such a game exists so
> this might need further clarification if this is the case.
>
> [EV] The worst thing about this text is, that you put the side effect
> (closing the private) at the front, where the main purpose (buying a cheap
> train) should be. So I would suggest something like "Purchase.... (closing
> <private>)".

Hmm, Interesting, I think it depends whether you view closing the
private as a cost or a consequence.  In some games (not talking 18XX
here, just generic boardgames) you would often see powers listed as:

Cost: benefit

So I immediately think of things in these terms (I close the private,
that allows me to buy a train cheaply) rather than closing the private
being a consequence of choosing to buy a cheap train.  I think this
comes down to a personal choice but I can appreciate your thinking on
this.  We should be emphasising the benefit instead of the detriment
so this should get switched round.

> Also, you haven't localized "any".

Very valid point...was trying to think of a cute way of doing this and
obviously failed :p

> I'm also unaware of any other cases (which proves nothing). We can always
> refine if such a case would show up later.

> [EV] Want to try another shot?

As long as you don't mind me bothering you for feedback, I'll get a
chance to play with this during the week hopefully.

Phil

[Rails-devel] 1835 Prussian formation

[Erik V. <eri...@xs...>]

I have committed a bunch of changes related to the Prussian formation in
1835.
This has affected a large number of files, but most changes are name changes
directly or indirectly caused by the need to move the SpecialProperties
possession attribute one level up: from PrivateCompany to Company. So Public
Companies now also can have special properties.

Long ago I had defined the exchange of the "black" privates and minors for a
Prussian as special properties, reusing the M&H/NYC swap special property. I
still couldn't think of a better way to specify this (in particular, whether
a 5% or 10% share will be obtained), so I had to add special properties to
minors, which are public companies.

I have tested most of the existing special properties of other games, and
these still work, so I suppose the damage can't be great. Should any
glitches arise nevertheless, I will no doubt soon here about it.

Erik.

[Rails-devel] NoMapMode: break of save compatibility

[Stefan F. <ste...@we...>]

In preparation of the new correction actions I had to adjust the 
NoMap actions. 

This implies that games that used the NoMap option in CVS cannot 
be restored with version built from the updated source code (thus keep the
existing built somewhere).

Stefan

Re: [Rails-devel] Stockmarket type

[Stefan F. <ste...@we...>]

Not too weird ;-)
1860's stockmarket is in fact a 2-d with two rows of hexagons
- with sides NW, NE, E, SE, SW, W
- and an arrow pointing from SW to NW for the zig-zag selling pattern

Stefan

On Tuesday 23 February 2010 22:52:50 Aliza Panitz wrote:
> On Mon, Feb 22, 2010 at 2:57 PM, Erik Vos <eri...@xs...> wrote:
> > Linear is rectangular with only a single row. :-)
> >
> > [EV] Yes, but both the layout (higher and narrower) and the token moves
> > rules (no up/down) will be somewhat different.
>
> 1860 has a 1.5-dimensional stock market, among its many many many
> weirdnesses.
>
> I'd be surprised if Rails ever supported it, though.
>
>  - A
>
> ---------------------------------------------------------------------------
>--- Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] train-buying privates

[Phil D. <de...@gm...>]

oh yay,  my copy of 1844 should be arriving soon, will keep that in mind :)

On 24 February 2010 00:47, Chris Shaffer <chr...@gm...> wrote:
>> 18something-or-other has a private that *is* a 5-train, which can be
>>
>> handed to a company after the first 5 has been bought outright.
>> (That's quite powerful, as (if the timing works perfectly) it can be
>> handed to a newly-floated company which will then not fall in its
>> first OR.) Sadly, I don't remember which game that was.  (John T.?
>> One of yours?)
>
> That's 1844.
>
> --
> Chris
>
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] train-buying privates

[Chris S. <chr...@gm...>]

>
> 18something-or-other has a private that *is* a 5-train, which can be
>
handed to a company after the first 5 has been bought outright.
> (That's quite powerful, as (if the timing works perfectly) it can be
> handed to a newly-floated company which will then not fall in its
> first OR.) Sadly, I don't remember which game that was.  (John T.?
> One of yours?)
>

That's 1844.

--
Chris

[Rails-devel] 1889 in CVS

[Stefan F. <ste...@we...>]

The current implementation of 1889 now fully supports the
behavior of private companies B and C in the full game:

* The special tile lay of B can now be requested from the special menu if B is 
owned by a different player than the owner of the operating company. 

* The special tile lay of C is now triggered as an interruption immediately 
after the purchase of that private. Skipping ("No Tile") means to forfeit 
that special lay.

WIth the exception of the missing restriction in Rails of dumping another 
company during forced selling (which some player might even use as a variant 
rule) 1889 should be fully supported by now (but still only available from 
CVS).

NoMapMode and BeginnerGame are not changed by that.

Stefan

Re: [Rails-devel] train-buying privates

[Aliza P. <ali...@gm...>]

On Tue, Feb 23, 2010 at 6:59 AM, Phil Davies <de...@gm...> wrote:
> [...]
>
> One thing that might be an issue is the text for SpecialTrainBuy which
> states 'Close {private} to purchase...' This would be incorrect if
> there is an 18XX game out there that had train discounts that didn't
> close the private.  I am unaware whether or not such a game exists so
> this might need further clarification if this is the case.
>

18io has *companies* with special powers, some of which are a discount
on the first train. (18io company powers are more of a distraction
than anything else, though.)

1848 has a private that hands the owning company a token that is a
discount on a certain train type after the privates are killed.

18something-or-other has a private that *is* a 5-train, which can be
handed to a company after the first 5 has been bought outright.
(That's quite powerful, as (if the timing works perfectly) it can be
handed to a newly-floated company which will then not fall in its
first OR.) Sadly, I don't remember which game that was.  (John T.?
One of yours?)

I am not aware of a private that helps with a train purchase and does
not close.

 - Aliza

Re: [Rails-devel] Stockmarket type

[Aliza P. <ali...@gm...>]

On Mon, Feb 22, 2010 at 2:57 PM, Erik Vos <eri...@xs...> wrote:
> Linear is rectangular with only a single row. :-)
>
> [EV] Yes, but both the layout (higher and narrower) and the token moves
> rules (no up/down) will be somewhat different.

1860 has a 1.5-dimensional stock market, among its many many many weirdnesses.

I'd be surprised if Rails ever supported it, though.

 - A

Re: [Rails-devel] Info

[Erik V. <eri...@xs...>]

"And to make it
worse, this special property now shows up *twice* in the Special menu for
the company owning M&C (not sure why)."

Apologies, that wasn't your fault, but an existing bug (which I have now
fixed).

Erik.

Re: [Rails-devel] Info

[Erik V. <eri...@xs...>]

Gave this one a shot, in several cases I found the local getInfo() was
just pointing straight at the toMenu() method so I've done the same
here.  I also extended the description to include the value for the
routes on the named trains and the full name for the destinations.

[EV] Equalizing toMenu() and getInfo() can be an easy shortcut, and it
reduces the number of LocalizedText entries (which is a Good Thing). But it
does not work if the info gets long (3 lines in this case). And to make it
worse, this special property now shows up *twice* in the Special menu for
the company owning M&C (not sure why).
In any case, toMenu() should produce a sensible and not overly long
one-liner. 

One thing that might be an issue is the text for SpecialTrainBuy which
states 'Close {private} to purchase...' This would be incorrect if
there is an 18XX game out there that had train discounts that didn't
close the private.  I am unaware whether or not such a game exists so
this might need further clarification if this is the case.

[EV] The worst thing about this text is, that you put the side effect
(closing the private) at the front, where the main purpose (buying a cheap
train) should be. So I would suggest something like "Purchase.... (closing
<private>)".
Also, you haven't localized "any". 
I'm also unaware of any other cases (which proves nothing). We can always
refine if such a case would show up later.

[EV] Want to try another shot?

Erik.

Re: [Rails-devel] Info

[Phil D. <de...@gm...>]

Gave this one a shot, in several cases I found the local getInfo() was
just pointing straight at the toMenu() method so I've done the same
here.  I also extended the description to include the value for the
routes on the named trains and the full name for the destinations.

One thing that might be an issue is the text for SpecialTrainBuy which
states 'Close {private} to purchase...' This would be incorrect if
there is an 18XX game out there that had train discounts that didn't
close the private.  I am unaware whether or not such a game exists so
this might need further clarification if this is the case.

Phil

On 22 February 2010 23:34, Erik Vos <eri...@xs...> wrote:
>
> Patch for 18AL longnames for companies
>
> [EV] Applied.
>
> The 'powers' for the M&C and NDY aren't in particularly clear English
> but I'm unsure exactly how the info menu is populated here.  I'm
> assuming it's somewhere in LocalisedText.properties but couldn't
> totally work out where the existing companies are picking up their
> info from.
>
> Any pointers on where to put this information and I'll add it.
>
> [EV] These are the return values of the getInfo() methods of NameTrains and
> SpecialTrainBuy.
> By default, these values are equal to the (by design not localized)
> toString() results (which are mainly meant for logging).
> So you might want to compose new localized return values of these getInfo()
> methods.
>
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Info

[Erik V. <eri...@xs...>]

Patch for 18AL longnames for companies

[EV] Applied.

The 'powers' for the M&C and NDY aren't in particularly clear English
but I'm unsure exactly how the info menu is populated here.  I'm
assuming it's somewhere in LocalisedText.properties but couldn't
totally work out where the existing companies are picking up their
info from.

Any pointers on where to put this information and I'll add it.

[EV] These are the return values of the getInfo() methods of NameTrains and
SpecialTrainBuy.
By default, these values are equal to the (by design not localized)
toString() results (which are mainly meant for logging).
So you might want to compose new localized return values of these getInfo()
methods.

Re: [Rails-devel] Stockmarket type

[Erik V. <eri...@xs...>]

Linear is rectangular with only a single row. :-)

[EV] Yes, but both the layout (higher and narrower) and the token moves
rules (no up/down) will be somewhat different.

Erik.