poseverts[MAXALIASFRAMES] access is missing bounds check

A modern, cross-platform Quake game engine based on FitzQuake.

Brought to you by: ewasylishen, sezero, stevenaaus

#37 poseverts[MAXALIASFRAMES] access is missing bounds check

Milestone: None

Status: closed-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2020-04-13

Created: 2019-11-25

Creator: Eric Wasylishen

Private: No

Currently, .mdl's with >256 frames will cause memory corruption since the limit is not checked.

We could easily lift this limit since protocol 666 already supports 16-bit frame indices on models.
QSS probably has already done this since Spike revamped the mdl loading code there.

Discussion

Ozkan Sezer - 2019-12-03

Have a patch for this?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eric Wasylishen - 2020-04-13

Fixed in r1670 with Oz's patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eric Wasylishen - 2020-04-13

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

poseverts[MAXALIASFRAMES] access is missing bounds check

A modern, cross-platform Quake game engine based on FitzQuake.

Milestone

Searches

Help

#37 poseverts[MAXALIASFRAMES] access is missing bounds check

Discussion