QmailAdmin / Patches / #2 Replace hard-coded values with sizeof()

#2 Replace hard-coded values with sizeof()

Status: closed-accepted

Owner: Tom Collins

Labels: None

Priority: 5

Updated: 2003-06-25

Created: 2003-06-17

Creator: Tom Collins

Private: No

This is a cleanup patch, resulting from a quick pass I made
through the source looking for calls to snprintf, GetValue,
memset, fgets, strncmp and strncpy.

I found many instances where a hard-coded value (or even
a reference to MAX_BUFF) could be replaced by a safer
sizeof().

I also noticed some areas where there was a discrepancy
between the assumed size of a character array and its
actual size.

Please review the patch and let me know if you find any
errors in it. It touches a lot of the code, but I feel it's
necessary for making qmailadmin more robust/secure.

Discussion

Tom Collins - 2003-06-17

the gzipped patch

patch-1.0.21-tbc-cleanup.txt.gz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tom Collins - 2003-06-25

assigned_to: nobody --> tomcollins

status: open --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tom Collins - 2003-06-25

Logged In: YES
user_id=117662

This patch has been rolled into the 1.0.22 release.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Replace hard-coded values with sizeof()

Group

Searches

Help

#2 Replace hard-coded values with sizeof()

Discussion