[Qce-ga-discussion] Making qc-usb 0.63 compile on GCC 4.0

[Aart de V. <aar...@sh...>]

When trying to compile qc-usb-0.6.3 on a SuSE 10.0 (gcc 4.02)=20
system, I got the following error messages:
  qcset.c: In function =E2=80=98pnm_open=E2=80=99:
  qcset.c:390: warning: pointer targets in passing argument 1 of =E2=80=98f=
open=E2=80=99 differ in signedness
  qcset.c: In function =E2=80=98main=E2=80=99:
  qcset.c:661: warning: pointer targets in passing argument 1 of =E2=80=98p=
nm_open=E2=80=99 differ in signedness

I only needed to make a single code change in the=20
file qcset.c on line 386 to make things work:
  void pnm_open(unsigned char *name, unsigned int *width, unsigned int *hei=
ght) {
changed to:
  void pnm_open(char *name, unsigned int *width, unsigned int *height) {

By taking away this 'unsigned' declaration the compilation=20
problem was resolved, and I could do a 'make all' and=20
'make install' without problems. When pluggin in my=20
Quickcam Express webcam the driver loaded cleanly=20
and I could use it with gnomemeeting no problem.

The code change seems rather harmless since:
1) pnm_open is only called from line 661 with the argument 'argp', and argp=
=20
    is not declared unsigned there.
2) On line 390 the fopen apparently expects a non unsigned parameter, since
    the code change makes the error message reported against line 390 go aw=
ay.

I hope a 0.6.4 version including this fix can be released asap, as I expect=
=20
more people will soon upgrade to SuSE 10.0 now it's final version has been=
=20
released about 2 weeks ago.

regards,
Aart