[pywin32-bugs] [ pywin32-Bugs-3612206 ] Deadlock with Loader Lock and GIL

[SourceForge.net <no...@so...>]

Bugs item #3612206, was opened at 2013-04-29 08:12
Message generated for change (Comment added) made by sschukat
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=3612206&group_id=78018

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Stefan Schukat (sschukat)
Assigned to: Nobody/Anonymous (nobody)
Summary: Deadlock with Loader Lock and GIL

Initial Comment:
FormatMessage could implicit load libraries to read resource strings for the message formatting. For this the windows DLL loader lock is acquired. In an multithreaded application which makes use of native an Python threads a deadlock could happen if these two locks (Loader Lock, GIL) are acquired in wrong order. This fix releases the GIL before a call to FormatMessage is made.

----------------------------------------------------------------------

>Comment By: Stefan Schukat (sschukat)
Date: 2013-04-30 05:02

Message:
I provided a patch in the patch queue with the changes suggested.

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2013-04-29 23:30

Message:
This patch looks fine, but could you please remove the lines like "// code
changed by ssc" - source control can tell us that (and if you upload a
patch from a mercurial queue, you will be directly attributed for the
change)

Thanks!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551954&aid=3612206&group_id=78018