[pywin32-bugs] [ pywin32-Patches-3083568 ] Adding support for IExchangeModifyTables for Rules and ACLs

[SourceForge.net <no...@so...>]

Patches item #3083568, was opened at 2010-10-08 18:56
Message generated for change (Comment added) made by mhammond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551956&aid=3083568&group_id=78018

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Patrick Breucking (marquies)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adding support for IExchangeModifyTables for Rules and ACLs

Initial Comment:
This patch provides an implementation of the wrapping IExchangeModifyTable interface and the needed utility methods. The patch contains methods to wrap ROWLIST and ACTIONS structures and a set of flags to work with it. Please give me feedback if something is not conform to coding guidelines or other things to change.

Thanks
Patrick

----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2010-12-21 09:00

Message:
If you get the latest from cvs and follow the instructions in setup.py, you
should be able to get all the exchange modules building with just MSVC and
the most recent platform SDK.

----------------------------------------------------------------------

Comment By: Patrick Breucking (marquies)
Date: 2010-12-21 00:17

Message:
Hi Mark,

I'm glad that you respond this patch. I agree with you that this stuff is
exchange specific and could be moved. Do you have a hint where to get the
exchange sdk files to build the exchange extensions? I have installed this
one [1] but I can't find the expected files to compile.

I would be pleased if we can fix this problem to continue the integration
of this patch


[1]
http://www.microsoft.com/downloads/details.aspx?familyid=4afe3504-c209-4a73-ac5d-ff2a4a3b48b7

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2010-12-18 11:34

Message:
Sorry for the delay in looking at this.

Any chance this could be moved into the exchange module - it seems
specific to exchange itself and I'm reluctant to have mapi itself include
headers specific to the exchange SDK as I've been burnt before with mapi
building but exchange failing.  

Also, the addition of blank lines which aren't surrounded by other changes
should be removed, and it appears OOF_TEXT isn't used so should be removed
too.

Any reason you had to stick with integer literals instead of macro names
in things like:
+        case  8:  //OP_DELEGATE,
+            lpAction->acttype = OP_DELEGATE;
? OP_DELEGATE must exist as it is used in the following line.

+                printf ("Fatal Error, can not parse message ID");
Should set a Python error instead of a simple printf - ditto for a couple
of other printfs.

The addition of EdkMdb.h etc worries me - the copyright statements don't
say they are able to be copied - isn't this stuff in the exchange SDK?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551956&aid=3083568&group_id=78018