postfixadmin-tracker — Postfix Admin tracker notification - READ ONLY!

[ postfixadmin-Patches-3371641 ] vacation.pl patch for postfix helo_check

[SourceForge.net <no...@so...>]

Patches item #3371641, was opened at 2011-07-19 10:51
Message generated for change (Settings changed) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3371641&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: ichier (ichier)
Assigned to: Nobody/Anonymous (nobody)
Summary: vacation.pl patch for postfix helo_check

Initial Comment:
i had the problem, that on my mailsetup, postfix wouldnt let vacation.pl send mails due to helo restrictions. vacation.pl was greeting with localhost.localdomain. so i added the possibility to define the smtp client to something. add that something to your helo-whitelist (you shouldnt whitelist local...) and vacaion magically starts working :)

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2012-04-19 14:01

Message:
I've merged this into vacation.pl; I'm not currently able to test it
though... 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3371641&group_id=191583

[ postfixadmin-Patches-3371641 ] vacation.pl patch for postfix helo_check

[SourceForge.net <no...@so...>]

Patches item #3371641, was opened at 2011-07-19 10:51
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3371641&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: ichier (ichier)
Assigned to: Nobody/Anonymous (nobody)
Summary: vacation.pl patch for postfix helo_check

Initial Comment:
i had the problem, that on my mailsetup, postfix wouldnt let vacation.pl send mails due to helo restrictions. vacation.pl was greeting with localhost.localdomain. so i added the possibility to define the smtp client to something. add that something to your helo-whitelist (you shouldnt whitelist local...) and vacaion magically starts working :)

----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2012-04-19 14:01

Message:
I've merged this into vacation.pl; I'm not currently able to test it
though... 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3371641&group_id=191583

[ postfixadmin-Patches-3181465 ] vacation and autoreply

[SourceForge.net <no...@so...>]

Patches item #3181465, was opened at 2011-02-14 16:07
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3181465&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: Vacation
Group: None
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: vacation and autoreply

Initial Comment:
This patch allow the admin to select three type of vacation message

one reply
reply after delay time 
autoreply


The admin of a domain can give the users of that domain the right to change the setting of the vacation type or not.
If this function is used is set  by $conf [allow_user_reply]


other default setting are put in config.inc.php or config.local.php
 

----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2012-04-19 13:52

Message:
Typo fixes for the below; also suggest the config parameters are all
renamed to start with 'vacation_' (which I haven't done).

I can't merge the patch as edit-domain has now been removed. 

You also have a syntax error in VacationHandler ( 'interval_time' =>
$$interval_time). (double $)

Can you also remove the 'e' off the end of users_domain_controle ?

The vacation.pl part of the patch looks fine to me.

thanks for taking the time to submit the patch; if you could resync it with
trunk and make the few changes I'm asking for, I'll merge it.

David.



//
// 
// Virtual Vacation Stuff
//
// 

// If you want to use virtual vacation for you mailbox users set this to
'YES'.
// NOTE: Make sure that you install the vacation module. (See
VIRTUAL-VACATION/)
$CONF['vacation'] = 'NO';
// This is the autoreply domain that you will need to set in your Postfix
// transport maps to handle virtual vacations. It does not need to be a
// real domain (i.e. you don't need to setup DNS for it).
$CONF['vacation_domain'] = 'autoreply.change-this-to-your.domain.tld';

// Vacation Control
// If you want users to take control of vacation set this to 'YES'.
$CONF['vacation_control'] ='YES';

// Vacation Control for admins
// Set to 'YES' if your domain admins should be able to edit user
vacation.
$CONF['vacation_control_admin'] = 'YES';

// Alllow ReplyType Control
// This varible will be checked in ./templates/vacation.tpl 
// YES means it show the reply option, everything else means it will not
show
$CONF['replytype_control'] = 'YES';

// AllowUser Reply
// You can Allow or Disable User control over Reply Type
// This variable will be checked in ./templates/vacation.tpl 
// YES means it show the reply option, anything else means it will not
show
$CONF['allow_user_reply'] = 'YES';

// ReplyType options
// If you want to define additional reply options put them in array below.
$CONF['choice_of_reply'] = array (
    'One Reply', // Sends only Once the message during Out of Office
    'Auto Reply', // Reply on every email but not within autoreplydelay
    'Interval Reply' // Reply on every email but not within
intervaldelay_default 
);

// ReplyType default
// You should define default replytype. It must be in array above.
$CONF['replytype_default'] = 'One Reply';


// autoreplydelay
// You should define autodefaultdelay is seconds
// if a new message comes in within this delay it most likely that that the
sender is
// autoreplying on our autoreply message.
$CONF['autoreplydelay_default'] = '100';

// Replydelay default
// You should define default replydelay time here time in in seconds.
$CONF['intervaldelay_default'] = '86400'; // is 1 day = 60 sec * 60 min *
24 hours

//
// End Vacation Stuff.
//


----------------------------------------------------------------------

Comment By: J.Kruis (jan-kruis)
Date: 2011-02-14 16:11

Message:
// Vacation Control
// If you want users to take control of vacation set this to 'YES'.
$CONF['vacation_control'] ='YES';

// Vacation Control for admins
// Set to 'YES' if your domain admins should be able to edit user
vacation.
$CONF['vacation_control_admin'] = 'YES';

// Alllow ReplyType Control
// This varible will be check in ./templates/vacation.tpl if it should
enable this option
// YES mains it show the reply option everthing els mains it will not show
$CONF['replytype_control'] = 'YES';

// AllowUser Reply
// You can Allow or Disable User to contole over Reply Type
// This varible will be check in ./templates/vacation.tpl if it should
enable this option
// YES mains it show the reply option everthing els mains it will not show
$CONF['allow_user_reply'] = 'YES';

// RepleyType options
// If you want to define additional reply options put them in array below.
$CONF['choice_of_reply']  = array (
    'One Reply',  		// Sends only Once the message during Out of Office
    'Auto Reply',     		// Reply on every email but not within
autoreplydelay
    'Interval Reply'    	// Reply on every email but not within
repldelay_default
);

// ReplyType default
// You should define default replytype. It must be in array above.
$CONF['replytype_default'] = 'One Reply';

// autoreplydelay
// You should define autodefaultdelay is seconds
// if a new message comes in within this delay it most likely that that the
sender is
// autoreplying on our autoreply message.
$CONF['autoreplydelay_default'] = '100';

// Replydelay default
// You should define default replydelay time here time in in seconds.
$CONF['intervaldelay_default'] = '86400'; // is 1 day = 60 sec * 60 min *
24 hours

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3181465&group_id=191583

[ postfixadmin-Patches-3152352 ] sorting capabilities

[SourceForge.net <no...@so...>]

Patches item #3152352, was opened at 2011-01-06 01:59
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3152352&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: Martin Jaros (piszta)
Assigned to: Nobody/Anonymous (nobody)
Summary: sorting capabilities

Initial Comment:
it allows to sort records by any column. it is used in virtual list only just now, but another sections are supported too.

changes:
 - functions.inc.php: added function get_sort()
 - list-virtual.php: it uses session for limit (paging) and calls get_sort()
 - templates/list-virtual_mailbox.tpl, templates/list-virtual_alias.tpl: table headers became links


----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2012-04-19 13:34

Message:
Summary:

 * patch needs work;
 * I don't think it can/will merge with the current trunk easily.
 * security problems exist within it.

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2012-04-19 13:33

Message:
Hi - 

Thanks for taking the time to submit this patch.

Some feedback.

1. It's vulnerable to SQL Injection - although you call safeget &
escape_string on the data from $_GET, what you're embedding within the SQL
query is not enclosed within quote marks (i.e. you're doing the equivalent
of " ...... FROM foo ORDER BY {$_GET['key']} ASC"

I think the best way to solve this is to change the code so that there is a
known 'good' list of fields which you are allowed to do a sort by on - and
not accept any input from the end user.

2. I'm not overly keen on seeing @ within code; I'd rather it was checked
with isset or something instead.

3. I don't like the way the order will flip on each page load if
$_GET['sort'] is present. This will be painful if you're on e.g. page 5 of
15, and trying to advance through the records.

I've pasted in what seems a better get_sort() function below - no doubt SF
will screw up my indentation ... 

thanks
David.



/**
 * This attempts to persist a sort order on records when viewing in a
list.
 * See
https://sourceforge.net/tracker/?func=detail&aid=3152352&group_id=191583&atid=937966
 *
 * @param string $default_column - the default column if neither
$_GET['sort'] or $_POST['sort'] are set. Column MUST be one of the ones
defined in $allowed_columns
 * @param string $default_dir - ASC or DESC
 * @return string some SQL (e.g. 'foobar ASC')
 */
function get_sort($default_column, $default_dir = 'ASC') {

    $allowed_columns = array('address', 'goto', 'modified', 'active');
    $allowed_dirs = array('ASC', 'DESC');

    if(!in_array($default_dir, $allowed_dirs)) {
        die("Invalid sort direction");
    }

    $fSort = false;
    if (isset ($_GET['sort'])) {
        if(in_array($_GET['sort'], $allowed_columns)) {
            $fSort = safeget('sort');
        }
    }
    if (isset ($_POST['sort'])) {
        if(in_array($_POST['sort'], $allowed_columns)) {
            $fSort = safepost('sort');
        }
    }

    // if nothing in $_GET/$_POST; see if we have anything in $_SESSION.
    if(false == $fSort) {
        if (isset($_SESSION['sort'])) {
            $fSort = $_SESSION['sort'];
            $fSortDir = $_SESSION['sort_dir'];
        } else {
            // No? oh, well, let's default to whatever was passed in
            $fSort = $default_column;
            $fSortDir = 'ASC';
        }
    } else {
        // we had something in $_GET/$_POST; store it in $_SESSION for
later on.
        $_SESSION['sort_dir'] = $fSortdir = 'ASC';
        $_SESSION['sort'] = $fSort;
    }
    return $fSort . ' ' . $fSortDir;
}

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3152352&group_id=191583

[ postfixadmin-Patches-3152352 ] sorting capabilities

[SourceForge.net <no...@so...>]

Patches item #3152352, was opened at 2011-01-06 01:59
Message generated for change (Comment added) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3152352&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Martin Jaros (piszta)
Assigned to: Nobody/Anonymous (nobody)
Summary: sorting capabilities

Initial Comment:
it allows to sort records by any column. it is used in virtual list only just now, but another sections are supported too.

changes:
 - functions.inc.php: added function get_sort()
 - list-virtual.php: it uses session for limit (paging) and calls get_sort()
 - templates/list-virtual_mailbox.tpl, templates/list-virtual_alias.tpl: table headers became links


----------------------------------------------------------------------

>Comment By: GingerDog (gingerdog)
Date: 2012-04-19 13:33

Message:
Hi - 

Thanks for taking the time to submit this patch.

Some feedback.

1. It's vulnerable to SQL Injection - although you call safeget &
escape_string on the data from $_GET, what you're embedding within the SQL
query is not enclosed within quote marks (i.e. you're doing the equivalent
of " ...... FROM foo ORDER BY {$_GET['key']} ASC"

I think the best way to solve this is to change the code so that there is a
known 'good' list of fields which you are allowed to do a sort by on - and
not accept any input from the end user.

2. I'm not overly keen on seeing @ within code; I'd rather it was checked
with isset or something instead.

3. I don't like the way the order will flip on each page load if
$_GET['sort'] is present. This will be painful if you're on e.g. page 5 of
15, and trying to advance through the records.

I've pasted in what seems a better get_sort() function below - no doubt SF
will screw up my indentation ... 

thanks
David.



/**
 * This attempts to persist a sort order on records when viewing in a
list.
 * See
https://sourceforge.net/tracker/?func=detail&aid=3152352&group_id=191583&atid=937966
 *
 * @param string $default_column - the default column if neither
$_GET['sort'] or $_POST['sort'] are set. Column MUST be one of the ones
defined in $allowed_columns
 * @param string $default_dir - ASC or DESC
 * @return string some SQL (e.g. 'foobar ASC')
 */
function get_sort($default_column, $default_dir = 'ASC') {

    $allowed_columns = array('address', 'goto', 'modified', 'active');
    $allowed_dirs = array('ASC', 'DESC');

    if(!in_array($default_dir, $allowed_dirs)) {
        die("Invalid sort direction");
    }

    $fSort = false;
    if (isset ($_GET['sort'])) {
        if(in_array($_GET['sort'], $allowed_columns)) {
            $fSort = safeget('sort');
        }
    }
    if (isset ($_POST['sort'])) {
        if(in_array($_POST['sort'], $allowed_columns)) {
            $fSort = safepost('sort');
        }
    }

    // if nothing in $_GET/$_POST; see if we have anything in $_SESSION.
    if(false == $fSort) {
        if (isset($_SESSION['sort'])) {
            $fSort = $_SESSION['sort'];
            $fSortDir = $_SESSION['sort_dir'];
        } else {
            // No? oh, well, let's default to whatever was passed in
            $fSort = $default_column;
            $fSortDir = 'ASC';
        }
    } else {
        // we had something in $_GET/$_POST; store it in $_SESSION for
later on.
        $_SESSION['sort_dir'] = $fSortdir = 'ASC';
        $_SESSION['sort'] = $fSort;
    }
    return $fSort . ' ' . $fSortDir;
}

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3152352&group_id=191583

[ postfixadmin-Patches-3305187 ] Logging patch

[SourceForge.net <no...@so...>]

Patches item #3305187, was opened at 2011-05-20 08:09
Message generated for change (Settings changed) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3305187&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Dale Blount (lnxus)
Assigned to: Nobody/Anonymous (nobody)
Summary: Logging patch

Initial Comment:
Patch to add ability to only allow super admin to view logs

----------------------------------------------------------------------

Comment By: Dale Blount (lnxus)
Date: 2011-05-23 07:06

Message:
Hi.  Sorry about the old patch, this was before I started using the SVN
version. 

The reason I want to have the option to hide the logs is that it logs IPs
of the superadmins giving possible targets to gain additional privileges.

Yes, I know it's quite a long shot.


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-05-22 15:07

Message:
Your patch hides the link to viewlog.php, but any domain admin can still
type viewlog.php in his browser's address bar and view the log. You should
add a permission check in viewlog.php to fix this.

Additionally, our current development version is much different from 2.3.x
because we switched to smarty templates. This means the template changes in
your patch won't apply to SVN trunk. (Not a real problem, it would be quite
easy for me to convert your patch to the smarty templates.)

That said: is there a special reason why you want to hide the log from your
domain admins? I have to admit that I don't see why this would make sense.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3305187&group_id=191583

[ postfixadmin-Patches-3305187 ] Logging patch

[SourceForge.net <no...@so...>]

Patches item #3305187, was opened at 2011-05-20 08:09
Message generated for change (Settings changed) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3305187&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Dale Blount (lnxus)
Assigned to: Nobody/Anonymous (nobody)
Summary: Logging patch

Initial Comment:
Patch to add ability to only allow super admin to view logs

----------------------------------------------------------------------

Comment By: Dale Blount (lnxus)
Date: 2011-05-23 07:06

Message:
Hi.  Sorry about the old patch, this was before I started using the SVN
version. 

The reason I want to have the option to hide the logs is that it logs IPs
of the superadmins giving possible targets to gain additional privileges.

Yes, I know it's quite a long shot.


----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-05-22 15:07

Message:
Your patch hides the link to viewlog.php, but any domain admin can still
type viewlog.php in his browser's address bar and view the log. You should
add a permission check in viewlog.php to fix this.

Additionally, our current development version is much different from 2.3.x
because we switched to smarty templates. This means the template changes in
your patch won't apply to SVN trunk. (Not a real problem, it would be quite
easy for me to convert your patch to the smarty templates.)

That said: is there a special reason why you want to hide the log from your
domain admins? I have to admit that I don't see why this would make sense.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3305187&group_id=191583

[ postfixadmin-Feature Requests-3488194 ] Official support for MariaDB

[SourceForge.net <no...@so...>]

Feature Requests item #3488194, was opened at 2012-02-16 04:31
Message generated for change (Comment added) made by libertytrek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3488194&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database
Group: None
Status: Closed
Resolution: Works For Me
Priority: 5
Private: No
Submitted By: Charles (libertytrek)
Assigned to: Nobody/Anonymous (nobody)
Summary: Official support for MariaDB

Initial Comment:
Hola,

I've been seriously questioning my continued use of MySQL ever since Oracle bought Sun, and even more so recently. I'd really like to switch to MariaDB (seems to be the best one of the forks, and the closest to a drop-in replacement)... however, since postfixadmin is my main use of mysql, I'd rather not do this unless/until postfixadmin offically adds support for it.

Are there any existing plans/efforts to do this? From what I've read about MariaDB, it is virtually a drop in replacement for MySQL, so I was hoping it wouldn't be too difficult to add official support for it, then maybe after a certain period, just drop official support for MySQL - unless of course the devs are ok with maintaining them both until such time as they diverge to the point that maintaining them both becomes too much work.

Regardless, many thanks to all who make postfixadmin the best way to maintain a mail server!

----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2012-04-10 04:14

Message:
Ok, I'll be rolling out a new server (virtualized) in the next few weeks
(or 2-3 months at the most), and will report back...

I'd still like to see the comments in the config files properly reflect
this all of this though - meaning, the fact that MariaDB should 'just
work', but the DB type still needs to be defined as mysql or mysqli...

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 14:00

Message:
AFAIK MariaDB should just work (even if you will still have to use 'mysql'
or 'mysqli' and not 'mariadb' in $CONF[database_type] ;-)

If something doesn't work with MariaDB, please open a bugreport. If I don't
see any bugreport, then we can consider MariaDB as officially supported
;-))


@alex-j: using $database_abstraction_of_the_day is a topic that comes up
regularly, and I have written several quite long mails to the
postfixadmin-devel mailinglist where I explained why I don't like the idea.
Basically there are two reasons:

a) I don't see a real advantage over the db_* functions we have -
especially with the *Handler classes in SVN trunk, we already have a quite
good abstraction.

b) some special cases most probably won't work with the same queries in
$database_abstraction. For example, take the page browser, which is broken
for postgresql in trunk - and uses a very interesting[tm] query for MySQL.
I doubt any abstraction layer could convert this query to something that
also works with postgresql and is still fast. (The query in 2.3.x works
with all databases, but is damm slow - we received reports that loading
list-virtual can take minutes.)

----------------------------------------------------------------------

Comment By: Alexander (alex-j)
Date: 2012-03-03 21:33

Message:
I don't think that need to be done something with postfixadmin to be able
to work with MariaDB. It's practically drop in replacement. Nothing should
be changed in PHP scripts.
PostfixAdmins table is pretty simple and don't use anything
special(triggers, procedure...) as far as I know.
We already replaced a few DB servers to MariaDB without any issues and get
better performance with it.
Here is an information about compatibility:
http://kb.askmonty.org/en/mariadb-versus-mysql

BTW, It would be good to switch to PDO in PHP instead of direct call of
mysql's functions.
In this case it will be possible to use different Database engines without 
touching actual logic.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3488194&group_id=191583

[ postfixadmin-Feature Requests-2190501 ] Superadmin should not be able to delete or disable himself

[SourceForge.net <no...@so...>]

Feature Requests item #2190501, was opened at 2008-10-23 15:27
Message generated for change (Settings changed) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2190501&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: SVN (please specify revision!)
>Status: Closed
>Resolution: Wont Fix
Priority: 1
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Nobody/Anonymous (nobody)
Summary: Superadmin should not be able to delete or disable himself

Initial Comment:
A superadmin should not be able to shoot himself in the foot^W^W^W^W^Wdelete or disable himself (in the list/edit admin section) because this will lock him out of postfixadmin.

This can be done by
a) not showing the delete link for the currently logged in superadmin
b) like a, but at server side before deleting the admin
c) while editing an admin, unchecking the superadmin checkbox should be impossible for the currently logged in superadmin
d) c) should also be checked server-side

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 14:30

Message:
I don't remember someone asking for help how to re-create an accidently
deleted superadmin account, and with setup.php it is quite easy nowadays.

In other words: no need for additional protection ;-)

(This doesn't mean I'll reject a patch for AdminHandler if someone is bored
enough ;-)

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2010-06-22 14:40

Message:
e) use bullet-proof shoes ;-)

Seriously: setup.php can easily create a new superadmin - therefore the
reason to implement self-protection has gone to nearly zero.

I'm lowering the priority to lowest. I'll accept patches, but I won't
implement it myself.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=2190501&group_id=191583

[ postfixadmin-Feature Requests-3041449 ] Mailbox Quota should be overwritable by Superadmin

[SourceForge.net <no...@so...>]

Feature Requests item #3041449, was opened at 2010-08-08 02:30
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3041449&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interface Improvements (example)
Group: None
>Status: Closed
>Resolution: Wont Fix
Priority: 3
Private: No
Submitted By: Valkum (valkum)
Assigned to: Nobody/Anonymous (nobody)
Summary: Mailbox Quota should be overwritable by Superadmin

Initial Comment:
An Admin should not be bound on the default/max quota.
So SUoeradmin can define that user x had an quota about 2 MBs but default/max conf var is set to 1 MB

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 14:27

Message:
After thinking about this again: wontfix - see previous comment.
We already have enough exceptions and complexity - no need to add more ;-)

Besides that, domain admins would not be able to edit a mailbox (for
example to change the password) without shrinking the quota to the value
they are allowed to use.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-03-09 13:39

Message:
I tend to reject this because it adds complexity without a real need and
advantage IMHO.

Additionally, my usage of PostfixAdmin includes a setup where $other_person
is superadmin and manages the mailboxes for various customer domains. (In
other words: this server sees nearly no "domain admin" logins.) The quota
restriction for superadmins makes much sense there...

BTW: There is a workaround - first edit the domain max quota, then edit the
mailbox and reset the domain settings. This will however break when editing
the mailbox the next time (unless you change the domain settings again).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3041449&group_id=191583

[ postfixadmin-Feature Requests-3488194 ] Official support for MariaDB

[SourceForge.net <no...@so...>]

Feature Requests item #3488194, was opened at 2012-02-16 04:31
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3488194&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database
Group: None
>Status: Closed
>Resolution: Works For Me
Priority: 5
Private: No
Submitted By: Charles (libertytrek)
Assigned to: Nobody/Anonymous (nobody)
Summary: Official support for MariaDB

Initial Comment:
Hola,

I've been seriously questioning my continued use of MySQL ever since Oracle bought Sun, and even more so recently. I'd really like to switch to MariaDB (seems to be the best one of the forks, and the closest to a drop-in replacement)... however, since postfixadmin is my main use of mysql, I'd rather not do this unless/until postfixadmin offically adds support for it.

Are there any existing plans/efforts to do this? From what I've read about MariaDB, it is virtually a drop in replacement for MySQL, so I was hoping it wouldn't be too difficult to add official support for it, then maybe after a certain period, just drop official support for MySQL - unless of course the devs are ok with maintaining them both until such time as they diverge to the point that maintaining them both becomes too much work.

Regardless, many thanks to all who make postfixadmin the best way to maintain a mail server!

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 14:00

Message:
AFAIK MariaDB should just work (even if you will still have to use 'mysql'
or 'mysqli' and not 'mariadb' in $CONF[database_type] ;-)

If something doesn't work with MariaDB, please open a bugreport. If I don't
see any bugreport, then we can consider MariaDB as officially supported
;-))


@alex-j: using $database_abstraction_of_the_day is a topic that comes up
regularly, and I have written several quite long mails to the
postfixadmin-devel mailinglist where I explained why I don't like the idea.
Basically there are two reasons:

a) I don't see a real advantage over the db_* functions we have -
especially with the *Handler classes in SVN trunk, we already have a quite
good abstraction.

b) some special cases most probably won't work with the same queries in
$database_abstraction. For example, take the page browser, which is broken
for postgresql in trunk - and uses a very interesting[tm] query for MySQL.
I doubt any abstraction layer could convert this query to something that
also works with postgresql and is still fast. (The query in 2.3.x works
with all databases, but is damm slow - we received reports that loading
list-virtual can take minutes.)

----------------------------------------------------------------------

Comment By: Alexander (alex-j)
Date: 2012-03-03 21:33

Message:
I don't think that need to be done something with postfixadmin to be able
to work with MariaDB. It's practically drop in replacement. Nothing should
be changed in PHP scripts.
PostfixAdmins table is pretty simple and don't use anything
special(triggers, procedure...) as far as I know.
We already replaced a few DB servers to MariaDB without any issues and get
better performance with it.
Here is an information about compatibility:
http://kb.askmonty.org/en/mariadb-versus-mysql

BTW, It would be good to switch to PDO in PHP instead of direct call of
mysql's functions.
In this case it will be possible to use different Database engines without 
touching actual logic.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3488194&group_id=191583

[ postfixadmin-Bugs-3436282 ] No pagination links for alias list

[SourceForge.net <no...@so...>]

Bugs item #3436282, was opened at 2011-11-10 16:57
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3436282&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interface (example)
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jonathan Dray (spiroid)
Assigned to: Nobody/Anonymous (nobody)
Summary: No pagination links for alias list

Initial Comment:
When more than 10 aliases are stored in the database, only the 10 first are displayed.
There are no links to navigate and to go to the next 10 elements.

Postfixadmin svn installed, rev : r1263

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 13:42

Message:
I can't reproduce that with current SVN r1366 and MySQL as database. OTOH,
the pagebrowser is broken in postgresql (known issue,
https://sourceforge.net/tracker/?func=detail&aid=3292648&group_id=191583&atid=937964
)

Can you still reproduce this bug? If yes, which database are you using?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3436282&group_id=191583

[ postfixadmin-Bugs-3427541 ] Cannot restrict alias creation to managed domains.

[SourceForge.net <no...@so...>]

Bugs item #3427541, was opened at 2011-10-23 06:55
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3427541&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: v2.3.4
Status: Open
>Resolution: None
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Cannot restrict alias creation to managed domains.

Initial Comment:
I cannot find a configuration option which allows me to set a rule which says that you cannot create an alias to domains which your server does not manage. An example of what someone who doesn't understand mail may do is, let's say they own the domain example.com. They use postfix.admin to setup for the domain example.com and then they create a alias for joh...@ex... which redirects to joh...@gm.... 

IMHO postfix.admin is designed for people who don't know how to configure postfix through postfix itself and hence it's also more likely that these same people may also not understand email concepts as well as a seasoned postfix administrator (I had to install it for these types of people). While once upon a time, creating an alias like this would have worked, it has never been condoned and with todays modern mail servers it often causes a lot of mail to be rejected when sent from the server you set the alias up on to the final or intermediate MTA for a server you don't administer. The reason behind this is many domains, and this number is constantly rising, but many domains have an SPF (sender policy framework) . An SPF is a DNS record which typically states who can and cannot send mail on behalf of a domain. 

Most modern mail servers, when they receive mail, they will check the DNS of an envelope senders domain to see if a SPF exists. If they find an SPF then they will parse the SPF and compare it against the server which has sent the mail. Since an alias exists to an outside domain which the server doesn't manage, that means that the mail server you run which postfix.admin manages will receive email from all sorts of outside addresses and re-send them to the aliased email on a third party server. The third party server will look up an SPF for the envelope sender which is the original sending domain and will see which hosts are allowed to send for it. It will see that the mail server you run is not on that list and then depending on the configuration of the original SPF and the configuration of the final MTA, it will either drop or bounce the message and will also count towards email backscatter or possibly consider it a more severe type of spam which can lead to having your mail server listed DNS blacklist sites like spamhaus, etc.

I'm sure there are probably more ways to configure this for most people but there are two types of rules I would like to create. For all users including super admins, I would like to have a restriction which says a alias cannot send to domains we don't manage which I can do through a SQL query. For regular users / non-superusers, I would like to say that they cannot create an alias to any other domain then the domains they manage in the server, for example if normal-user manages example.com then they can only create aliases to example.com and they cannot even create aliases to other domains that we do manage if they have not been selected as a user for that domain though I'm sure many people would probably want the option of only limiting it to domains they manage for normal users too so I think that should be an option for normal users to either limit it them to all domains the server manages or to just domains that they have rights on.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 13:39

Message:
Implementing this as configurable option was a good idea - it gives you
better chances that we will implement it ;-) (I'd call it
$CONF['alias_allow_external_goto'], but that's a technical detail.)

However, your patch misses some details:
- alias domains are not handled
- no permission checks - in other words: the check could be abused to find
out if an address exists on another domain that is managed in postfixadmin,
but the current admin doesn't have access to (even without a log entry if
you make sure to always include an invalid address)

Besides that, I'm currently rewriting the code to use classes (see SVN
trunk). This means checking if an alias exists is quite easy now:

$handler = new AliasHandler(0, $admin_username); # includes permission
check
$address_exists = $handler->init($address);

BTW: no need to check the mailbox table - every mailbox has an alias.

To get a list of alias domains, use AliasdomainHandler->getList (see
list-virtual.php in SVN trunk for a usage example). Then rewrite all
aliases to the target domain and check with AliasHandler if they exist.

If you want to update your patch: the check needs to go into function
_field_goto() in model/AliasHandler.php.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2011-10-23 13:57

Message:
I modified postfix.admin v2.3.4 to now have an option in the config which,
when enabled will error alias creation or editing when a alias is crated or
edited to point a email address that is not defined in mailbox or alias
tables. The patch itself doesn't cause this to happen immediately but it
adds the option $CONF['limit_unknown_domain_alias'] to config.inc.php which
is set to "NO" in the patch. Changing this option to "YES" will cause it to
only allow an alias to point to a already known address. Disclaimer: I
almost never code in PHP and I learned it about a decade ago but the change
is simple and the code looks clean. I'm sure if this option is incorporated
then the maintainers may tidy it a little, rename aspects, etc etc but
everything seems clean and running. Seems safe but use at your own risk.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3427541&group_id=191583

[ postfixadmin-Bugs-1865123 ] unclear that Superadmin is the admin of all existing domains

[SourceForge.net <no...@so...>]

Bugs item #1865123, was opened at 2008-01-06 07:21
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=1865123&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database
Group: SVN (please specify revision!)
>Status: Closed
>Resolution: Fixed
Priority: 4
Private: No
Submitted By: Raphael Schmid (sixtyfive)
Assigned to: Nobody/Anonymous (nobody)
Summary: unclear that Superadmin is the admin of all existing domains

Initial Comment:
Right now, you have to manually add any new domain to the superadmin. This should be done automatically. (Rev. 286)

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 13:18

Message:
Finally fixed in SVN trunk r1366 :-)

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-01-10 11:05

Message:
Logged In: NO 

Hi Christian,

what about a simplified version of your idea #2:

Idea 2.1:
Show "All domains" as the first item of the list box when logged in as
superadmin.

Cheers,
Raphael

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2008-01-06 13:10

Message:
Logged In: YES 
user_id=593261
Originator: NO

Idea 1:
Simply add a note "Super admins have access to all domains, can manage
domains and admin accounts."

Idea 2, more work: radio buttons

Domains:
( ) all domains (super admin)  *)
( ) the following domains
    [listbox]

*) not really a good text, because superadmins have more permissions
(add/delete domains, edit domain settings, manage admins, ...)

----------------------------------------------------------------------

Comment By: Raphael Schmid (sixtyfive)
Date: 2008-01-06 12:50

Message:
Logged In: YES 
user_id=658318
Originator: YES

Probably yeah... sorry, I might not have looked too closely. This _is_ a UI
design problem however...

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2008-01-06 09:10

Message:
Logged In: YES 
user_id=1761957
Originator: NO

Errm.. a superadmin can edit any domain; note the checkbox _overrides_ any
domains selected through the edit-admin page.

(Perhaps the UI needs modifying to make this obvious however)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=1865123&group_id=191583

[ postfixadmin-Bugs-2021826 ] edit-alias allows empty alias when vacation is on

[SourceForge.net <no...@so...>]

Bugs item #2021826, was opened at 2008-07-18 13:39
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2021826&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 4
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Nobody/Anonymous (nobody)
Summary: edit-alias allows empty alias when vacation is on

Initial Comment:
It's possible to set an empty alias goto, see https://sourceforge.net/forum/message.php?msg_id=5104264 for details. Most important is the reproducer:

Usually edit-mailbox errors out if you clear all target addresses. But I found a way to work around this safety net :-(

Reproducer:
- enable vacation
- edit the alias for the mailbox, remove us...@ex... (so that only the vacation address remains)
- disable vacation -> the alias now has an empty target


Possible solutions:
- the vacation alias should be ignored when testing if the alias target is empty
- the vacation alias should not even be listed in the target list (print a "vacation is on" note instead)

Needs to be tested with users/edit-alias also.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 13:08

Message:
Fixed in SVN trunk (tested with r1364 which uses AliasHandler for admins
and users, so it should be fixed everywhere)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2021826&group_id=191583

[ postfixadmin-Bugs-3232719 ] postfixadmin-cli error by adding alias

[SourceForge.net <no...@so...>]

Bugs item #3232719, was opened at 2011-03-21 11:18
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3232719&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: SVN (please specify revision!)
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: john doe (johndoe64)
Assigned to: Nobody/Anonymous (nobody)
Summary: postfixadmin-cli error by adding alias

Initial Comment:
If I use

postfixadmin-cli alias add us...@ex... us...@li...

I get an PHP error:

PHP Fatal error:  Call to undefined method AliasHandler::add() in /usr/share/postfixadmin/scripts/shells/alias.php on line 107

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-04-09 13:03

Message:
When you reported the bug, this was not implemented yet.

I worked on  the *Handler classes in the last days, which means this is
fixed in SVN trunk r1364 :-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3232719&group_id=191583

[ postfixadmin-Patches-3508083 ] vacation with choose of reply

[SourceForge.net <no...@so...>]

Patches item #3508083, was opened at 2012-03-18 14:16
Message generated for change (Tracker Item Submitted) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3508083&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: vacation with choose of reply

Initial Comment:
This patch provides users and administrators the ability to choose between three types of reply.

one reply
autoreply
reply with delay

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3508083&group_id=191583

[ postfixadmin-Patches-3507673 ] check_4_vacation

[SourceForge.net <no...@so...>]

Patches item #3507673, was opened at 2012-03-18 02:32
Message generated for change (Tracker Item Submitted) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3507673&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_4_vacation

Initial Comment:
change the three sql query for vacation into a function


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3507673&group_id=191583

[ postfixadmin-Patches-3507319 ] check_4_vacation

[SourceForge.net <no...@so...>]

Patches item #3507319, was opened at 2012-03-17 16:52
Message generated for change (Tracker Item Submitted) made by jan-kruis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3507319&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_4_vacation

Initial Comment:
change the three sql query for vacation into a function


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3507319&group_id=191583

[ postfixadmin-Feature Requests-3496325 ] Drop support of Vacation in favor of SIEVE

[SourceForge.net <no...@so...>]

Feature Requests item #3496325, was opened at 2012-03-02 08:42
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3496325&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Alexander (alex-j)
Assigned to: Nobody/Anonymous (nobody)
Summary: Drop support of Vacation in favor of SIEVE 

Initial Comment:
I propose to drop support of "Vacation" in favor of standardized SIEVE (RFC 3028, RFC 5230, RFC 5804, RFC 5435) that support vacations auto-responder in addition to very powerful filtering mechanism.

SIEVE already supported in major email's clients (Thunderbird, RoundCube, Horde and etc) and allow much more flexibility to assign Vacation response(it could be special rules to avoid respond to robots, or other auto-responders/notificators)
SIEVE supported very well by well known Dovecot, Courier for a long time and actually it will be better to leave actual mail delivery to primary servers instead of custom, non standard Perl's spike.

So, IMHO it would be a good step forward in 3.x development to drop custom, non standard Vacation support in favor of supporting SIEVE language.

Since postfixadmin allows regular users to manage own settings, it will be good to implement in a future web based SIEVE's rules management via postfixadmin in manner as it done in INGO application from Horde framework for example that bring a lot of power to users and administrators to manage Vacation, Spam filtering, forwarding, black/white listing  and much more without actual need to learn SIEVE language...


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-03-12 17:55

Message:
I'm not familiar with SIEVE, so my question might be silly - or not ;-)

Currently an admin can manage the vacation settings for an user and the
user can manage the same vacation settings. Will this be possible with
SIEVE, too?

I assume your answer is "you have to login as this user with SIEVE" - so
the interesting part of my question is: What if an admin wants to change an
user's vacatio settings and the mailbox password is encrypted in the
database? How will he be able to change the user's vacation settings?

----------------------------------------------------------------------

Comment By: Alexander (alex-j)
Date: 2012-03-04 15:52

Message:
>How would this work with both a Global
>script and is the User has created their own?

It is pretty simple, first will be executed global and after that - user's
script exactly on delivery. So it is up to you, as admin you can discard
mail, redirect, or reject and then issue "stop" command on the end, which
is mean - no further processing or in other words - do not run users script
after some action.

>Would the Domain Admin be able to enforce
>a Global Sieve script,
Yes, if you place your global script to "sieve_before" option then global
script will be executed first, before users.

> and users could add their own, but it would be called from the Global,
No. There no such things as "calling" in Sieve.
First, will be executed global and after that user's script if no "stop"
command issued in a global script.

>and the user would not be allowed to 
>override anything in the Global script?
Sure. If you already discard mail for example in global script and issue
"stop" command then user's script will not be executed and user will not
receive any mail for processing.

Users can't see source of global script and don't have any legal access to
global script to be able to control mail delivery handled by global script.

In dovecot for example there is parameters "sieve_before" that point to
directory with global scripts that will be executed before calling user's
scripts. If you need to do something after users scripts there is parameter
"sieve_after".

As for global scripts - there is two options that behave completely
different. For example "sieve_global_path" will be executed only in case if
there no users scripts, so it act as your recommended, non enforced action,
but global scripts from  "sieve_before" will be executed always before
users and users has no choice to control mail delivery before that global
script is finished.

> As for where the sieve scripts are stored, 
> dovecot currently has excellent
> sieve support when using its LDA, and it 
> prefers that the users sieve scripts live 
> in ~ (user home dir)...

It just safety default settings and nothing else.
We use for example: sieve = /usr/local/virtual/%Ld/%Ln/dovecot.sieve
where "dovecot.sieve" is simlink to /usr/local/virtual/%Ld/%Ln/sieve
directory.
Since dovecot show to users only that directories where first character is
"." then "sieve" directory is invisible for users and accessible only
through network protocol.


----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2012-03-04 08:05

Message:
A few questions...

How would this work with both a Global script and is the User has created
their own? Would the Domain Admin be able to enforce a Global Sieve script,
and users could add their own, but it would be called from the Global, and
the user would not be allowed to override anything in the Global script?

As for where the sieve scripts are stored, dovecot currently has excellent
sieve support when using its LDA, and it prefers that the users sieve
scripts live in ~ (user home dir), *outside* the user mail dir (usually
~/mail)...

http://wiki2.dovecot.org/Pigeonhole/Sieve/Configuration

----------------------------------------------------------------------

Comment By: Alexander (alex-j)
Date: 2012-03-03 16:46

Message:
@libertytrek
You're absolutely right. I just wanted to say that "sieve" is much much
better.

@gingerdog
I prepared a few screen shots taken from Horde that is self explanatory.

http://www.mejuba.com/albums/Alexander_J/90865

>"Does the sieve file need writing out to disk somewhere?"
No. It is the network protocol. All sieve scripts kept on server side.
Global sieve script available only for server's administrators, but users
scripts are located in there mailboxes as hidden directory and allowed to
edit it over SIEVE protocol.

I think it would be possible to fork Horde's or RoundCube's scripts that
communicate over SIEVE to embeds it to postfixadmin in a future .

Horde's SIEVE scripts are here: (horde//ingo/lib/Script)
https://github.com/horde/horde/tree/e261dbd1eaacee9243d5230d04b9da19547dfec1/ingo/lib/Script



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2012-03-02 09:03

Message:
Not to belabor the obvious, but I'm assuming this would be done by first
*adding* support for sieve, then, once it is working well, provide dual
support for a time, warning everyone well in advance before vacation
support was removed...

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2012-03-02 09:00

Message:
If this is possible, it'd obviously be a good move.

I'm not sure how feasible it is to write a rool which is a wizard for a
sieve file though - perhaps there could just be a number of pre-generated
ones - where the user fills in some blanks or something?

Does the sieve file need writing out to disk somewhere?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3496325&group_id=191583

[ postfixadmin-Feature Requests-3499573 ] Vacation alias optional

[SourceForge.net <no...@so...>]

Feature Requests item #3499573, was opened at 2012-03-08 05:54
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3499573&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Vacation alias optional

Initial Comment:
I use postfixadmin together with Exim (hope this is not a heresy :)) and i really really really don't need all those vacation aliases. Is it possible to add a config option to switch em off so it wont be needed to edit code every time postfixadmin updates? Tyvm.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-03-12 17:46

Message:
No, Exim is not heresy ;-) and I'm happy to hear that PostfixAdmin works
with it. (I'd even welcome a howto for our wiki - if you want to write one
;-)  I can also give you write permissions in the wiki if you want.)

About your request: Do I understand you correctly that with Exim vacation
works without having the alias user#exa...@au... in
the alias table? So you just need the entry in the vacation table?

Adding a config option to not include the vacation alias shouldn't be too
hard, but I'm afraid the devil is in the details. Currently VacationHandler
and AliasHandler detect the vacation status based on the alias - yes,
technically it's a bug, but it works and nobody changed it until now ;-)
(On the positive side, list-virtual checks the 'active' field in the
vacation table.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3499573&group_id=191583

[ postfixadmin-Bugs-3502195 ] UTF-8 string display problem

[SourceForge.net <no...@so...>]

Bugs item #3502195, was opened at 2012-03-11 16:24
Message generated for change (Settings changed) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3502195&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interface (example)
Group: v2.3.5
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Laddobar (laddobar)
Assigned to: Nobody/Anonymous (nobody)
Summary: UTF-8 string display problem

Initial Comment:
In two places (as I discovered so far) PA has trouble displaying UTF-8 characters - in both cases these are "description" fields. From the superadmin point of view:
- description of the domain when listing all the domains in /postfixadmin/list-domain.php
- name of the mailbox owner when listing aliases and mailboxes of a domain in /postfixadmin/list-virtual.php?domain=example.com

I found the problem in the usage of HTMLEntities function, which is missing the encoding parameter.
Change in templates admin_list-domain.php and list_virtual.php seems sufficient:
original: print "<td>" . htmlentities($domain_properties[$i]['description']) . "</td>";
resolved:  print "<td>" . htmlentities($domain_properties[$i]['description'],ENT_QUOTES,'UTF-8') . "</td>";

Thanks for your good work!
Laddobar

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-03-12 17:26

Message:
That's a known regression in 2.3.5 :-( - but it's still better than the XSS
issues those files had before.

I already fixed it in SVN, but just that fix isn't worth a new release
IMHO. If you need the fixed files, you can download them directly from SVN
at
http://postfixadmin.svn.sourceforge.net/viewvc/postfixadmin/branches/postfixadmin-2.3/templates/
or apply the patch that I'll attach to this bugreport.

And BTW, you found both places that are affected by this bug ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3502195&group_id=191583

[ postfixadmin-Bugs-3502195 ] UTF-8 string display problem

[SourceForge.net <no...@so...>]

Bugs item #3502195, was opened at 2012-03-11 16:24
Message generated for change (Tracker Item Submitted) made by laddobar
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3502195&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interface (example)
Group: v2.3.5
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Laddobar (laddobar)
Assigned to: Nobody/Anonymous (nobody)
Summary: UTF-8 string display problem

Initial Comment:
In two places (as I discovered so far) PA has trouble displaying UTF-8 characters - in both cases these are "description" fields. From the superadmin point of view:
- description of the domain when listing all the domains in /postfixadmin/list-domain.php
- name of the mailbox owner when listing aliases and mailboxes of a domain in /postfixadmin/list-virtual.php?domain=example.com

I found the problem in the usage of HTMLEntities function, which is missing the encoding parameter.
Change in templates admin_list-domain.php and list_virtual.php seems sufficient:
original: print "<td>" . htmlentities($domain_properties[$i]['description']) . "</td>";
resolved:  print "<td>" . htmlentities($domain_properties[$i]['description'],ENT_QUOTES,'UTF-8') . "</td>";

Thanks for your good work!
Laddobar

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3502195&group_id=191583

[ postfixadmin-Feature Requests-3499573 ] Vacation alias optional

[SourceForge.net <no...@so...>]

Feature Requests item #3499573, was opened at 2012-03-08 05:54
Message generated for change (Tracker Item Submitted) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3499573&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Vacation alias optional

Initial Comment:
I use postfixadmin together with Exim (hope this is not a heresy :)) and i really really really don't need all those vacation aliases. Is it possible to add a config option to switch em off so it wont be needed to edit code every time postfixadmin updates? Tyvm.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3499573&group_id=191583

[ postfixadmin-Feature Requests-3496325 ] Drop support of Vacation in favor of SIEVE

[SourceForge.net <no...@so...>]

Feature Requests item #3496325, was opened at 2012-03-02 08:42
Message generated for change (Comment added) made by alex-j
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3496325&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: None
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Alexander (alex-j)
Assigned to: Nobody/Anonymous (nobody)
Summary: Drop support of Vacation in favor of SIEVE 

Initial Comment:
I propose to drop support of "Vacation" in favor of standardized SIEVE (RFC 3028, RFC 5230, RFC 5804, RFC 5435) that support vacations auto-responder in addition to very powerful filtering mechanism.

SIEVE already supported in major email's clients (Thunderbird, RoundCube, Horde and etc) and allow much more flexibility to assign Vacation response(it could be special rules to avoid respond to robots, or other auto-responders/notificators)
SIEVE supported very well by well known Dovecot, Courier for a long time and actually it will be better to leave actual mail delivery to primary servers instead of custom, non standard Perl's spike.

So, IMHO it would be a good step forward in 3.x development to drop custom, non standard Vacation support in favor of supporting SIEVE language.

Since postfixadmin allows regular users to manage own settings, it will be good to implement in a future web based SIEVE's rules management via postfixadmin in manner as it done in INGO application from Horde framework for example that bring a lot of power to users and administrators to manage Vacation, Spam filtering, forwarding, black/white listing  and much more without actual need to learn SIEVE language...


----------------------------------------------------------------------

Comment By: Alexander (alex-j)
Date: 2012-03-04 15:52

Message:
>How would this work with both a Global
>script and is the User has created their own?

It is pretty simple, first will be executed global and after that - user's
script exactly on delivery. So it is up to you, as admin you can discard
mail, redirect, or reject and then issue "stop" command on the end, which
is mean - no further processing or in other words - do not run users script
after some action.

>Would the Domain Admin be able to enforce
>a Global Sieve script,
Yes, if you place your global script to "sieve_before" option then global
script will be executed first, before users.

> and users could add their own, but it would be called from the Global,
No. There no such things as "calling" in Sieve.
First, will be executed global and after that user's script if no "stop"
command issued in a global script.

>and the user would not be allowed to 
>override anything in the Global script?
Sure. If you already discard mail for example in global script and issue
"stop" command then user's script will not be executed and user will not
receive any mail for processing.

Users can't see source of global script and don't have any legal access to
global script to be able to control mail delivery handled by global script.

In dovecot for example there is parameters "sieve_before" that point to
directory with global scripts that will be executed before calling user's
scripts. If you need to do something after users scripts there is parameter
"sieve_after".

As for global scripts - there is two options that behave completely
different. For example "sieve_global_path" will be executed only in case if
there no users scripts, so it act as your recommended, non enforced action,
but global scripts from  "sieve_before" will be executed always before
users and users has no choice to control mail delivery before that global
script is finished.

> As for where the sieve scripts are stored, 
> dovecot currently has excellent
> sieve support when using its LDA, and it 
> prefers that the users sieve scripts live 
> in ~ (user home dir)...

It just safety default settings and nothing else.
We use for example: sieve = /usr/local/virtual/%Ld/%Ln/dovecot.sieve
where "dovecot.sieve" is simlink to /usr/local/virtual/%Ld/%Ln/sieve
directory.
Since dovecot show to users only that directories where first character is
"." then "sieve" directory is invisible for users and accessible only
through network protocol.


----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2012-03-04 08:05

Message:
A few questions...

How would this work with both a Global script and is the User has created
their own? Would the Domain Admin be able to enforce a Global Sieve script,
and users could add their own, but it would be called from the Global, and
the user would not be allowed to override anything in the Global script?

As for where the sieve scripts are stored, dovecot currently has excellent
sieve support when using its LDA, and it prefers that the users sieve
scripts live in ~ (user home dir), *outside* the user mail dir (usually
~/mail)...

http://wiki2.dovecot.org/Pigeonhole/Sieve/Configuration

----------------------------------------------------------------------

Comment By: Alexander (alex-j)
Date: 2012-03-03 16:46

Message:
@libertytrek
You're absolutely right. I just wanted to say that "sieve" is much much
better.

@gingerdog
I prepared a few screen shots taken from Horde that is self explanatory.

http://www.mejuba.com/albums/Alexander_J/90865

>"Does the sieve file need writing out to disk somewhere?"
No. It is the network protocol. All sieve scripts kept on server side.
Global sieve script available only for server's administrators, but users
scripts are located in there mailboxes as hidden directory and allowed to
edit it over SIEVE protocol.

I think it would be possible to fork Horde's or RoundCube's scripts that
communicate over SIEVE to embeds it to postfixadmin in a future .

Horde's SIEVE scripts are here: (horde//ingo/lib/Script)
https://github.com/horde/horde/tree/e261dbd1eaacee9243d5230d04b9da19547dfec1/ingo/lib/Script



----------------------------------------------------------------------

Comment By: Charles (libertytrek)
Date: 2012-03-02 09:03

Message:
Not to belabor the obvious, but I'm assuming this would be done by first
*adding* support for sieve, then, once it is working well, provide dual
support for a time, warning everyone well in advance before vacation
support was removed...

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2012-03-02 09:00

Message:
If this is possible, it'd obviously be a good move.

I'm not sure how feasible it is to write a rool which is a wizard for a
sieve file though - perhaps there could just be a number of pre-generated
ones - where the user fills in some blanks or something?

Does the sieve file need writing out to disk somewhere?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937967&aid=3496325&group_id=191583