[Podofo-users] building shared library and cmake arguments

[Jaseem A. K T <jas...@hc...>]

Hi

This is small question I had when I started working with PoDoFo.
Is it deliberate that you have to set PODOFO_BUILD_SHARED=false to build shared dll in windows?

The cmake command in the section "CMake builds on Windows with Visual Studio"  has the argument -DPODOFO_BUILD_SHARED:BOOL=FALSE. The build will generate shared dlls.

I haven't written any cmake file so far. The lines 53 to 54of CMakeLists in the root directory is as follows

IF(DEFINED PODOFO_BUILD_SHARED AND NOT DEFINED PODOFO_BUILD_STATIC)
    SET(PODOFO_BUILD_SHARED NOT ${PODOFO_BUILD_SHARED})
ENDIF(DEFINED PODOFO_BUILD_SHARED AND NOT DEFINED PODOFO_BUILD_STATIC)

I believe this should be
IF(DEFINED PODOFO_BUILD_SHARED AND NOT DEFINED PODOFO_BUILD_STATIC)
    SET(PODOFO_BUILD_STATIC NOT ${PODOFO_BUILD_SHARED})
ENDIF(DEFINED PODOFO_BUILD_SHARED AND NOT DEFINED PODOFO_BUILD_STATIC)


Also as per readme file, on windows <<By default only the shared library will be built. If you want a static library, just disable generation of the shared library with the extra argument to cmake:>>

But this is not the case, by default it is static library. I think windows users will prefer shared dll. The lines starting  240 in CMakeLists set the build to static library if both variables are set.

Regards
Ali



::DISCLAIMER::
----------------------------------------------------------------------------------------------------------------------------------------------------

The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only.
E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted,
lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents
(with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates.
Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the
views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification,
distribution and / or publication of this message without the prior written consent of authorized representative of
HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately.
Before opening any email and/or attachments, please check them for viruses and other defects.

----------------------------------------------------------------------------------------------------------------------------------------------------