[pmd-devel] [ pmd-Bugs-3481636 ] Class java.beans.Statement triggered in CloseResource rule
A source code analyzer
Brought to you by:
adangel,
juansotuyo
From: SourceForge.net <no...@so...> - 2012-02-02 13:51:03
|
Bugs item #3481636, was opened at 2012-01-30 05:44 Message generated for change (Comment added) made by cayel You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=479921&aid=3481636&group_id=56262 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pmd Group: None >Status: Open Resolution: None Priority: 5 Private: No Submitted By: Kenneth Ljunggren (cayel) Assigned to: Tom Copeland (tomcopeland) Summary: Class java.beans.Statement triggered in CloseResource rule Initial Comment: Using PMD 4.2.5 Having the following code below and including the ruleset/design.xml The CloseResource rule incorrectly reports the Statement variable as a resource that should be closed. import java.beans.Statement; ... Statement stmt = new Statement(vo, "set" + prop, new Object[] { vector }); try { stmt.execute(); } catch (Exception e) { throw new RuntimeException("Could not set property prop: " + prop + "of type:" + pd.getPropertyType(), e); } ---------------------------------------------------------------------- >Comment By: Kenneth Ljunggren (cayel) Date: 2012-02-02 05:51 Message: Same result using PMD 4.3. <pmd version="4.3" timestamp="2012-02-02T14:43:55.013"> ... <violation beginline="66" endline="66" begincolumn="27" endcolumn="30" rule="CloseResource" ruleset="Design Rules" package="common.utils" class="TestUtil" method="setBoolean" variable="stmt" externalInfoUrl="http://pmd.sourceforge.net/rules/design.html#CloseResource" priority="3">Ensure that resources like this Statement object are closed after use</violation> .. ---------------------------------------------------------------------- Comment By: Romain PELISSE (rpelisse) Date: 2012-01-30 06:05 Message: Hi, Thanks for the report. Would you mind checking if this is still happening with PMD 4.3 ? I think some tweaking on CloseResource was done. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=479921&aid=3481636&group_id=56262 |