#1436 [java] UnnecessaryFullyQualifiedName: false positive on clashing static imports with enums

[Thrawn]

The UnnecessaryFullyQualifiedName rule fires on a class that performs static imports from several enums (so that it can use the enum constants directly), and then references the values() method of each enum using its qualified name.

It is not possible to use the unqualified values() method, since the different enums all provide it.

[Andreas Dangel]

I've fixed it to ignore the enum case. However, this only works, if PMD can detect the actual type of the statically imported class. This means, typeresolution/auxclasspath needs to be enabled and the compiled classes need to be on the classpath during PMD execution.

The fix will be included in PMD 5.3.6 and later.

Commit: https://github.com/pmd/pmd/commit/b4c2a517811f12528fb1cd81a45c465aef81fd27

[Juan Sotuyo]

This issue is actually much broader than enums. Any static import can cause collisions that require an explicit access, for instance:

import static org.mockito.Mockito;
import static org.mockito.Mockito.*;
import static org.powermock.api.mockito.PowerMockito.*;

public class Foo {
  private Bar bar = Mockito.mock(Bar.class); // doing simply mock(Bar.class) is ambiguous (compile error)

Also could happen if PowerMockito was not a star import:

import static org.mockito.Mockito;
import static org.mockito.Mockito.*;
import static org.powermock.api.mockito.PowerMockito.mock;

public class Foo {
  private Bar bar = Mockito.mock(Bar.class); // doing simply mock(Bar.class) would use a differen method than intended

I'm opening a new issue to track this, and reworking this rule.