PMD / Issues / #1380 InsufficientStringBufferDeclaration false positive when literal string passed to a lookup service

#1380 InsufficientStringBufferDeclaration false positive when literal string passed to a lookup service

Milestone: PMD-5.3.4

Status: closed

Owner: Andreas Dangel

Labels: false positive (4)

Module: PMD

Priority: 4-Minor

Type: Bug

Affects version: 5.3.2

Ruleset / Rule: String and StringBuffer /InsufficientStringBufferDeclaration

Updated: 2015-09-13

Created: 2015-07-14

Creator: Thrawn

Private: No

InsufficientStringBufferDeclaration triggers a false positive when a literal String of sufficient length is passed to a lookup service, eg a Spring MessageSource, and then the result is appended to a StringBuilder. See attached sample class.

It's possible to work around this by extracting the literal string to a constant.

1 Attachments

StringBuilderWithMessageRetrieval.java

Discussion

Andreas Dangel - 2015-09-13

status: open --> closed

assigned_to: Andreas Dangel

Milestone: New Tickets --> PMD-5.3.4
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2015-09-13

This will be fixed with PMD 5.3.4.

Commit: https://github.com/pmd/pmd/commit/9f6190f3b6ad26d6f2f1d9437a9d739a69056703

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

InsufficientStringBufferDeclaration false positive when literal string...

A source code analyzer

Milestone

Searches

Help

#1380 InsufficientStringBufferDeclaration false positive when literal string passed to a lookup service

Discussion