Re: [Plplot-devel] [Post-release] Memory management issues with -dev tk

[Alan W. I. <ir...@be...>]

On 2013-12-18 23:45-0000 Andrew Ross wrote:

> On Wed, Dec 18, 2013 at 03:27:28PM -0800, Alan Irwin wrote:
>> On 2013-12-18 22:01-0000 Andrew Ross wrote:
>>> One other issue I encountered was that detecting of the various tcl
>>> components is not entirely robust. I had tcl8.5 and tcl8.6 installed.
>>> On Ubuntu the default is tcl8.5 so tclsh points to tclsh8.5. This
>>> means that most of the tcl-related variables were set to point to 8.5,
>>> however the code setting TCL_INCLUDE_PATH ended up pointing to tcl8.6.
>>> This is probably a cmake issue rather than a plplot issue, but I
>>> thought I'd flag it up.
>>
>> Did our build system warn about those version inconsistencies?  And if
>> so, could you straighten out CMake finding Tcl/Tk library versions
>> that were inconsistent with tclsh by using CMAKE_INCLUDE_PATH and
>> CMAKE_LIBRARY_PATH?
>
> No - the build system didn't warn of the inconsistencies. Well at least
> cmake didn't. I spotted it by eye and to fix it I actually used
> update-alternatives to make tclsh point to tclsh8.6 since that seemed
> easiest.

OK.  To deal with this issue post release, I will implement a check
for tclsh consistency with the libtcl and libtk versions that the
CMake find module finds. I plan to use the same tclsh "package
require" methods I currently use to determine Itcl/Itk/Iwidgets
consistency.  And probably the best thing to do if tclsh is
not consistent with the tcl/tk library versions is to error out
with an explanatory message to choose a tclsh version that
is consistent with the Tcl/Tk library versions or else
set -DENABLE_tcl=OFF to disable all Tcl-related aspects
of the PLplot build.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________