Re: [Plplot-devel] Custom axis labeling is now in PLplot trunk

[Alan W. I. <ir...@be...>]

On 2009-08-05 11:25-0400 Hezekiah M. Carty wrote:

> Commit 10215 fixes the problem [segfault for example 19] on my system, with a slight change to
> the custom label callback signature.  It now takes a string length
> argument, and the callback is expected to set the label text directly.
> Example 19 has been updated to reflect this change.
>
> Please let me know if this fixes the issue.  Example 19 is now
> valgrind-clean on my system (64bit Ubuntu 9.04).

Hi Hez:

Yep, all is well now on my platform; example 19 no longer has a segfault and
it is valgrind clean as well.  Thanks for your quick response to the
problem I found.

Once you have some more time for PLplot would you be willing to add some
additional documentation of plslabelfunc? At minimum, the meaning of the
callback function label_func arguments should be documented.  You already
document the char* argument, but what about the PLINT, PLFLT arguments
before it, and the PLINT, void * arguments after it? Probably, the best way
to do such callback documentation is to move your documentation of the char*
argument to some full documentation of at least one particular example of
the label_func callback similar to how the plshades documentation refers to
the full pltr0, pltr1, and pltr2 documentation for details about its pltr
callback function, see
http://plplot.sourceforge.net/docbook-manual/plplot-html-5.9.4/plshades.html.

plshades documentation also refers to a chapter of general documentation
concerning use of plshade(s), but it is up to you whether such a chapter
would be useful in the plslabelfunc case or not.  If you decide to go ahead
with such a chapter (which could be as small as a few paragraphs) but cannot
figure out how to stick it into the right place in the overall
documentation, let me have the xml for the chapter, and I can do the rest of
it.

>
> My wife defended her PhD dissertation yesterday and we are moving in
> the next few days.  I apologize for my relatively slow responses
> recently.  Once we are moved and somewhat settled in (~1 week from
> now, hopefully) I should be able to keep up with PLplot more
> effectively!

No problem.  PLplot developers are volunteers who often drop out for periods
of time as other things take higher priority. You cannot go wrong if you do
as much as you can with PLplot in your spare time (when that is available)
on PLplot projects which are fun for you or which satisfy some basic
plotting need that you feel is important.  Of course, when you do make a
change it is good to have a little spare time in hand for quick response
(like you did above) in case there turns out to be some problem with your
change.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of
Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__________________________

Linux-powered Science
__________________________