#180 cmake 3.7 can't build PLplot

[LI Chang-Sheng]

I use PLplot-5.11.0. When I build Plplot using MSYS2/MinGW 64-bit, Cmake3.7 can't find pango. I find in PLplot-5.11.0/cmake/modeulespkg-config.cmake:

if(CMAKE_VERSION VERSION_LESS "3.1")
    _pkg_check_modules_internal(0 0 ${_prefix} "${_package}")
  else(CMAKE_VERSION VERSION_LESS "3.1")
    _pkg_check_modules_internal(0 0  0 0 ${_prefix} "${_package}")
  endif(CMAKE_VERSION VERSION_LESS "3.1")

I used cmak-3.7, so the parameters of _pkg_check_modules_internal is (0 0 0 0 ${_prefix} "${_package}")

For cmake-3.7 modules, /msys64/ming64/share/cmake-3.7/Modules/FindConfig.cmake

macro(_pkg_check_modules_internal _is_required _is_silent _no_cmake_path _no_cmake_environment_path _imp_target _prefix)

As we can see, the parameter postion of _prefix is six (_pkg_check_modules_internal 1_is_required 2_is_silent 3_no_cmake_path 4_no_cmake_environment_path 5_imp_target 6_prefix). However, in PLplot , postion of _prefix is five. So, I add a zero to PLplot-5.11.0/cmake/modeulespkg-config.cmake:

    _pkg_check_modules_internal(0 0 0 0 0 ${_prefix} "${_package}")

Then, PLplot can build correctly.

I'm not too will use cmake. Is it a bug in PLplot ?

[Alan W. Irwin]

This should be fixed in the git master branch version. Please try that and report back.

[Alan W. Irwin]

I am virtually positive our git branch has long since fixed this, and since there was no response to the contrary from this user I am closing this as fixed.

[LI Chang-Sheng]

It(plplot-plplot-af417651da9a130c050392a1cbdb362a4a609f82) works well.Thanks