plib-devel Mailing List for PLIB (Page 4)
Brought to you by:
sjbaker
Menu
▾
▴
plib-devel
You can subscribe to this list here.
| 2000 |
Jan
|
Feb
(80) |
Mar
(128) |
Apr
(111) |
May
(157) |
Jun
(70) |
Jul
(116) |
Aug
(465) |
Sep
(574) |
Oct
(325) |
Nov
(163) |
Dec
(182) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2001 |
Jan
(167) |
Feb
(191) |
Mar
(319) |
Apr
(118) |
May
(252) |
Jun
(427) |
Jul
(187) |
Aug
(96) |
Sep
(219) |
Oct
(161) |
Nov
(109) |
Dec
(210) |
| 2002 |
Jan
(97) |
Feb
(80) |
Mar
(143) |
Apr
(234) |
May
(72) |
Jun
(246) |
Jul
(155) |
Aug
(280) |
Sep
(418) |
Oct
(81) |
Nov
(72) |
Dec
(88) |
| 2003 |
Jan
(59) |
Feb
(63) |
Mar
(33) |
Apr
(27) |
May
(87) |
Jun
(50) |
Jul
(97) |
Aug
(45) |
Sep
(35) |
Oct
(67) |
Nov
(78) |
Dec
(13) |
| 2004 |
Jan
(167) |
Feb
(144) |
Mar
(172) |
Apr
(93) |
May
(43) |
Jun
(7) |
Jul
(27) |
Aug
(36) |
Sep
(48) |
Oct
(54) |
Nov
(5) |
Dec
(44) |
| 2005 |
Jan
(53) |
Feb
(36) |
Mar
(13) |
Apr
(3) |
May
(19) |
Jun
|
Jul
(49) |
Aug
(39) |
Sep
(8) |
Oct
(8) |
Nov
(51) |
Dec
(23) |
| 2006 |
Jan
(26) |
Feb
(5) |
Mar
(26) |
Apr
(26) |
May
(52) |
Jun
(36) |
Jul
(8) |
Aug
(12) |
Sep
(6) |
Oct
(75) |
Nov
(34) |
Dec
(25) |
| 2007 |
Jan
(46) |
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
(7) |
Jul
(2) |
Aug
|
Sep
(40) |
Oct
(9) |
Nov
(3) |
Dec
|
| 2008 |
Jan
|
Feb
|
Mar
(26) |
Apr
|
May
|
Jun
(2) |
Jul
(4) |
Aug
(6) |
Sep
|
Oct
|
Nov
(5) |
Dec
(2) |
| 2009 |
Jan
(63) |
Feb
(4) |
Mar
(12) |
Apr
|
May
(5) |
Jun
(1) |
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
| 2010 |
Jan
|
Feb
(14) |
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2011 |
Jan
(2) |
Feb
(1) |
Mar
(2) |
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(5) |
| 2012 |
Jan
|
Feb
(1) |
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
(3) |
Sep
|
Oct
|
Nov
(2) |
Dec
|
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: John F. F. <joh...@cy...> - 2009-01-23 00:47:36
|
I'm missing something here; my copy of "pu.h" doesn't have that on line 30. -----Original Message----- From: Melchior FRANZ Sent: Wednesday, January 21, 2009 5:39 PM To: pli...@li... Subject: Re: [Plib-devel] [RFC] changing slider behavior Sigh ... and please remove this from pu.h (line 30): #include <iostream> using std::cerr; using std::endl; I should put that somewhere where I won't submit it accidentally. :-) m. ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel |
|
From: Melchior F. <mf...@us...> - 2009-01-21 23:39:34
|
Sigh ... and please remove this from pu.h (line 30): #include <iostream> using std::cerr; using std::endl; I should put that somewhere where I won't submit it accidentally. :-) m. |
|
From: Melchior F. <mf...@us...> - 2009-01-21 23:25:15
|
OK, so I've implemented both old and new ("modern") behavior.
Actually, the former can be useful in some cases, where quick
selection of an estimated value is desirable without having
to grab a small slider handle. The old behavior is even default
now.
As the new behavior makes the slider position jump in fixed
intervals, for which a new parameter was required, this parameter
also decides whether old or new behavior should be used. In
the Qt-Toolkit these big steps are called PageStep (while the
small steps are called LineStep). I've used the same name:
setPageStepSize(0); ... no step chosen -> use default
(this is consistent with the already
existing puRange::setStepSize(),
where 0 also means to use a default)
setPageStepSize(4); ... increase/decrease value by 4 if one
clicks on the slider background rather
than the slider handle
setPageStepSize(-1); ... page steps disabled -> old behavior
(this is default)
The patch also fixes arrow highlighting in puaScrollBar. Somebody
had started to implement that, but stopped half-way. This wasn't
functional. Additionally, it reduced the slider minimum-width
from 10px to 8px. (I had introduced the 10px a few years ago,
but a bit smaller can't hurt.)
Files on my homepage. I hope this helps to apply the changes,
saving you from applying diffs manually. :-)
./src/pui/
http://members.aon.at/mfranz/plib/pu.h [45.2 kB]
http://members.aon.at/mfranz/plib/puSlider.cxx [6.1 kB]
./src/puAux/
http://members.aon.at/mfranz/plib/puAuxScrollBar.cxx [9.3 kB]
I'll submit the necessary changes do the HTML documentation in
another patch.
m.
|
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-21 18:13:36
|
OK, this one is in SVN. John F. Fay Technical Fellow Jacobs Technology TEAS Group 850-883-1294 -----Original Message----- From: Melchior FRANZ [mailto:mf...@us...] Sent: Wednesday, January 21, 2009 11:51 AM To: pli...@li... Subject: [Plib-devel] [PATCH] demos/build_all_demos: add autogen.sh calls diff --git a/demos/build_all_demos b/demos/build_all_demos index 2b42052..eef78b9 100755 --- a/demos/build_all_demos +++ b/demos/build_all_demos @@ -1,18 +1,21 @@ echo "Building ExPoser..." cd exposer +./autogen.sh ./configure make cd .. echo "Building P-Guide..." cd p-guide +./autogen.sh ./configure make cd .. echo "Building 3D TicTacToe..." cd ttt3d +./autogen.sh ./configure make cd .. ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel |
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-21 18:03:06
|
Done ...
John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294
-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...]
Sent: Wednesday, January 21, 2009 11:56 AM
To: pli...@li...
Subject: [Plib-devel] [PATCH] demos/p-guide/src: fix Makefile.am
- drop CreateWidget.cxx (which doesn't exist since a few years :-)
- add plibpuaux, which is needed for several widgets
diff --git a/demos/p-guide/src/Makefile.am
b/demos/p-guide/src/Makefile.am
index 81cb634..ecc73d2 100644
--- a/demos/p-guide/src/Makefile.am
+++ b/demos/p-guide/src/Makefile.am
@@ -1,7 +1,9 @@
bin_PROGRAMS = pguide
-pguide_SOURCES = CreateWidget.cxx pGuide.cxx StatusWindow.cxx
WidgetList.h \
+pguide_SOURCES = pGuide.cxx StatusWindow.cxx WidgetList.h \
WidgetWindow.cxx WriteCode.cxx LoadSave.cxx PropertiesWindow.cxx
+pguide_LDADD = -lplibpuaux
+
EXTRA_DIST = pGuide.dsp
------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel
|
|
From: Melchior F. <mf...@us...> - 2009-01-21 18:00:00
|
* Fay, John F Dr CTR USAF AFMC 46 SK -- Wednesday 21 January 2009: > Is "autogen.sh" supposed to be necessary for a release version? I'm no > Linux guru so I have no idea. It needs to be run to generate "configure". Otherwise the next step will fail. Of course, it's easy to run manually, but then the whole "build_all_demos" wouldn't make much sense. > +./autogen.sh > ./configure > make m. |
|
From: Melchior F. <mf...@us...> - 2009-01-21 17:55:57
|
- drop CreateWidget.cxx (which doesn't exist since a few years :-)
- add plibpuaux, which is needed for several widgets
diff --git a/demos/p-guide/src/Makefile.am b/demos/p-guide/src/Makefile.am
index 81cb634..ecc73d2 100644
--- a/demos/p-guide/src/Makefile.am
+++ b/demos/p-guide/src/Makefile.am
@@ -1,7 +1,9 @@
bin_PROGRAMS = pguide
-pguide_SOURCES = CreateWidget.cxx pGuide.cxx StatusWindow.cxx WidgetList.h \
+pguide_SOURCES = pGuide.cxx StatusWindow.cxx WidgetList.h \
WidgetWindow.cxx WriteCode.cxx LoadSave.cxx PropertiesWindow.cxx
+pguide_LDADD = -lplibpuaux
+
EXTRA_DIST = pGuide.dsp
|
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-21 17:53:48
|
Is "autogen.sh" supposed to be necessary for a release version? I'm no Linux guru so I have no idea. John F. Fay Technical Fellow Jacobs Technology TEAS Group 850-883-1294 -----Original Message----- From: Melchior FRANZ [mailto:mf...@us...] Sent: Wednesday, January 21, 2009 11:51 AM To: pli...@li... Subject: [Plib-devel] [PATCH] demos/build_all_demos: add autogen.sh calls diff --git a/demos/build_all_demos b/demos/build_all_demos index 2b42052..eef78b9 100755 --- a/demos/build_all_demos +++ b/demos/build_all_demos @@ -1,18 +1,21 @@ echo "Building ExPoser..." cd exposer +./autogen.sh ./configure make cd .. echo "Building P-Guide..." cd p-guide +./autogen.sh ./configure make cd .. echo "Building 3D TicTacToe..." cd ttt3d +./autogen.sh ./configure make cd .. ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel |
|
From: Melchior F. <mf...@us...> - 2009-01-21 17:51:31
|
diff --git a/demos/build_all_demos b/demos/build_all_demos index 2b42052..eef78b9 100755 --- a/demos/build_all_demos +++ b/demos/build_all_demos @@ -1,18 +1,21 @@ echo "Building ExPoser..." cd exposer +./autogen.sh ./configure make cd .. echo "Building P-Guide..." cd p-guide +./autogen.sh ./configure make cd .. echo "Building 3D TicTacToe..." cd ttt3d +./autogen.sh ./configure make cd .. |
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-21 17:19:28
|
And this one's into SVN as well. John F. Fay Technical Fellow Jacobs Technology TEAS Group 850-883-1294 -----Original Message----- From: Melchior FRANZ [mailto:mf...@us...] Sent: Tuesday, January 20, 2009 4:46 PM To: pli...@li... Subject: [Plib-devel] [PATCH] examples: replace deprecated (and removed)methods |
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-21 17:14:51
|
OK, this one's into SVN. John F. Fay Technical Fellow Jacobs Technology TEAS Group 850-883-1294 -----Original Message----- From: Melchior FRANZ [mailto:mf...@us...] Sent: Tuesday, January 20, 2009 4:45 PM To: pli...@li... Subject: [Plib-devel] [PATCH] puaLargeInput: make sure top_line_in_windowisn't negative The diff was made with git, and you'll have to apply it with $ patch -p1 <puaLargeInput.diff from the base dir. m. |
|
From: Melchior F. <mf...@us...> - 2009-01-21 15:13:15
|
* Norman Vine -- Wednesday 21 January 2009: > Melchior FRANZ writes: > > There *is* a patch utility for MS Windows, > Supplying full files rather then 'diffs' might help also Sure. If that's what John prefers then I will send those. I don't like it much when projects require full files. This pretty much kills any peer review. Only the committer is going to have a look at the code, then. But in cases like plib that might be exactly as many reviewers than would look at the diff. ;-) m. |
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-21 15:07:03
|
Sorry, but compressed files won't make it past the Air Force e-mail filters. Other attachments are touch-and-go that way, too. Patches are good, even if they are difficult; this is why I need somebody to make sure I haven't put something in wrong. Think of it more as Purgatory than Hell. John F. Fay Technical Fellow Jacobs Technology TEAS Group 850-883-1294 -----Original Message----- From: Norman Vine [mailto:nh...@ca...] Sent: Wednesday, January 21, 2009 9:03 AM To: 'PLIB Developers' Subject: Re: [Plib-devel] [PATCH] puaLargeInput: makesuretop_line_in_window isn't negative Melchior FRANZ writes: > > * John F. Fay -- Wednesday 21 January 2009: > * * Melchior FRANZ: > > > $ patch -p1 <puaLargeInput.diff > > > This "patch" utility looks really nice. Unfortunately I > work in Windows > > and have been putting in all the changes by hand. > > Argh ... seriously? :-) That sounds like hell! > > There *is* a patch utility for MS Windows, and you should get one > of those. One source is MSYS: http://www.mingw.org/wiki/msys > I guess you'd need the base system and the diff-utils. You don't > need the whole MinGW installation. I've once tried it under > Windows and it worked very well (that was msysgit back then, > that is: msys + git and related tools). Supplying full files rather then 'diffs' might help also < compressed of course > Norman ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel |
|
From: Norman V. <nh...@ca...> - 2009-01-21 15:03:12
|
Melchior FRANZ writes: > > * John F. Fay -- Wednesday 21 January 2009: > * * Melchior FRANZ: > > > $ patch -p1 <puaLargeInput.diff > > > This "patch" utility looks really nice. Unfortunately I > work in Windows > > and have been putting in all the changes by hand. > > Argh ... seriously? :-) That sounds like hell! > > There *is* a patch utility for MS Windows, and you should get one > of those. One source is MSYS: http://www.mingw.org/wiki/msys > I guess you'd need the base system and the diff-utils. You don't > need the whole MinGW installation. I've once tried it under > Windows and it worked very well (that was msysgit back then, > that is: msys + git and related tools). Supplying full files rather then 'diffs' might help also < compressed of course > Norman |
|
From: Melchior F. <mf...@us...> - 2009-01-21 14:54:59
|
* John F. Fay -- Wednesday 21 January 2009: * * Melchior FRANZ: > > $ patch -p1 <puaLargeInput.diff > This "patch" utility looks really nice. Unfortunately I work in Windows > and have been putting in all the changes by hand. Argh ... seriously? :-) That sounds like hell! There *is* a patch utility for MS Windows, and you should get one of those. One source is MSYS: http://www.mingw.org/wiki/msys I guess you'd need the base system and the diff-utils. You don't need the whole MinGW installation. I've once tried it under Windows and it worked very well (that was msysgit back then, that is: msys + git and related tools). m. |
|
From: John F. F. <joh...@cy...> - 2009-01-21 13:20:13
|
Not sure if this went out last night. -----Original Message----- From: John F. Fay Sent: Tuesday, January 20, 2009 11:48 PM To: 'PLIB Developers' Subject: RE: [Plib-devel] [PATCH] puaLargeInput: make sure top_line_in_window isn't negative Melchior, This "patch" utility looks really nice. Unfortunately I work in Windows and have been putting in all the changes by hand. (This is why it took me five days to get to the first one.) I'll put in this second patch tomorrow. - John -----Original Message----- From: Melchior FRANZ Sent: Tuesday, January 20, 2009 4:45 PM To: pli...@li... Subject: [Plib-devel] [PATCH] puaLargeInput: make sure top_line_in_window isn't negative The diff was made with git, and you'll have to apply it with $ patch -p1 <puaLargeInput.diff from the base dir. m. << File: puaLargeInput.diff; charset = iso 8859-15 >> << File: ATT00012.txt >> << File: ATT00013.txt >> |
|
From: Melchior F. <mf...@us...> - 2009-01-20 22:51:14
|
* Fay, John F Dr CTR USAF AFMC 46 SK -- Tuesday 20 January 2009: > OK, I just put the fixes into SVN. Thanks. > What's an RFC? Oh, sorry. That's "Request For Comments". One of the subject tags that's standard on some developer lists, together with [PATCH] and [BUG], e.g. on the Linux kernel mailing list, or FlightGear lists. :-) m. |
|
From: Melchior F. <mf...@us...> - 2009-01-20 22:45:33
|
|
From: Melchior F. <mf...@us...> - 2009-01-20 22:44:53
|
The diff was made with git, and you'll have to apply it with $ patch -p1 <puaLargeInput.diff from the base dir. m. |
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-20 22:41:59
|
Quite frankly, I always hated the old style (sorry, Steve) but never had
the time to do anything about it.
John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294
-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...]
Sent: Tuesday, January 20, 2009 2:04 PM
To: pli...@li...
Subject: [Plib-devel] [RFC] changing slider behavior
Sliders (puSlider, puaScrollbox) work in a very unconventional
way now. The reference point for moving the slider handle is
always in the middle of the handle (A)...
+---+------------+=============+--------------+---+
| < | | B A | | > |
+---+------------+=============+--------------+---+
bgnd handle bgnd
If you click anywhere on the slider, the handle jumps there,
in a way that the handle is centered under the mouse. If you
grab the handle at 'B', then the slider will first jump to
the left, and can only then get adjusted. That's weird and
unlike any slider behavior in one of today's GUIs (that I
know). If the handle was at one end, then you have to move
the mouse first until you reach the center point, before the
slider even starts moving! Weird and unexpected!
In any other GUI it's like this (as you probably know):
You can grab the slider at any point and start moving. No
jumps at all. If you click on the background left and
right of the slider, then it makes a big jump ("page_step"),
and on the arrow buttons (if available) it makes a small
step ("line_step"). I'd like to change puSlider/puaScrollbar
to this behavior (and puaList, puaLargeInput etc. would
inherit it). Actually, the patch for that is already finished
and waits for submission.
Does anyone have an objection to this change? If not, should
the old style be available as an alternative? As default?
m.
------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel
|
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-20 22:41:58
|
OK, I just put the fixes into SVN. What's an RFC? John F. Fay Technical Fellow Jacobs Technology TEAS Group 850-883-1294 -----Original Message----- From: Melchior FRANZ [mailto:mf...@us...] Sent: Tuesday, January 20, 2009 3:21 PM To: pli...@li... Subject: Re: [Plib-devel] [PATCH] puAuxLargeInput: fix selection bug,make not needed sliders disappear * Fay, John F Dr CTR USAF AFMC 46 SK -- Tuesday 20 January 2009: > On building it I get two compiler warnings in puAuxLargeInput.c, one on > line 1262 and the other on line 1299. [...] > I tried fixing them by changing "float maxw" to "int maxw" on line 1241. > Is this appropriate? Yes, sorry about that. I missed that and my compiler didn't complain. "int maxw" is correct. BTW: There is one minor bug left in that version for which I'll submit a fix as soon as you've committed. And I plan some more changes to puaLargeInput, but these will be handy patches. One optimization, and maybe slider changes, but that depends on the RFC outcome. :-) m. ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel |
|
From: Melchior F. <mf...@us...> - 2009-01-20 21:21:01
|
* Fay, John F Dr CTR USAF AFMC 46 SK -- Tuesday 20 January 2009: > On building it I get two compiler warnings in puAuxLargeInput.c, one on > line 1262 and the other on line 1299. [...] > I tried fixing them by changing "float maxw" to "int maxw" on line 1241. > Is this appropriate? Yes, sorry about that. I missed that and my compiler didn't complain. "int maxw" is correct. BTW: There is one minor bug left in that version for which I'll submit a fix as soon as you've committed. And I plan some more changes to puaLargeInput, but these will be handy patches. One optimization, and maybe slider changes, but that depends on the RFC outcome. :-) m. |
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-20 21:05:46
|
Very good.
On building it I get two compiler warnings in puAuxLargeInput.c, one on
line 1262 and the other on line 1299. They flag a conversion from "int"
to "float" and vice versa. Have I missed something?
I tried fixing them by changing "float maxw" to "int maxw" on line 1241.
Is this appropriate?
John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294
-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...]
Sent: Tuesday, January 20, 2009 2:19 PM
To: pli...@li...
Subject: Re: [Plib-devel] [PATCH] puAuxLargeInput: fix selection
bug,make not needed sliders disappear
* Fay, John F Dr CTR USAF AFMC 46 SK -- Tuesday 20 January 2009:
> As I am making the changes, I find that the default value of the
> puAuxLargeInput text is being changed from a "\n" to an empty string.
setValue() does this:
void puaLargeInput::setValue ( const char *s )
{
if (!s || !*s) {
puValue::setValue ( "\n" ) ;
cursor_position = select_start_position = select_end_position = 0 ;
} else {
int len = strlen(s);
if (s[len - 1] == '\n') {
puValue::setValue ( s ) ;
} else {
char *buf = new char [ len + 2 ] ;
strcpy ( buf, s ) ;
strcat ( buf, "\n" ) ;
puValue::setValue ( buf ) ;
delete [] buf ;
}
}
... so for an empty string, "\n" is set automatically. But this branch
also sets the selection variables, which I kept from the old code, and
it's a tad faster. So, yes. It's intentional.
m.
------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel
|
|
From: Melchior F. <mf...@us...> - 2009-01-20 20:18:45
|
* Fay, John F Dr CTR USAF AFMC 46 SK -- Tuesday 20 January 2009:
> As I am making the changes, I find that the default value of the
> puAuxLargeInput text is being changed from a "\n" to an empty string.
setValue() does this:
void puaLargeInput::setValue ( const char *s )
{
if (!s || !*s) {
puValue::setValue ( "\n" ) ;
cursor_position = select_start_position = select_end_position = 0 ;
} else {
int len = strlen(s);
if (s[len - 1] == '\n') {
puValue::setValue ( s ) ;
} else {
char *buf = new char [ len + 2 ] ;
strcpy ( buf, s ) ;
strcat ( buf, "\n" ) ;
puValue::setValue ( buf ) ;
delete [] buf ;
}
}
... so for an empty string, "\n" is set automatically. But this branch
also sets the selection variables, which I kept from the old code, and
it's a tad faster. So, yes. It's intentional.
m.
|
|
From: Fay, J. F Dr C. U. A. 46 S. <joh...@eg...> - 2009-01-20 20:10:44
|
Melchior,
As I am making the changes, I find that the default value of the
puAuxLargeInput text is being changed from a "\n" to an empty string.
In the original large input, I required all lines to end with a carriage
return and in some cases the application program depended on it being
there. Is this a deliberate change?
John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294
-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...]
Sent: Tuesday, January 20, 2009 1:31 PM
To: pli...@li...
Subject: Re: [Plib-devel] [PATCH] puAuxLargeInput: fix selection
bug,make not needed sliders disappear
* Fay, John F Dr CTR USAF AFMC 46 SK -- Tuesday 20 January 2009:
> Is it all one change or can it be broken up into pieces?
It's two things: a minor fix (which is only two lines, so factoring
it out doesn't make a lot of sense), and the rest is one feature
(with a bit of cleanup and abstraction).
The feature is "autohiding sliders". They are hiding, if they aren't
necessary, because the lines are short enough for the width, and
few enough for the box height. This doesn't only look nicer, it also
frees precious space and is kind of a standard in modern GUIs.
With shorter response times I could make smaller patches, but if
getting one patch in takes five days, then this is impractical.
I can do a lot in five days, and there is too much overlapping
to write subsequent patches. What if you make changes to the first?
Then all others are likely no longer applicable. I know, of course,
that you are the only left-over committer (just as I'm the only
left-over pui/puAux developer :-), and I'm happy to get something
reviewed and committed at all.
m.
PS: Here's my testing setup in FlightGear:
http://members.aon.at/mfranz/fgfs-plib.jpg [98.3 kB]
The "windows" are all resizable, so autohiding and line
wrapping are easy to observe.
------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel
|
34 messages has been excluded from this view by a project administrator.
