plib-devel

[Plib-devel] load DDS

[Xavier B. <ber...@ya...>]

Hi All,

is it possible to load the DDS textures in PLIB library ?

Best Regards,
Xavier

[Plib-devel] [patch] Improved joystick support for MacOSX

[Jari H. <ja...@fl...>]

Hi,

To get my joystick (Saitek Cyborg Evo Force) to work with flightgear on
my mac I made the plib changes outlined in the attached diff file.

The issue resolved is that my joystick/mac mixes usage pages
kHIDPage_GenericDesktop	and kHIDPage_Simulation for axises. The
suggested code change treats the two usage pages similarly. In the
original code the Simulation usage page is treated as "weird" according
to the error output.

Can someone with subversion write credentials please review my additions
and apply the patch into the subversion repository if you the suggested
improvements useful.


Thank you,

Jari

[Plib-devel] CMake build files for plib 1.8.5

[Hugh F. <hug...@an...>]

I'm rewriting an old SGI Performer program to use PLIB and
using CMake for cross-platform builds. If anyone else is
interested, here's a set of CMakeLists.txt files for 1.8.5:
<http://cs.anu.edu.au/~hugh.fisher/3dstuff/plib-cmake.tar>

If you haven't looked at CMake (www.cmake.org) before, I
can recommend it. It's a two step process: first you use
CMake to generate Makefiles, Visual Studio projects, or
Mac Xcode projects depending on the platform and config
you select; then use the native platform tools to compile
and link.

-- 
	Hugh Fisher
	CECS, ANU

Re: [Plib-devel] [PATCH] puInput: don't segfault if one pastes an empty(NULL) paste buffer

[Fay, J. F Dr C. U. A. 46 S. <joh...@eg...>]

And that's taken care of as well.

John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294 

-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...] 
Sent: Monday, February 09, 2009 7:42 AM
To: pli...@li...
Subject: [Plib-devel] [PATCH] puInput: don't segfault if one pastes an
empty(NULL) paste buffer

diff --git a/src/pui/puInput.cxx b/src/pui/puInput.cxx
index 006ad18..bca61e9 100644
--- a/src/pui/puInput.cxx
+++ b/src/pui/puInput.cxx
@@ -369,6 +369,9 @@ int puInput::checkKey ( int key, int updown )

       case 0x16 /* ^V */ : /* Paste buffer into text */
         {
+          if ( ! puGetPasteBuffer () )
+            break ;
+
           if ( select_start_position != select_end_position )
             removeSelectRegion () ;


------------------------------------------------------------------------
------
Create and Deploy Rich Internet Apps outside the browser with
Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and
code to
build responsive, highly engaging applications that combine the power of
local
resources and data with the reach of the web. Download the Adobe AIR SDK
and
Ajax docs to start building applications
today-http://p.sf.net/sfu/adobe-com
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

Re: [Plib-devel] [PATCH] puaLargeInput: don't move text to the rightwhen increasing width

[Fay, J. F Dr C. U. A. 46 S. <joh...@eg...>]

OK, that's into SVN

John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294 

-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...] 
Sent: Monday, February 09, 2009 6:54 AM
To: pli...@li...
Subject: [Plib-devel] [PATCH] puaLargeInput: don't move text to the
rightwhen increasing width

Hi,

here's a fix for a bug that slipped through: if one increased the
widget width beyond the width of the longest line, then the slider
did (correctly) disappear, but from then on the text moved to the
left. We have to reset the slider to the leftmost position then.

m.


diff --git a/src/puAux/puAuxLargeInput.cxx
b/src/puAux/puAuxLargeInput.cxx
index 34fef07..c39a6b9 100644
--- a/src/puAux/puAuxLargeInput.cxx
+++ b/src/puAux/puAuxLargeInput.cxx
@@ -170,11 +170,14 @@ void puaLargeInput::updateGeometry ( void )
   // horizontal slider
   if ( bottom_slider ) {
     bottom_slider->setSize ( w - ( slider & VERTICAL ? slider_width : 0
), slider_width ) ;
-    bottom_slider->setSliderFraction ( float(input_width) / max_width )
;
     float page_step = 1.0f, line_step = 1.0f ;
     if ( max_width > input_width ) {
       page_step = float(input_width) / ( max_width - input_width ) ;
       line_step = legendFont.getFloatStringWidth( "M" ) / ( max_width -
input_width ) ;
+      bottom_slider->setSliderFraction ( float(input_width) / max_width
) ;
+    } else {
+      bottom_slider->setSliderFraction ( 1.0f ) ;
+      bottom_slider->setValue ( 0.0f );
     }

     bottom_slider->setPageStepSize ( page_step ) ;

------------------------------------------------------------------------
------
Create and Deploy Rich Internet Apps outside the browser with
Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and
code to
build responsive, highly engaging applications that combine the power of
local
resources and data with the reach of the web. Download the Adobe AIR SDK
and
Ajax docs to start building applications
today-http://p.sf.net/sfu/adobe-com
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

[Plib-devel] [PATCH] puInput: don't segfault if one pastes an empty (NULL) paste buffer

[Melchior F. <mf...@us...>]

diff --git a/src/pui/puInput.cxx b/src/pui/puInput.cxx
index 006ad18..bca61e9 100644
--- a/src/pui/puInput.cxx
+++ b/src/pui/puInput.cxx
@@ -369,6 +369,9 @@ int puInput::checkKey ( int key, int updown )

       case 0x16 /* ^V */ : /* Paste buffer into text */
         {
+          if ( ! puGetPasteBuffer () )
+            break ;
+
           if ( select_start_position != select_end_position )
             removeSelectRegion () ;

[Plib-devel] [PATCH] puaLargeInput: don't move text to the right when increasing width

[Melchior F. <mf...@us...>]

Hi,

here's a fix for a bug that slipped through: if one increased the
widget width beyond the width of the longest line, then the slider
did (correctly) disappear, but from then on the text moved to the
left. We have to reset the slider to the leftmost position then.

m.


diff --git a/src/puAux/puAuxLargeInput.cxx b/src/puAux/puAuxLargeInput.cxx
index 34fef07..c39a6b9 100644
--- a/src/puAux/puAuxLargeInput.cxx
+++ b/src/puAux/puAuxLargeInput.cxx
@@ -170,11 +170,14 @@ void puaLargeInput::updateGeometry ( void )
   // horizontal slider
   if ( bottom_slider ) {
     bottom_slider->setSize ( w - ( slider & VERTICAL ? slider_width : 0 ), slider_width ) ;
-    bottom_slider->setSliderFraction ( float(input_width) / max_width ) ;
     float page_step = 1.0f, line_step = 1.0f ;
     if ( max_width > input_width ) {
       page_step = float(input_width) / ( max_width - input_width ) ;
       line_step = legendFont.getFloatStringWidth( "M" ) / ( max_width - input_width ) ;
+      bottom_slider->setSliderFraction ( float(input_width) / max_width ) ;
+    } else {
+      bottom_slider->setSliderFraction ( 1.0f ) ;
+      bottom_slider->setValue ( 0.0f );
     }

     bottom_slider->setPageStepSize ( page_step ) ;

Re: [Plib-devel] [PATCH] examples/src/pui/{combobox.cxx=>widget_test.cxx}

[Fay, J. F Dr C. U. A. 46 S. <joh...@eg...>]

Good.

<heaves giant sigh of relief>

John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294 

-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...] 
Sent: Saturday, January 31, 2009 5:20 AM
To: pli...@li...
Subject: Re: [Plib-devel] [PATCH]
examples/src/pui/{combobox.cxx=>widget_test.cxx}

* Fay, John F Dr CTR USAF AFMC 46 SK -- Friday 30 January 2009:
> As usual, please make sure it works and (specifically) that I haven't
> put DOS line endings into a *nix file. 

Everything perfect, thanks. No DOS endings either.

m.

------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

Re: [Plib-devel] [PATCH] examples/src/pui/{combobox.cxx =>widget_test.cxx}

[Melchior F. <mf...@us...>]

* Fay, John F Dr CTR USAF AFMC 46 SK -- Friday 30 January 2009:
> As usual, please make sure it works and (specifically) that I haven't
> put DOS line endings into a *nix file. 

Everything perfect, thanks. No DOS endings either.

m.

Re: [Plib-devel] [PATCH] examples/src/pui/{combobox.cxx =>widget_test.cxx}

[Fay, J. F Dr C. U. A. 46 S. <joh...@eg...>]

Done.  I also added the ".dsp" file to the list of files to ignore.

As usual, please make sure it works and (specifically) that I haven't
put DOS line endings into a *nix file.  I edited the file in Notepad and
it's a text file (downloaded and uploaded with Windows' TortoiseSVN) so
it should be okay, but it bears looking into.

John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294 

-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...] 
Sent: Thursday, January 29, 2009 4:36 PM
To: pli...@li...
Subject: Re: [Plib-devel] [PATCH] examples/src/pui/{combobox.cxx
=>widget_test.cxx}

* Melchior FRANZ -- Thursday 29 January 2009:
> Could you replace combobox.cxx by the attached file and rename
> it to widget_test.cxx (or something else appropriate)? Of course,
> you'd also have to change all occurrences in the build files
> (Makefile.am etc.) as well.
   ^^^^^^^^^^^

Thanks for renaming/committing. Can you please adapt the Unix part
of the build system, too?  :-)

m.


diff --git a/examples/src/pui/Makefile.am b/examples/src/pui/Makefile.am
index e8a5721..8044be0 100644
--- a/examples/src/pui/Makefile.am
+++ b/examples/src/pui/Makefile.am
@@ -2,3 +2,3 @@ if BUILD_PUI

-noinst_PROGRAMS = simple complex widget_list PointPicker combobox
+noinst_PROGRAMS = simple complex widget_list PointPicker widget_test

@@ -8,3 +8,3 @@ complex_SOURCES = complex.cxx

-combobox_SOURCES = combobox.cxx
+widget_test_SOURCES = widget_test.cxx

@@ -18,3 +18,3 @@ complex_LDADD = -lplibpuaux -lplibpu -lplibfnt
-lplibsg -lplibul $(GLUT_LIBS) $(

-combobox_LDADD = -lplibpuaux -lplibpu -lplibfnt -lplibsg -lplibul
$(GLUT_LIBS) $(OGL_LIBS)
+widget_test_LDADD = -lplibpuaux -lplibpu -lplibfnt -lplibsg -lplibul
$(GLUT_LIBS) $(OGL_LIBS)


------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

Re: [Plib-devel] [PATCH] examples/src/pui/{combobox.cxx => widget_test.cxx}

[Melchior F. <mf...@us...>]

* Melchior FRANZ -- Thursday 29 January 2009:
> Could you replace combobox.cxx by the attached file and rename
> it to widget_test.cxx (or something else appropriate)? Of course,
> you'd also have to change all occurrences in the build files
> (Makefile.am etc.) as well.
   ^^^^^^^^^^^

Thanks for renaming/committing. Can you please adapt the Unix part
of the build system, too?  :-)

m.


diff --git a/examples/src/pui/Makefile.am b/examples/src/pui/Makefile.am
index e8a5721..8044be0 100644
--- a/examples/src/pui/Makefile.am
+++ b/examples/src/pui/Makefile.am
@@ -2,3 +2,3 @@ if BUILD_PUI

-noinst_PROGRAMS = simple complex widget_list PointPicker combobox
+noinst_PROGRAMS = simple complex widget_list PointPicker widget_test

@@ -8,3 +8,3 @@ complex_SOURCES = complex.cxx

-combobox_SOURCES = combobox.cxx
+widget_test_SOURCES = widget_test.cxx

@@ -18,3 +18,3 @@ complex_LDADD = -lplibpuaux -lplibpu -lplibfnt -lplibsg -lplibul $(GLUT_LIBS) $(

-combobox_LDADD = -lplibpuaux -lplibpu -lplibfnt -lplibsg -lplibul $(GLUT_LIBS) $(OGL_LIBS)
+widget_test_LDADD = -lplibpuaux -lplibpu -lplibfnt -lplibsg -lplibul $(GLUT_LIBS) $(OGL_LIBS)

Re: [Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

[Fay, J. F Dr C. U. A. 46 S. <joh...@eg...>]

OK, I have put this one in as well.

John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294 

-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...] 
Sent: Thursday, January 29, 2009 8:30 AM
To: pli...@li...
Subject: [Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

Hi,

I just noticed that I didn't free the buffer in
puaLargeInput::getTextProperties(). Please apply
this patch. Sorry.

m.


diff --git a/src/puAux/puAuxLargeInput.cxx
b/src/puAux/puAuxLargeInput.cxx
index 11834e6..8ac1f19 100644
--- a/src/puAux/puAuxLargeInput.cxx
+++ b/src/puAux/puAuxLargeInput.cxx
@@ -1219,7 +1219,7 @@ int puaLargeInput::checkKey ( int key, int updown
)
 void puaLargeInput::getTextProperties(int *numlines, int *maxwidth)
 {
   int num = 0, max = 0 ;
-  char *s = ulStrDup ( getStringValue () ) ;
+  char *buf = ulStrDup ( getStringValue () ), *s = buf ;
   while ( *s ) {
     char *cr = strchr ( s, '\n' ) ;
     if ( cr )
@@ -1233,6 +1233,7 @@ void puaLargeInput::getTextProperties(int
*numlines, int *maxwidth)
   }
   *numlines = num ;
   *maxwidth = max ;
+  delete [] buf ;
 }

 char *puaLargeInput::wrapText ( int target_width, int *numlines, int
*maxwidth )

------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

[Plib-devel] [PATCH] examples/src/pui/{combobox.cxx => widget_test.cxx}

[Melchior F. <mf...@us...>]

Here's one last (for a while :-) change. Not really a patch, but
again a full source file:

Quite a while ago I submitted a fix for a puaComboBox bug. To
demonstrate both bug and fix, I wrote a simple test application.
It wasn't really meant to be committed, but Bram did it anyway.
Not a bad idea, actually, as this is a nice testbed for trying
out widgets, especially during widget development.

I've beefed this up a bit now. Could you replace combobox.cxx by
the attached file and rename it to widget_test.cxx (or something
else appropriate)? Of course, you'd also have to change all
occurrences in the build files (Makefile.am etc.) as well.

- adds sample lists and text for usage in widgets
- adds key/special handling for puInput/puaLargeInput tests
- adds generic callback function
- resizes the widget with the window
- demonstrates puaLargeInput by default (which doesn't only
  allow to explore the recent changes, but also displays a
  short introduction) 

Unfortunately it flickers badly on resizing, although I've used
glutSwapBuffers().

m.

Re: [Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

[Melchior F. <mf...@us...>]

* Fay, John F Dr CTR USAF AFMC 46 SK -- Thursday 29 January 2009:
> OK, that's those changes in.  That was quite a bit.
> 
> As usual, please check that I've done things properly.  It builds on
> MSVC properly.

Excellent. Many thanks! Everything fine so far. (Or will be
once you've applied the leak fix. :-)

m.

Re: [Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

[Fay, J. F Dr C. U. A. 46 S. <joh...@eg...>]

OK, that's those changes in.  That was quite a bit.

As usual, please check that I've done things properly.  It builds on
MSVC properly.

John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294 

-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...] 
Sent: Thursday, January 29, 2009 10:44 AM
To: pli...@li...
Subject: Re: [Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

* Fay, John F Dr CTR USAF AFMC 46 SK -- Thursday 29 January 2009:
> By the way, in "puaLargeInput.cxx" around line 200, why is the integer
> "top_line_in_window" being compared with and set to a floating-point
> value?

For no good reason. I was just doing some late "cleanup" to make
data types more obvious for the reader. This slipped through. 
Please fix.  :-)

m.

------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

Re: [Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

[Melchior F. <mf...@us...>]

* Fay, John F Dr CTR USAF AFMC 46 SK -- Thursday 29 January 2009:
> By the way, in "puaLargeInput.cxx" around line 200, why is the integer
> "top_line_in_window" being compared with and set to a floating-point
> value?

For no good reason. I was just doing some late "cleanup" to make
data types more obvious for the reader. This slipped through. 
Please fix.  :-)

m.

Re: [Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

[Fay, J. F Dr C. U. A. 46 S. <joh...@eg...>]

By the way, in "puaLargeInput.cxx" around line 200, why is the integer
"top_line_in_window" being compared with and set to a floating-point
value?

John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294 

-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...] 
Sent: Thursday, January 29, 2009 8:30 AM
To: pli...@li...
Subject: [Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

Hi,

I just noticed that I didn't free the buffer in
puaLargeInput::getTextProperties(). Please apply
this patch. Sorry.

m.


diff --git a/src/puAux/puAuxLargeInput.cxx
b/src/puAux/puAuxLargeInput.cxx
index 11834e6..8ac1f19 100644
--- a/src/puAux/puAuxLargeInput.cxx
+++ b/src/puAux/puAuxLargeInput.cxx
@@ -1219,7 +1219,7 @@ int puaLargeInput::checkKey ( int key, int updown
)
 void puaLargeInput::getTextProperties(int *numlines, int *maxwidth)
 {
   int num = 0, max = 0 ;
-  char *s = ulStrDup ( getStringValue () ) ;
+  char *buf = ulStrDup ( getStringValue () ), *s = buf ;
   while ( *s ) {
     char *cr = strchr ( s, '\n' ) ;
     if ( cr )
@@ -1233,6 +1233,7 @@ void puaLargeInput::getTextProperties(int
*numlines, int *maxwidth)
   }
   *numlines = num ;
   *maxwidth = max ;
+  delete [] buf ;
 }

 char *puaLargeInput::wrapText ( int target_width, int *numlines, int
*maxwidth )

------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

[Plib-devel] [PATCH] puAuxLargeInput.cxx: fix leak

[Melchior F. <mf...@us...>]

Hi,

I just noticed that I didn't free the buffer in
puaLargeInput::getTextProperties(). Please apply
this patch. Sorry.

m.


diff --git a/src/puAux/puAuxLargeInput.cxx b/src/puAux/puAuxLargeInput.cxx
index 11834e6..8ac1f19 100644
--- a/src/puAux/puAuxLargeInput.cxx
+++ b/src/puAux/puAuxLargeInput.cxx
@@ -1219,7 +1219,7 @@ int puaLargeInput::checkKey ( int key, int updown )
 void puaLargeInput::getTextProperties(int *numlines, int *maxwidth)
 {
   int num = 0, max = 0 ;
-  char *s = ulStrDup ( getStringValue () ) ;
+  char *buf = ulStrDup ( getStringValue () ), *s = buf ;
   while ( *s ) {
     char *cr = strchr ( s, '\n' ) ;
     if ( cr )
@@ -1233,6 +1233,7 @@ void puaLargeInput::getTextProperties(int *numlines, int *maxwidth)
   }
   *numlines = num ;
   *maxwidth = max ;
+  delete [] buf ;
 }

 char *puaLargeInput::wrapText ( int target_width, int *numlines, int *maxwidth )

Re: [Plib-devel] [PATCH] puSlider/puaScrollBar: more work on optional 'new behavior'

[Melchior F. <mf...@us...>]

Maybe I should repeat once more what all those patches were about
(apart from fixing some bugs and making some minor improvements):

- everything is by default (almost) like before (source compatible,
  but, of course, not binary compatible). The only incompatible
  change is the removal of three puaLargeInput methods that were
  marked as "deprecated" since several years.

- puSlider and puaScrollBar can now be configured to work in a more
  commonly used way. This mode is activated by setting a page
  step > 0. (-> setPageStepSize()). If one clicks on the slider
  background, then the slider does now not jump there, but
  makes one "page step".

- puList and puaLargeInput are configured to use this new
  behavior: clicking on the slider background scrolls one
  page forward/backward. This makes the [>>] button superfluous,
  and arrows=11 is now recommended (i.e. one button on each slider).
  (arrows=2 is still supported for puaLargeInput.)

m.

Re: [Plib-devel] [PATCH] puSlider/puaScrollBar: more work on optional'new behavior'

[Melchior F. <mf...@us...>]

* Fay, John F Dr CTR USAF AFMC 46 SK -- Wednesday 28 January 2009:
> I realize this sounds backwards, but can you please send me diff
> files? 

Hehe ... sure. (Is my homepage blocked? Maybe I shouldn't have
used the apostrophe on the intro page ...  ;-)



> I'll be going through the files line by line (well, screen by 
> screen) anyway and I can't get to your links from here.

Oh, dear. BTW: I removed three (I think) of your cast operators.
If this causes the warnings again, then I apologize and will never
ever remove one again. But I think they are really unnecessary,
and I don't like redundant noise. The plib coding style is already
bad enough without that.  :-P


Next planned steps:
- change puaFileSelector to the new behavior
- puaLargeInput: auto-scroll contents if mouse in selection mode
  leaves window (this isn't a priority, though, and may take longer)

m.

Re: [Plib-devel] [PATCH] puSlider/puaScrollBar: more work on optional'new behavior'

[Fay, J. F Dr C. U. A. 46 S. <joh...@eg...>]

Melchior,

	I realize this sounds backwards, but can you please send me diff
files?  I'll be going through the files line by line (well, screen by
screen) anyway and I can't get to your links from here.

John F. Fay
Technical Fellow
Jacobs Technology TEAS Group
850-883-1294 

-----Original Message-----
From: Melchior FRANZ [mailto:mf...@us...] 
Sent: Wednesday, January 28, 2009 12:44 PM
To: pli...@li...
Subject: [Plib-devel] [PATCH] puSlider/puaScrollBar: more work on
optional'new behavior'

Here's another round of patches (or rather: full source files):

puaScrollBar:
- introduce [sg]etLineStepSize (using the slider's step size
  was a bad idea, as sliders also need a line-step (small step)
  if they don't use stepping)

pu.h/puSlider.cxx/puaScrollBar:
- if page-step size is <=0 use the old behavior (default),
  otherwise the new (i.e. do no longer use -1 for that)

puaLargeInput:
- fix a bug in puaLargeInput where increasing the widget width
  moved the text to the right
- make sure added lines scroll the box down if the slider was
  in bottom position
- let font changes also update the geometry
- simplify and optimize the slider autohiding code
- use puaScrollBar also for the bottom scrollbar. The "arrows"
  argument also sets the number of arrow buttons there, whereby
  the former meaning is retained (0, 1, 2 means 0, 1, 2 buttons
  for the vertical scrollbar). The "tens" are used for the bottom
  slider: decimal 12 means: one arrow button on the bottom
  scrollbar, and two on the vertical one.
- setPageStepSize() for both sliders, enabling the new slider
  behavior

puaList:
- setPageStepSize() for the slider, enabling the new behavior
 

The code works well in FlightGear and is valgrind-clean. If
I should run into glitches, then I will, of course, submit fixes.


./src/pui/:
  http://members.aon.at/mfranz/plib/pu.h  [45.2 kB]
  http://members.aon.at/mfranz/puSlider.cxx  [6.0 kB]

./src/puAux/:
  http://members.aon.at/mfranz/plib/puAux.h  [29.4 kB]
  http://members.aon.at/mfranz/plib/puAuxScrollBar.cxx  [9.4 kB]
  http://members.aon.at/mfranz/plib/puAuxLargeInput.cxx  [43.6 kB]
  http://members.aon.at/mfranz/plib/puAuxList.cxx  [7.0 kB]  

./doc/pui/:
  http://members.aon.at/mfranz/plib/index.html  [105.5 kB]

m.

------------------------------------------------------------------------
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

[Plib-devel] [PATCH] puSlider/puaScrollBar: more work on optional 'new behavior'

[Melchior F. <mf...@us...>]

Here's another round of patches (or rather: full source files):

puaScrollBar:
- introduce [sg]etLineStepSize (using the slider's step size
  was a bad idea, as sliders also need a line-step (small step)
  if they don't use stepping)

pu.h/puSlider.cxx/puaScrollBar:
- if page-step size is <=0 use the old behavior (default),
  otherwise the new (i.e. do no longer use -1 for that)

puaLargeInput:
- fix a bug in puaLargeInput where increasing the widget width
  moved the text to the right
- make sure added lines scroll the box down if the slider was
  in bottom position
- let font changes also update the geometry
- simplify and optimize the slider autohiding code
- use puaScrollBar also for the bottom scrollbar. The "arrows"
  argument also sets the number of arrow buttons there, whereby
  the former meaning is retained (0, 1, 2 means 0, 1, 2 buttons
  for the vertical scrollbar). The "tens" are used for the bottom
  slider: decimal 12 means: one arrow button on the bottom
  scrollbar, and two on the vertical one.
- setPageStepSize() for both sliders, enabling the new slider
  behavior

puaList:
- setPageStepSize() for the slider, enabling the new behavior
 

The code works well in FlightGear and is valgrind-clean. If
I should run into glitches, then I will, of course, submit fixes.


./src/pui/:
  http://members.aon.at/mfranz/plib/pu.h  [45.2 kB]
  http://members.aon.at/mfranz/puSlider.cxx  [6.0 kB]

./src/puAux/:
  http://members.aon.at/mfranz/plib/puAux.h  [29.4 kB]
  http://members.aon.at/mfranz/plib/puAuxScrollBar.cxx  [9.4 kB]
  http://members.aon.at/mfranz/plib/puAuxLargeInput.cxx  [43.6 kB]
  http://members.aon.at/mfranz/plib/puAuxList.cxx  [7.0 kB]  

./doc/pui/:
  http://members.aon.at/mfranz/plib/index.html  [105.5 kB]

m.

Re: [Plib-devel] [RFC] changing slider behavior

[Melchior F. <mf...@us...>]

* John F. Fay -- Friday 23 January 2009:
> But do, please, let me know if I made any mistakes in putting
> in the changes. 

Thanks, everything fine so far. The commit log messages may be
a bit misleading, as the committed patch did ultimately not
"change" the slider behavior, but only add an alternative one,
which is off by default. The next patches shall enable that for
widgets that make use of them, though.



> There were some compile warnings about type changes so I added
> some explicit type casts.

Sigh. I need to be more careful with that (and also find a
compiler setting that warns me ... though I have -Wall on
already). But you added more casts than make sense:

+    int upper = lower + int(float(box_len) * slider_fraction) ;

The "float" is superfluous (and I'll remove that again). Did
your compiler really suggest that? box_len is an int, but this
is implicitly turned to a float by the compiler for the
multiplication with float slider_fraction. Says the C++ standard.
The int cast, however, is of course desirable -- be it only to
make the intention clear. Not that it's actually required.


Next planned patches:
- fix a bug in puaLargeInput where increasing the widget width
  moved the text to the right (my fault)
- let font changes also update the geometry (my fault)
- simplify and optimize the slider autohiding code. That was a
  bit ugly in one of the last patches. Sorry.  :-)
- convert all widgets that use puSlider or puaScrollBar to the
  new slider behavior. (

Thanks for committing.

m.

Re: [Plib-devel] [RFC] changing slider behavior

[John F. F. <joh...@cy...>]

OK, that's in.  I made up an address for "puAux.h" and found it there, 
finishing the change set.

What was happening with me was that my spam filter caught some of the 
e-mails but not the others, and the order of some of them was switched 
around, and so life got very confusing.  But do, please, let me know if I 
made any mistakes in putting in the changes.

There were some compile warnings about type changes so I added some 
explicit type casts.

	- John


-----Original Message-----
From:	Melchior FRANZ
Sent:	Wednesday, January 21, 2009 5:25 PM
To:	pli...@li...
Subject:	Re: [Plib-devel] [RFC] changing slider behavior


OK, so I've implemented both old and new ("modern") behavior.
Actually, the former can be useful in some cases, where quick
selection of an estimated value is desirable without having
to grab a small slider handle. The old behavior is even default
now.

As the new behavior makes the slider position jump in fixed
intervals, for which a new parameter was required, this parameter
also decides whether old or new behavior should be used. In
the Qt-Toolkit these big steps are called PageStep (while the
small steps are called LineStep). I've used the same name:

  setPageStepSize(0);    ... no step chosen -> use default
                             (this is consistent with the already
                             existing puRange::setStepSize(),
                             where 0 also means to use a default)

  setPageStepSize(4);    ... increase/decrease value by 4 if one
                             clicks on the slider background rather
                             than the slider handle

  setPageStepSize(-1);   ... page steps disabled -> old behavior
                             (this is default)


The patch also fixes arrow highlighting in puaScrollBar. Somebody
had started to implement that, but stopped half-way. This wasn't
functional. Additionally, it reduced the slider minimum-width
from 10px to 8px. (I had introduced the 10px a few years ago,
but a bit smaller can't hurt.)


Files on my homepage. I hope this helps to apply the changes,
saving you from applying diffs manually.  :-)

./src/pui/
  http://members.aon.at/mfranz/plib/pu.h  [45.2 kB]
  http://members.aon.at/mfranz/plib/puSlider.cxx  [6.1 kB]

./src/puAux/
  http://members.aon.at/mfranz/plib/puAuxScrollBar.cxx  [9.3 kB]

I'll submit the necessary changes do the HTML documentation in
another patch.

m.

------------------------------------------------------------------------  
------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

Re: [Plib-devel] [RFC] changing slider behavior

[Melchior F. <mf...@us...>]

* John F. Fay -- Thursday 22 January 2009:
> I'm missing something here; my copy of "pu.h" doesn't have that
> on line 30. 

That's because I removed it later. The advantage of using links
rather than attachments. (Don't ask why I hadn't done that
immediately, instead of sending this message. Old habits,
I guess.  :-)

m.