The Player Project / Patches / #583 Strings created by EncodeHex are not null-terminated

#583 Strings created by EncodeHex are not null-terminated

Milestone: Unstable

Status: closed-accepted

Owner: Brian Gerkey

Labels: Player (393)

Priority: 5

Updated: 2010-06-02

Created: 2010-05-27

Creator: Sebastian Scherer

Private: No

The function EncodeHex in server/drivers/encode.cc does not null-terminate the c-strings it writes.

This in itself might just be unfavorable design and not a bug, but the writelog driver in WriteLog::WriteCamera assumes this string to be null-terminated. This leads to writelog writing strings for images that are too long (appending junk until a \0 is found), which in turn leads to ReadLog failing the assertion in ReadLog::ParseCamera:1530 once such a corrupted logfile is replayed.

The only other usage of EncodeHex seems to be in WriteLog::WriteRFID, where the whole string is properly set to \0 before calling EncodeHex.

Discussion

Sebastian Scherer - 2010-05-27

patch EncodeHex to null-terminate its strings

patchEncodeNullTermination.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

G Biggs - 2010-06-02

The changes have been made in SVN trunk.
Thank you for your contribution.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

G Biggs - 2010-06-02

status: open --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Strings created by EncodeHex are not null-terminated

Group

Searches

Help

#583 Strings created by EncodeHex are not null-terminated

Discussion