[Playerstage-developers] Player-3.0.2 on QNX6.4: bad design of client library

[Paul O. <new...@ki...>]

Guys, can you tell me why we need to use such a big amounts of memory?:

/** The largest possible message */
#define PLAYER_MAX_MESSAGE_SIZE 8388608 /*8MB*/
#define PLAYERXDR_MAX_MESSAGE_SIZE (4*PLAYER_MAX_MESSAGE_SIZE)

It will fail in libplayerc programs started on memory constrained systems 
(as QNX6.3 and later since swap functionality was removed):
   // TODO: make this memory allocation more conservative
   client->data = (char*)malloc(PLAYER_MAX_MESSAGE_SIZE);
   client->write_xdrdata = (char*)malloc(PLAYERXDR_MAX_MESSAGE_SIZE);
   client->read_xdrdata = (char*)malloc(PLAYERXDR_MAX_MESSAGE_SIZE);
   client->read_xdrdata_len = 0;
   assert(client->data);
   assert(client->write_xdrdata);
   assert(client->read_xdrdata); <- more than 64MB needed, it will fail here

I guess it can be redesigned: I've tried to use such a configuration file 
on QNX6.4 and it connected correctly to other Player server. If it can be 
done on server side, it should be possible on client side!
driver
(
   name "cameracompress"
   requires "192.168.1.2:6888:camera:0"
   provides "camera:0"
   alwayson 1
)

Paul

On Wed, 30 Jun 2010, Paul Osmialowski wrote:

> I've compiled successfully latest Player v.3.0.2 on QNX6.4. It works fine
> on server side, unfortunately, no client program can be started, it always
> fails with assertion:
> In function playerc_client_create --
> psg3/src/player-3.0.2/client_libs/libplayerc/client.c:193
> client->read_xdrdata -- assertion failed
>
> Looks like this assertion occurs before client is connecting to server: it
> fails no matter if server is started or not.
>
> I'll look at this closer in next few days, now I'm having few days break
> from coding so I don't want to involve in anything bigger.
>
> Paul
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Sprint
> What will you do first with EVO, the first 4G phone?
> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
> _______________________________________________
> Playerstage-developers mailing list
> Pla...@li...
> https://lists.sourceforge.net/lists/listinfo/playerstage-developers
>