Re: [Playerstage-developers] HAVE_CONFIG_H?

[gbiggs <gb...@ki...>]

Paul Osmialowski wrote:
> Hello devels,
> 
> I did little investigation regarding some defines from config.h that 
> aren't seen in certain drivers and I've found that most of the drivers 
> includes config.h just like that:
> 
> #include <config.h>
> 
> ...and it seems to be OK,
> while others have something like this:
> #if HAVE_CONFIG_H
> #include <config.h>
> #endif
> 
> ...and it causes things defined in config.h aren't seen inside of such 
> driver code.

The few drivers that were checking for HAVE_CONFIG_H were in error. This
was a hang-over from the autotools build system. I've removed these
checks now.

> There are also drivers which does not include config.h at all and few 
> others that previously were including config.h but now they have such 
> inclusion remarked by /* */.

Those drivers where including config.h is commented out are more likely
to have never used it. The example drivers all have a comment showing
how to include config.h if you need it, and most people start writing a
new driver by copying one of the examples.

> In my opinion, all drivers should include config.h, and since almost all 
> drivers include libplayercore/playercore.h, inclusion of config.h should 
> be added there. Also all occurences of HAVE_CONFIG_H should be removed 
> from Player distribution code.

Only drivers that need something from config.h should be including it.
There is no reason to include an extra file if it isn't necessary.


Geoff