[Playerstage-developers] HAVE_CONFIG_H?

[Paul O. <new...@ki...>]

Hello devels,

I did little investigation regarding some defines from config.h that 
aren't seen in certain drivers and I've found that most of the drivers 
includes config.h just like that:

#include <config.h>

...and it seems to be OK,
while others have something like this:
#if HAVE_CONFIG_H
#include <config.h>
#endif

...and it causes things defined in config.h aren't seen inside of such 
driver code.
There are also drivers which does not include config.h at all and few 
others that previously were including config.h but now they have such 
inclusion remarked by /* */.

In my opinion, all drivers should include config.h, and since almost all 
drivers include libplayercore/playercore.h, inclusion of config.h should 
be added there. Also all occurences of HAVE_CONFIG_H should be removed 
from Player distribution code.

Most of the cases where problem occurs you may never realise since only 
exotic build environments causes not typical config.h settings to be 
defined! (namely, compilation on QNX showed some hidden problems with 
drivers code).

Cheers,
Paul