From: Alexis M. <mal...@cs...> - 2008-05-13 01:21:14
|
Hello, On Tue, May 13, 2008 at 09:19:02AM +0900, Geoffrey Biggs wrote: > Thanks again for the patch. If only we could start using CMake 2.6 stuff > right away, we could have done it with a strip instead of a regex... > > This may sound picky, but I have a small request for when you submit > patches: Please make sure that you follow the same coding style as the > code you are editing. This helps to keep the source code clean and more > readable/maintainable without requiring more work by the person applying > the patch. In addition, don't forget to remove unnecessary debugging > prints, etc that you added while working on the changes. > > Geoff Sure, I'll try to pay attention to those details in the future to make the patches easier to integrate. Thanks for applying them so quickly! Greetings and good night, Alexis. |