Re: [Playerstage-users] Problems with RFID structures and type

[Giulio Z. <Giu...@ir...>]

On Wed, 2007-11-21 at 17:56 +0100, Giulio Zecca wrote:
> SUGGESTED CHANGES:
> /** @brief Structure describing a single RFID tag. */
> typedef struct player_rfid_tag
> {
>   /** Tag type. */
>   uint32_t type;
>   /** GUID count. */
>   uint32_t guid_count;
>   /** The Globally Unique IDentifier (GUID) of the tag. */
>   char * guid;
>   /** Data count. */
>   uint32_t data_count;
>   /** The data stored on the tag. */
>   char * data;
> } player_rfid_tag_t;
> 
> /***************/

I forgot to add the change in the structure player_rfid_data_t , which
was made according to the new specification in CVS version too.

typedef struct player_rfid_data
{
  /** The number of RFID tags found. */
  uint32_t tags_count;
  /** The list of RFID tags. */
  player_rfid_tag_t * tags;
} player_rfid_data_t;

/**/

Moreover, i found absolutely difficult to understand the message passing
because of the variables having the same name both in server and in
client files. This is a problem when manipulating files where your have
only a pointer to that values, and no clues whether you need to assign
Client or Server variable.
That's why I also propose a minor change to the variables name (like
adding a 'C' at the end of client variables. This is just an idea, I'd
just like not to confuse the 2 structures).

/** file PLAYERC.H */
/***************************************************************************************/
/** @brief Structure describing a single RFID tag. */
typedef struct
{
    /** Tag type. */
    uint32_t typeC;
    /** GUID count. */
    uint32_t guid_countC;
    /** The Globally Unique IDentifier (GUID) of the tag. */
    uint8_t * guidC;
    /** Data count. */
    uint32_t data_countC;
    /** The data stored on the tag. */
    uint8_t * dataC;
}  playerc_rfidtag_t;

/** @brief RFID proxy data. */
typedef struct
{
  /** Device info; must be at the start of all device structures. */
  playerc_device_t info;

  /** The number of RFID tags found. */
  uint16_t tags_countC;

  /** The list of RFID tags. */
  playerc_rfidtag_t * tagsC;
} playerc_rfid_t;
/***************************************************************************************/

Thanks