Re: [Platonos-plugeng-dev] bugs in pluginengine with unresolving plugins?

[Kevin D. <kev...@ya...>]

Sounds good to me. I am fine with this commit if u like. I am so swamped with day job and family right now I haven't had time to do much of anything else. :( I still want to start a 2.0 from scratch one day. :)

Potje rode kool <eve...@gm...> wrote: Hi guys,

For a long time I have runed the unit test of the pluginengine and got some errors in the PluginEngineTest test.

I tracked down what was going wrong and found out that in the PluginEngine#unresolvePlugin, at the end 
the pluginClassloader of the plugin was set to null and put in the unresolvedPlugins List.
The plugin is still in the plugins map and if another plugin tries to use that plugin it will result in a NPE because
the pluginClassLoader of the plugin is null. 

To fix this I assigned a new classloader (the old classloader is gc-ed) to the plugin and removed it from the plugins map,
but this resulted in an exception in Plugin1 which tried to use an E of another plugin which was unresolved. 

Didn't commited anything yet, I think we first have to write a document that describes the hole process of loading, resolving,
unresolving, unloading, etc of plugins so it is clear to everyone and than see where we have to fix things. 

What do you think?

Evert

 

			
---------------------------------
Sneak preview the  all-new Yahoo.com. It's not radically different. Just radically better.