pidgin-patches Mailing List for Pidgin IM (Page 17)

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Patches item #1203481, was opened at 2005-05-17 07:22
Message generated for change (Settings changed) made by lschiere
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1203481&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Michael Wardle (mwardle)
Assigned to: Nobody/Anonymous (nobody)
Summary: don't require reentry of password on disconnect/reconnect

Initial Comment:
If all my connections drops, the ugly initial Gaim
screen appears and forces me to reenter my password.

Gaim should remember my password.

----------------------------------------------------------------------

Comment By: Michael Wardle (mwardle)
Date: 2005-05-20 08:40

Message:
Logged In: YES 
user_id=554253

Sorry, obviously the "info" variable should be a handle to
an object from the "hash" hash not the "awayStates" hash,
but you get the idea.

----------------------------------------------------------------------

Comment By: Michael Wardle (mwardle)
Date: 2005-05-20 08:35

Message:
Logged In: YES 
user_id=554253

No, no.  I was using 1.3.0.  I just didn't plan on hacking
on it, so I lazily checked out HEAD as it was the default.

----------------------------------------------------------------------

Comment By: Michael Wardle (mwardle)
Date: 2005-05-20 08:33

Message:
Logged In: YES 
user_id=554253

So something like the attachment.

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2005-05-20 08:28

Message:
Logged In: YES 
user_id=28833

consider that one of the main points of 2.0.0 is to entirely
replace the state controls (online/offline, away/present, so
on).  NATURALLY this is going to change.  as I just said,
this entire plugin is deprecated and on its way out in the
cvs HEAD, the 2.0.0cvs, code.   so of course the fix for 1.x
will be entirely unrelated to the *right* way to handle this
in 2.0.0cvs. 

----------------------------------------------------------------------

Comment By: Michael Wardle (mwardle)
Date: 2005-05-20 08:21

Message:
Logged In: YES 
user_id=554253

In branch 1.48.2 (rev 1.48.2.2), the place to put such a
call would be in restore_state(), since that's the call back
for when a user is signed on.  On the down side, the
corresponding call back is called reconnected() in CVS.

I guess the ugly way is to add it to restore_state() or to
add a function reconnected() that resets the delay and then
called restore_state() as appropriate.

The nice way would take into account what's changed since
the branch. :-/

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2005-05-20 08:16

Message:
Logged In: YES 
user_id=28833

ah. you are pointing out a bug in cvs HEAD.  no wonder you
are having issues.  the code is in a transient state, with
the autorecon plugin only partly merged into gaim proper.  

the correct fix here is to move this functionality into the
core, change the error dialogs entirely into the type of
display presented at
http://gaim.sourceforge.net/sean/status.php and somewhat
modified in the last 9-12 months of gaim-devel archives, and
then remove the autorecon plugin entirely. 

Do not use cvs HEAD unless you are writing a patch.  do not
report bugs against it without a patch ever. 

----------------------------------------------------------------------

Comment By: Michael Wardle (mwardle)
Date: 2005-05-20 08:06

Message:
Logged In: YES 
user_id=554253

In CVS there is a function reconnected() as well as
reconnect().  I don't know about the 1.x branch.

It seemed to me that do_signon() was called either when we
wanted to connect to a server or once a TCP connection was
established with the server, so it didn't indicate we'd
successfully authenticated yet.  I was worried that
resetting the autoreconnection state in do_signon() could
lead to problems if the server was not fully operational or
if the user had entered an incorrect password.  As far as I
could tell, reconnected() was called after do_signon(), and
only once the user was fully reconnected.

I don't know the code base well and didn't spend enough time
stepping thru the whole sign on process.  It's not a patch
since I'm not confident it's correct.  I didn't even try
building it.  It's just a suggestion so someone who knows
Gaim can hopefully understand what I mean and maybe
implement it a little quicker.

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2005-05-20 07:50

Message:
Logged In: YES 
user_id=28833

I don't see a "reconnected" function, I do see "reconnect."  

now, If I'm reading your change correct (a real patch would
be nice, preferably with the -up flags to diff), then you'd
forget the delay even when the connection attempt failed.
which is obviously unacceptable. 

now. look down in do_signon, this is where we need to check,
and I'm not sure how to do that best. 

----------------------------------------------------------------------

Comment By: Michael Wardle (mwardle)
Date: 2005-05-18 22:44

Message:
Logged In: YES 
user_id=554253

I think the reconnection delay should be reset after a
successful connection.

It seems this can be achieved by adding these calls to the
appropriate place in plugins/autorecon.c: reconnected():

GaimAutoRecon * info;
...
info = g_hash_table_lookup(hash, account);
...
info->delay = 0;

At a quick glance, I also can't tell why we'd want to retain
the GaimAutoRecon handle after the dropped connection is
successfully reconnected, so perhaps instead do:

GaimAutoRecon * info;
...
info = g_hash_table_lookup(hash, account);
...
free_auto_recon(info);
g_slist_remove(info);

----------------------------------------------------------------------

Comment By: Michael Wardle (mwardle)
Date: 2005-05-18 21:34

Message:
Logged In: YES 
user_id=554253

Again, another bug written when I was highly annoyed at
seemingly having to click "Sign On" several times per day. 
I did enable the remember password preference, yet I still
found myself needing to click the "Sign On" button lots.

I've observed today that the first time I was disconnected,
Gaim attempted reconnection about 5 seconds later, the
second time about 10 seconds later, and the third time about
60 seconds later.

While some kind of delay seems reasonable, this kind of
apparently exponential backoff (combined with frequent
disconnections) results in:
a) the main Gaim sign on screen appearing above all my other
windows, taking input focus, thus almost demanding my attention
b) long delays between reconnection attempts when, in my
case, a reconnection attempt as soon as disconnection is
detected would probably succeed

----------------------------------------------------------------------

Comment By: Stu Tomlinson (nosnilmot)
Date: 2005-05-18 07:59

Message:
Logged In: YES 
user_id=309779

You're all confused!

If all your connections get disconnected, the login window
does show up. However, the autoreconnect plugin *will* still
do it's thing and reconnect your accounts, you just need to
give it enough time.

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2005-05-18 07:42

Message:
Logged In: YES 
user_id=28833

remember password is irrelevent here.  go look at the modify
account dialog.  there are 3 fields: username, password, and
alias. (not necessarily in that order).  you put your
password in the alias field as well as the password field. 

----------------------------------------------------------------------

Comment By: Michael Wardle (mwardle)
Date: 2005-05-17 09:43

Message:
Logged In: YES 
user_id=554253

I should have mentioned this in my original message, but of
course I have remember password checked, which is why this
is a bug!

In any case, if one account is disconnected, I am not asked
for my password again, only if they all are.

----------------------------------------------------------------------

Comment By: Daniel Atallah (datallah)
Date: 2005-05-17 09:40

Message:
Logged In: YES 
user_id=325843

Modify your account and tell it to remember your password.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1203481&group_id=235

2004	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct	Nov (435)	Dec (252)
2005	Jan (177)	Feb (157)	Mar (187)	Apr (168)	May (127)	Jun (291)	Jul (38)	Aug	Sep	Oct	Nov	Dec

pidgin-patches Mailing List for Pidgin IM (Page 17)

A universal instant messaging (IM) program

pidgin-patches — Updates to the Gaim patches tracker