From: SourceForge.net <no...@so...> - 2005-05-12 09:36:12
|
Patches item #1175520, was opened at 2005-04-02 20:57 Message generated for change (Comment added) made by monkey77 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1175520&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: dennisne (dennisne) Assigned to: Sean Egan (seanegan) Summary: autoaccept file transfers Initial Comment: This patch (against gaim 2.0.0cvs-2005-04-02) adds an option to autoaccept file transfers, in Preferences > Conversations tab > File Transfers. gaim 2.0.0 has preferences listed in tabs, instead of in a list like the 1.x series ... and I didn't want to make the window wider =| ... although i did have doubts about bunching it in with the Conversation preferences. The gaim preference for this feature is: /gaim/gtk/conversations/autoaccept_transfers it is disabled by default. In Preferences, the download directory can also be specified. For this i added gaim_request_folder(), which adds support for gtk's folder-selection dialog. The default download folder, should one not be specified, is the user's home directory. All in all, autoaccepting of file transfers should be a part of gaim. ---------------------------------------------------------------------- Comment By: Phil Hannent (monkey77) Date: 2005-05-12 09:36 Message: Logged In: YES user_id=898116 I have to add here that I created a RFE regarding this, thanks for writing it. While auto-accepting files might be a security issue I think it would be an idea to allow accepting files from trusted buddies. Any files that are sent to you would be put into a folder of your choosing and therefore you know what level of trust you should have on files in that folder. Is there a chance this patch could be back ported to the oldstatus since 2.0.0 is still an unknown at this time? Many thanks Phil ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-26 01:49 Message: Logged In: YES user_id=20979 I guess that's a valid reason. I still don't really like this, though. I think auto-accepting files from other people is a really bad idea. And we're trying to move away from having preferences for everything. Some of the changes in your patch are nice, though. The last_save_folder change in ft.c isn't a bad idea. And the gaim_request_folder addition to the request API looks pretty well done (I guess we don't really need it anywhere else, though). ---------------------------------------------------------------------- Comment By: dennisne (dennisne) Date: 2005-04-25 22:30 Message: Logged In: YES user_id=997396 people constantly send me small files ... text files, images ... they are small, and numerous, and it takes a lot of time to manually accept and choose download location for each file ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-25 18:43 Message: Logged In: YES user_id=20979 Why do you feel autoaccepting of file transfers should be a part of Gaim? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1175520&group_id=235 |