Menu
▾
▴
pidgin-patches — Updates to the Gaim patches tracker
You can subscribe to this list here.
| 2004 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(435) |
Dec
(252) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
(177) |
Feb
(157) |
Mar
(187) |
Apr
(168) |
May
(127) |
Jun
(291) |
Jul
(38) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: SourceForge.net <no...@so...> - 2005-07-05 16:21:56
|
Patches item #1232875, was opened at 2005-07-05 22:21 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1232875&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Yahoo: Set login-status (HEAD) Initial Comment: Hello. This is how things should probably be? This one-line patch allows to login as invisible if you select `Invisible' from the status-selector. It will probably login in other states (like Busy, On Phone etc) if selected (if available in the dropdown). It does not login in the `Away state with a message' status though. I don't know how to do that, or if that can be done. -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1232875&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-05 14:28:24
|
Patches item #1226486, was opened at 2005-06-23 15:23 Message generated for change (Comment added) made by tak_tak You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226486&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Richard Laager (rlaager) Summary: Fixes #1224178 Initial Comment: Fixes #1224178. Only tested with IRC. ---------------------------------------------------------------------- >Comment By: Levi Bard (tak_tak) Date: 2005-07-05 10:28 Message: Logged In: YES user_id=644705 Good catch @ leak - update attached. Whether the other protocols send back the new topic to the node that requests the change was my worry as well; imo any "sane" protocol would do it, but I guess we'll see. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 01:50 Message: Logged In: YES user_id=156487 This leaks memory if you hit this if block: if(current_topic && !g_utf8_collate(new_topic, current_topic)) It needs to g_free(new_topic); inside that block. This works for IRC because the server sends back the new topic, which causes Gaim to update the text box. I'm not sure how this works for Jabber, SILC, and Zephyr, which are the other protocols which define set_chat_topic. I think you're taking the correct approach here. If the other protocols' servers don't send a topic update back to the client on success, they can fake it. I'm going to try to find out what the situation is with those protocols and what the developers who maintain the relevant prpls have to say about this. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-23 15:24 Message: Logged In: YES user_id=644705 (Also applies to oldstatus.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226486&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-05 03:56:10
|
Patches item #1224555, was opened at 2005-06-21 01:50 Message generated for change (Comment added) made by enix You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224555&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: win32 Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Enix (enix) Assigned to: Daniel Atallah (datallah) Summary: [HEAD, Oldstatus] Tooltip appears over gtkblist context menu Initial Comment: When the gtkblist context menu is displayed, the tooltip timeout is not removed. This results in the tooltip displaying over the context menu when the timeout occurs. Included is a short patch to remove the timeout before displaying the context menu. Applies against HEAD and Oldstatus. ---------------------------------------------------------------------- >Comment By: Enix (enix) Date: 2005-07-05 03:56 Message: Logged In: YES user_id=17877 Oh, being in the COPYRIGHT file would be very nice. My name is Palmer Cox. ---------------------------------------------------------------------- Comment By: Daniel Atallah (datallah) Date: 2005-07-05 02:00 Message: Logged In: YES user_id=325843 The GTK+ bug has gotten some attention lately, but the fix will not be available until GTK+ 2.8. Hopefully this patch will avoid a bug report or two in the meantime. If you want to be in the COPYRIGHT file, we'll need to know your name. ---------------------------------------------------------------------- Comment By: Daniel Atallah (datallah) Date: 2005-06-24 15:54 Message: Logged In: YES user_id=325843 I'm guessing that this is related to the whole GTK+ focus problem: http://bugzilla.gnome.org/show_bug.cgi?id=107320 This seems like it isn't a bad workaround to this annoyance (it probably should be #ifdef _WIN32 'd) until this gtk bug is sorted (which, as you can see in the bug report, isn't particlarly likely to happen soon). This also could probably be done to prevent the popup from interfering with dnd of blist nodes. ---------------------------------------------------------------------- Comment By: Enix (enix) Date: 2005-06-22 23:12 Message: Logged In: YES user_id=17877 i just attached a screenshot of the problem on windows XP ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 22:35 Message: Logged In: YES user_id=20979 I can't reproduce the problem you're describing. Do you only have this problem when using MS Windows? Could you take a screen shot? I'm not opposed to fixing this, but it sounds like it might be something we'll want to file a gtk bug about (I'm thinking that when the context menu is open then the blist should not have focus, and should therefore not display the tooltip). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224555&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-05 02:00:12
|
Patches item #1224555, was opened at 2005-06-20 20:50 Message generated for change (Settings changed) made by datallah You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224555&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: win32 Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Enix (enix) >Assigned to: Daniel Atallah (datallah) Summary: [HEAD, Oldstatus] Tooltip appears over gtkblist context menu Initial Comment: When the gtkblist context menu is displayed, the tooltip timeout is not removed. This results in the tooltip displaying over the context menu when the timeout occurs. Included is a short patch to remove the timeout before displaying the context menu. Applies against HEAD and Oldstatus. ---------------------------------------------------------------------- >Comment By: Daniel Atallah (datallah) Date: 2005-07-04 21:00 Message: Logged In: YES user_id=325843 The GTK+ bug has gotten some attention lately, but the fix will not be available until GTK+ 2.8. Hopefully this patch will avoid a bug report or two in the meantime. If you want to be in the COPYRIGHT file, we'll need to know your name. ---------------------------------------------------------------------- Comment By: Daniel Atallah (datallah) Date: 2005-06-24 10:54 Message: Logged In: YES user_id=325843 I'm guessing that this is related to the whole GTK+ focus problem: http://bugzilla.gnome.org/show_bug.cgi?id=107320 This seems like it isn't a bad workaround to this annoyance (it probably should be #ifdef _WIN32 'd) until this gtk bug is sorted (which, as you can see in the bug report, isn't particlarly likely to happen soon). This also could probably be done to prevent the popup from interfering with dnd of blist nodes. ---------------------------------------------------------------------- Comment By: Enix (enix) Date: 2005-06-22 18:12 Message: Logged In: YES user_id=17877 i just attached a screenshot of the problem on windows XP ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 17:35 Message: Logged In: YES user_id=20979 I can't reproduce the problem you're describing. Do you only have this problem when using MS Windows? Could you take a screen shot? I'm not opposed to fixing this, but it sounds like it might be something we'll want to file a gtk bug about (I'm thinking that when the context menu is open then the blist should not have focus, and should therefore not display the tooltip). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224555&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-05 00:04:08
|
Patches item #1223021, was opened at 2005-06-17 21:35 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223021&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Jason Roth (jroth2) Assigned to: Richard Laager (rlaager) Summary: fixes bug #1222552 Initial Comment: As described in bug report #1222552, gaim will disconnect the current msn session and corrupt blist.xml when you try to add an msn screenname with a space in it (e.g. "foo ba...@ho..."). This patch adds a check to userlist.c in the form of a three line if statement if(strrchr(who, " ") == NULL) { gaim_debug("msn", "MSN screennames cannot contain spaces"); return; } ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-04 19:04 Message: Logged In: YES user_id=156487 Accepted with changes. Thanks for the patch. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:59 Message: Logged In: YES user_id=156487 This should also use gaim_notify_error() to inform the user instead of just silently dropping the add request. ---------------------------------------------------------------------- Comment By: Jason Roth (jroth2) Date: 2005-06-20 21:39 Message: Logged In: YES user_id=1298163 yeah, sorry, i misread my man page. strchr(who, " ") != NULL is better. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-18 23:25 Message: Logged In: YES user_id=156487 My man page says: The strchr() and strrchr() functions return a pointer to the matched character or NULL if the character is not found. I also don't see the point of using strrchr. Wouldn't strchr do? Therefore, shouldn't this be something like: if (strchr(who, " ") != NULL) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223021&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-04 11:38:19
|
Patches item #1231086, was opened at 2005-07-01 22:45 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231086&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Richard Laager (rlaager) Summary: Auto-complete in Pounce-dialog (HEAD) Initial Comment: Hello. This patch adds auto-complete functionality to the pounce-dialog. It uses the API function gaim_buddies_get_all introduced in patch#1231082. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-07-04 17:38 Message: Logged In: YES user_id=1132702 setting the list free :) -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 15:46 Message: Logged In: YES user_id=1132702 I have modified the patch so it now has the alias in the auto-complete list in addition to the names. I have looked at your codes in gtkrequest.c, and had planned on using exactly that. But the pounce-dialog does not use the request-API (I am not sure whether it can with its complex GUI), and so I decided to go this way. -- Adil ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 11:10 Message: Logged In: YES user_id=156487 I haven't tested this, but it looks good. However, I'd like it if you could auto-complete by aliases as well. That way we won't have autocomplete behaving in different ways in different parts of the application. Really, the code I wrote for gtkrequest.c needs to be tweaked so it can be exported in a generic way. Then, this dialog can use it as well. This may be non-trivial. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231086&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-04 11:08:46
|
Patches item #1231082, was opened at 2005-07-01 22:40 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: New API gaim_buddies_get_all (HEAD) Initial Comment: Hello. This patch introduces a new function gaim_buddies_get_all which returns a linked-list of the buddies. It takes a boolean parameter to decide whether to include buddies from un/dis-connected accounts. A somewhat similar function gaim_get_blist does exist. But it needs to be traversed in an ugly nested loop to get a simple list. This patch removes the need for that, and thus will possibly make a few other functions (in src/gtkconv.c, src/gtkblist.c etc) simpler. It will probably be useful for plugins as well. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-07-04 17:08 Message: Logged In: YES user_id=1132702 ah yes... the list deserves to be freed :) ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-04 01:18 Message: Logged In: YES user_id=156487 gaim_buddies_get_all builds a new GList. In the places where you're calling it, you need to g_list_free() when you're done with it. ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 14:49 Message: Logged In: YES user_id=1132702 I have made some changes, so the functions in Gaim which were using loops are now using this function. It's somewhat of a big patch. But I don't think I've broken anything here. -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 11:50 Message: Logged In: YES user_id=1132702 I think the sorting can be left to the caller. That shouldn't be a prob. >> It would be totally cool if you could find places in Gaim that >> are doing this complicated loop and simplify it to use this >> new function. I plan on doing that actually :-) I will modify the patch accordingly and resubmit it. -- Adil ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 11:33 Message: Logged In: YES user_id=156487 Is it necessary to do an insertion sort? Callers could sort the list if they wanted it sorted. The buddy pounce ChangeLog entry slipped into this patch. As for the other entry, changes to the API are documented in plugins/ChangeLog.API. It would be totally cool if you could find places in Gaim that are doing this complicated loop and simplify it to use this new function. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 19:18:56
|
Patches item #1231082, was opened at 2005-07-01 11:40 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: New API gaim_buddies_get_all (HEAD) Initial Comment: Hello. This patch introduces a new function gaim_buddies_get_all which returns a linked-list of the buddies. It takes a boolean parameter to decide whether to include buddies from un/dis-connected accounts. A somewhat similar function gaim_get_blist does exist. But it needs to be traversed in an ugly nested loop to get a simple list. This patch removes the need for that, and thus will possibly make a few other functions (in src/gtkconv.c, src/gtkblist.c etc) simpler. It will probably be useful for plugins as well. -- Adil ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 14:18 Message: Logged In: YES user_id=156487 gaim_buddies_get_all builds a new GList. In the places where you're calling it, you need to g_list_free() when you're done with it. ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 03:49 Message: Logged In: YES user_id=1132702 I have made some changes, so the functions in Gaim which were using loops are now using this function. It's somewhat of a big patch. But I don't think I've broken anything here. -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 00:50 Message: Logged In: YES user_id=1132702 I think the sorting can be left to the caller. That shouldn't be a prob. >> It would be totally cool if you could find places in Gaim that >> are doing this complicated loop and simplify it to use this >> new function. I plan on doing that actually :-) I will modify the patch accordingly and resubmit it. -- Adil ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:33 Message: Logged In: YES user_id=156487 Is it necessary to do an insertion sort? Callers could sort the list if they wanted it sorted. The buddy pounce ChangeLog entry slipped into this patch. As for the other entry, changes to the API are documented in plugins/ChangeLog.API. It would be totally cool if you could find places in Gaim that are doing this complicated loop and simplify it to use this new function. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 16:36:26
|
Patches item #1231528, was opened at 2005-07-02 22:09 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231528&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Mark Doliner (thekingant) Summary: Oscar crash fix (?) (HEAD) Initial Comment: Hello. Gaim seems to be crashing when I enable an AIM account, and couple of seconds later, while it's still connecting, disable it. I have attached the backtrace and the patch which seems to have fixed the problem. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-07-03 22:36 Message: Logged In: YES user_id=1132702 The crash is reproduceable with a plugin, but not without it. The problem that's occuring is this: Gaim in HEAD uses _set_status functions to connect/disconnect an account. The plugin used the old-style _connect and _disconnect functions for that purpose. These functions work just fine with protocols like msn/irc without any problem because they don't [yet] consider the `status'. Yahoo does consider it, but it ignores GAIM_STATUS_OFFLINE status. Among the ones I have looked into (yahoo,msn,irc,oscar) oscar is the only one to check for that, and hence it does not go upto the part where od->sess gets set. I would suggest the _connect/_disconnect functions be made unavailable to the plugins, since those are likely to be causing further similar problems. -- Adil ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-07-03 16:49 Message: Logged In: YES user_id=20979 Is this reproduceable for you? I could not reproduce it, and I don't really understand how this crash should happen... od->sess should really never be null. It should be in oscar_login at the same time od is created, and never freed. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 11:04 Message: Logged In: YES user_id=156487 This looks pretty simple and safe, but I don't know for sure so I'm assigning it to Mark. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231528&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 10:49:58
|
Patches item #1231528, was opened at 2005-07-02 12:09 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231528&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Mark Doliner (thekingant) Summary: Oscar crash fix (?) (HEAD) Initial Comment: Hello. Gaim seems to be crashing when I enable an AIM account, and couple of seconds later, while it's still connecting, disable it. I have attached the backtrace and the patch which seems to have fixed the problem. -- Adil ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-07-03 06:49 Message: Logged In: YES user_id=20979 Is this reproduceable for you? I could not reproduce it, and I don't really understand how this crash should happen... od->sess should really never be null. It should be in oscar_login at the same time od is created, and never freed. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 01:04 Message: Logged In: YES user_id=156487 This looks pretty simple and safe, but I don't know for sure so I'm assigning it to Mark. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231528&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 09:46:39
|
Patches item #1231086, was opened at 2005-07-01 22:45 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231086&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Richard Laager (rlaager) Summary: Auto-complete in Pounce-dialog (HEAD) Initial Comment: Hello. This patch adds auto-complete functionality to the pounce-dialog. It uses the API function gaim_buddies_get_all introduced in patch#1231082. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-07-03 15:46 Message: Logged In: YES user_id=1132702 I have modified the patch so it now has the alias in the auto-complete list in addition to the names. I have looked at your codes in gtkrequest.c, and had planned on using exactly that. But the pounce-dialog does not use the request-API (I am not sure whether it can with its complex GUI), and so I decided to go this way. -- Adil ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 11:10 Message: Logged In: YES user_id=156487 I haven't tested this, but it looks good. However, I'd like it if you could auto-complete by aliases as well. That way we won't have autocomplete behaving in different ways in different parts of the application. Really, the code I wrote for gtkrequest.c needs to be tweaked so it can be exported in a generic way. Then, this dialog can use it as well. This may be non-trivial. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231086&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 08:49:01
|
Patches item #1231082, was opened at 2005-07-01 22:40 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: New API gaim_buddies_get_all (HEAD) Initial Comment: Hello. This patch introduces a new function gaim_buddies_get_all which returns a linked-list of the buddies. It takes a boolean parameter to decide whether to include buddies from un/dis-connected accounts. A somewhat similar function gaim_get_blist does exist. But it needs to be traversed in an ugly nested loop to get a simple list. This patch removes the need for that, and thus will possibly make a few other functions (in src/gtkconv.c, src/gtkblist.c etc) simpler. It will probably be useful for plugins as well. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-07-03 14:49 Message: Logged In: YES user_id=1132702 I have made some changes, so the functions in Gaim which were using loops are now using this function. It's somewhat of a big patch. But I don't think I've broken anything here. -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 11:50 Message: Logged In: YES user_id=1132702 I think the sorting can be left to the caller. That shouldn't be a prob. >> It would be totally cool if you could find places in Gaim that >> are doing this complicated loop and simplify it to use this >> new function. I plan on doing that actually :-) I will modify the patch accordingly and resubmit it. -- Adil ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 11:33 Message: Logged In: YES user_id=156487 Is it necessary to do an insertion sort? Callers could sort the list if they wanted it sorted. The buddy pounce ChangeLog entry slipped into this patch. As for the other entry, changes to the API are documented in plugins/ChangeLog.API. It would be totally cool if you could find places in Gaim that are doing this complicated loop and simplify it to use this new function. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 06:43:24
|
Patches item #1218079, was opened at 2005-06-10 05:06 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1218079&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Stanislav Brabec (sbrabec) Assigned to: Richard Laager (rlaager) Summary: Groupwise evolution integration patch Initial Comment: Attached patch adds basic support for Novell Groupwise to Gaim Evolution integration. New Person dialog for both Add Buddy and Evolution Integration can be improved in future to be able to get name, e-mail and maybe other information from Groupwise. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 01:43 Message: Logged In: YES user_id=156487 Thanks for the patch. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-01 11:30 Message: Logged In: YES user_id=156487 Novell acquired SuSE, I think. Unless someone objects, using Novell (which already exists in COPYRIGHT) seems like the right approach. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-07-01 10:41 Message: Logged In: YES user_id=20979 This conversation seemed very disjoint to me until I realized that Stanislav works for SUSE. It looks like the copyright for all the code we've received from Mike Stoddard is currently assigned to Novell. I suggest using Stanislav's company name for this, unless he objects. I'm not sure if that should be Novell or SUSE. ---------------------------------------------------------------------- Comment By: Stanislav Brabec (sbrabec) Date: 2005-07-01 08:13 Message: Logged In: YES user_id=616997 SuSE has no written policy about this, but developer names are used usually. ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-30 12:15 Message: Logged In: YES user_id=28833 I think that's what Richard was attempting to ask :-) ---------------------------------------------------------------------- Comment By: Stu Tomlinson (nosnilmot) Date: 2005-06-30 12:11 Message: Logged In: YES user_id=309779 Isn't it more relevant what Novell's (or Suse's) policy is on copyright assignment? Novell is already in the COPYRIGHT file from the original inclusion of the Groupwise protocol plugin. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-30 11:52 Message: Logged In: YES user_id=156487 Which of you wrote *this patch*? ---------------------------------------------------------------------- Comment By: Stanislav Brabec (sbrabec) Date: 2005-06-30 04:11 Message: Logged In: YES user_id=616997 If you think, that my name should be included into this file, use Stanislav Brabec (sbrabec at suse.cz). But in this case Mike Stoddard (mistoddard at novell.com), who did more work on Novell Groupwise support, should be included there for sure, too. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-29 23:18 Message: Logged In: YES user_id=156487 I'm going to accept this, but I need to know what name you'd like listed in the COPYRIGHT file. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-25 18:54 Message: Logged In: YES user_id=156487 This looks right to me. It compiles and loads. I don't have a Novell Groupwise server, so I couldn't test the actual functionality, but it doesn't seem to break anything. ---------------------------------------------------------------------- Comment By: Stanislav Brabec (sbrabec) Date: 2005-06-10 07:17 Message: Logged In: YES user_id=616997 The patch only adds Groupwise to known protocols to gevolution plugin. It does not fill name and e-mail while adding buddy to addressbook. Groupwise explicitly provides this information (see nmuserrecord.c). For other protocols it can be done, too, but with some limitations. ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-10 06:21 Message: Logged In: YES user_id=28833 how does this differ from the gevolution plugin? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1218079&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 06:12:53
|
Patches item #1231506, was opened at 2005-07-02 09:54 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Implementing gaim_accounts_get_all_active (HEAD) Initial Comment: Hello. gaim_accounts_get_all_active functions is declared in src/account.h which should return a list of active (enabled) accounts, but it is not implemented anywhere. This patch implements the function. -- Adil ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 01:12 Message: Logged In: YES user_id=156487 All other uses of that function (the ones which use GAIM_GTK_UI) are in files name gtkBLAH.c, so they're part of the GTK+ UI. When adding #includes to a file where the #includes are sorted alphabetically within blocks, please add the new #include to the block in alphabetical order. Thanks for the patch. ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 00:54 Message: Logged In: YES user_id=1132702 I am currently writing a plugin to do the status-works. It requires this function. Right now, I can include this function in my plugin, but I realized the function is planned to be included in the core anyway (since it's there in account.h). [The plugin I am working on: http://sourceforge.net/projects/geam] -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 00:38 Message: Logged In: YES user_id=1132702 GAIM_GTK_UI is the GTK+ UI code here? I have replaced it with gaim_core_get_ui() function (which is also used in src/status.c). This probably honours the core/ui split? gaim_account_get_enabled seems always to be using GAIM_GTK_UI as the second parameter (except for that one instance) which seems rather confusing right now, but that's probably another matter. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:14 Message: Logged In: YES user_id=156487 This patch is using GTK+ UI code in a core file. This breaks the core/ui split. I don't know what the plan is for that function. Unless you have a need for it, let the developer(s) working on status get to it. If you do have a need for it, talk to someone that knows what the status API is supposed to be like before implementing it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:59:24
|
Patches item #1223021, was opened at 2005-06-17 21:35 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223021&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Jason Roth (jroth2) Assigned to: Richard Laager (rlaager) Summary: fixes bug #1222552 Initial Comment: As described in bug report #1222552, gaim will disconnect the current msn session and corrupt blist.xml when you try to add an msn screenname with a space in it (e.g. "foo ba...@ho..."). This patch adds a check to userlist.c in the form of a three line if statement if(strrchr(who, " ") == NULL) { gaim_debug("msn", "MSN screennames cannot contain spaces"); return; } ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:59 Message: Logged In: YES user_id=156487 This should also use gaim_notify_error() to inform the user instead of just silently dropping the add request. ---------------------------------------------------------------------- Comment By: Jason Roth (jroth2) Date: 2005-06-20 21:39 Message: Logged In: YES user_id=1298163 yeah, sorry, i misread my man page. strchr(who, " ") != NULL is better. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-18 23:25 Message: Logged In: YES user_id=156487 My man page says: The strchr() and strrchr() functions return a pointer to the matched character or NULL if the character is not found. I also don't see the point of using strrchr. Wouldn't strchr do? Therefore, shouldn't this be something like: if (strchr(who, " ") != NULL) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223021&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:54:41
|
Patches item #1231506, was opened at 2005-07-02 20:54 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Open >Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Implementing gaim_accounts_get_all_active (HEAD) Initial Comment: Hello. gaim_accounts_get_all_active functions is declared in src/account.h which should return a list of active (enabled) accounts, but it is not implemented anywhere. This patch implements the function. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-07-03 11:54 Message: Logged In: YES user_id=1132702 I am currently writing a plugin to do the status-works. It requires this function. Right now, I can include this function in my plugin, but I realized the function is planned to be included in the core anyway (since it's there in account.h). [The plugin I am working on: http://sourceforge.net/projects/geam] -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-07-03 11:38 Message: Logged In: YES user_id=1132702 GAIM_GTK_UI is the GTK+ UI code here? I have replaced it with gaim_core_get_ui() function (which is also used in src/status.c). This probably honours the core/ui split? gaim_account_get_enabled seems always to be using GAIM_GTK_UI as the second parameter (except for that one instance) which seems rather confusing right now, but that's probably another matter. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 11:14 Message: Logged In: YES user_id=156487 This patch is using GTK+ UI code in a core file. This breaks the core/ui split. I don't know what the plan is for that function. Unless you have a need for it, let the developer(s) working on status get to it. If you do have a need for it, talk to someone that knows what the status API is supposed to be like before implementing it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:50:36
|
Patches item #1226486, was opened at 2005-06-23 14:23 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226486&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Levi Bard (tak_tak) >Assigned to: Richard Laager (rlaager) Summary: Fixes #1224178 Initial Comment: Fixes #1224178. Only tested with IRC. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:50 Message: Logged In: YES user_id=156487 This leaks memory if you hit this if block: if(current_topic && !g_utf8_collate(new_topic, current_topic)) It needs to g_free(new_topic); inside that block. This works for IRC because the server sends back the new topic, which causes Gaim to update the text box. I'm not sure how this works for Jabber, SILC, and Zephyr, which are the other protocols which define set_chat_topic. I think you're taking the correct approach here. If the other protocols' servers don't send a topic update back to the client on success, they can fake it. I'm going to try to find out what the situation is with those protocols and what the developers who maintain the relevant prpls have to say about this. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-23 14:24 Message: Logged In: YES user_id=644705 (Also applies to oldstatus.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226486&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:50:02
|
Patches item #1231082, was opened at 2005-07-01 22:40 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: New API gaim_buddies_get_all (HEAD) Initial Comment: Hello. This patch introduces a new function gaim_buddies_get_all which returns a linked-list of the buddies. It takes a boolean parameter to decide whether to include buddies from un/dis-connected accounts. A somewhat similar function gaim_get_blist does exist. But it needs to be traversed in an ugly nested loop to get a simple list. This patch removes the need for that, and thus will possibly make a few other functions (in src/gtkconv.c, src/gtkblist.c etc) simpler. It will probably be useful for plugins as well. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-07-03 11:50 Message: Logged In: YES user_id=1132702 I think the sorting can be left to the caller. That shouldn't be a prob. >> It would be totally cool if you could find places in Gaim that >> are doing this complicated loop and simplify it to use this >> new function. I plan on doing that actually :-) I will modify the patch accordingly and resubmit it. -- Adil ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 11:33 Message: Logged In: YES user_id=156487 Is it necessary to do an insertion sort? Callers could sort the list if they wanted it sorted. The buddy pounce ChangeLog entry slipped into this patch. As for the other entry, changes to the API are documented in plugins/ChangeLog.API. It would be totally cool if you could find places in Gaim that are doing this complicated loop and simplify it to use this new function. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:38:28
|
Patches item #1231506, was opened at 2005-07-02 20:54 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Implementing gaim_accounts_get_all_active (HEAD) Initial Comment: Hello. gaim_accounts_get_all_active functions is declared in src/account.h which should return a list of active (enabled) accounts, but it is not implemented anywhere. This patch implements the function. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-07-03 11:38 Message: Logged In: YES user_id=1132702 GAIM_GTK_UI is the GTK+ UI code here? I have replaced it with gaim_core_get_ui() function (which is also used in src/status.c). This probably honours the core/ui split? gaim_account_get_enabled seems always to be using GAIM_GTK_UI as the second parameter (except for that one instance) which seems rather confusing right now, but that's probably another matter. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 11:14 Message: Logged In: YES user_id=156487 This patch is using GTK+ UI code in a core file. This breaks the core/ui split. I don't know what the plan is for that function. Unless you have a need for it, let the developer(s) working on status get to it. If you do have a need for it, talk to someone that knows what the status API is supposed to be like before implementing it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:33:46
|
Patches item #1231082, was opened at 2005-07-01 11:40 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: New API gaim_buddies_get_all (HEAD) Initial Comment: Hello. This patch introduces a new function gaim_buddies_get_all which returns a linked-list of the buddies. It takes a boolean parameter to decide whether to include buddies from un/dis-connected accounts. A somewhat similar function gaim_get_blist does exist. But it needs to be traversed in an ugly nested loop to get a simple list. This patch removes the need for that, and thus will possibly make a few other functions (in src/gtkconv.c, src/gtkblist.c etc) simpler. It will probably be useful for plugins as well. -- Adil ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:33 Message: Logged In: YES user_id=156487 Is it necessary to do an insertion sort? Callers could sort the list if they wanted it sorted. The buddy pounce ChangeLog entry slipped into this patch. As for the other entry, changes to the API are documented in plugins/ChangeLog.API. It would be totally cool if you could find places in Gaim that are doing this complicated loop and simplify it to use this new function. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:29:26
|
Patches item #1227165, was opened at 2005-06-24 13:00 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1227165&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Load new plugins at runtime Initial Comment: Hello. It would be great if gaim could add new plugins in the least that were added while gaim was running. It is a one-liner, it calls gaim_plugin_probe, which is called at start-up from the core just once. This patch makes the call when the preferences-page is being loaded (since that's the only way a user can enable the new plugin anyway), and gaim_plugin_probe does nothing about the plugins that were already loaded earlier. [This patch is in no way connected to "[1226022] Reload modified plugins at runtime" :) ] -- Adil ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:29 Message: Logged In: YES user_id=156487 Thanks. ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-24 13:05 Message: Logged In: YES user_id=1132702 >> It would be great if gaim could add new plugins in >> the least that were added while gaim was running. It would be great if gaim could add new plugins in the *list* that were added while gaim was running. -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1227165&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:14:52
|
Patches item #1231506, was opened at 2005-07-02 09:54 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Implementing gaim_accounts_get_all_active (HEAD) Initial Comment: Hello. gaim_accounts_get_all_active functions is declared in src/account.h which should return a list of active (enabled) accounts, but it is not implemented anywhere. This patch implements the function. -- Adil ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:14 Message: Logged In: YES user_id=156487 This patch is using GTK+ UI code in a core file. This breaks the core/ui split. I don't know what the plan is for that function. Unless you have a need for it, let the developer(s) working on status get to it. If you do have a need for it, talk to someone that knows what the status API is supposed to be like before implementing it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231506&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:10:41
|
Patches item #1231086, was opened at 2005-07-01 11:45 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231086&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) >Assigned to: Richard Laager (rlaager) Summary: Auto-complete in Pounce-dialog (HEAD) Initial Comment: Hello. This patch adds auto-complete functionality to the pounce-dialog. It uses the API function gaim_buddies_get_all introduced in patch#1231082. -- Adil ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:10 Message: Logged In: YES user_id=156487 I haven't tested this, but it looks good. However, I'd like it if you could auto-complete by aliases as well. That way we won't have autocomplete behaving in different ways in different parts of the application. Really, the code I wrote for gtkrequest.c needs to be tweaked so it can be exported in a generic way. Then, this dialog can use it as well. This may be non-trivial. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231086&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:04:35
|
Patches item #1231528, was opened at 2005-07-02 11:09 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231528&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) >Assigned to: Mark Doliner (thekingant) Summary: Oscar crash fix (?) (HEAD) Initial Comment: Hello. Gaim seems to be crashing when I enable an AIM account, and couple of seconds later, while it's still connecting, disable it. I have attached the backtrace and the patch which seems to have fixed the problem. -- Adil ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:04 Message: Logged In: YES user_id=156487 This looks pretty simple and safe, but I don't know for sure so I'm assigning it to Mark. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231528&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-07-03 05:02:38
|
Patches item #1230845, was opened at 2005-07-01 04:57 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1230845&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Richard Laager (rlaager) Summary: History Plugin: Show date of last log (HEAD) Initial Comment: Hello. This patch makes the history-plugin show the date the log was created on. (it gets kind of confusing at times without the date) (I don't know whether this is the appropriate place to submit this patch, but this plugin does come with the official package. So I thought I might submit here. I hope that's ok?) -- Adil ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:02 Message: Logged In: YES user_id=156487 I should've mentioned... I didn't apply this to oldstatus as I ended up making a variety of HEAD-only changes at the same time. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-07-03 00:01 Message: Logged In: YES user_id=156487 Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1230845&group_id=235 |
3 messages has been excluded from this view by a project administrator.
