[Gaim-patches] [ gaim-Patches-1231082 ] New API gaim_buddies_get_all (HEAD)

[SourceForge.net <no...@so...>]

Patches item #1231082, was opened at 2005-07-01 22:40
Message generated for change (Comment added) made by sadrul
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Sadrul H C (sadrul)
Assigned to: Nobody/Anonymous (nobody)
Summary: New API gaim_buddies_get_all (HEAD)

Initial Comment:
Hello.

This patch introduces a new function
gaim_buddies_get_all which returns a linked-list of the
buddies. It takes a boolean parameter to decide whether
to include buddies from un/dis-connected accounts.

A somewhat similar function gaim_get_blist does exist.
But it needs to be traversed in an ugly nested loop to
get a simple list. This patch removes the need for
that, and thus will possibly make a few other functions
(in src/gtkconv.c, src/gtkblist.c etc) simpler. It will
probably be useful for plugins as well.

-- Adil

----------------------------------------------------------------------

>Comment By: Sadrul H C (sadrul)
Date: 2005-07-03 14:49

Message:
Logged In: YES 
user_id=1132702

I have made some changes, so the functions in Gaim which
were using loops are now using this function.

It's somewhat of a big patch. But I don't think I've broken
anything here.

-- Adil

----------------------------------------------------------------------

Comment By: Sadrul H C (sadrul)
Date: 2005-07-03 11:50

Message:
Logged In: YES 
user_id=1132702

I think the sorting can be left to the caller. That
shouldn't be a prob.

>> It would be totally cool if you could find places in Gaim
that
>> are doing this complicated loop and simplify it to use this
>> new function. 
I plan on doing that actually :-)

I will modify the patch accordingly and resubmit it.

-- Adil

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-07-03 11:33

Message:
Logged In: YES 
user_id=156487

Is it necessary to do an insertion sort? Callers could sort the list if 
they wanted it sorted. 
 
The buddy pounce ChangeLog entry slipped into this patch. As for 
the other entry, changes to the API are documented in 
plugins/ChangeLog.API. 
 
It would be totally cool if you could find places in Gaim that are 
doing this complicated loop and simplify it to use this new 
function. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1231082&group_id=235