[phpslash-users] Re: Issues with skins

[Robin B. <ro...@ro...>]

Doh, you beat me to it! 

R. 

Joe Stewart writes: 

> Sorry to follow up my own post, but this will be fixed in just a couple of 
> minutes. 
> 
> The default wan't being applied to this exception. 
> 
>      if(@is_dir($templatedir . "/" . $HTTP_COOKIE_VARS['skin'])) {
>          debug("HTTP_COOKIE_VARS['skin']", $HTTP_COOKIE_VARS['skin']);
>          $new_skin=$HTTP_COOKIE_VARS['skin'];
>       } else {
>          $new_skin = $_PSL['defaultskin']; 
>       } 
> 
> 
> On Mon, Apr 29, 2002 at 03:36:02PM -0500, Joe Stewart wrote:
>> On Mon, Apr 29, 2002 at 09:10:27PM +0100, Robin Bowes wrote:
>> > Hi, 
>> > 
>> > Here's a couple of issues I've noticed with skins: 
>> > 
>> > 1. If the skin doesn't exist (template directory doesn't exist), an error is 
>> > returned. Perhaps phpSlash should check for the existence of the skin 
>> > (template) and use the default one if the skin (template) specified doesn't 
>> > exist? 
>> >  
>> 
>> This does happen - try ?skin=foo. 
>> 
>> > 2. Actually, 2. is a consequence of 1. If you have logged in and selected a 
>> > skin and the skin is subsequently removed then when you next access the site 
>> > you get an error. 
>> >  
>> 
>> This can be true.  It's supposed to be checking this as well.  I'll look 
>> a little closer. 
>> 
>> Maybe someone can see the folly below.  I'm a little stretched at the 
>> moment. 
>> 
>> The lines in functions.inc::setSkinTpl: 
>> 
>>    } elseif (!empty($HTTP_COOKIE_VARS['skin'])) {
>>       if(@is_dir($templatedir . "/" . $HTTP_COOKIE_VARS['skin'])) {
>>          $new_skin=$HTTP_COOKIE_VARS['skin'];
>>       }
>>    }  
>> 
>> Joe 
>> 
> 
> _______________________________________________
> phpslash-users mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpslash-users
 


 ---
Robin Bowes | ro...@ro...
http://www.robinbowes.com