Re: [Phpslash-devel] RC2: Block-admins parentage

[Joe S. <joe...@us...>]

On Wed, Feb 12, 2003 at 04:06:09PM +0000, Peter Cruickshank wrote:
> At 09:35 12/02/03 -0600, Joe Stewart wrote:
> >On Wed, Feb 12, 2003 at 11:02:16AM +0000, Peter Cruickshank wrote:
> >> 
> >> A snippet from Block_admin.class:
> 
> <snip>
> 
> >> 
> >> Shouldnt this last line be $this->Block_i()? or does Block_admin extend Block? Or is something tricksy going on?
> >> 
> >
> >Okay, I'm still hampered by cold medicine so not able to think too 
> >clearly :)
> >
> >It seems to be a little sloppiness on my part.  When Block_admin was split 
> >off from Block_i it looks like the constructor was cut and pasted instead 
> >of restructuring it to call the Block_i constructor.
> >
> >Probably the admin templates could be trimmed from Block_i and this->psl 
> >only should be in Block.class?
> 
> Yeah, that's what I've done in my Back-End converted version. I've also changed listblocktypes() to use the same templ object - needed templ->set_var(...'rows') changed to ...'addrows'.
>

Okay take a look at the changes:

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/phpslash/phpslash-ft/class/Block_admin.class.diff?r1=1.7&r2=1.8

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/phpslash/phpslash-ft/class/Block_admin.class.diff?r1=1.7&r2=1.8
 
> I hope you feel better soon :-)
> 

I think so but keep a close eye on the code :)

> P
> 
>