RE: [Phpgwtimetrack-developers] Addressbook problems (plus additional errata)

[Bob S. <bo...@pr...>]

Initial patch for addressbook is attached. It is the whole
index.php file from the addressbook directory. Place the
file into the <phpgroupware_dir>/addressbook directory.
I still need to also fix the view.php file in there to display
to company name properly.

I found the cause of this problem relates to the fact that
the SQL code I originally contributed to this code was doing
a cross join with a WHERE clause that specified 
WHERE addressbook.company_id = customers.company_id
this would fail if these weren't set, so I fixed it by
adding an "OR addressbook.company_id = ''", but then I
had to also test this id for 0 when printing the
company name. If it is zero, "Not Set" is printed in the
company field.

At some point, I would like to add a method to migrate any
older data, using the addressbook.company_name field to populate
the customers table, but I have also been toying with the idea
of redoing the whole customers schema to better match the iif
standard that Quickbooks uses for it's customers data, thereby
in essence reversing the current dependency of Timetrack on
addressbook code, instead focusing on the customers list, which
would then provide links to addressbook contacts inside the
customers list, instead of providing links to customers
inside the addressbook list. 

_____________________________
Bob Schader
CAD Systems Admin
Product Design Intl., Inc.
4880 36th St. SE, Suite 100
Grand Rapids, MI 49512
(616) 667-2600 x104