phpbt-dev — Developer's mailing list and cvs commits

[phpBT-dev] "bug 1 changed"

[Ken T. <ke...@to...>]

hi all,
 i have been experiencing a very unusual glitch lately, which has 
happened four times today!
 my phpbt installation (http://dev.conduet.org/phpbt) keeps sending me 
this email:

============================================================================
THIS MESSAGE WAS GENERATED BY THE BUGTRACKER SOFTWARE PLEASE DO NOT REPLY

INSTEAD FOLLOW BUG'S URL BELOW IN ORDER TO DETAIL BUG:
============================================================================
         Bug #: 1 (http://dev.conduet.org/phpbt/bug.php?op=show&bugid=1)
   Reported By: ke...@to...
----------------------------------------------------------------------------
       Summary: 1
           URL: 1
       Product: Conduet Kernel
       Version: HEAD
  To be Closed in Version: HEAD
        Closed in Version: HEAD
     Component: code
       Site(s): www.conduet.org
!       Status: New
    Resolution: Fixed
      Severity: Unassigned
    OS/Version: All
      Database: None
      Priority: 1 - Low
   Assigned To: ke...@to...
============================================================================


I am listed as to: twice, indicating that the bug was modified from my 
account.

I have not loaded any phpbt pages today, so I am certain that I never 
did this. What's with "1" over and
over? I'll try to go through the logs, see who's connecting, and what 
they're doing. Also, this change that is mailed to me -- it doesn't ever 
get committed to the database! I know that *someone* must be accessing 
the site, and doing *something*, because php scripts on http servers 
just don't do this kind of thing on their own. :-/

Feel free to screw around with that tracker -- nothing's happening there.

Ken

[phpBT-dev] CVS: phpbt/admin project.php,1.45,1.46

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv25307/admin

Modified Files:
	project.php 
Log Message:
eww, it looks like i broke the project admin interface :-[
added missing global $perm statements; changed 8-space to tab.


Index: project.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/project.php,v
retrieving revision 1.45
retrieving revision 1.46
diff -u -r1.45 -r1.46
--- project.php	9 Apr 2003 18:27:44 -0000	1.45
+++ project.php	7 Jun 2003 02:52:24 -0000	1.46
@@ -27,9 +27,9 @@
 include 'include.php';
 
 function del_version($versionid, $projectid) {
-	global $db, $me;
+	global $db, $me, $perm;
 
-        $perm->check_proj($projectid);
+	$perm->check_proj($projectid);
 
 	if (!$db->getOne('select count(*) from '.TBL_BUG." where version_id = $versionid")) {
 		$db->query("delete from ".TBL_VERSION." where version_id = $versionid");
@@ -40,7 +40,7 @@
 function save_version($version_id = 0) {
 	global $db, $me, $_pv, $STRING, $now, $u, $t, $perm;
 
-        $perm->check_proj($projectid);
+	$perm->check_proj($projectid);
 
 	$error = '';
 	// Validation
@@ -88,7 +88,7 @@
 function del_component($componentid, $projectid) {
 	global $db, $me, $perm;
 
-        $perm->check_proj($projectid);
+	$perm->check_proj($projectid);
 
 	if (!$db->getOne('select count(*) from '.TBL_BUG." where component_id = $componentid")) {
 		$db->query("delete from ".TBL_COMPONENT." where component_id = $componentid");
@@ -99,7 +99,7 @@
 function save_component($component_id = 0) {
 	global $db, $me, $_pv, $u, $STRING, $now, $t, $perm;
 
-        $perm->check_proj($projectid);
+	$perm->check_proj($projectid);
 
 	$error = '';
 	// Validation
@@ -150,7 +150,7 @@
 function save_project($projectid = 0) {
   global $db, $me, $u, $STRING, $now, $_pv, $perm;
 
-  $perm->check_proj($projectid);
+	$perm->check_proj($projectid);
 
 	$error = '';
   // Validation

[phpBT-dev] CVS: phpbt/inc functions.php,1.40,1.41

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/inc
In directory sc8-pr-cvs1:/tmp/cvs-serv29275/inc

Modified Files:
	functions.php 
Log Message:
logged-in users receive X results depending on what they set as def_results
  this satisfies rfe # 743683


Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- functions.php	19 Apr 2003 18:12:39 -0000	1.40
+++ functions.php	4 Jun 2003 19:16:40 -0000	1.41
@@ -274,7 +274,7 @@
 ///
 /// Divide the results of a database query into multiple pages
 function multipages($nr, $page, $urlstr) {
-  global $me, $selrange, $t;
+  global $me, $selrange, $t, $u, $db, $perm;
 
   $pages = '';
   if (!$page) $page = 1;
@@ -283,7 +283,8 @@
     $llimit = 0;
     $page = 0;
   } else {
-    #$selrange = 60;
+    if ($perm->check_auth('group', 'Users'))
+		$selrange = $db->getOne('select def_results from '.TBL_USER_PREF.' where user_id = '.$u);
     $llimit = ($page-1)*$selrange;
   }
   if ($nr) $npages = ceil($nr/$selrange);

[phpBT-dev] CVS: phpbt/templates/default user.html,1.9,1.10

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/templates/default
In directory sc8-pr-cvs1:/tmp/cvs-serv6144/templates/default

Modified Files:
	user.html 
Log Message:
finished storage handler for user's default #-of-results returned
discovered and fixed bug in user preferences page ("set" appeared many times)
pushed db_version pointer up to 3, adding def_results to TBL_USER_PREF
   - updated schemas
   - update.php
languages for def_results



Index: user.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/user.html,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- user.html	18 Jun 2002 16:36:21 -0000	1.9
+++ user.html	4 Jun 2003 18:47:21 -0000	1.10
@@ -40,6 +40,10 @@
 			<td><input type="checkbox" name="preferences[]" value="{$preferences[pref].pref}" {if $preferences[pref].checked}checked{/if}></td>
 		    </tr>
 {/section}
+			<tr>
+				<td>{$STRING.USER_PREF.DefResults}</td>
+				<td><input type="text" name="def_results" value="{$def_results}" size="4"></td>
+			</tr>
 		    <tr>
 			<td colspan="2" align="center"><br>
 			    <input type="reset"> <input type="submit" value="Submit"></td>

[phpBT-dev] CVS: phpbt/languages en.php,1.37,1.38

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/languages
In directory sc8-pr-cvs1:/tmp/cvs-serv6144/languages

Modified Files:
	en.php 
Log Message:
finished storage handler for user's default #-of-results returned
discovered and fixed bug in user preferences page ("set" appeared many times)
pushed db_version pointer up to 3, adding def_results to TBL_USER_PREF
   - updated schemas
   - update.php
languages for def_results



Index: en.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/languages/en.php,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- en.php	1 Apr 2003 21:39:43 -0000	1.37
+++ en.php	4 Jun 2003 18:47:20 -0000	1.38
@@ -225,7 +225,8 @@
 		'Votes' => 'Votes',
 		'Bug' => 'Bug',
 		'When' => 'When',
-		'ColumnPreferencesSaved' => 'Your bug list column preferences have been saved'
+		'ColumnPreferencesSaved' => 'Your bug list column preferences have been saved',
+		'DefResults' => 'Number of results on query page:'
 	),
 	'INDEX' => array(
 		'FiveRecentlySubmitted' => 'Five most recently submitted bugs',

[phpBT-dev] CVS: phpbt/schemas mysql.in,1.40,1.41 oci8.in,1.24,1.25 pgsql.in,1.42,1.43

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/schemas
In directory sc8-pr-cvs1:/tmp/cvs-serv6144/schemas

Modified Files:
	mysql.in oci8.in pgsql.in 
Log Message:
finished storage handler for user's default #-of-results returned
discovered and fixed bug in user preferences page ("set" appeared many times)
pushed db_version pointer up to 3, adding def_results to TBL_USER_PREF
   - updated schemas
   - update.php
languages for def_results



Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- mysql.in	7 May 2003 14:32:06 -0000	1.40
+++ mysql.in	4 Jun 2003 18:47:20 -0000	1.41
@@ -246,6 +246,7 @@
     user_id int(11) NOT NULL default '0',
     email_notices tinyint(1) NOT NULL default '1',
     saved_queries tinyint(1) NOT NULL default '1',
+    def_results int(11) NOT NULL default '20',
     PRIMARY KEY (user_id)
 ) TYPE=MyISAM;
 

Index: oci8.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/oci8.in,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- oci8.in	14 May 2003 00:13:27 -0000	1.24
+++ oci8.in	4 Jun 2003 18:47:21 -0000	1.25
@@ -250,7 +250,8 @@
     user_id number(10) default '0' NOT NULL,
     email_notices number(1) default '1' NOT NULL,
     saved_queries number(1) default '1' NOT NULL,
-    PRIMARY KEY (user_id)
+    def_results number(10) default '20' NOT NULL,
+	PRIMARY KEY (user_id)
 );
 
 CREATE TABLE TBL_VERSION (

Index: pgsql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/pgsql.in,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- pgsql.in	14 May 2003 00:13:27 -0000	1.42
+++ pgsql.in	4 Jun 2003 18:47:21 -0000	1.43
@@ -243,7 +243,8 @@
     user_id INT4 NOT NULL DEFAULT '0',
     email_notices INT2 NOT NULL DEFAULT '1',
     saved_queries INT2 NOT NULL DEFAULT '1',
-    PRIMARY KEY (user_id)
+    def_results INT4 NOT NULL DEFAULT '20',
+	PRIMARY KEY (user_id)
 );
 
 CREATE TABLE TBL_VERSION (

[phpBT-dev] CVS: phpbt config.php,1.36,1.37 upgrade.php,1.33,1.34 user.php,1.27,1.28

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv6144

Modified Files:
	config.php upgrade.php user.php 
Log Message:
finished storage handler for user's default #-of-results returned
discovered and fixed bug in user preferences page ("set" appeared many times)
pushed db_version pointer up to 3, adding def_results to TBL_USER_PREF
   - updated schemas
   - update.php
languages for def_results



Index: config.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config.php,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- config.php	19 Apr 2003 18:12:36 -0000	1.36
+++ config.php	4 Jun 2003 18:47:19 -0000	1.37
@@ -37,7 +37,7 @@
 
 // Database Table Config
 // you can change either the prefix of the table names or each table name individually
-define ('DB_VERSION', 2); // the version of the database
+define ('DB_VERSION', 3); // the version of the database
 define ('TBL_PREFIX', '');	// the prefix for all tables, leave empty to use the old style
 define ('TBL_ACTIVE_SESSIONS', TBL_PREFIX.'active_sessions');
 define ('TBL_DB_SEQUENCE',     TBL_PREFIX.'db_sequence');

Index: upgrade.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/upgrade.php,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- upgrade.php	19 Apr 2003 18:12:37 -0000	1.33
+++ upgrade.php	4 Jun 2003 18:47:19 -0000	1.34
@@ -45,10 +45,15 @@
 				$db->query("create table if not exists ".TBL_PROJECT_PERM." ( project_id int(11) NOT NULL default '0', user_id int(11) NOT NULL default '0' )");
 				if ($thisvers < 2)
 					$db->query("alter table ".TBL_AUTH_GROUP." ADD assignable TINYINT DEFAULT 0 NOT NULL AFTER locked");
+				if ($thisvers < 3)
+					$db->query("ALTER TABLE ".TBL_USER_PREF." ADD def_results INT DEFAULT '20' NOT NULL");
 				break;
+			case 'pgsql' :
+				//! Missing Alter/Create's
 			case 'oci8' :
 				$db->query("create table ".TBL_PROJECT_PERM." ( project_id number(10) default '0' NOT NULL, user_id number(10) default '0' NOT NULL )");
 				//! TBL_AUTH_GROUP
+				//! TBL_USER_PERM.def_results (see mysql)
 				break;
 		}
 
@@ -60,10 +65,6 @@
 			$db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('DB_VERSION', '".DB_VERSION."', 'Database Version <b>Warning:</b> Changing this might make things go horribly wrong.', 'string')");
 		}
 
-		if ($thisvers < 3) {
-
-		}
-
 		/* update to current DB_VERSION */
 		$db->query("UPDATE ".TBL_CONFIGURATION." SET varvalue = '".DB_VERSION."' WHERE varname = 'DB_VERSION'");
 
@@ -77,4 +78,4 @@
 	include 'templates/default/upgrade.html';
 }
 
-?>
\ No newline at end of file
+?>

Index: user.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/user.php,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- user.php	18 Jun 2002 16:36:21 -0000	1.27
+++ user.php	4 Jun 2003 18:47:19 -0000	1.28
@@ -77,14 +77,18 @@
     array_shift($old_prefs); // Drop the user_id field
     $updates = array();
     foreach ($old_prefs as $pref => $val) {
+	if ($pref == 'def_results') continue;
 	if (in_array($pref, $prefs) and !$val) {
-	    $updates[] = "set $pref = 1";
+	    $updates[] = "$pref = 1";
 	} elseif (!in_array($pref, $prefs) and $val) {
-	    $updates[] = "set $pref = 0";
+	    $updates[] = "$pref = 0";
 	}
     }
+
+	$updates[] = 'def_results = '.(int)$prefs['def_results']; // override previous set
+	
     if (count($updates)) {
-	$db->query("update ".TBL_USER_PREF.' '.@join(', ', $updates).
+	$db->query("update ".TBL_USER_PREF.' set '.@join(', ', $updates).
 	    " where user_id = $u");
     }
 
@@ -104,7 +108,7 @@
     $pref_labels = array(
 	'email_notices' => $STRING['USER_PREF']['ReceiveNotifications'],
 	'saved_queries' => $STRING['USER_PREF']['ShowSavedQueries']
-    );
+	);
     
     $prefs = $db->getRow("select * from ".TBL_USER_PREF." where user_id = $u");
     foreach ($pref_labels as $pref => $label) {
@@ -113,14 +117,17 @@
 	    'label' => $label,
 	    'checked' => $prefs[$pref]
 	);
-    }
+	}
+	
+	$def_results = $prefs['def_results'];
 
     $t->assign(array(
 	'error' => $error,
 	'my_fields' => $_sv['db_fields'] ? $_sv['db_fields'] : $default_db_fields,
 	'field_titles' => $all_db_fields,
-	'preferences' => $preferences
-    ));
+	'preferences' => $preferences,
+    'def_results' => $def_results
+	));
 		
     $t->wrap('user.html', 'preferences');
 }
@@ -142,7 +149,7 @@
 	    change_bug_list_columns($_pv['column_list']);
 	break;
 	case 'changeprefs':
-	    change_preferences(isset($_pv['preferences']) ? $_pv['preferences'] : array());
+	    change_preferences(isset($_pv['preferences']) ? array_merge($_pv['preferences'], array('def_results' => $_pv['def_results'])) : array());
 	break;
 	default:
 	    show_preferences_form();

Re: [phpBT-dev] CVS: phpbt bug.php,1.129,1.130

[Ken T. <ke...@to...>]

php...@be... wrote:

>Ah, I see - I didn't notice the filename -- just the code.
>  
>
Still, it's not the greatest solution. A better result would be bug.php 
outputting an error message *and* filing the bug (minus attachment)

Ken

>On Sun, Jun 01, 2003 at 04:13:13PM -0400, Ken Tossell wrote:
>  
>
>>That's not what this patch does -- it simply fails silently when an 
>>attachement is done *at bug creation* -- not when the attachment link is 
>>used (in which case it's controlled by attachment.php)
>>    
>>
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: eBay
>Get office equipment for less on eBay!
>http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
>_______________________________________________
>phpbt-dev mailing list
>php...@li...
>https://lists.sourceforge.net/lists/listinfo/phpbt-dev
>  
>

Re: [phpBT-dev] CVS: phpbt bug.php,1.129,1.130

[<php...@be...>]

Ah, I see - I didn't notice the filename -- just the code.

On Sun, Jun 01, 2003 at 04:13:13PM -0400, Ken Tossell wrote:
> 
> That's not what this patch does -- it simply fails silently when an 
> attachement is done *at bug creation* -- not when the attachment link is 
> used (in which case it's controlled by attachment.php)

Re: [phpBT-dev] CVS: phpbt bug.php,1.129,1.130

[Ken T. <ke...@to...>]

php...@be... wrote:

>This update needs to be reverted.  Error messages need to be shown to
>users when attaching something to an existing bug.  If you want to not
>fail bug creation due to an attachment problem, then some logic needs to
>be added to handle just that case.  
>

>Removing all error messages for any
>attachment is not the way to do it.
>  
>
That's not what this patch does -- it simply fails silently when an 
attachement is done *at bug creation* -- not when the attachment link is 
used (in which case it's controlled by attachment.php)

>On Sun, Jun 01, 2003 at 11:18:49AM -0700, Ken Tossell wrote:
>  
>
>>Update of /cvsroot/phpbt/phpbt
>>In directory sc8-pr-cvs1:/tmp/cvs-serv26267
>>
>>Modified Files:
>>	bug.php 
>>Log Message:
>>let bug entry succeed with attachment errors
>>
>>
>>Index: bug.php
>>===================================================================
>>RCS file: /cvsroot/phpbt/phpbt/bug.php,v
>>retrieving revision 1.129
>>retrieving revision 1.130
>>diff -u -r1.129 -r1.130
>>--- bug.php	18 May 2003 23:40:22 -0000	1.129
>>+++ bug.php	1 Jun 2003 18:18:46 -0000	1.130
>>@@ -464,14 +464,12 @@
>> 
>> 	if (!isset($HTTP_POST_FILES['attachment']) ||
>> 		$HTTP_POST_FILES['attachment']['tmp_name'] == 'none') {
>>-		show_attachment_form($bugid, $STRING['give_attachment']);
>> 		return;
>> 	}
>> 
>> 	// Check the upload size.  If the size was greater than the max in
>> 	// php.ini, the file won't even be set and will fail at the check above
>> 	if ($HTTP_POST_FILES['attachment']['size'] > ATTACHMENT_MAX_SIZE) {
>>-		show_attachment_form($bugid, $STRING['attachment_too_large']);
>> 		return;
>> 	}
>> 
>>@@ -487,7 +485,6 @@
>> 		"and a.bug_id = b.bug_id");
>> 	while ($rs->fetchInto($ainfo)) {
>> 		if ($bugid == $ainfo['bug_id'] && $projectid == $ainfo['project_id']) {
>>-			show_attachment_form($bugid, $STRING['dupe_attachment']);
>> 			return;
>> 		}
>> 	}
>>@@ -497,12 +494,10 @@
>> 	$filename = "$bugid-{$HTTP_POST_FILES['attachment']['name']}";
>> 
>> 	if (!is_dir($filepath)) {
>>-		show_attachment_form($bugid, $STRING['no_attachment_save_path']);
>> 		return;
>> 	}
>> 
>> 	if (!is_writeable($filepath)) {
>>-		show_attachment_form($bugid, $STRING['attachment_path_not_writeable']);
>> 		return;
>> 	}
>> 
>>@@ -512,7 +507,6 @@
>> 
>> 	if (!@move_uploaded_file($HTTP_POST_FILES['attachment']['tmp_name'],
>> 		"$filepath/$projectid/$filename")) {
>>-		show_attachment_form($bugid, $STRING['attachment_move_error']);
>> 		return;
>> 	}
>> 
>>
>>
>>
>>-------------------------------------------------------
>>This SF.net email is sponsored by: eBay
>>Get office equipment for less on eBay!
>>http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
>>_______________________________________________
>>phpbt-dev mailing list
>>php...@li...
>>https://lists.sourceforge.net/lists/listinfo/phpbt-dev
>>    
>>
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: eBay
>Get office equipment for less on eBay!
>http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
>_______________________________________________
>phpbt-dev mailing list
>php...@li...
>https://lists.sourceforge.net/lists/listinfo/phpbt-dev
>  
>

Re: [phpBT-dev] CVS: phpbt bug.php,1.129,1.130

[<php...@be...>]

This update needs to be reverted.  Error messages need to be shown to
users when attaching something to an existing bug.  If you want to not
fail bug creation due to an attachment problem, then some logic needs to
be added to handle just that case.  Removing all error messages for any
attachment is not the way to do it.

On Sun, Jun 01, 2003 at 11:18:49AM -0700, Ken Tossell wrote:
> Update of /cvsroot/phpbt/phpbt
> In directory sc8-pr-cvs1:/tmp/cvs-serv26267
> 
> Modified Files:
> 	bug.php 
> Log Message:
> let bug entry succeed with attachment errors
> 
> 
> Index: bug.php
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/bug.php,v
> retrieving revision 1.129
> retrieving revision 1.130
> diff -u -r1.129 -r1.130
> --- bug.php	18 May 2003 23:40:22 -0000	1.129
> +++ bug.php	1 Jun 2003 18:18:46 -0000	1.130
> @@ -464,14 +464,12 @@
>  
>  	if (!isset($HTTP_POST_FILES['attachment']) ||
>  		$HTTP_POST_FILES['attachment']['tmp_name'] == 'none') {
> -		show_attachment_form($bugid, $STRING['give_attachment']);
>  		return;
>  	}
>  
>  	// Check the upload size.  If the size was greater than the max in
>  	// php.ini, the file won't even be set and will fail at the check above
>  	if ($HTTP_POST_FILES['attachment']['size'] > ATTACHMENT_MAX_SIZE) {
> -		show_attachment_form($bugid, $STRING['attachment_too_large']);
>  		return;
>  	}
>  
> @@ -487,7 +485,6 @@
>  		"and a.bug_id = b.bug_id");
>  	while ($rs->fetchInto($ainfo)) {
>  		if ($bugid == $ainfo['bug_id'] && $projectid == $ainfo['project_id']) {
> -			show_attachment_form($bugid, $STRING['dupe_attachment']);
>  			return;
>  		}
>  	}
> @@ -497,12 +494,10 @@
>  	$filename = "$bugid-{$HTTP_POST_FILES['attachment']['name']}";
>  
>  	if (!is_dir($filepath)) {
> -		show_attachment_form($bugid, $STRING['no_attachment_save_path']);
>  		return;
>  	}
>  
>  	if (!is_writeable($filepath)) {
> -		show_attachment_form($bugid, $STRING['attachment_path_not_writeable']);
>  		return;
>  	}
>  
> @@ -512,7 +507,6 @@
>  
>  	if (!@move_uploaded_file($HTTP_POST_FILES['attachment']['tmp_name'],
>  		"$filepath/$projectid/$filename")) {
> -		show_attachment_form($bugid, $STRING['attachment_move_error']);
>  		return;
>  	}
>  
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: eBay
> Get office equipment for less on eBay!
> http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev

[phpBT-dev] CVS: phpbt bug.php,1.129,1.130

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv26267

Modified Files:
	bug.php 
Log Message:
let bug entry succeed with attachment errors


Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.129
retrieving revision 1.130
diff -u -r1.129 -r1.130
--- bug.php	18 May 2003 23:40:22 -0000	1.129
+++ bug.php	1 Jun 2003 18:18:46 -0000	1.130
@@ -464,14 +464,12 @@
 
 	if (!isset($HTTP_POST_FILES['attachment']) ||
 		$HTTP_POST_FILES['attachment']['tmp_name'] == 'none') {
-		show_attachment_form($bugid, $STRING['give_attachment']);
 		return;
 	}
 
 	// Check the upload size.  If the size was greater than the max in
 	// php.ini, the file won't even be set and will fail at the check above
 	if ($HTTP_POST_FILES['attachment']['size'] > ATTACHMENT_MAX_SIZE) {
-		show_attachment_form($bugid, $STRING['attachment_too_large']);
 		return;
 	}
 
@@ -487,7 +485,6 @@
 		"and a.bug_id = b.bug_id");
 	while ($rs->fetchInto($ainfo)) {
 		if ($bugid == $ainfo['bug_id'] && $projectid == $ainfo['project_id']) {
-			show_attachment_form($bugid, $STRING['dupe_attachment']);
 			return;
 		}
 	}
@@ -497,12 +494,10 @@
 	$filename = "$bugid-{$HTTP_POST_FILES['attachment']['name']}";
 
 	if (!is_dir($filepath)) {
-		show_attachment_form($bugid, $STRING['no_attachment_save_path']);
 		return;
 	}
 
 	if (!is_writeable($filepath)) {
-		show_attachment_form($bugid, $STRING['attachment_path_not_writeable']);
 		return;
 	}
 
@@ -512,7 +507,6 @@
 
 	if (!@move_uploaded_file($HTTP_POST_FILES['attachment']['tmp_name'],
 		"$filepath/$projectid/$filename")) {
-		show_attachment_form($bugid, $STRING['attachment_move_error']);
 		return;
 	}
 

[phpBT-dev] milestones

[Ken T. <ke...@to...>]

i know you can assign "to be closed in" by version, but that's often not 
the nicest way. how about a separate milestone table with separate 
relations? for example, people could define M1, M2, M3, where Mx is 
version independent, based on time, or functionality. this just came up 
when trying to use phpbt as a task manager -- i'll see about 
implementing it a bit later. :-)

writing this reminds me about bftm, my new phpbt site :) i'll try to get 
that working soon, too, though finals might throw it off just a little 
bit >;-)

ken
http://kennyt.com/

ps. see my ub3r1337 install of phpbt at http://kennyt.com/tools/bugs

[phpBT-dev] CVS: phpbt attachment.php,1.20,1.21

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv24275

Modified Files:
	attachment.php 
Log Message:
Patch from Paul Duncan for improving attachment download with IE 5

Index: attachment.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/attachment.php,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- attachment.php	28 Oct 2002 22:03:21 -0000	1.20
+++ attachment.php	20 May 2003 03:08:01 -0000	1.21
@@ -164,10 +164,15 @@
 	}
 } elseif (isset($_pv['submit'])) {
 	$perm->check('Editbug');
-	add_attachment($_pv['bugid'],	$_pv['description']);
+	add_attachment($_pv['bugid'], $_pv['description']);
 } elseif (isset($_gv['attachid'])) {
 	if (list($filename, $mimetype) = grab_attachment($_gv['attachid'])) {
-		header("Content-type: $mimetype");
+		$base = basename($filename);
+		header("Content-Disposition: attachment; filename=\"$base\"");
+		header("Content-Type: $mimetype");
+		header("Connection: close");
+		header("Pragma: nocache");
+		header("Expires: 0 ");
 		@readfile($filename);
 		exit;
 	}

[phpBT-dev] The Future of phpBT

[Ken T. <ke...@to...>]

Hi,
 Do any of you have plans for features to write prior to rolling 1.0? This 
email interface -- I do not think that it should be a release blocker. 
But that's just MHO. I have been asking people about what they might like 
-- or what's in Bugzilla but not phpBT. Certainly, a BZ->phpBT conversion 
script would be very cool, but it has the potential to ruin peoples' 
impressions if there should be any tiny error, and they happen to have a 
non-standard BZ setup. These problems can be avoided with *lots* of 
testing, of course. :-)

 I'd like to talk to some of you, and the spirit could use a little 
prodding ;-) so why don't we meet on IRC? Yes, IRC. It really is the best 
place. How about irc.freenode.net , #phpbt ? When? Heh, I'm always 
connected :-D

See you there,
 Ken

-- 
Ken Tossell
ken at tossell dot net
http://www.kennyt.com/
washington, dc / gmt -4
"capital(world::free);"

[phpBT-dev] CVS: phpbt bug.php,1.128,1.129

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv27108

Modified Files:
	bug.php 
Log Message:
email the person who made the changes. we can make this *not* done by request.


Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.128
retrieving revision 1.129
diff -u -r1.128 -r1.129
--- bug.php	12 May 2003 22:26:26 -0000	1.128
+++ bug.php	18 May 2003 23:40:22 -0000	1.129
@@ -246,6 +246,7 @@
 	$reporter = $db->getOne('select email from '.TBL_AUTH_USER.
 		" u, ".TBL_USER_PREF." p where u.user_id = {$buginfo['created_by']} ".
 		"and u.user_id = p.user_id and email_notices = 1");
+
 	$reporterstat = ' ';
 
 	// If there are new comments grab the comments immediately before the latest
@@ -290,13 +291,9 @@
 
 	$maillist = array();
 
-	// Don't email the person who just made the changes (later, make this
-	// behavior toggable by the user)
-	if ($userid != $buginfo['created_by'] and !empty($reporter)) {
-		$maillist[] = $reporter;
-	}
-	if ($userid != (!empty($cf['assigned_to']) ? $cf['assigned_to'] : $buginfo['assigned_to'])
-		and !empty($assignedto) and $emailassignedto) {
+	$maillist[] = $reporter;
+
+	if (!empty($assignedto) and $emailassignedto) {
 	    $maillist[] = $assignedto;
 	}
 

[phpBT-dev] CVS: phpbt README,1.3,1.4

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv14738

Modified Files:
	README 
Log Message:
updated dmbs's and added MagicQuotes requirement.


Index: README
===================================================================
RCS file: /cvsroot/phpbt/phpbt/README,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- README	15 Dec 2001 19:17:09 -0000	1.3
+++ README	18 May 2003 23:23:26 -0000	1.4
@@ -21,7 +21,9 @@
 
 Here is a list of the requirements to get this running on your server.
 1. A webserver
-2. PHP
-3. A database - Currently MySQL and PostgreSQL have been tested,
+2. PHP with support for your database and MagicQuotes. PHP by default
+   with MySQL support. *Without MagicQuotes, escaping in comments will
+   not work correctly.
+3. A database - Currently MySQL, Oracle and PostgreSQL have been tested,
    though the goal is to be database independent.  The query routine is a 
 	 notable exception to that goal at the moment. 

[phpBT-dev] CVS: phpbt/schemas oci8.in,1.23,1.24 pgsql.in,1.41,1.42

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/schemas
In directory sc8-pr-cvs1:/tmp/cvs-serv1069/schemas

Modified Files:
	oci8.in pgsql.in 
Log Message:
These need to disappear -- they're no longer respected.


Index: oci8.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/oci8.in,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- oci8.in	9 Apr 2003 12:25:20 -0000	1.23
+++ oci8.in	14 May 2003 00:13:27 -0000	1.24
@@ -336,7 +336,6 @@
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_ASSIGNED','3','The status to assign a bug when it is assigned.','multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_REOPENED','4','The status to assign a bug when it is reopened.','multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_CLOSED','7','The status to assign a bug when it is closed.','multi');
-INSERT INTO TBL_CONFIGURATION VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');
 
 INSERT INTO TBL_OS VALUES (1,'All',1,'');

Index: pgsql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/pgsql.in,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -r1.41 -r1.42
--- pgsql.in	9 Apr 2003 12:25:21 -0000	1.41
+++ pgsql.in	14 May 2003 00:13:27 -0000	1.42
@@ -333,7 +333,6 @@
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_ASSIGNED','3','The status to assign a bug when it is assigned.','multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_REOPENED','4','The status to assign a bug when it is reopened.','multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_CLOSED','7','The status to assign a bug when it is closed.','multi');
-INSERT INTO TBL_CONFIGURATION VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');
 
 INSERT INTO TBL_OS VALUES (1,'All',1,'');

[phpBT-dev] CVS: phpbt install.php,1.36,1.37

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv29828

Modified Files:
	install.php 
Log Message:
added tbl_project_perm translation (new installs were getting phpbt_project_PERM as table name)


Index: install.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/install.php,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- install.php	9 Apr 2003 12:11:44 -0000	1.36
+++ install.php	12 May 2003 23:18:37 -0000	1.37
@@ -84,6 +84,7 @@
 		'/TBL_OS/' => $_pv['tbl_prefix'].'os',
 		'/TBL_PROJECT_GROUP/' => $_pv['tbl_prefix'].'project_group',
 		'/TBL_PROJECT/' => $_pv['tbl_prefix'].'project',
+		'/TBL_PROJECT_PERM/' => $_pv['tbl_prefix'].'project_perm',
 		'/TBL_RESOLUTION/'  => $_pv['tbl_prefix'].'resolution',
 		'/TBL_SAVED_QUERY/' => $_pv['tbl_prefix'].'saved_query',
 		'/TBL_SEVERITY/' => $_pv['tbl_prefix'].'severity',

[phpBT-dev] upload attachment from bug entry page

[Ken T. <ke...@to...>]

hi,
 this feature has been implemented and was just checked into cvs. it 
works for me :-) if you have a problem, open up bug 520018

kennyt

[phpBT-dev] CVS: phpbt bug.php,1.127,1.128

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv10456

Modified Files:
	bug.php 
Log Message:
Attachments can now be added in the enter-bug page.
 This satisfies feature request #520018


Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.127
retrieving revision 1.128
diff -u -r1.127 -r1.128
--- bug.php	4 Apr 2003 13:07:12 -0000	1.127
+++ bug.php	12 May 2003 22:26:26 -0000	1.128
@@ -462,6 +462,80 @@
 	header("Location: bug.php?op=show&bugid=$bugid&pos=$pos");
 }
 
+function add_attachment($bugid, $description) {
+	global $db, $HTTP_POST_FILES, $now, $u, $STRING, $t, $_pv;
+
+	if (!isset($HTTP_POST_FILES['attachment']) ||
+		$HTTP_POST_FILES['attachment']['tmp_name'] == 'none') {
+		show_attachment_form($bugid, $STRING['give_attachment']);
+		return;
+	}
+
+	// Check the upload size.  If the size was greater than the max in
+	// php.ini, the file won't even be set and will fail at the check above
+	if ($HTTP_POST_FILES['attachment']['size'] > ATTACHMENT_MAX_SIZE) {
+		show_attachment_form($bugid, $STRING['attachment_too_large']);
+		return;
+	}
+
+	$projectid = $db->getOne("select project_id from ".TBL_BUG." where bug_id = $bugid");
+	if (!$projectid) {
+		show_text($STRING['nobug'], true);
+		return;
+	}
+
+	// Check for a previously-uploaded attachment with the same name, bug, and project
+	$rs = $db->query("select a.bug_id, project_id from ".TBL_ATTACHMENT." a, ".
+		TBL_BUG." b where file_name = '{$HTTP_POST_FILES['attachment']['name']}' ".
+		"and a.bug_id = b.bug_id");
+	while ($rs->fetchInto($ainfo)) {
+		if ($bugid == $ainfo['bug_id'] && $projectid == $ainfo['project_id']) {
+			show_attachment_form($bugid, $STRING['dupe_attachment']);
+			return;
+		}
+	}
+
+	$filepath = ATTACHMENT_PATH;
+	$tmpfilename = $HTTP_POST_FILES['attachment']['tmp_name'];
+	$filename = "$bugid-{$HTTP_POST_FILES['attachment']['name']}";
+
+	if (!is_dir($filepath)) {
+		show_attachment_form($bugid, $STRING['no_attachment_save_path']);
+		return;
+	}
+
+	if (!is_writeable($filepath)) {
+		show_attachment_form($bugid, $STRING['attachment_path_not_writeable']);
+		return;
+	}
+
+	if (!is_dir("$filepath/$projectid")) {
+		@mkdir("$filepath/$projectid", 0775);
+	}
+
+	if (!@move_uploaded_file($HTTP_POST_FILES['attachment']['tmp_name'],
+		"$filepath/$projectid/$filename")) {
+		show_attachment_form($bugid, $STRING['attachment_move_error']);
+		return;
+	}
+
+	@chmod("$filepath/$projectid/$filename", 0766);
+	$db->query("insert into ".TBL_ATTACHMENT." (attachment_id, bug_id, file_name, ".
+		"description, file_size, mime_type, created_by, created_date) values (".
+		join(', ', array($db->nextId(TBL_ATTACHMENT), $bugid,
+			$db->quote($HTTP_POST_FILES['attachment']['name']),
+			$db->quote(stripslashes($description)),
+			$HTTP_POST_FILES['attachment']['size'],
+			$db->quote($HTTP_POST_FILES['attachment']['type']), $u, $now)).")");
+
+	if ($_pv['use_js']) {
+		$t->display('admin/edit-submit.html');
+	} else {
+		header("Location: bug.php?op=show&bugid=$bugid");
+	}
+}
+
+
 ///
 /// Move attachments from one project directory to another
 function move_attachments($bug_id, $old_project, $new_project) {
@@ -549,6 +623,9 @@
 		    "last_modified_by = $u, last_modified_date = $time ".
 		    "where bug_id = '$bugid'");
 	}
+
+	if (isset($_pv['at_description']))
+		add_attachment($bugid, $_pv['at_description']); //attachment (initial)
 
 	if (isset($another)) {
 		header("Location: $me?op=add&project=$project");

[phpBT-dev] CVS: phpbt/templates/default bugform.html,1.8,1.9

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/templates/default
In directory sc8-pr-cvs1:/tmp/cvs-serv10456/templates/default

Modified Files:
	bugform.html 
Log Message:
Attachments can now be added in the enter-bug page.
 This satisfies feature request #520018


Index: bugform.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugform.html,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- bugform.html	16 Sep 2002 19:04:35 -0000	1.8
+++ bugform.html	12 May 2003 22:26:27 -0000	1.9
@@ -1,4 +1,4 @@
-<form action="bug.php" method="post">
+<form action="bug.php" method="post" enctype="multipart/form-data">
     <input type="hidden" name="bugid" value="0">
     <input type="hidden" name="project" value="{$project}">
     <input type="hidden" name="op" value="do">
@@ -51,8 +51,37 @@
 	    <td><select name="os">{build_select box=os selected=$os}
 		</select></td>
 	</tr><tr>
-	    <td align="right" valign="top">{$STRING.BUGFORM.AddAnother}:</td>
-		<td valign="top"><input type="checkbox" name="another" value="1"></td>
+	    <td align="right">Attachment:</td>
+	    <td>
+<table border="0" align="center">
+        <tr>
+                <td colspan="2" align="center">
+                        Please choose a file to upload and enter a one-line description.
+                        <br>
+                        Maximum file size: {$max_size} bytes
+                        <br>
+                        <br>
+                </td>
+        </tr>
+        <tr>
+                <td>
+                        File:
+                </td>
+                <td>
+                        <input type="file" name="attachment">
+                </td>
+        </tr>
+        <tr>
+                <td>
+                        Description:
+                </td>
+                <td>
+                        <input type="text" name="at_description" maxlength="255" value="{$description}">
+                </td>
+        </tr>
+</table>
+
+	    </td>
 	</tr>
     </table>
     <input type="submit" name="submit" value="{$STRING.BUGFORM.Submit}">

[phpBT-dev] CVS: phpbt/schemas mysql.in,1.39,1.40

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/schemas
In directory sc8-pr-cvs1:/tmp/cvs-serv3920/schemas

Modified Files:
	mysql.in 
Log Message:
found this laying around :-\


Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -r1.39 -r1.40
--- mysql.in	9 Apr 2003 12:25:19 -0000	1.39
+++ mysql.in	7 May 2003 14:32:06 -0000	1.40
@@ -19,6 +19,7 @@
   group_id int(10) unsigned NOT NULL default '0',
   group_name varchar(80) NOT NULL default '',
   locked tinyint(1) unsigned NOT NULL default '0',
+  assignable tinyint(1) unsigned NOT NULL default '0',
   created_by int(10) unsigned NOT NULL default '0',
   created_date bigint(20) unsigned NOT NULL default '0',
   last_modified_by int(10) unsigned NOT NULL default '0',

[phpBT-dev] DB Update

[Ken T. <ke...@to...>]

Hi,
 Would someone who knows pg + oracle please update upgrade.php? I marked 
lines with //! where ALTER queries need to be run.

Ken

[phpBT-dev] CVS: phpbt/inc functions.php,1.39,1.40

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/inc
In directory sc8-pr-cvs1:/tmp/cvs-serv13800/inc

Modified Files:
	functions.php 
Log Message:
 * new database update model
    - database schema is versioned
 * new assignable-group declaration
    - each group has an assignable flag
    - configurable by admin/group.php
    - updated build_select's owner section


Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -r1.39 -r1.40
--- functions.php	7 Apr 2003 18:55:38 -0000	1.39
+++ functions.php	19 Apr 2003 18:12:39 -0000	1.40
@@ -151,7 +151,7 @@
 	    }
 		break;
 	case 'owner':
-	    $rs = $db->query("select u.user_id, login from ".TBL_AUTH_USER." u, ".TBL_USER_GROUP." ug where u.active > 0 and u.user_id = ug.user_id and ug.group_id = ".GROUP_ASSIGN_TO." order by login");
+	    $rs = $db->query("select u.user_id, login from ".TBL_AUTH_USER." u, ".TBL_USER_GROUP." ug, ".TBL_AUTH_GROUP." g where u.active > 0 and u.user_id = ug.user_id and ug.group_id = g.group_id and g.assignable > 0 order by login");
 	    while ($rs->fetchInto($row)) {
 			// either singular matches, or array matches are acceptable
 		if (($selected == $row['user_id']) || in_array($row['user_id'], $selected)) {