phpbt-dev — Developer's mailing list and cvs commits

[phpBT-dev] CVS administrivia

[<php...@be...>]

Please remember that we are currently branched for a version 1.0
release.  This means that all changes committed to the HEAD will not be
available in the 1.0 release unless they are committed to the branch as
well.  It is my hope that new feature additions will be kept to a
minimum on the branch as we should be trying to stabilize that code for
a release.

[phpBT-dev] Database changes

[<php...@be...>]

When making changes to the database schema, please make sure that you
change both mysql and pgsql schemas.  I'm not planning on actively
supporting oracle in the future, but it is critical that we keep the
other two schemas (and code in inc/db/*.php) in sync.

So, as a policy, then, whenever you make a change to one, please make
the same changes in the other, and don't commit either until both have
been modified.  Thanks!

Re: [phpBT-dev] phpbt's tracker

[<php...@be...>]

I have considered this in the past, but I haven't done it yet because of
the time that would be involved in maintaining it.  Of course you would
want it to be the latest version, but you would also want it to be very
stable, and that would require some effort.  Since I have very little
time to work on this project, so far I have hesitated to do this simply
because it would eat up some of that available time.  Another thing that
would take some time is writing a script to convert the sourceforge
artifacts for use with phpBT.  Finally, you'd have to determine what to
do with the artifacts submitted by 'nobody' since phpBT doesn't allow
for anonymous bug submission.

In theory, I like the idea of running phpBT for our own bugs -- it
simple gives a better impression.  However, to date I haven't been
willing to surrender the time required to make that happen.

On Wed, Jul 23, 2003 at 12:40:06PM -0400, Ken Tossell wrote:
> hey all,
> 
> what would you think of moving from the sf.net tracker to phpbt? i think 
> it'd be a good way to demo our product.
> 
> ken
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> Data Reports, E-commerce, Portals, and Forums are available now.
> Download today and enter to win an XBOX or Visual Studio .NET.
> http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev

[phpBT-dev] CVS: phpbt/inc functions.php,1.43,1.44

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/inc
In directory sc8-pr-cvs1:/tmp/cvs-serv3347/inc

Modified Files:
	functions.php 
Log Message:
okay, so maybe you don't want to ever really *close* bugs ;)


Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -r1.43 -r1.44
--- functions.php	24 Jul 2003 04:47:13 -0000	1.43
+++ functions.php	24 Jul 2003 04:57:00 -0000	1.44
@@ -581,7 +581,7 @@
 		$closed_statuses[] = (int)$row['status_id'];
 	}
 	
-	return '('.$column.' = '.join(' OR '.$column.' = ', $closed_statuses).')';
+	return '('.$column.' = '.(count($closed_statuses ? join(' OR '.$column.' = ', $closed_statuses) : '1')).')';
 }
 
 // Check whether or not a status-id means BUG_CLOSED

[phpBT-dev] CVS: phpbt/templates/default/admin status-edit.html,1.6,1.7

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv2810/templates/default/admin

Modified Files:
	status-edit.html 
Log Message:
eek, a little bit of debug code slipped through


Index: status-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/status-edit.html,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- status-edit.html	24 Jul 2003 04:47:13 -0000	1.6
+++ status-edit.html	24 Jul 2003 04:53:29 -0000	1.7
@@ -42,7 +42,7 @@
   <td><input type="text" size="3" maxlength="3" name="sort_order" value="{$sort_order}"></td>
 </tr>
 <tr>
-	<td align="right" valign="top">Bugs Are:{$bug_open}</td>
+	<td align="right" valign="top">Bugs Are:</td>
 	<td><input type="radio" name="bug_open" value="1"{if $bug_open neq 0} checked="checked"{/if}/>Open <input type="radio" name="bug_open" value="0"{if $bug_open eq 0} checked="checked"{/if}/>Closed</td>
 </tr>
 </table>

[phpBT-dev] CVS: phpbt/schemas mysql.in,1.41,1.42

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/schemas
In directory sc8-pr-cvs1:/tmp/cvs-serv1772/schemas

Modified Files:
	mysql.in 
Log Message:
Multiple statuses can now be set as 'open' or 'closed' -- no longer will 
just BUG_CLOSED show up in most-recently-closed-bugs, etc.

Admin ui allow reassigning open/closed bit to statuses. mysql DB 
touched, rolling to version 4.

Fixed install.php DB_VERSIONing problem.


Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -r1.41 -r1.42
--- mysql.in	4 Jun 2003 18:47:20 -0000	1.41
+++ mysql.in	24 Jul 2003 04:47:13 -0000	1.42
@@ -221,6 +221,7 @@
   status_name varchar(30) NOT NULL default '',
   status_desc text NOT NULL,
   sort_order tinyint(3) unsigned NOT NULL default '0',
+  bug_open tinyint(1) unsigned NOT NULL default '1',
   PRIMARY KEY  (status_id)
 ) TYPE=MyISAM;
 
@@ -338,8 +339,6 @@
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_PROMOTED','2','The status to assign a bug when it is promoted (if enabled).','multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_ASSIGNED','3','The status to assign a bug when it is assigned.','multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('BUG_REOPENED','4','The status to assign a bug when it is reopened.','multi');
-INSERT INTO TBL_CONFIGURATION VALUES ('BUG_CLOSED','7','The status to assign a bug when it is closed.','multi');
-INSERT INTO TBL_CONFIGURATION VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');
 INSERT INTO TBL_CONFIGURATION VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');
 
 INSERT INTO TBL_OS VALUES (1,'All',1,'');
@@ -395,13 +394,13 @@
 create table TBL_SEVERITY_seq (id int unsigned auto_increment not null primary key);
 insert into TBL_SEVERITY_seq values (7);
 
-INSERT INTO TBL_STATUS VALUES (1,'Unconfirmed','Reported but not confirmed',1);
-INSERT INTO TBL_STATUS VALUES (2,'New','A new bug',2);
-INSERT INTO TBL_STATUS VALUES (3,'Assigned','Assigned to a developer',3);
-INSERT INTO TBL_STATUS VALUES (4,'Reopened','Closed but opened again for further inspection',4);
-INSERT INTO TBL_STATUS VALUES (5,'Resolved','Set by engineer with a resolution',5);
-INSERT INTO TBL_STATUS VALUES (6,'Verified','The resolution is confirmed by the reporter',6);
-INSERT INTO TBL_STATUS VALUES (7,'Closed','The bug is officially squashed (QA)',7);
+INSERT INTO TBL_STATUS VALUES (1,'Unconfirmed','Reported but not confirmed',1, 1);
+INSERT INTO TBL_STATUS VALUES (2,'New','A new bug',2,1);
+INSERT INTO TBL_STATUS VALUES (3,'Assigned','Assigned to a developer',3,1);
+INSERT INTO TBL_STATUS VALUES (4,'Reopened','Closed but opened again for further inspection',4,1);
+INSERT INTO TBL_STATUS VALUES (5,'Resolved','Set by engineer with a resolution',5,0);
+INSERT INTO TBL_STATUS VALUES (6,'Verified','The resolution is confirmed by the reporter',6,0);
+INSERT INTO TBL_STATUS VALUES (7,'Closed','The bug is officially squashed (QA)',7,0);
 create table TBL_STATUS_seq (id int unsigned auto_increment not null primary key);
 insert into TBL_STATUS_seq values (7);
 

[phpBT-dev] CVS: phpbt bug.php,1.133,1.134 config-dist.php,1.25,1.26 config.php,1.37,1.38 index.php,1.38,1.39 install.php,1.38,1.39 upgrade.php,1.34,1.35

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv1772

Modified Files:
	bug.php config-dist.php config.php index.php install.php 
	upgrade.php 
Log Message:
Multiple statuses can now be set as 'open' or 'closed' -- no longer will 
just BUG_CLOSED show up in most-recently-closed-bugs, etc.

Admin ui allow reassigning open/closed bit to statuses. mysql DB 
touched, rolling to version 4.

Fixed install.php DB_VERSIONing problem.


Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.133
retrieving revision 1.134
diff -u -r1.133 -r1.134
--- bug.php	6 Jul 2003 22:57:33 -0000	1.133
+++ bug.php	24 Jul 2003 04:47:13 -0000	1.134
@@ -437,7 +437,7 @@
 	$os_id = $os_id ? $os_id : 0;
 	$severity_id = $severity_id ? $severity_id : 0;
 
-	if ($status_id == BUG_CLOSED) {
+	if (is_closed($status_id)) {
 		$closed_query = ", close_date = $now";
 	} else {
 		$closed_query = '';

Index: config-dist.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config-dist.php,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- config-dist.php	10 Jun 2003 16:18:59 -0000	1.25
+++ config-dist.php	24 Jul 2003 04:47:13 -0000	1.26
@@ -34,7 +34,7 @@
 
 // Database Table Config
 // you can change either the prefix of the table names or each table name individually
-define ('DB_VERSION', 3); // the version of the database
+define ('DB_VERSION', 4); // the version of the database
 define ('TBL_PREFIX', '{tbl_prefix}');	// the prefix for all tables, leave empty to use the old style
 
 define ('TBL_ACTIVE_SESSIONS', TBL_PREFIX.'active_sessions');

Index: config.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config.php,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- config.php	4 Jun 2003 18:47:19 -0000	1.37
+++ config.php	24 Jul 2003 04:47:13 -0000	1.38
@@ -37,7 +37,7 @@
 
 // Database Table Config
 // you can change either the prefix of the table names or each table name individually
-define ('DB_VERSION', 3); // the version of the database
+define ('DB_VERSION', 4); // the version of the database
 define ('TBL_PREFIX', '');	// the prefix for all tables, leave empty to use the old style
 define ('TBL_ACTIVE_SESSIONS', TBL_PREFIX.'active_sessions');
 define ('TBL_DB_SEQUENCE',     TBL_PREFIX.'db_sequence');

Index: index.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/index.php,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- index.php	18 Feb 2003 12:50:57 -0000	1.38
+++ index.php	24 Jul 2003 04:47:13 -0000	1.39
@@ -171,7 +171,7 @@
 	$db->getAll($db->modifyLimitQuery('select b.bug_id, title, project_name from '.TBL_BUG.' b, '.
 		TBL_PROJECT.' p'.
 		" where b.project_id not in ($restricted_projects)".
-		' and status_id = '.BUG_CLOSED.
+		' and '.in_closed('status_id').
 		' and b.project_id = p.project_id order by close_date desc', 0, 5)));
 
 if ($u != 'nobody') {

Index: install.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/install.php,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- install.php	11 Jun 2003 12:05:17 -0000	1.38
+++ install.php	24 Jul 2003 04:47:13 -0000	1.39
@@ -193,6 +193,12 @@
 		$db->query(stripslashes($do_query));
 		$do_query = '';
 	}
+	/*!! BAD! Must figure out how to get db_version from config-dist.php... */
+	$query = preg_replace(array_keys($tables), array_values($tables), 'INSERT INTO '.TBL_CONFIGURATION.' (varname,varvalue,description,vartype) VALUES (\'DB_VERSION\', './*!!!*/4/*!!!*/.', \'Database Version <b>Warning:</b> Changing this might make things go horribly wrong, so don\\\'t change it.\', \'mixed\')');
+	$res = $db->query($query);
+	if (PEAR::isError($res)) {
+		echo 'DB_VERSION not set!';
+	}
 }
 
 function check_vars() {

Index: upgrade.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/upgrade.php,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- upgrade.php	4 Jun 2003 18:47:19 -0000	1.34
+++ upgrade.php	24 Jul 2003 04:47:13 -0000	1.35
@@ -43,10 +43,15 @@
 				break;
 			case 'mysql' :
 				$db->query("create table if not exists ".TBL_PROJECT_PERM." ( project_id int(11) NOT NULL default '0', user_id int(11) NOT NULL default '0' )");
-				if ($thisvers < 2)
+				if ($thisvers < 2) {
 					$db->query("alter table ".TBL_AUTH_GROUP." ADD assignable TINYINT DEFAULT 0 NOT NULL AFTER locked");
-				if ($thisvers < 3)
+				}
+				if ($thisvers < 3) {
 					$db->query("ALTER TABLE ".TBL_USER_PREF." ADD def_results INT DEFAULT '20' NOT NULL");
+				}
+				if ($thisvers < 4) {
+					$db->query('ALTER TABLE '.TBL_STATUS.' ADD bug_open TINYINT DEFAULT \'1\' NOT NULL');
+				}
 				break;
 			case 'pgsql' :
 				//! Missing Alter/Create's
@@ -57,12 +62,18 @@
 				break;
 		}
 
+		/** Database-independent changes */
 		if ($thisvers < 2) {
 			$db->query("DELETE FROM ".TBL_CONFIGURATION." WHERE varname = 'GROUP_ASSIGN_TO'");
 			$db->query("UPDATE ".TBL_AUTH_GROUP." SET assignable = 1 WHERE group_id = 3");
 			$db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');");
 			/* add db-version attribute */
 			$db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('DB_VERSION', '".DB_VERSION."', 'Database Version <b>Warning:</b> Changing this might make things go horribly wrong.', 'string')");
+		}
+
+		if ($thisvers < 4) {
+			$db->query('DELETE FROM '.TBL_CONFIGURATION.' WHERE varname = \'BUG_CLOSED\'');
+			echo 'You must set your Statuses to either open or closed. Default settings should be modified so that "resolved", "closed", and "verified" are shown as being closed, and all other statuses are set to open.';
 		}
 
 		/* update to current DB_VERSION */

[phpBT-dev] CVS: phpbt/admin status.php,1.29,1.30

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv1772/admin

Modified Files:
	status.php 
Log Message:
Multiple statuses can now be set as 'open' or 'closed' -- no longer will 
just BUG_CLOSED show up in most-recently-closed-bugs, etc.

Admin ui allow reassigning open/closed bit to statuses. mysql DB 
touched, rolling to version 4.

Fixed install.php DB_VERSIONing problem.


Index: status.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/status.php,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- status.php	26 Aug 2002 18:11:13 -0000	1.29
+++ status.php	24 Jul 2003 04:47:13 -0000	1.30
@@ -58,14 +58,16 @@
 	if (empty($sort_order)) $sort_order = 0;
 	if (!$statusid) {
 		$db->query("insert into ".TBL_STATUS.
-			" (status_id, status_name, status_desc, sort_order) values (".
+			" (status_id, status_name, status_desc, bug_open, sort_order) values (".
 			$db->nextId(TBL_STATUS).', '.
 			$db->quote(stripslashes($status_name)).', '.
-			$db->quote(stripslashes($status_desc)).", '$sort_order')");
+			$db->quote(stripslashes($status_desc)).', '.
+			(int)$bug_open.", '$sort_order')");
 	} else {
 		$db->query("update ".TBL_STATUS.
 			" set status_name = ".$db->quote(stripslashes($status_name)).
 			', status_desc = '.$db->quote(stripslashes($status_desc)).
+			', bug_open = '.(int)$bug_open.
 			", sort_order = $sort_order where status_id = $statusid");
 	}
 	if ($use_js) {
@@ -84,6 +86,7 @@
 			" where status_id = '$statusid'"));
 	} else {
  		$t->assign($_pv);
+		$t->assign(array('bug_open' => 1)); // new bugs def. open :)
 	}
 	$t->assign('error', $error);
 	$t->wrap('admin/status-edit.html', ($statusid ? 'editstatus' : 'addstatus'));

[phpBT-dev] CVS: phpbt/inc functions.php,1.42,1.43

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/inc
In directory sc8-pr-cvs1:/tmp/cvs-serv1772/inc

Modified Files:
	functions.php 
Log Message:
Multiple statuses can now be set as 'open' or 'closed' -- no longer will 
just BUG_CLOSED show up in most-recently-closed-bugs, etc.

Admin ui allow reassigning open/closed bit to statuses. mysql DB 
touched, rolling to version 4.

Fixed install.php DB_VERSIONing problem.


Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- functions.php	5 Jul 2003 22:54:26 -0000	1.42
+++ functions.php	24 Jul 2003 04:47:13 -0000	1.43
@@ -571,4 +571,27 @@
     return ($retval);
 }
 
+// Generate a testable WHERE expression for closed bugs
+function in_closed($column) {
+	global $db;
+	
+	$closed_statuses = array();
+	
+	foreach($db->getAll('SELECT status_id FROM '.TBL_STATUS.' WHERE bug_open = 0') as $row) {
+		$closed_statuses[] = (int)$row['status_id'];
+	}
+	
+	return '('.$column.' = '.join(' OR '.$column.' = ', $closed_statuses).')';
+}
+
+// Check whether or not a status-id means BUG_CLOSED
+function is_closed($status_id) {
+	global $db;
+
+	if ($db->getOne('SELECT status_id FROM '.TBL_STATUS.' WHERE bug_open = 0 AND status_id = '.$status_id)) {
+		return true;
+	} else {
+		return false;
+	}
+}
 ?>

[phpBT-dev] CVS: phpbt/inc/db mysql.php,1.17,1.18

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/inc/db
In directory sc8-pr-cvs1:/tmp/cvs-serv1772/inc/db

Modified Files:
	mysql.php 
Log Message:
Multiple statuses can now be set as 'open' or 'closed' -- no longer will 
just BUG_CLOSED show up in most-recently-closed-bugs, etc.

Admin ui allow reassigning open/closed bit to statuses. mysql DB 
touched, rolling to version 4.

Fixed install.php DB_VERSIONing problem.


Index: mysql.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/db/mysql.php,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- mysql.php	21 Jun 2003 13:36:30 -0000	1.17
+++ mysql.php	24 Jul 2003 04:47:13 -0000	1.18
@@ -40,7 +40,7 @@
 		TBL_BUG.' using (site_id) group by s.site_id, site_name, sort_order '.
 		'order by %s %s',
 	'admin-list-statuses' => 'select s.status_id, status_name, status_desc, '.
-		'sort_order, count(bug_id) as bug_count '.
+		'sort_order, bug_open, count(bug_id) as bug_count '.
 		'from '.TBL_STATUS.' s left join '. TBL_BUG.' using (status_id) '.
 		'group by s.status_id, status_name, status_desc, sort_order '.
 		'order by %s %s',

[phpBT-dev] CVS: phpbt/templates/default/admin status-edit.html,1.5,1.6 statuslist.html,1.10,1.11

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv1772/templates/default/admin

Modified Files:
	status-edit.html statuslist.html 
Log Message:
Multiple statuses can now be set as 'open' or 'closed' -- no longer will 
just BUG_CLOSED show up in most-recently-closed-bugs, etc.

Admin ui allow reassigning open/closed bit to statuses. mysql DB 
touched, rolling to version 4.

Fixed install.php DB_VERSIONing problem.


Index: status-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/status-edit.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- status-edit.html	5 Nov 2002 20:58:19 -0000	1.5
+++ status-edit.html	24 Jul 2003 04:47:13 -0000	1.6
@@ -41,7 +41,10 @@
   <td align="right" valign="top">Sort Order:</td>
   <td><input type="text" size="3" maxlength="3" name="sort_order" value="{$sort_order}"></td>
 </tr>
-
+<tr>
+	<td align="right" valign="top">Bugs Are:{$bug_open}</td>
+	<td><input type="radio" name="bug_open" value="1"{if $bug_open neq 0} checked="checked"{/if}/>Open <input type="radio" name="bug_open" value="0"{if $bug_open eq 0} checked="checked"{/if}/>Closed</td>
+</tr>
 </table>
 <br>
 <input type='submit' name='submit' value='Submit'>

Index: statuslist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/statuslist.html,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- statuslist.html	21 Jun 2003 13:42:57 -0000	1.10
+++ statuslist.html	24 Jul 2003 04:47:13 -0000	1.11
@@ -19,6 +19,7 @@
 					<th class="{$headers.name.class}"><a href="{$headers.name.url}">Name</a></th>
 					<th class="{$headers.description.class}"><a href="{$headers.description.url}">Description</a></th>
 					<th class="{$headers.sortorder.class}"><a href="{$headers.sortorder.url}">Sort Order</a></th>
+					<th>Bugs are</th>
 					<th>Delete</th>
 				</tr>
 				{section name=status loop=$statuses}
@@ -26,6 +27,13 @@
 					<td><a href="{$smarty.server.PHP_SELF}?op=edit&status_id={$statuses[status].status_id}" onClick="popupStatus({$statuses[status].status_id}); return false;">{$statuses[status].status_name|stripslashes}</a></td>
 					<td>&nbsp;{$statuses[status].status_desc}</td>
 					<td align="center">{$statuses[status].sort_order}</td>
+					<td align="center">
+						{if $statuses[status].bug_open eq 1}
+							Open
+							{else}
+							Closed
+						{/if}
+					</td>
 					<td align="center">
 						{if not $statuses[status].bug_count and $statuses[status].status_id neq BUG_UNCONFIRMED}
 						<a href="{$smarty.server.PHP_SELF}?op=del&status_id={$statuses[status].status_id}" onClick="return confirm('Are you sure you want to delete this status?')">Delete</a>

[phpBT-dev] CVS: phpbt/schemas mysql.in,1.42,1.43

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/schemas
In directory sc8-pr-cvs1:/tmp/cvs-serv2459/schemas

Modified Files:
	mysql.in 
Log Message:
Developers group is new automatically assignable...


Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- mysql.in	24 Jul 2003 04:47:13 -0000	1.42
+++ mysql.in	24 Jul 2003 04:50:51 -0000	1.43
@@ -291,7 +291,7 @@
 # Start off with three user levels...
 INSERT INTO TBL_AUTH_GROUP (group_id, group_name, locked) VALUES (1, 'Admin', 1);
 INSERT INTO TBL_AUTH_GROUP (group_id, group_name, locked) VALUES (2, 'User', 1);
-INSERT INTO TBL_AUTH_GROUP (group_id, group_name, locked) VALUES (3, 'Developer', 1);
+INSERT INTO TBL_AUTH_GROUP (group_id, group_name, locked, assignable) VALUES (3, 'Developer', 1, 1);
 create table TBL_AUTH_GROUP_seq (id int unsigned auto_increment not null primary key);
 insert into TBL_AUTH_GROUP_seq values (3);
 

[phpBT-dev] phpbt's tracker

[Ken T. <ke...@to...>]

hey all,

what would you think of moving from the sf.net tracker to phpbt? i think 
it'd be a good way to demo our product.

ken

[phpBT-dev] CVS: phpbt CHANGELOG,1.66,1.67 query.php,1.97,1.98

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv23265

Modified Files:
	CHANGELOG query.php 
Log Message:
Added additional-comments searching support.
Fixes RFE 722667 and many many more!
- ken


Index: CHANGELOG
===================================================================
RCS file: /cvsroot/phpbt/phpbt/CHANGELOG,v
retrieving revision 1.66
retrieving revision 1.67
diff -u -r1.66 -r1.67
--- CHANGELOG	9 Apr 2003 12:41:30 -0000	1.66
+++ CHANGELOG	23 Jul 2003 01:22:12 -0000	1.67
@@ -11,6 +11,7 @@
 : Added ability to disable all email sent from the system.
 : Fixed a bug with not being able to change the name of the 'Developer' group.
 : Added tracking of changes in priority to the bug history.
+: You can now search on "additional comments" and "description".
 
 -- 0.9.1 -- 4 Jan 2003
 : Fixed bugs with PostgreSQL

Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.97
retrieving revision 1.98
diff -u -r1.97 -r1.98
--- query.php	13 Jul 2003 14:22:42 -0000	1.97
+++ query.php	23 Jul 2003 01:22:12 -0000	1.98
@@ -123,8 +123,14 @@
 			$query[] = '('.@join(' and ',$equery).')';
 		}
 
+		// Search for additional comments with 'description'
+		$bugs_with_comment = array();
+		foreach ($db->getAll('SELECT bug_id FROM '.TBL_COMMENT.' WHERE comment_text LIKE \'%'.$description.'%\'') as $row) {
+			$bugs_with_comment[] = $row['bug_id'];
+		}
+		
 		// Text search field(s)
-		foreach(array('title','description','url') as $searchfield) {
+		foreach(array('title','url') as $searchfield) {
 			if (!empty($$searchfield)) {
 				switch (${$searchfield."_type"}) {
 					case 'like' : $cond = "like '%".$$searchfield."%'"; break;
@@ -133,6 +139,14 @@
 				}
 				$fields[] = "$searchfield $cond";
 			}
+		}
+		if (!empty($description)) {
+			switch($description_type) {
+				case 'like' : $cond = 'like \'%'.$description.'%\''; break;
+				case 'rlike' : $cond = 'rlike \''.$description.'\''; break;
+				case 'not rlike' : $cond = 'not rlike \''.$description.'\'';
+			}
+			$fields[] = '(description '.$cond.(count($bugs_with_comment) ? ' OR bug_id = '.join(' OR bug_id = ', $bugs_with_comment):'').')';
 		}
 		if (!empty($fields)) $query[] = '('.@join(' and ',$fields).')';
 

[phpBT-dev] CVS: phpbt/languages en.php,1.38,1.39

[Ken T. <ke...@us...>]

Update of /cvsroot/phpbt/phpbt/languages
In directory sc8-pr-cvs1:/tmp/cvs-serv23265/languages

Modified Files:
	en.php 
Log Message:
Added additional-comments searching support.
Fixes RFE 722667 and many many more!
- ken


Index: en.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/languages/en.php,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- en.php	4 Jun 2003 18:47:20 -0000	1.38
+++ en.php	23 Jul 2003 01:22:12 -0000	1.39
@@ -103,7 +103,7 @@
 		'Database' => 'Database',
 		'ReportedOnSite' => 'Reported on Site',
 		'Summary' => 'Summary',
-		'DescriptionEntry' => 'A description entry',
+		'DescriptionEntry' => 'Description / Comment',
 		'SortBy' => 'Sort By',
 		'SortBy_BugNumber' => 'Bug Number',
 		'SortBy_Severity' => 'Severity',

Re: [phpBT-dev] 2.0

[<php...@be...>]

It's partly a change of personal preference and partly because of the
hassles experienced from people trying to get smarty set up correctly to
be able to use phpbt.  The html templates will be edited so that the
smarty markup is replaced with plain ol' php.  The interface to the code
will be the same -- that is, there will still be a template class which
is called to render the page after the data has been retrieved by the
php scripts such as query.php.

On Thu, Jul 17, 2003 at 09:38:03AM -0400, Cliff Brake wrote:
> What is the reason(s) for moving away from the smarty templates?
> 
> Thanks,
> Cliff

[phpBT-dev] Project Heirachies

[Brent R. <br...@mb...>]

This is a feature request from a user of phpBT v0.51.
It doesn't appear to be in the current version either, but I have only
read the docs for v0.9x on the web -- not installed it to test.

What do you think of it?
Is is already present in the current version?
If not, would it be considered?
Are the better ways to get the same effect?

In a nutshell, this user wants project hierarchies where projects are 
made up
of components, each of which may be viewed as a project in their own right.

Here's the original "bug" this user filed against phpbt in our phpbt 
database :-)
------------------

The version tracking model in phpbt seems insufficient. While tracking 
bugs against major project releases is an important feature, it is also 
necessary to track bugs against releases of individual components. (On 
some projects, components may be updated many times without having a new 
version of the overall project. Other projects may bundle many different 
kinds of components, which may not be tightly coupled to 'project' 
progress at all.)

There are workarounds which can get us by in the short term. For a VARS 
component, I called the version "VCR yymmdd", encoding the component 
name in the version ID. This is functional, but cumbersome, and not 
suitable for larger projects with many components. Another option would 
be to use a standard syntax for versioning components, e.g., 
ProjectVersion.ComponentVersion (so all components would start at x.1, 
then x.2, etc). This ends up being a little awkward as well, and you're 
still encoding the project version in the same field, which is a little 
bogus.

Soo, although it's probably a lot of work, Component versioning is 
something the phpbg folks need to support.

-- 
 Brent Roman                                   MBARI
 Software Engineer               Tel: (831) 775-1808
 7700 Sandholdt Road,         Moss Landing, CA 95039
 mailto:br...@mb...  http://www.mbari.org/~brent

Re: [phpBT-dev] 2.0

[Ken T. <ke...@to...>]

Umm...

#1 and #3 are important features that are missing in phpbt, but are usefu=
l in
bugzilla. #2 could be a big part of getting phpbt adopted by more users.

ken

Quoting Ken Tossell <ke...@to...>:

> more changes on the wiki
>=20
> Quoting Cliff Brake <cb...@ac...>:
>=20
> > What is the reason(s) for moving away from the smarty templates?
> >=20
> > Thanks,
> > Cliff
> >=20
> > ------------------------------------------
> > On Monday 23 June 2003 10:00 am, php...@be... wrote:
> > >Well, since there weren't any objections to my idea to branch 1.0, g=
et
> > >it ready for release, and start working on 2.0, I've update the
> > >development road map at
> > >http://phpbt.sourceforge.net/wiki/index.php/RoadMap to list some of =
the
> > >major features I want to get done for 2.0.  You are welcome to add a=
ny
> > >other major features you think should be included in that release, o=
r
> > >just reply to this email with your ideas.
> > >
> > >
> > >-------------------------------------------------------
> > >This SF.Net email is sponsored by: INetU
> > >Attention Web Developers & Consultants: Become An INetU Hosting Part=
ner.
> > >Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commiss=
ion!
> > >INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.p=
hp
> > >_______________________________________________
> > >phpbt-dev mailing list
> > >php...@li...
> > >https://lists.sourceforge.net/lists/listinfo/phpbt-dev
> >=20
> >=20
> >=20
> > -------------------------------------------------------
> > This SF.net email is sponsored by: VM Ware
> > With VMware you can run multiple operating systems on a single machin=
e.
> > WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at t=
he
> > same time. Free trial click here: http://www.vmware.com/wl/offer/345/=
0
> > _______________________________________________
> > phpbt-dev mailing list
> > php...@li...
> > https://lists.sourceforge.net/lists/listinfo/phpbt-dev
> >=20
>=20
>=20
> --=20
> Ken Tossell
> ken at tossell dot net
> http://www.kennyt.com/
> washington, dc / gmt-4
> world::free.capital();
>=20
>=20
> -------------------------------------------------------
> This SF.net email is sponsored by: VM Ware
> With VMware you can run multiple operating systems on a single machine.
> WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
> same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev
>=20


--=20
Ken Tossell
ken at tossell dot net
http://www.kennyt.com/
washington, dc / gmt-4
world::free.capital();

Re: [phpBT-dev] 2.0

[Ken T. <ke...@to...>]

more changes on the wiki

Quoting Cliff Brake <cb...@ac...>:

> What is the reason(s) for moving away from the smarty templates?
>=20
> Thanks,
> Cliff
>=20
> ------------------------------------------
> On Monday 23 June 2003 10:00 am, php...@be... wrote:
> >Well, since there weren't any objections to my idea to branch 1.0, get
> >it ready for release, and start working on 2.0, I've update the
> >development road map at
> >http://phpbt.sourceforge.net/wiki/index.php/RoadMap to list some of th=
e
> >major features I want to get done for 2.0.  You are welcome to add any
> >other major features you think should be included in that release, or
> >just reply to this email with your ideas.
> >
> >
> >-------------------------------------------------------
> >This SF.Net email is sponsored by: INetU
> >Attention Web Developers & Consultants: Become An INetU Hosting Partne=
r.
> >Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commissio=
n!
> >INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php
> >_______________________________________________
> >phpbt-dev mailing list
> >php...@li...
> >https://lists.sourceforge.net/lists/listinfo/phpbt-dev
>=20
>=20
>=20
> -------------------------------------------------------
> This SF.net email is sponsored by: VM Ware
> With VMware you can run multiple operating systems on a single machine.
> WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
> same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev
>=20


--=20
Ken Tossell
ken at tossell dot net
http://www.kennyt.com/
washington, dc / gmt-4
world::free.capital();

Re: [phpBT-dev] 2.0

[Cliff B. <cb...@ac...>]

What is the reason(s) for moving away from the smarty templates?

Thanks,
Cliff

------------------------------------------
On Monday 23 June 2003 10:00 am, php...@be... wrote:
>Well, since there weren't any objections to my idea to branch 1.0, get
>it ready for release, and start working on 2.0, I've update the
>development road map at
>http://phpbt.sourceforge.net/wiki/index.php/RoadMap to list some of the
>major features I want to get done for 2.0.  You are welcome to add any
>other major features you think should be included in that release, or
>just reply to this email with your ideas.
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by: INetU
>Attention Web Developers & Consultants: Become An INetU Hosting Partner.
>Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
>INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php
>_______________________________________________
>phpbt-dev mailing list
>php...@li...
>https://lists.sourceforge.net/lists/listinfo/phpbt-dev

[phpBT-dev] CVS: phpbt query.php,1.96,1.97

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv1698

Modified Files:
	query.php 
Log Message:
Fixes bug #723019 (again) - Use and instead of or for joining query chunks

Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.96
retrieving revision 1.97
diff -u -r1.96 -r1.97
--- query.php	21 Jun 2003 13:36:30 -0000	1.96
+++ query.php	13 Jul 2003 14:22:42 -0000	1.97
@@ -120,7 +120,7 @@
 				case '=' : $econd = "$emailtype1 '$email1'"; break;
 			}
 			foreach($emailfield1 as $field) $equery[] = "$field.$emailsearch1 $econd";
-			$query[] = '('.@join(' or ',$equery).')';
+			$query[] = '('.@join(' and ',$equery).')';
 		}
 
 		// Text search field(s)
@@ -134,7 +134,7 @@
 				$fields[] = "$searchfield $cond";
 			}
 		}
-		if (!empty($fields)) $query[] = '('.@join(' or ',$fields).')';
+		if (!empty($fields)) $query[] = '('.@join(' and ',$fields).')';
 
 		// Project/Version/Component
 		if (!empty($projects)) {
@@ -147,6 +147,12 @@
 		} elseif (!$perm->have_perm('Admin')) { // Filter results from hidden projects
 			$query[] = "b.project_id not in ($restricted_projects)";
 		}
+		// TODO: Something like this can be used for searching descriptions
+		/* 
+		select b.bug_id, b.title, b.description, c.comment_id, c.comment_text 
+		from bug b left join comment c using (bug_id)
+		where description like '%yet%' or comment_text like '%yet%'
+		*/
 	}
 
 	if (!empty($query)) {

[phpBT-dev] CVS: phpbt query.php,1.96,1.96.2.1

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv1373

Modified Files:
      Tag: phpbt-1_0
	query.php 
Log Message:
Fixes bug #723019 (again) - Use and instead of or for joining query chunks

Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.96
retrieving revision 1.96.2.1
diff -u -r1.96 -r1.96.2.1
--- query.php	21 Jun 2003 13:36:30 -0000	1.96
+++ query.php	13 Jul 2003 14:20:18 -0000	1.96.2.1
@@ -120,7 +120,7 @@
 				case '=' : $econd = "$emailtype1 '$email1'"; break;
 			}
 			foreach($emailfield1 as $field) $equery[] = "$field.$emailsearch1 $econd";
-			$query[] = '('.@join(' or ',$equery).')';
+			$query[] = '('.@join(' and ',$equery).')';
 		}
 
 		// Text search field(s)
@@ -134,7 +134,7 @@
 				$fields[] = "$searchfield $cond";
 			}
 		}
-		if (!empty($fields)) $query[] = '('.@join(' or ',$fields).')';
+		if (!empty($fields)) $query[] = '('.@join(' and ',$fields).')';
 
 		// Project/Version/Component
 		if (!empty($projects)) {
@@ -147,6 +147,12 @@
 		} elseif (!$perm->have_perm('Admin')) { // Filter results from hidden projects
 			$query[] = "b.project_id not in ($restricted_projects)";
 		}
+		// TODO: Something like this can be used for searching descriptions
+		/* 
+		select b.bug_id, b.title, b.description, c.comment_id, c.comment_text 
+		from bug b left join comment c using (bug_id)
+		where description like '%yet%' or comment_text like '%yet%'
+		*/
 	}
 
 	if (!empty($query)) {

[phpBT-dev] Branch

[<php...@be...>]

I have just created the branch phpbt-1_0 in cvs.  This branch should be
used for all cleanup work needed to get to a 1.0 release.  That work
includes things like testing the upgrade script with a fresh install of
0.9.1, testing the installation on (at least) both mysql and postgres,
and perhaps tidying up the documentation a bit.

I have lots of changes in mind for version 2... I'm just hoping I will
actually have the time to do some of them. :)

[phpBT-dev] CVS: phpbt bug.php,1.132,1.133

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv16358

Modified Files:
	bug.php 
Log Message:
I want to not email the user who made the change until we have a user preference to turn it on and off

Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.132
retrieving revision 1.133
diff -u -r1.132 -r1.133
--- bug.php	20 Jun 2003 01:10:20 -0000	1.132
+++ bug.php	6 Jul 2003 22:57:33 -0000	1.133
@@ -249,7 +249,6 @@
 	$reporter = $db->getOne('select email from '.TBL_AUTH_USER.
 		" u, ".TBL_USER_PREF." p where u.user_id = {$buginfo['created_by']} ".
 		"and u.user_id = p.user_id and email_notices = 1");
-
 	$reporterstat = ' ';
 
 	// If there are new comments grab the comments immediately before the latest
@@ -294,9 +293,13 @@
 
 	$maillist = array();
 
-	$maillist[] = $reporter;
-
-	if (!empty($assignedto) and $emailassignedto) {
+	// Don't email the person who just made the changes (later, make this
+	// behavior toggable by the user)
+	if ($userid != $buginfo['created_by'] and !empty($reporter)) {
+		$maillist[] = $reporter;
+	}
+	if ($userid != (!empty($cf['assigned_to']) ? $cf['assigned_to'] : $buginfo['assigned_to'])
+		and !empty($assignedto) and $emailassignedto) {
 	    $maillist[] = $assignedto;
 	}
 

[phpBT-dev] CVS: phpbt include.php,1.125,1.126

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv17381

Modified Files:
	include.php 
Log Message:
Fixes bug #764962 - Specify files as a session save handler just in case some php installations have user as the default handler

Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.125
retrieving revision 1.126
diff -u -r1.125 -r1.126
--- include.php	18 Oct 2002 17:48:34 -0000	1.125
+++ include.php	5 Jul 2003 22:57:33 -0000	1.126
@@ -24,6 +24,7 @@
 
 ini_set("magic_quotes_runtime", 0);
 ini_set("magic_quotes_sybase", 0);
+@ini_set("session.save_handler", "files");
 
 if (!@include('config.php')) {
   header("Location: install.php");