Menu
▾
▴
phpbt-dev — Developer's mailing list and cvs commits
You can subscribe to this list here.
| 2001 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(34) |
Aug
(215) |
Sep
(180) |
Oct
(135) |
Nov
(105) |
Dec
(81) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2002 |
Jan
(76) |
Feb
(22) |
Mar
(154) |
Apr
(149) |
May
(128) |
Jun
(94) |
Jul
(14) |
Aug
(24) |
Sep
(77) |
Oct
(52) |
Nov
(22) |
Dec
(6) |
| 2003 |
Jan
(4) |
Feb
(10) |
Mar
(6) |
Apr
(29) |
May
(10) |
Jun
(37) |
Jul
(39) |
Aug
(13) |
Sep
(23) |
Oct
(3) |
Nov
(7) |
Dec
(2) |
| 2004 |
Jan
|
Feb
(10) |
Mar
(4) |
Apr
|
May
(35) |
Jun
(4) |
Jul
(17) |
Aug
(6) |
Sep
(14) |
Oct
(18) |
Nov
(2) |
Dec
(14) |
| 2005 |
Jan
(9) |
Feb
(30) |
Mar
(6) |
Apr
|
May
(38) |
Jun
(23) |
Jul
(21) |
Aug
(76) |
Sep
(50) |
Oct
(51) |
Nov
(13) |
Dec
|
|
From: Ken T. <ke...@us...> - 2003-04-19 18:13:11
|
Update of /cvsroot/phpbt/phpbt/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv13800/admin
Modified Files:
group.php
Log Message:
* new database update model
- database schema is versioned
* new assignable-group declaration
- each group has an assignable flag
- configurable by admin/group.php
- updated build_select's owner section
Index: group.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/group.php,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- group.php 18 May 2002 03:00:00 -0000 1.10
+++ group.php 19 Apr 2003 18:12:38 -0000 1.11
@@ -51,13 +51,13 @@
if (!$groupid) {
$db->query("insert into ".TBL_AUTH_GROUP.
- " (group_id, group_name, created_by, created_date, last_modified_by, last_modified_date)"
+ " (group_id, group_name, created_by, created_date, last_modified_by, last_modified_date, assignable)"
." values (".$db->nextId(TBL_AUTH_GROUP).", ".
- $db->quote(stripslashes($group_name)).", $u, $now, $u, $now)");
+ $db->quote(stripslashes($group_name)).", $u, $now, $u, $now, $assignable)");
} else {
$db->query("update ".TBL_AUTH_GROUP.
" set group_name = ".$db->quote(stripslashes($group_name)).
- ", last_modified_by = $u, last_modified_date = $now where group_id = '$groupid'");
+ ", last_modified_by = $u, last_modified_date = $now, assignable = ".($assignable?1:0)." where group_id = '$groupid'");
}
if ($use_js) {
$t->display('admin/edit-submit.html');
@@ -90,7 +90,7 @@
$order = $_gv['order'];
$sort = $_gv['sort'];
}
-
+
$page = isset($_gv['page']) ? $_gv['page'] : 0;
$nr = $db->getOne("select count(*) from ".TBL_AUTH_GROUP);
|
|
From: Ken T. <ke...@us...> - 2003-04-19 18:13:11
|
Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv13800
Modified Files:
config-dist.php config.php upgrade.php
Log Message:
* new database update model
- database schema is versioned
* new assignable-group declaration
- each group has an assignable flag
- configurable by admin/group.php
- updated build_select's owner section
Index: config-dist.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config-dist.php,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- config-dist.php 8 Apr 2003 14:34:44 -0000 1.23
+++ config-dist.php 19 Apr 2003 18:12:36 -0000 1.24
@@ -34,6 +34,7 @@
// Database Table Config
// you can change either the prefix of the table names or each table name individually
+define ('DB_VERSION', 2); // the version of the database
define ('TBL_PREFIX', '{tbl_prefix}'); // the prefix for all tables, leave empty to use the old style
define ('TBL_ACTIVE_SESSIONS', TBL_PREFIX.'active_sessions');
Index: config.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config.php,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- config.php 7 Apr 2003 18:55:35 -0000 1.35
+++ config.php 19 Apr 2003 18:12:36 -0000 1.36
@@ -37,6 +37,7 @@
// Database Table Config
// you can change either the prefix of the table names or each table name individually
+define ('DB_VERSION', 2); // the version of the database
define ('TBL_PREFIX', ''); // the prefix for all tables, leave empty to use the old style
define ('TBL_ACTIVE_SESSIONS', TBL_PREFIX.'active_sessions');
define ('TBL_DB_SEQUENCE', TBL_PREFIX.'db_sequence');
Index: upgrade.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/upgrade.php,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- upgrade.php 9 Apr 2003 12:25:18 -0000 1.32
+++ upgrade.php 19 Apr 2003 18:12:37 -0000 1.33
@@ -29,8 +29,9 @@
function upgrade() {
global $db;
- $upgraded = $db->getOne('select varname from '.TBL_CONFIGURATION.' where varname = \'GROUP_ASSIGN_TO\'');
- if (!$upgraded or DB::isError($upgraded)) {
+ $thisvers = $db->getOne('select varvalue from '.TBL_CONFIGURATION.' where varname = \'DB_VERSION\'');
+ if ($thisvers == DB_VERSION) $upgraded = 1;
+ if (!$upgraded or DB::isError($thisvers)) {
if (!@is_writeable('c_templates')) {
include('templates/default/base/templatesperm.html');
exit;
@@ -38,17 +39,34 @@
switch(DB_TYPE) {
case 'pgsql' :
$db->query("create table ".TBL_PROJECT_PERM." ( project_id INT4 NOT NULL DEFAULT '0', user_id INT4 NOT NULL DEFAULT '0' )");
+ //! TBL_AUTH_GROUP
break;
case 'mysql' :
- $db->query("create table ".TBL_PROJECT_PERM." ( project_id int(11) NOT NULL default '0', user_id int(11) NOT NULL default '0' )");
+ $db->query("create table if not exists ".TBL_PROJECT_PERM." ( project_id int(11) NOT NULL default '0', user_id int(11) NOT NULL default '0' )");
+ if ($thisvers < 2)
+ $db->query("alter table ".TBL_AUTH_GROUP." ADD assignable TINYINT DEFAULT 0 NOT NULL AFTER locked");
break;
case 'oci8' :
$db->query("create table ".TBL_PROJECT_PERM." ( project_id number(10) default '0' NOT NULL, user_id number(10) default '0' NOT NULL )");
+ //! TBL_AUTH_GROUP
break;
}
- $db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');");
- $db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');");
+ if ($thisvers < 2) {
+ $db->query("DELETE FROM ".TBL_CONFIGURATION." WHERE varname = 'GROUP_ASSIGN_TO'");
+ $db->query("UPDATE ".TBL_AUTH_GROUP." SET assignable = 1 WHERE group_id = 3");
+ $db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');");
+ /* add db-version attribute */
+ $db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('DB_VERSION', '".DB_VERSION."', 'Database Version <b>Warning:</b> Changing this might make things go horribly wrong.', 'string')");
+ }
+
+ if ($thisvers < 3) {
+
+ }
+
+ /* update to current DB_VERSION */
+ $db->query("UPDATE ".TBL_CONFIGURATION." SET varvalue = '".DB_VERSION."' WHERE varname = 'DB_VERSION'");
+
}
include 'templates/default/upgrade-finished.html';
}
@@ -59,4 +77,4 @@
include 'templates/default/upgrade.html';
}
-?>
+?>
\ No newline at end of file
|
|
From: Ken T. <ke...@us...> - 2003-04-19 18:12:46
|
Update of /cvsroot/phpbt/phpbt/inc/db
In directory sc8-pr-cvs1:/tmp/cvs-serv13800/inc/db
Modified Files:
mysql.php oci8.php pgsql.php
Log Message:
* new database update model
- database schema is versioned
* new assignable-group declaration
- each group has an assignable flag
- configurable by admin/group.php
- updated build_select's owner section
Index: mysql.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/db/mysql.php,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- mysql.php 30 Sep 2002 18:02:06 -0000 1.15
+++ mysql.php 19 Apr 2003 18:12:40 -0000 1.16
@@ -1,7 +1,7 @@
<?php
$QUERY = array(
'admin-list-groups' => 'select ag.group_id, group_name, locked, '.
- 'count(ug.group_id) as count '.
+ 'count(ug.group_id) as count, assignable '.
'from '.TBL_AUTH_GROUP.' ag '.
'left join '.TBL_USER_GROUP.' ug using (group_id) '.
'left join '.TBL_AUTH_USER.' using (user_id) '.
Index: oci8.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/db/oci8.php,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- oci8.php 30 Sep 2002 18:02:06 -0000 1.13
+++ oci8.php 19 Apr 2003 18:12:41 -0000 1.14
@@ -2,7 +2,7 @@
$QUERY = array(
'admin-list-groups' => 'select ag.group_id, ag.group_name, ag.locked, '.
- 'count(ug.group_id) as count '.
+ 'count(ug.group_id) as count, asssignable '.
'from '.TBL_AUTH_GROUP.' ag, '.TBL_USER_GROUP.' ug,'.TBL_AUTH_USER.' au '.
'where ag.group_id = ug.group_id(+) and ug.user_id = au.user_id(+) '.
'group by ag.group_id, ag.group_name, ag.locked '.
Index: pgsql.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/db/pgsql.php,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- pgsql.php 17 Dec 2002 13:27:21 -0000 1.22
+++ pgsql.php 19 Apr 2003 18:12:41 -0000 1.23
@@ -2,7 +2,7 @@
$QUERY = array(
'admin-list-groups' => 'select ag.group_id, group_name, locked, '.
- 'count(ug.group_id) as count '.
+ 'count(ug.group_id) as count, assignable '.
'from '.TBL_AUTH_GROUP.' ag '.
'left join '.TBL_USER_GROUP.' ug using (group_id) '.
'left join '.TBL_AUTH_USER.' using (user_id) '.
|
|
From: Ken T. <ke...@us...> - 2003-04-19 18:12:46
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv13800/templates/default/admin
Modified Files:
group-edit.html grouplist.html
Log Message:
* new database update model
- database schema is versioned
* new assignable-group declaration
- each group has an assignable flag
- configurable by admin/group.php
- updated build_select's owner section
Index: group-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/group-edit.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- group-edit.html 5 Nov 2002 20:58:19 -0000 1.5
+++ group-edit.html 19 Apr 2003 18:12:41 -0000 1.6
@@ -27,6 +27,9 @@
<td align="right" valign="top">Name:</td>
<td><input type="text" size="20" maxlength="40" name="group_name" value="{$group_name|stripslashes|htmlspecialchars}"></td>
</tr>
+<tr>
+ <td align="right" valign="top">Assignable:</td>
+ <td><input type="checkbox" name="assignable" value="1" {if $assignable > 0}checked="checked"{/if}></td>
</table>
<br>
<input type='submit' name='submit' value='Submit'>
Index: grouplist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/grouplist.html,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- grouplist.html 18 May 2002 03:00:50 -0000 1.6
+++ grouplist.html 19 Apr 2003 18:12:42 -0000 1.7
@@ -31,6 +31,9 @@
<a href="{$smarty.server.PHP_SELF}?op=del&group_id={$groups[group].group_id}" onClick="return confirm('This will remove all user assignments to this group and the group itself. Continue?')">Delete</a> |
<a href="{$smarty.server.PHP_SELF}?op=purge&group_id={$groups[group].group_id}" onClick="return confirm('This will remove all user assignments to this group. Continue?')">Purge</a>
{/if}
+ {if $groups[group].assignable}
+ | Assignable
+ {/if}
</td>
</tr>
{/section}
|
|
From: Ken T. <ke...@us...> - 2003-04-09 21:52:38
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory sc8-pr-cvs1:/tmp/cvs-serv29108/templates/default
Modified Files:
bugdisplay.html
Log Message:
added |htmlspecialchars| to comment display processor
Index: bugdisplay.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay.html,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -r1.44 -r1.45
--- bugdisplay.html 28 Oct 2002 22:06:02 -0000 1.44
+++ bugdisplay.html 9 Apr 2003 21:52:32 -0000 1.45
@@ -234,14 +234,14 @@
<td>{$STRING.BUGDISPLAY.postedby}: {$reporter|maskemail} <br>
{$STRING.BUGDISPLAY.date}: {$created_date|date:TIME_FORMAT} {$STRING.BUGDISPLAY.dateon} {$created_date|date:DATE_FORMAT}</td>
</tr><tr>
- <td>{$description|stripslashes|format_comments|nl2br} <br><br></td>
+ <td>{$description|stripslashes|htmlspecialchars|format_comments|nl2br} <br><br></td>
</tr>
{section name=comment loop=$comments}
<tr class="alt">
<td>{$STRING.BUGDISPLAY.postedby}: {$comments[comment].login|maskemail} <br>
{$STRING.BUGDISPLAY.date}: {$comments[comment].created_date|date:TIME_FORMAT} {$STRING.BUGDISPLAY.on} {$comments[comment].created_date|date:DATE_FORMAT}</td>
</tr><tr>
- <td>{$comments[comment].comment_text|stripslashes|format_comments|nl2br} <br><br></td>
+ <td>{$comments[comment].comment_text|stripslashes|htmlspecialchars|format_comments|nl2br} <br><br></td>
</tr>
{/section}
</table>
|
|
From: Ken T. <ke...@us...> - 2003-04-09 18:27:51
|
Update of /cvsroot/phpbt/phpbt/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv800/admin
Modified Files:
project.php
Log Message:
missing global $perm -- error when trying to add new version to project.
Index: project.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/project.php,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -r1.44 -r1.45
--- project.php 7 Apr 2003 18:55:37 -0000 1.44
+++ project.php 9 Apr 2003 18:27:44 -0000 1.45
@@ -38,7 +38,7 @@
}
function save_version($version_id = 0) {
- global $db, $me, $_pv, $STRING, $now, $u, $t;
+ global $db, $me, $_pv, $STRING, $now, $u, $t, $perm;
$perm->check_proj($projectid);
|
|
From: Benjamin C. <bc...@us...> - 2003-04-09 12:41:34
|
Update of /cvsroot/phpbt/phpbt In directory sc8-pr-cvs1:/tmp/cvs-serv11100 Modified Files: CHANGELOG Log Message: Index: CHANGELOG =================================================================== RCS file: /cvsroot/phpbt/phpbt/CHANGELOG,v retrieving revision 1.65 retrieving revision 1.66 diff -u -r1.65 -r1.66 --- CHANGELOG 9 Apr 2003 12:40:44 -0000 1.65 +++ CHANGELOG 9 Apr 2003 12:41:30 -0000 1.66 @@ -10,6 +10,7 @@ : Allow admins to delegate power to developers, on a per-project basis. : Added ability to disable all email sent from the system. : Fixed a bug with not being able to change the name of the 'Developer' group. +: Added tracking of changes in priority to the bug history. -- 0.9.1 -- 4 Jan 2003 : Fixed bugs with PostgreSQL |
|
From: Benjamin C. <bc...@us...> - 2003-04-09 12:40:49
|
Update of /cvsroot/phpbt/phpbt In directory sc8-pr-cvs1:/tmp/cvs-serv10810 Modified Files: CHANGELOG Log Message: Index: CHANGELOG =================================================================== RCS file: /cvsroot/phpbt/phpbt/CHANGELOG,v retrieving revision 1.64 retrieving revision 1.65 diff -u -r1.64 -r1.65 --- CHANGELOG 7 Apr 2003 21:52:26 -0000 1.64 +++ CHANGELOG 9 Apr 2003 12:40:44 -0000 1.65 @@ -8,6 +8,8 @@ name as an old one. : Added client-side validation to admin pages. : Allow admins to delegate power to developers, on a per-project basis. +: Added ability to disable all email sent from the system. +: Fixed a bug with not being able to change the name of the 'Developer' group. -- 0.9.1 -- 4 Jan 2003 : Fixed bugs with PostgreSQL |
|
From: Ben C. <php...@be...> - 2003-04-09 12:38:04
|
I didn't put the change in upgrade.php because I figured that if an individual had a need for a longer version name he would make the change to his database anyway. I decided, then, to just modify the schema files so that new installations would have the longer name field. I think that browsing the CVS history for the schema file is the only way we have currently to track changes to the database. On Mon, Apr 07, 2003 at 11:11:32PM +0200, Patrick Mairif wrote: > Hi Ben, > > I noticed you changed the length of the field version_name in table > TBL_VERSION. > > upgrade.php does not change the length of the field, should it? Is there > any ressource beside cvs where I can find latest database-changes? |
|
From: Benjamin C. <bc...@us...> - 2003-04-09 12:25:52
|
Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv3704
Modified Files:
upgrade.php
Log Message:
Fixed bug with GROUP_ASSIGN_TO config variable and added EMAIL_DISABLED config variable
Index: upgrade.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/upgrade.php,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- upgrade.php 9 Apr 2003 12:11:44 -0000 1.31
+++ upgrade.php 9 Apr 2003 12:25:18 -0000 1.32
@@ -48,6 +48,7 @@
}
$db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');");
+ $db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');");
}
include 'templates/default/upgrade-finished.html';
}
|
|
From: Benjamin C. <bc...@us...> - 2003-04-09 12:25:25
|
Update of /cvsroot/phpbt/phpbt/schemas
In directory sc8-pr-cvs1:/tmp/cvs-serv3704/schemas
Modified Files:
mysql.in oci8.in pgsql.in
Log Message:
Fixed bug with GROUP_ASSIGN_TO config variable and added EMAIL_DISABLED config variable
Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- mysql.in 7 Apr 2003 18:55:39 -0000 1.38
+++ mysql.in 9 Apr 2003 12:25:19 -0000 1.39
@@ -337,7 +337,8 @@
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_ASSIGNED','3','The status to assign a bug when it is assigned.','multi');
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_REOPENED','4','The status to assign a bug when it is reopened.','multi');
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_CLOSED','7','The status to assign a bug when it is closed.','multi');
-INSERT INTO TBL_CONFIGURATION VALUES ('ASSIGN_TO_GROUP', '3', 'The group to whom bugs can be assigned', 'multi');
+INSERT INTO TBL_CONFIGURATION VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');
+INSERT INTO TBL_CONFIGURATION VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');
INSERT INTO TBL_OS VALUES (1,'All',1,'');
INSERT INTO TBL_OS VALUES (2,'Windows 3.1',2,'/Mozilla.*\\(Win16.*\\)/');
Index: oci8.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/oci8.in,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- oci8.in 9 Apr 2003 12:11:43 -0000 1.22
+++ oci8.in 9 Apr 2003 12:25:20 -0000 1.23
@@ -336,7 +336,8 @@
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_ASSIGNED','3','The status to assign a bug when it is assigned.','multi');
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_REOPENED','4','The status to assign a bug when it is reopened.','multi');
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_CLOSED','7','The status to assign a bug when it is closed.','multi');
-INSERT INTO TBL_CONFIGURATION VALUES ('ASSIGN_TO_GROUP', '3', 'The group to whom bugs can be assigned', 'multi');
+INSERT INTO TBL_CONFIGURATION VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');
+INSERT INTO TBL_CONFIGURATION VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');
INSERT INTO TBL_OS VALUES (1,'All',1,'');
INSERT INTO TBL_OS VALUES (2,'Windows 3.1',2,'/Mozilla.*\\(Win16.*\\)/');
Index: pgsql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/pgsql.in,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- pgsql.in 9 Apr 2003 12:11:44 -0000 1.40
+++ pgsql.in 9 Apr 2003 12:25:21 -0000 1.41
@@ -333,7 +333,8 @@
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_ASSIGNED','3','The status to assign a bug when it is assigned.','multi');
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_REOPENED','4','The status to assign a bug when it is reopened.','multi');
INSERT INTO TBL_CONFIGURATION VALUES ('BUG_CLOSED','7','The status to assign a bug when it is closed.','multi');
-INSERT INTO TBL_CONFIGURATION VALUES ('ASSIGN_TO_GROUP', '3', 'The group to whom bugs can be assigned', 'multi');
+INSERT INTO TBL_CONFIGURATION VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');
+INSERT INTO TBL_CONFIGURATION VALUES ('EMAIL_DISABLED', '0', 'Whether to disable all mail sent from the system', 'bool');
INSERT INTO TBL_OS VALUES (1,'All',1,'');
INSERT INTO TBL_OS VALUES (2,'Windows 3.1',2,'/Mozilla.*\\(Win16.*\\)/');
|
|
From: Benjamin C. <bc...@us...> - 2003-04-09 12:11:49
|
Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv30407
Modified Files:
upgrade.php install.php
Log Message:
Adding project_perm table
Index: upgrade.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/upgrade.php,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- upgrade.php 11 Mar 2003 13:25:35 -0000 1.30
+++ upgrade.php 9 Apr 2003 12:11:44 -0000 1.31
@@ -35,49 +35,17 @@
include('templates/default/base/templatesperm.html');
exit;
}
- /*switch(DB_TYPE) {
+ switch(DB_TYPE) {
case 'pgsql' :
- $db->query("alter table ".TBL_USER_PREF." add saved_queries int2");
- $db->query("alter table ".TBL_USER_PREF." alter saved_queries set default 1");
- $db->query("update ".TBL_USER_PREF." set saved_queries = 1");
- $db->query("create table ".TBL_BUG_HISTORY."_old as select * from ".TBL_BUG_HISTORY);
- $db->query("drop table ".TBL_BUG_HISTORY);
- $db->query("create table ".TBL_BUG_HISTORY." ( bug_id INT4 NOT NULL DEFAULT '0', changed_field varchar(30) NOT NULL DEFAULT '', old_value varchar(255) NOT NULL DEFAULT '', new_value varchar(255) NOT NULL DEFAULT '', created_by INT4 NOT NULL DEFAULT '0', created_date INT8 NOT NULL DEFAULT '0' )");
- $db->query("insert into ".TBL_BUG_HISTORY." select * from ".TBL_BUG_HISTORY."_old");
- $db->query("drop table ".TBL_BUG_HISTORY."_old");
- $db->query("alter table ".TBL_BUG." add database_id int4");
- $db->query("alter table ".TBL_BUG." add site_id int4");
- $db->query("alter table ".TBL_BUG." add closed_in_version_id int4");
- $db->query("alter table ".TBL_BUG." add to_be_closed_in_version_id int4");
- $db->query("create table ".TBL_SITE." ( site_id INT2 NOT NULL DEFAULT '0', site_name varchar(50) NOT NULL DEFAULT '', sort_order INT2 NOT NULL DEFAULT '0', PRIMARY KEY (site_id) )");
- $db->query("INSERT INTO ".TBL_SITE." VALUES (0,'All',1)");
- $db->query("INSERT INTO ".TBL_SITE." VALUES (1,'Development',2)");
- $db->query("INSERT INTO ".TBL_SITE." VALUES (2,'Testing',3)");
- $db->query("INSERT INTO ".TBL_SITE." VALUES (3,'Staging',4)");
- $db->query("INSERT INTO ".TBL_SITE." VALUES (4,'Production',5)");
- $db->query("CREATE SEQUENCE ".TBL_SITE."_seq START 5");
- $db->query("create table ".TBL_DATABASE." ( database_id INT2 NOT NULL DEFAULT '0', database_name varchar(40) NOT NULL DEFAULT '', sort_order INT2 NOT NULL DEFAULT '0', PRIMARY KEY (database_id) )");
- $db->query("INSERT INTO ".TBL_DATABASE." VALUES (1,'Oracle 8.1.7',1)");
- $db->query("INSERT INTO ".TBL_DATABASE." VALUES (2,'MySQL 3.23.49',2)");
- $db->query("INSERT INTO ".TBL_DATABASE." VALUES (3,'PostgreSQL 7.1.3',3)");
- $db->query("CREATE SEQUENCE ".TBL_DATABASE."_seq START 4");
+ $db->query("create table ".TBL_PROJECT_PERM." ( project_id INT4 NOT NULL DEFAULT '0', user_id INT4 NOT NULL DEFAULT '0' )");
break;
case 'mysql' :
- $db->query("alter table ".TBL_USER_PREF." add saved_queries tinyint(1) not null default '1' after email_notices");
- $db->query("alter table ".TBL_BUG_HISTORY." change changed_field changed_field varchar(30) not null");
- $db->query("alter table ".TBL_BUG." add database_id int not null after resolution_id, add site_id int not null after database_id, add closed_in_version_id int not null after version_id, add to_be_closed_in_version_id int not null after closed_in_version_id");
- $db->query("create table ".TBL_SITE." (site_id int unsigned NOT NULL default '0', site_name varchar(50) NOT NULL default '', sort_order tinyint(3) unsigned NOT NULL default '0', PRIMARY KEY (site_id))");
- $db->query("create table ".TBL_SITE."_seq (id int unsigned auto_increment not null primary key)");
- $db->query("insert into ".TBL_SITE."_seq values (4)");
- $db->query("create table ".TBL_DATABASE." (database_id int(10) unsigned NOT NULL default '0', database_name varchar(40) NOT NULL default '', sort_order tinyint(3) unsigned NOT NULL default '0', PRIMARY KEY (database_id))");
- $db->query("create table ".TBL_DATABASE."_seq (id int unsigned auto_increment not null primary key)");
- $db->query("insert into ".TBL_DATABASE."_seq values (3)");
- $db->query("INSERT INTO ".TBL_SITE." VALUES (0,'All',1), (1,'Development',2), (2,'Testing',3), (3,'Staging',4), (4,'Production',5)");
- $db->query("INSERT INTO ".TBL_DATABASE." VALUES (1,'Oracle 8.1.7',1), (2,'MySQL 3.23.49',2), (3,'PostgreSQL 7.1.3',3)");
+ $db->query("create table ".TBL_PROJECT_PERM." ( project_id int(11) NOT NULL default '0', user_id int(11) NOT NULL default '0' )");
break;
case 'oci8' :
+ $db->query("create table ".TBL_PROJECT_PERM." ( project_id number(10) default '0' NOT NULL, user_id number(10) default '0' NOT NULL )");
break;
- }*/
+ }
$db->query("INSERT INTO ".TBL_CONFIGURATION." VALUES ('GROUP_ASSIGN_TO', '3', 'The group to whom bugs can be assigned', 'multi');");
}
Index: install.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/install.php,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- install.php 18 Oct 2002 17:48:35 -0000 1.35
+++ install.php 9 Apr 2003 12:11:44 -0000 1.36
@@ -92,7 +92,7 @@
'/TBL_USER_PERM/' => $_pv['tbl_prefix'].'user_perm',
'/TBL_USER_PREF/' => $_pv['tbl_prefix'].'user_pref',
'/TBL_VERSION/' => $_pv['tbl_prefix'].'version',
- '/TBL_PROJECT_GROUP/' => $_pv['tbl_prefix'].'project_group',
+ '/TBL_PROJECT_PERM/' => $_pv['tbl_prefix'].'project_perm',
'/TBL_DATABASE/' => $_pv['tbl_prefix'].'database_server',
'/TBL_SITE/' => $_pv['tbl_prefix'].'site',
'/OPTION_ADMIN_EMAIL/' => $_pv['admin_login'],
|
|
From: Benjamin C. <bc...@us...> - 2003-04-09 12:11:47
|
Update of /cvsroot/phpbt/phpbt/schemas In directory sc8-pr-cvs1:/tmp/cvs-serv30407/schemas Modified Files: oci8.in pgsql.in Log Message: Adding project_perm table Index: oci8.in =================================================================== RCS file: /cvsroot/phpbt/phpbt/schemas/oci8.in,v retrieving revision 1.21 retrieving revision 1.22 diff -u -r1.21 -r1.22 --- oci8.in 2 Mar 2003 15:28:54 -0000 1.21 +++ oci8.in 9 Apr 2003 12:11:43 -0000 1.22 @@ -189,6 +189,11 @@ CREATE INDEX GROUPPROJIDX ON TBL_PROJECT_GROUP ( group_id ); +CREATE TABLE TBL_PROJECT_PERM ( + project_id number(10) default '0' NOT NULL, + user_id number(10) default '0' NOT NULL +); + CREATE TABLE TBL_RESOLUTION ( resolution_id number(10) default '0' NOT NULL, resolution_name varchar2(30) default '' NOT NULL, Index: pgsql.in =================================================================== RCS file: /cvsroot/phpbt/phpbt/schemas/pgsql.in,v retrieving revision 1.39 retrieving revision 1.40 diff -u -r1.39 -r1.40 --- pgsql.in 2 Mar 2003 15:28:55 -0000 1.39 +++ pgsql.in 9 Apr 2003 12:11:44 -0000 1.40 @@ -184,6 +184,11 @@ PRIMARY KEY (project_id,group_id) ); +CREATE TABLE TBL_PROJECT_PERM ( + project_id INT4 NOT NULL DEFAULT '0', + user_id INT4 NOT NULL DEFAULT '0' +); + CREATE TABLE TBL_RESOLUTION ( resolution_id INT4 NOT NULL DEFAULT '0', resolution_name varchar(30) NOT NULL DEFAULT '', |
|
From: Patrick M. <mo...@us...> - 2003-04-08 14:34:49
|
Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv3119
Modified Files:
config-dist.php
Log Message:
missing TBL_PROJECT_PERM in config-dist.php
Index: config-dist.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config-dist.php,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- config-dist.php 14 Oct 2002 14:45:55 -0000 1.22
+++ config-dist.php 8 Apr 2003 14:34:44 -0000 1.23
@@ -63,6 +63,7 @@
define ('TBL_USER_PREF', TBL_PREFIX.'user_pref');
define ('TBL_VERSION', TBL_PREFIX.'version');
define ('TBL_PROJECT_GROUP', TBL_PREFIX.'project_group');
+define ('TBL_PROJECT_PERM', TBL_PREFIX.'project_perm');
define ('TBL_DATABASE', TBL_PREFIX.'database_server');
define ('TBL_SITE', TBL_PREFIX.'site');
|
|
From: Ken T. <ke...@us...> - 2003-04-07 21:58:35
|
Update of /cvsroot/phpbt/phpbt/inc
In directory sc8-pr-cvs1:/tmp/cvs-serv6497/inc
Modified Files:
auth.php
Log Message:
oops, this should have gone in with the proj-admin patch. (see functions.php)
Index: auth.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/auth.php,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- auth.php 24 May 2002 12:47:33 -0000 1.17
+++ auth.php 7 Apr 2003 21:58:30 -0000 1.18
@@ -128,6 +128,31 @@
}
}
+ function check_proj($project_id) {
+ global $db;
+
+ if ($this->have_perm_proj($project_id)) {
+ return true;
+ } else {
+ $this->perm_invalid($HTTP_SESSION_VARS['perms'], $p);
+ exit();
+ }
+ }
+
+ function have_perm_proj($project_id) {
+ global $db;
+
+ if ($this->have_perm('Admin')) {
+ return true;
+ }
+
+ if ( $db->getCol('SELECT user_id FROM '.TBL_PROJECT_PERM.' WHERE user_id = '.$_SESSION['uid']." AND project_id = $project_id") ) {
+ return true;
+ } else {
+ return false;
+ }
+ }
+
function check_auth($auth_var, $reqs) {
global $HTTP_SESSION_VARS;
|
|
From: Ken T. <ke...@us...> - 2003-04-07 21:52:33
|
Update of /cvsroot/phpbt/phpbt In directory sc8-pr-cvs1:/tmp/cvs-serv3661 Modified Files: CHANGELOG Log Message: added proj-admin entry Index: CHANGELOG =================================================================== RCS file: /cvsroot/phpbt/phpbt/CHANGELOG,v retrieving revision 1.63 retrieving revision 1.64 diff -u -r1.63 -r1.64 --- CHANGELOG 18 Feb 2003 12:59:46 -0000 1.63 +++ CHANGELOG 7 Apr 2003 21:52:26 -0000 1.64 @@ -7,6 +7,7 @@ : Allow users to override saved queries by saving a new query with the same name as an old one. : Added client-side validation to admin pages. +: Allow admins to delegate power to developers, on a per-project basis. -- 0.9.1 -- 4 Jan 2003 : Fixed bugs with PostgreSQL |
|
From: Patrick M. <mo...@su...> - 2003-04-07 21:11:43
|
Hi Ben, I noticed you changed the length of the field version_name in table TBL_VERSION. upgrade.php does not change the length of the field, should it? Is there any ressource beside cvs where I can find latest database-changes? |
|
From: Ken T. <ke...@us...> - 2003-04-07 18:56:20
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv9290/templates/default/admin
Modified Files:
project-edit.html projectlist.html
Log Message:
* Project-level Administration
- allows superadmin to delegate power to others.
- admin may assign multiple users to have administrative power on a project.
* new auth: have_perm_proj($proj_id); check_proj($proj);
* added <select> to project-form
* build_select(): in addition to 1-1 matching for selected, allow needle-in-haystack
Index: project-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/project-edit.html,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- project-edit.html 30 Oct 2002 22:34:57 -0000 1.12
+++ project-edit.html 7 Apr 2003 18:55:40 -0000 1.13
@@ -70,6 +70,27 @@
<input type="checkbox" name="active" value="1" {if $active}checked{/if}>
</td>
</tr>
+{if isset($perm) and $perm->have_perm('Administrator')}
+ <tr>
+ <td>
+ These developers can administer this project:
+ <br>
+ <select name="useradmin[]" size="10" multiple>
+ {build_select box=owner selected=$project_admins}
+ </select>
+ </td>
+ </tr>
+{else}
+ <tr>
+ <td>
+ These developers can administer this project:
+ <br>
+ {section name=admin loop=$project_admins}
+ {$project_developers[admin]}<br />
+ {/section}
+ </td>
+ </tr>
+{/if}
</table>
<input type='submit' name='submit' value='Submit'>
</form>
Index: projectlist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/projectlist.html,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- projectlist.html 18 May 2002 03:00:50 -0000 1.7
+++ projectlist.html 7 Apr 2003 18:55:40 -0000 1.8
@@ -11,7 +11,7 @@
</tr>
{section name=project loop=$projects}
<tr{if $smarty.section.project.iteration is even} class="alt"{/if}>
- <td><a href="{$smarty.server.PHP_SELF}?op=edit&id={$projects[project].project_id}">{$projects[project].project_name|stripslashes}</a></td>
+ <td>{if $perm->have_perm('Administrator') or $perm->have_perm_proj($projects[project].project_id)}<a href="{$smarty.server.PHP_SELF}?op=edit&id={$projects[project].project_id}">{$projects[project].project_name|stripslashes}</a>{else}{$projects[project].project_name|stripslashes}{/if}</td>
<td align="center">{$projects[project].created_date|date:DATE_FORMAT}</td>
<td align="center">{if $projects[project].active}Yes{else}No{/if}</td>
</tr>
|
|
From: Ken T. <ke...@us...> - 2003-04-07 18:56:14
|
Update of /cvsroot/phpbt/phpbt/schemas
In directory sc8-pr-cvs1:/tmp/cvs-serv9290/schemas
Modified Files:
mysql.in
Log Message:
* Project-level Administration
- allows superadmin to delegate power to others.
- admin may assign multiple users to have administrative power on a project.
* new auth: have_perm_proj($proj_id); check_proj($proj);
* added <select> to project-form
* build_select(): in addition to 1-1 matching for selected, allow needle-in-haystack
Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- mysql.in 2 Mar 2003 15:28:54 -0000 1.37
+++ mysql.in 7 Apr 2003 18:55:39 -0000 1.38
@@ -185,6 +185,11 @@
KEY group_id (group_id)
) TYPE=MyISAM;
+CREATE TABLE TBL_PROJECT_PERM (
+ project_id int(11) NOT NULL default '0',
+ user_id int(11) NOT NULL default '0'
+) TYPE=MyISAM;
+
CREATE TABLE TBL_RESOLUTION (
resolution_id int(10) unsigned NOT NULL default '0',
resolution_name varchar(30) NOT NULL default '',
|
|
From: Ken T. <ke...@us...> - 2003-04-07 18:56:14
|
Update of /cvsroot/phpbt/phpbt/inc
In directory sc8-pr-cvs1:/tmp/cvs-serv9290/inc
Modified Files:
functions.php
Log Message:
* Project-level Administration
- allows superadmin to delegate power to others.
- admin may assign multiple users to have administrative power on a project.
* new auth: have_perm_proj($proj_id); check_proj($proj);
* added <select> to project-form
* build_select(): in addition to 1-1 matching for selected, allow needle-in-haystack
Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- functions.php 2 Mar 2003 15:28:54 -0000 1.38
+++ functions.php 7 Apr 2003 18:55:38 -0000 1.39
@@ -153,7 +153,8 @@
case 'owner':
$rs = $db->query("select u.user_id, login from ".TBL_AUTH_USER." u, ".TBL_USER_GROUP." ug where u.active > 0 and u.user_id = ug.user_id and ug.group_id = ".GROUP_ASSIGN_TO." order by login");
while ($rs->fetchInto($row)) {
- if ($selected == $row['user_id']) {
+ // either singular matches, or array matches are acceptable
+ if (($selected == $row['user_id']) || in_array($row['user_id'], $selected)) {
$sel = ' selected';
} else {
$sel = '';
|
|
From: Ken T. <ke...@us...> - 2003-04-07 18:56:13
|
Update of /cvsroot/phpbt/phpbt/admin
In directory sc8-pr-cvs1:/tmp/cvs-serv9290/admin
Modified Files:
project.php
Log Message:
* Project-level Administration
- allows superadmin to delegate power to others.
- admin may assign multiple users to have administrative power on a project.
* new auth: have_perm_proj($proj_id); check_proj($proj);
* added <select> to project-form
* build_select(): in addition to 1-1 matching for selected, allow needle-in-haystack
Index: project.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/project.php,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -r1.43 -r1.44
--- project.php 16 Sep 2002 19:39:34 -0000 1.43
+++ project.php 7 Apr 2003 18:55:37 -0000 1.44
@@ -29,6 +29,8 @@
function del_version($versionid, $projectid) {
global $db, $me;
+ $perm->check_proj($projectid);
+
if (!$db->getOne('select count(*) from '.TBL_BUG." where version_id = $versionid")) {
$db->query("delete from ".TBL_VERSION." where version_id = $versionid");
}
@@ -38,6 +40,8 @@
function save_version($version_id = 0) {
global $db, $me, $_pv, $STRING, $now, $u, $t;
+ $perm->check_proj($projectid);
+
$error = '';
// Validation
if (!$_pv['version_name'] = trim($_pv['version_name']))
@@ -82,7 +86,9 @@
}
function del_component($componentid, $projectid) {
- global $db, $me;
+ global $db, $me, $perm;
+
+ $perm->check_proj($projectid);
if (!$db->getOne('select count(*) from '.TBL_BUG." where component_id = $componentid")) {
$db->query("delete from ".TBL_COMPONENT." where component_id = $componentid");
@@ -91,7 +97,9 @@
}
function save_component($component_id = 0) {
- global $db, $me, $_pv, $u, $STRING, $now, $t;
+ global $db, $me, $_pv, $u, $STRING, $now, $t, $perm;
+
+ $perm->check_proj($projectid);
$error = '';
// Validation
@@ -140,7 +148,9 @@
}
function save_project($projectid = 0) {
- global $db, $me, $u, $STRING, $now, $_pv;
+ global $db, $me, $u, $STRING, $now, $_pv, $perm;
+
+ $perm->check_proj($projectid);
$error = '';
// Validation
@@ -190,6 +200,32 @@
", project_desc = ".$db->quote(stripslashes($project_desc)).
", active = $active where project_id = $projectid");
}
+ // project -> user relationship
+ $old_useradmin = $db->getCol('select user_id from '.TBL_PROJECT_PERM.
+ " where project_id = $projectid");
+ if (isset($useradmin) and is_array($useradmin) and count($useradmin)) {
+ // Compute differences between old and new
+ $remove_from = array_diff($old_useradmin, $useradmin);
+ $add_to = array_diff($useradmin, $old_useradmin);
+
+ if (count($remove_from)) {
+ foreach ($remove_from as $user) {
+ $db->query('delete from '.TBL_PROJECT_PERM." where project_id = $projectid
+ and user_id = $user");
+ }
+ }
+ if (count($add_to)) {
+ foreach ($add_to as $user) {
+ $db->query("insert into ".TBL_PROJECT_PERM
+ ." (project_id, user_id)
+ values ('$projectid', $user)");
+ }
+ }
+ } elseif (count($old_useradmin)) {
+ // user killed em all
+ $db->query('delete from '.TBL_PROJECT_PERM." where project_id = $projectid");
+ }
+
// Handle project -> group relationship
$old_usergroup = $db->getCol('select group_id from '.TBL_PROJECT_GROUP.
@@ -228,32 +264,39 @@
}
function show_project($projectid = 0, $error = null) {
- global $db, $me, $t, $TITLE, $_gv, $_pv, $QUERY;
+ global $db, $me, $t, $TITLE, $_gv, $_pv, $QUERY, $perm;
if (is_array($error)) $t->assign($error);
else $t->assign('error', $error);
- $t->assign('project_groups', $db->getCol('select group_id from '.
+ $t->assign('project_groups', $db->getCol('select group_id from '.
TBL_PROJECT_GROUP." where project_id = $projectid"));
+ if ($perm->have_perm('Administrator')) {
+ $t->assign('project_admins', $db->getCol('select user_id from '.
+ TBL_PROJECT_PERM." where project_id = $projectid"));
+
+ } else {
+ $t->assign('project_admins', $db->getCol('select u.login from '.TBL_AUTH_USER.' as u, '.TBL_PROJECT_PERM.' as p where u.user_id = p.user_id and p.project_id = '.$projectid));
+ }
- if ($projectid) {
- $t->assign($db->getRow('select * from '.TBL_PROJECT
- ." where project_id = $projectid"));
- $t->assign(array(
- 'components' => $db->getAll(sprintf($QUERY['admin-list-components'],
- $projectid)),
- 'versions' => $db->getAll(sprintf($QUERY['admin-list-versions'],
- $projectid))
- ));
-
- $t->wrap('admin/project-edit.html', 'editproject');
- } else {
- if (!empty($_pv)) {
- $t->assign($_pv);
- } else {
- $t->assign('active', 1);
- }
- $t->wrap('admin/project-add.html', 'addproject');
- }
+ if ($projectid) {
+ $t->assign($db->getRow('select * from '.TBL_PROJECT
+ ." where project_id = $projectid"));
+ $t->assign(array(
+ 'components' => $db->getAll(sprintf($QUERY['admin-list-components'],
+ $projectid)),
+ 'versions' => $db->getAll(sprintf($QUERY['admin-list-versions'],
+ $projectid))
+ ));
+
+ $t->wrap('admin/project-edit.html', 'editproject');
+ } else {
+ if (!empty($_pv)) {
+ $t->assign($_pv);
+ } else {
+ $t->assign('active', 1);
+ }
+ $t->wrap('admin/project-add.html', 'addproject');
+ }
}
@@ -285,7 +328,7 @@
$t->wrap('admin/projectlist.html', 'project');
}
-$perm->check('Admin');
+// $perm->check('Admin');
if (isset($_gv['op'])) {
switch($_gv['op']) {
|
|
From: Ken T. <ke...@us...> - 2003-04-07 18:56:13
|
Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv9290
Modified Files:
config.php
Log Message:
* Project-level Administration
- allows superadmin to delegate power to others.
- admin may assign multiple users to have administrative power on a project.
* new auth: have_perm_proj($proj_id); check_proj($proj);
* added <select> to project-form
* build_select(): in addition to 1-1 matching for selected, allow needle-in-haystack
Index: config.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config.php,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- config.php 6 Feb 2003 13:33:03 -0000 1.34
+++ config.php 7 Apr 2003 18:55:35 -0000 1.35
@@ -65,6 +65,7 @@
define ('TBL_USER_PREF', TBL_PREFIX.'user_pref');
define ('TBL_VERSION', TBL_PREFIX.'version');
define ('TBL_PROJECT_GROUP', TBL_PREFIX.'project_group');
+define ('TBL_PROJECT_PERM', TBL_PREFIX.'project_perm');
define ('TBL_DATABASE', TBL_PREFIX.'database_server');
define ('TBL_SITE', TBL_PREFIX.'site');
|
|
From: Kikutani, M. <po...@mo...> - 2003-04-04 23:38:20
|
I can specify "cvs:modulename:1.5", but I can't use a tag instead of revision numbers. This is obvious because the current bug.php has a pattern '/cvs:([^\.\s:,\?!]+(\.[^\.\s:,\?!]+)*)(:)?(\d\.[\d\.]+)?([\W\s])?/i' But even if I change this to (:)?([\w\.]+)? or something, I don't see an expected result. Probably this is because I don't understand the URL syntax of viewcvs. It seems there are two ways in viewcvs to specify tags. ?only_with_tag=tag and #rev[rev] I searched the source tree of viewcvs, but I couldn't find any explanation. Anyway, isn't it good if we can specify tag name as well as revision ? Thanks, makoto -- Kikutani, Makoto |
|
From: Benjamin C. <bc...@us...> - 2003-04-04 13:29:30
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory sc8-pr-cvs1:/tmp/cvs-serv22772/templates/default
Modified Files:
queryform.html
Log Message:
Fixes bug #637136 - Added closed_in_version and to_be_closed_in_version selections to advanced query page
Index: queryform.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/queryform.html,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- queryform.html 5 Nov 2002 20:43:50 -0000 1.18
+++ queryform.html 4 Apr 2003 13:29:25 -0000 1.19
@@ -19,6 +19,16 @@
f.versions.options[x].value = versions[sel][x][0];
f.versions.options[x].text = versions[sel][x][1];
}
+ f.closedinversion.length = versions[sel].length;
+ for (var x = 0; x < versions[sel].length; x++) {
+ f.closedinversion.options[x].value = versions[sel][x][0];
+ f.closedinversion.options[x].text = versions[sel][x][1];
+ }
+ f.tobeclosedinversion.length = versions[sel].length;
+ for (var x = 0; x < versions[sel].length; x++) {
+ f.tobeclosedinversion.options[x].value = versions[sel][x][0];
+ f.tobeclosedinversion.options[x].text = versions[sel][x][1];
+ }
f.components.length = components[sel].length;
for (var x = 0; x < components[sel].length; x++) {
f.components.options[x].value = components[sel][x][0];
@@ -139,6 +149,12 @@
</tr><tr>
<td><b>{$STRING.QUERY.Version}:</b></td>
<td><select name="versions"><option value=''>{$STRING.QUERY.opt_All}</option></select></td>
+ </tr><tr>
+ <td><b>{$STRING.BUGDISPLAY.closedinversion}:</b></td>
+ <td><select name="closedinversion"><option value=''>{$STRING.QUERY.opt_All}</option></select></td>
+ </tr><tr>
+ <td><b>{$STRING.BUGDISPLAY.tobeclosedinversion}:</b></td>
+ <td><select name="tobeclosedinversion"><option value=''>{$STRING.QUERY.opt_All}</option></select></td>
</tr><tr>
<td><b>{$STRING.QUERY.Component}:</b></td>
<td><select name="components"><option value=''>{$STRING.QUERY.opt_All}</option></select></td>
|
|
From: Benjamin C. <bc...@us...> - 2003-04-04 13:29:29
|
Update of /cvsroot/phpbt/phpbt
In directory sc8-pr-cvs1:/tmp/cvs-serv22772
Modified Files:
query.php
Log Message:
Fixes bug #637136 - Added closed_in_version and to_be_closed_in_version selections to advanced query page
Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.93
retrieving revision 1.94
diff -u -r1.93 -r1.94
--- query.php 27 Mar 2003 13:25:40 -0000 1.93
+++ query.php 4 Apr 2003 13:29:24 -0000 1.94
@@ -139,6 +139,8 @@
if (!empty($projects)) {
$proj[] = "b.project_id = $projects";
if (!empty($versions) and $versions != 'All') $proj[] = "b.version_id = $versions";
+ if (!empty($closedinversion) and $closedinversion != 'All') $proj[] = "b.closed_in_version_id = $closedinversion";
+ if (!empty($tobeclosedinversion) and $tobeclosedinversion != 'All') $proj[] = "b.to_be_closed_in_version_id = $tobeclosedinversion";
if (!empty($components) and $components != 'All') $proj[] = "b.component_id = $components";
$query[] = '('.@join(' and ',$proj).')';
} elseif (!$perm->have_perm('Admin')) { // Filter results from hidden projects
|
2 messages has been excluded from this view by a project administrator.
