From: David M. <run...@us...> - 2012-04-23 19:43:35
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "pdl". The branch, master has been updated via 757691190bb503aea6e35a98106601974fca11af (commit) via 40022485a21ed1088de19c3ee795718f99e96eb1 (commit) via 13291d98f614ab534ea2c40367973d0c9a9d3f31 (commit) from 1f32e53304e3c1f30383f0daf35495112bef0b6b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 757691190bb503aea6e35a98106601974fca11af Merge: 4002248 1f32e53 Author: David Mertens <dcm...@gm...> Date: Mon Apr 16 11:49:27 2012 -0500 Merge branch 'master' into fix-PP-commentary commit 40022485a21ed1088de19c3ee795718f99e96eb1 Author: David Mertens <dcm...@gm...> Date: Mon Apr 16 10:33:29 2012 -0500 Added a test for now-functional multiline commenting in PP code commit 13291d98f614ab534ea2c40367973d0c9a9d3f31 Author: David Mertens <dcm...@gm...> Date: Mon Apr 16 10:09:55 2012 -0500 Fixed PP commentary PP generates lots of code. Some of that code is confusing at first blush, so PP added C-style multiline comments to help anybody examining the generated XS. Unfortunately, if a user had a bug in their code's logic and attempted to debug by commenting out large swaths of their PP code, the non-nesting of C-style comments would invariably lead to weird compile failures. My proposed solution is to #define the symbol PDL_COMMENT(comment), thus allowing any commentary such as this: _internal_var->value /* get some internal thing */ to be replaced with something like this: _internal_var->value PDL_COMMENT("get some internal thing") It's a bit more verbose, but it enables users to use multiline comments in the way described above. ----------------------------------------------------------------------- Summary of changes: Basic/Gen/PP.pm | 94 ++++++++++++++++++++++++++----------------- Basic/Gen/PP/PDLCode.pm | 29 +++++++------ Basic/Gen/PP/PdlParObj.pm | 6 ++- t/inline-comment-test.t | 98 +++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 175 insertions(+), 52 deletions(-) create mode 100644 t/inline-comment-test.t hooks/post-receive -- pdl |