#1049 Taskbar Icon and window focus after auto-lock

[Anonymous]

OS: Windows 7 64-bit
Program version: 3.29, 3.28, 3.27, 3.26 [earlier versions not used]
Description: On Windows 7 when using the program with both "Put icon in System Tray" and "Allow multiple instances" disabled, the program does not gain focus when the taskbar icon is clicked even though the the window is restored and the password field is highlighted. The taskbar icon also disappears at this point.

Steps to reproduce:

1. Create a password database and ensure it is set to auto lock.
2. Disable both "Put icon in system tray" and "Allow multiple instances" options.
3. Leave program idle at the unlocked database screen until it auto locks and minimizes.
4. Click taskbar icon to restore program. The bug now occurs.

[Anonymous]

very bad image i threw together to show what happens on my end

[ShivaKandi]

I am new to developing open source projects. Can I work on fixing this bug?

[Rony Shapiro]

Hi Shivak7,

The bug's all yours - let me know if you need help.

Thanks!

Rony

[ShivaKandi]

I am going through the code. It might be handy if you can help me out in narrowing down the part of the code where actions such as taskbar and window focus is handled.

[Rony Shapiro]

This would be in the GUI Windows-specific code, which is in src/ui/Windows.
SystemTray.cpp would be a good place to start there, specifically CSystemTray::OnTrayNotification()

Rony

[ShivaKandi]

I have compiled the code, there happens to be some differences in system environments though - windows 7 32 bit was used as I was unable to compile win 7 64 bits. The software was working fine. Its pop-ups a window on top of every other window asking for a password.

[Rony Shapiro]

Regarding the environments:
The released version of PasswordSafe is the 32bit build, which runs fine under both 32 and 64 bit versions of Windows7 (and XP/Vista)..
The 64bit build should compile, though, even if it's not supported.

[Ashley T]

This issue still repros Windows 10 and Windows 11 with version v3.63.

Steps are pretty much the same less disabling multiple instances which may have been in the original report for appropriate/comprehensive completeness.

Here are steps I took on Windows 10 and Windows 11:

1. Install Password Safe.
2. Manage, Options, System, uncheck "Put icon in System Tray" to disable system tray usage.
3. Lock Password Safe. You should see its icon remain in the taskbar given configuration step 2.
4. Single click Password Safe taskbar icon and, on repro, notice Password Safe restores to the password entry dialog but the password field does not have focus.

[Ashley T]

ShivaKandi/shivak7, This Password Safe bug 1049 as been inactive since 2012 (i.e., about 11 years ago). At that time, you were left set as the bug's owner. I am going to reassign ownership. Can you reply if you are working on the bug or otherwise want to retain ownership? Thank you!