Re: [PanoTools-devel] libpano13-2.9.19_beta1 released

[Andreas M. <ame...@be...>]

On 2013-12-17 Bruno Postle <br...@po...> wrote:
> libpano13 is the PanoTools library for panoramic imaging.

> A libpano13-2.9.19 beta1 tarball has been uploaded to sourceforge, this is
> for testing but is expected to be very similar to the final release:
[...]

Hello,

Thanking for jumpstarting the release process.

Taking a quick look:

1. License headers seem to have been copied from libtool without
change:

 *  You should have received a copy of the GNU General Public License
 *  along with GNU Libtool; see the file COPYING.  If not, a copy
 *  can be downloaded from http://www.gnu.org/licenses/gpl.html, or
 *  obtained by writing to the Free Software Foundation, Inc.,
 *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

s/GNU Libtool/this software/

2. Some typos:
---------------------------------
--- libpano13-2.9.19~beta1+dfsg.orig/PTcommon.c
+++ libpano13-2.9.19~beta1+dfsg/PTcommon.c
@@ -896,7 +896,7 @@ int panoCreatePanorama(fullPath ptrImage
                 croppedTIFFIntermediate = 0;
             } 
         } else {
-            PrintError("No support for this ouput image format (%s). Output will be TIFF_m", output_file_format);
+            PrintError("No support for this output image format (%s). Output will be TIFF_m", output_file_format);
         }
         // enable this to avoid cropped tiffs. usually for testing
         //croppedTIFFIntermediate = 0;
--- libpano13-2.9.19~beta1+dfsg.orig/tools/panoinfo_unix.c
+++ libpano13-2.9.19~beta1+dfsg/tools/panoinfo_unix.c
@@ -106,7 +106,7 @@ int main(int argc,char *argv[])
 	    int j;
 	    pano_projection_features features;
 	    if (!panoProjectionFeaturesQuery(i, &features) ) {
-		printf("Error trying to retreive features of projection index %d\n", i);
+		printf("Error trying to retrieve features of projection index %d\n", i);
 		continue;
 	    } 
 	    printf("Projection index: %d name: %s\n", features.projection, features.name);
---------------------------------

3. Could you please include the patch in 
<https://bugs.launchpad.net/panotools/+bug/734867>?

cu Andreas

-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'