From: Daniel M. G. <dm...@uv...> - 2006-11-27 20:08:04
|
Hi Pablo, >> I am confused about S cropping. Nona seems to treat S and C >> identically (I might be wrong here, I need to run tests using >> PTstitcher, which is always problematic in its own way). Pablo> The nona behaviour is a bug, because I first use the C syntax in the Pablo> scripts, and later discovered that I'm supposed to use S instead. In order Pablo> to be compatible to older project files created with hugin, nona just Pablo> accepts the C crop and treat it as S crop. Not an ideal solution. I should Pablo> probably check if it is indeed a hugin project file. Ok, it is good to know that nona is treating them equally (I was using Nona as an oracle). I am going to generate some output test using PTsticher under windows and I'll report back. >> Pablo, you are probably the best person to ask. Is my interpretation >> of S and C correct. Do I need to recalculate HFoV for C but not for S? Pablo> I don't think it is necessary to recalculate the HFoV in either case, since Pablo> it should just apply to the cropped region, or? Pablo> I remember seeing that handling the C syntax is implemented a bit strangely, Pablo> if the crop is inside the image, PTStitcher precrops the image. If the crop Pablo> is outside the image, the cropping is handled in the transformation Pablo> functions (see adjust.c:567). I hope I didn't break the cropping while Pablo> adding the new output projections... That is good to know. So far I have been concentrating in the code before the call to MakePano (since I was assuming the problem wouldn't be there). I'll experiment with PTmender before the new projections were added to make sure this is not the case. Pablo> I believe a cleaner solution would be to remove the Pablo> pre-cropping from PTmender. This might require some changes in Pablo> the transForm*() functions as well, since the computed Pablo> coordinates in the source image will refer to the crop, and Pablo> not the original image. This is a good point. I'll try to get it working first and then we'll discuss how to proceed. dmg Pablo> ciao Pablo Pablo> ------------------------------------------------------------------------- Pablo> Take Surveys. Earn Cash. Influence the Future of IT Pablo> Join SourceForge.net's Techsay panel and you'll get the chance to share your Pablo> opinions on IT & business topics through brief surveys - and earn cash Pablo> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV Pablo> _______________________________________________ Pablo> PanoTools-devel mailing list Pablo> Pan...@li... Pablo> https://lists.sourceforge.net/lists/listinfo/panotools-devel -- Daniel M. German "Great algorithms are Francis Sullivan -> the poetry of computation" http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |