Re: [PanoTools-devel] Q

[Daniel M. G. <dm...@uv...>]

 JD Smith twisted the bytes to say:

 JD> On Thu, 2006-10-26 at 15:14 -0700, Daniel M. German wrote:
 >> 
 >> 
 >> Ok, let us put the code in, but in a more generalizable way.
 >> 
 >> Instead of adding 2 parms, let us add only one (a pointer to a
 >> struct).
 >> 
 >> The struct will contain:
 >> 
 >> * Any info needed (in this case the 2 thresholds)
 >> 
 >> * A pointer to a function to call to determine if one should use the
 >> points. This function should accept:
 >> 
 >> What do you think?

 JD> Sounds reasonable.  The problem is, what does that function take as
 JD> input, RGBHSV for both pixels?  Pre-compute them all before deciding
 JD> whether to proceed?  Would slow things down a bit.

This is an important design decision, I think. This is where C++ would
help.

Why dont' we discuss it until we are all happy:

proposal A:

* Refactor a function for the computation of the histograms for a
  given line of the images. (it is currently embedded in the middle).

* Create one function to call for each method.

* Add a switch statement that determines which method to call.

proposal B:

* replace the predicate of the if that determines if the method is to
  be used with a function call. This function call will take 2
  parameters:

  1. A struct with information about what type of method to use (this
     is the one passed to ReadHistograms)

  2. A struct with info about the pixels (RGV, or HSV, and perhaps
  more data, such as the neighborhood).

  This might also require a switch to decide what type of information
  needs to be computed (if one wants it optimized for speed)

I don't think A and B are mutually exclusive. I think we can start
with B.

I'd like to hear what you think.


 JD> JD



 JD> -------------------------------------------------------------------------
 JD> Using Tomcat but need to do more? Need to support web services, security?
 JD> Get stuff done quickly with pre-integrated technology to make your job easier
 JD> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
 JD> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
 JD> _______________________________________________
 JD> PanoTools-devel mailing list
 JD> Pan...@li...
 JD> https://lists.sourceforge.net/lists/listinfo/panotools-devel

--
Daniel M. German                  "The WWW might get the glory,
                                   but e-mail is the quiet
   Beppi Crosanol ->               workhorse of the digital age."
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .