From: Daniel M. G. <dmg...@uv...> - 2006-05-09 16:05:47
|
walter harms twisted the bytes to say: walter> Hi, walter> i have just tested the lastest release and got a bunch of warnings walter> int resample.c (mostly incompatible pointer type) and fourier.c (mostly walter> signedness) walter> resample.c:1925: unsigned int *ffIsInQueue; walter> resample.c:2126: ffIsInQueue=(pt_uint32 *) calloc(ffIsInQueueSize * walter> sizeof(pt_uint32),1); walter> its also related to: walter> resample.c:2231: ptui=&ffIsInQueue[ptmod_first]; walter> of cause this causes a warning any good reason for that ? walter> otherwise i successd replacing (unsigned int *) with walter> (pt_uint32 *). I have been looking into that and I have a patch for them. Some of you might recall that we needed a big hack to get resample.c to compile (the problem was with the RESAMPLE_N when we passed float as a parameter, as there are no unsigned floats). We fixed it by undefining unsigned for a while. The problem is that we removed unsigned from the prototype of the functions too, which creates the warning. I have moved the undef inside each of the culprit functions (with their corresponding defines). I think this code is more solid, as the undef and define is right around the area where we needed. Before all these functions were dependent of not being moved and it was not obvious that we had undefined unsigned. I have not committed it yet. Perhaps somebody else wants to try it? daniel Index: resample.c =================================================================== RCS file: /cvsroot/panotools/libpano/resample.c,v retrieving revision 1.23 diff -r1.23 resample.c 694,696d693 < #undef maxalpha < #define maxalpha 1.0 < #define unsigned 699a697,699 > #undef maxalpha > #define maxalpha 1.0 > 703,704c703,707 < { < RESAMPLE_N( NNEIGHBOR, 1, float) } --- > { > #define unsigned > RESAMPLE_N( NNEIGHBOR, 1, float) > #undef unsigned > } 710c713,718 < { RESAMPLE_N( BILINEAR, 2, float) } --- > { > #define unsigned > RESAMPLE_N( BILINEAR, 2, float) > #undef unsigned > } > 718c726,730 < { RESAMPLE_N( CUBIC, 4, float) } --- > { > #define unsigned > RESAMPLE_N( CUBIC, 4, float) > #undef unsigned > } 725c737,742 < { RESAMPLE_N( SPLINE16, 4, float) } --- > { > #define unsigned > RESAMPLE_N( SPLINE16, 4, float) > #undef unsigned > } > 732c749,753 < { RESAMPLE_N( SPLINE36, 6, float) } --- > { > #define unsigned > RESAMPLE_N( SPLINE36, 6, float) > #undef unsigned > } 738c759,763 < { RESAMPLE_N( SPLINE64, 8, float) } --- > { > #define unsigned > RESAMPLE_N( SPLINE64, 8, float) > #undef unsigned > } 746c771,775 < { RESAMPLE_N( SINC, 16, float) } --- > { > #define unsigned > RESAMPLE_N( SINC, 16, float) > #undef unsigned > } 754,755c783,785 < { RESAMPLE_N( SINC, 32, float) } < --- > { > #define unsigned > RESAMPLE_N( SINC, 32, float) 757c787,788 < --- > } > |