#80 Finish the Japanese translation in resource files

[Joe Slater]

The files mdi.rc and hlpmanag.rc still had English strings in the Japanese string tables, marked as TODO. Need to add the appropriate Japanese for these two resource files.

[Vidar Hasfjord]

Hi Joe, I've fixed the revision log for [r2900]. Unfortunately, the SourceForge Allura tools caches the log, so it may not be visible on the projects site. It should however show up correctly in the raw Subversion log, e.g. using Tortoise SVN | Show log. By the way, this latter command brings up TortoiseSVN's "Log Messages" dialog box, which is where I edited the log message (context command "Edit log message" in the message field).

PS. Regarding ticket labels, do not add arbitrary keywords and terms that will show up in a search anyway. Labels are not search keywords; labels are meta-information. So use the conceptual labels from our defined set. See "Submitting bugs and feature requests". Feel free to add new ones as you see (e.g. "Translation", although that is a search term that is likely to find any ticket regarding translation anyway). Labels may be used in the future to add other meta-information to tickets, e.g. "Todo", "Review".

[Joe Slater]

Vidar,

I thought the Japanese message got garbled in your fix, as TurtoiseSVN diff for [r2900] displays the Unicode Japanese quite differently from [r2901]; but I checked the source, and it's okay.

[Joe Slater]

Also, thanks for editing the ticket log; I see how to do that now.

Should I change the status of this ticket, to pending/closed, or is that for you to do?

[Vidar Hasfjord]

The status of the ticket will be changed to "closed" (by you or me) when the milestone is released.

[Vidar Hasfjord]

I thought the Japanese message got garbled in your fix, as TurtoiseSVN diff for [r2900] displays the Unicode Japanese quite differently from [r2901];

This is because of the encoding of the source file. You obviously saved the file encoded as Unicode (probably UTF-8), which is why Allura and TortoiseMerge shows it with the correct Japanese characters, while I saved the file encoded as Windows Western European (codepage 1252), like the other resource files. In Visual Studio, you can set the encoding using command File | Advanced Save Options.

[Joe Slater]

You obviously saved the file encoded as Unicode (probably UTF-8)
 

No, I assure you I did not. I simply used NotePad which saved it as an ANSI text file (i.e., no BOM encoded). The only time I see those Japanese characters is with the diff on SourceForge; my TurtoiseSVN doesn't do that. :-(

I think it probably had to do with the fact the string wasn't in the StringTable anymore, where intelligence comes in and interprets the MB characters and converts it to Unicode on the fly to display. Since you now have it in a #define statement (good job), that intelligence just doesn't get applied.

In any case, it's not a problem. Just woke me up for a minute. :-)

[Vidar Hasfjord]

Sorry, wrong assumption on my part. I guess you're right, there's some magic detection going on. Both revisions are ASCII according to TortoiseMerge (tip: it tells you the encoding of the right and left file in on its status bar).

[Vidar Hasfjord]

A correction to the Japanese strings added in [r2900] was applied in [r2927]. This fix has been merged into 6.40 in [r2928].