Menu

#125 Source-code download in OWLMaker

OWLMaker
closed
1
2020-04-30
2018-03-24
No

It would be cool if the OWLMaker Wizard, on its first page, had a "Download" button that allowed the user to select a version of OWLNext for download and extraction into a specified folder, after which the wizard would proceed as normal with the build setup.

If the Wizard detected that Subversion was installed, it could give the user the option to check out a working copy instead, as per the current Installation Guide.

Related

Discussion: OWLMaker update function
Discussion: OWLMaker update function
Wiki: Installing_OWLNext_from_the_Code_Repository

Discussion

  • Vidar Hasfjord

    Vidar Hasfjord - 2018-03-24
    • Group: unspecified --> OWLMaker
     
  • Ognyan Chernokozhev

    [r4655] is an initial implementation of functionality to download OWLNext source code and documentation.

    It is still work in progress, next items to do are:

    1. Show progress while downloading and extracting the files
    2. Support for choosing version of OWLNext (latest stable or trunk)
    3. Button on OWLMaker Wizard
    4. Make the dialog prettier

    VH: Fixed list formatting.

     

    Related

    Commit: [r4655]


    Last edit: Vidar Hasfjord 2020-01-27
  • Vidar Hasfjord

    Vidar Hasfjord - 2019-11-21

    Nice!

    I've had a quick look. The code looks good, and it works great, but:

    • Download and unzipping is done, even if I select Cancel. The return value from the function ExecuteDownloadLocationDlg needs to be checked against IDOK.
    • The destination folder is used, even if left empty (although I cannot find where the unzipped content ends up, if anywhere at all, in this case). Validation of the existence of the destination folder might be a good idea, before proceeding with the download.
    • Coding Standard: Indentation should use spaces, not tabs.
     

    Last edit: Vidar Hasfjord 2019-11-21
    • Ognyan Chernokozhev

      Thanks, I corrected those issues in [r4658]

       

      Related

      Commit: [r4658]

  • Vidar Hasfjord

    Vidar Hasfjord - 2019-11-21
    • assigned_to: Ognyan Chernokozhev
     
  • Ognyan Chernokozhev

    Added a progress dialog in [r4670].

    Further improvements will be:

    • Show a message box to the user if an error happens during the download or extraction process.
    • Show a progress message in the progress dialog, like "Downloaded X KB".
    • If there is no reliable way of getting the size of the file to be downloaded, show indeterminate progress bar.
    • Investigate if progress can be shown for the extraction of files.
    • Allow cancellation of the download or extraction process.

    VH: Fixed list formatting.

     

    Related

    Commit: [r4670]


    Last edit: Vidar Hasfjord 2020-01-27
  • Vidar Hasfjord

    Vidar Hasfjord - 2020-01-27

    Hi Jogy,

    Are you actively working on further improvements regarding the source code download function?

    I'm thinking about integrating this functionality into the wizard, as I suggested in the discussion thread "OWLMaker update function" (60a69a9451/#c432):

    • New button "Download" beside "Locate" on the start page of the OWLMaker wizard.
    • The new button replaces the invisible checkbox "Update the OWLROOT environment variable". (This checkbox is not really needed, and it only shows up when OWLMaker is run with administrator privileges.)
    • Pressing the button opens your source code download dialog, with an option to include the documentation (i.e. source and documentation download merged into one function).
    • If the dialog is committed, the source code is downloaded into the given destination folder (if selected, documentation should perhaps be put into the "documentation" subfolder).
    • If the download completes successfully, the path of the destination folder is then inserted into the field "OWLNext root location" on the start page.

    If you want to take this on, great! Otherwise, I might have a stab at it. Let me know.

     

    Last edit: Vidar Hasfjord 2020-01-27
    • Ognyan Chernokozhev

      Hi Vidar,
      Right now I am a bit occupied with other work and don't have the time to finsh the OWLMaker improvements, so please go ahead.

      Jogy

       
  • Vidar Hasfjord

    Vidar Hasfjord - 2020-02-15

    Hi Jogy,

    Check out the new version — hope you like it! [r4763]

     

    Related

    Commit: [r4763]

    • Ognyan Chernokozhev

      Just tried it - the update worked perfectly, and the new download dialog is great!

       
  • Vidar Hasfjord

    Vidar Hasfjord - 2020-02-15

    Good! I just implemented [feature-requests:#150] as well.

     

    Related

    Feature Requests: #150

  • Vidar Hasfjord

    Vidar Hasfjord - 2020-04-30
    • status: open --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB